fix: route Java->JS calls to the runtime that created the binding instance

SBG-generated classes carried no runtime identity, so com.tns.Runtime had to
re-derive the target of every Java->JS call from the calling thread: the
currentRuntime thread-local, then the entered V8 isolate, then a linear scan of
every live runtime's object maps (getObjectRuntime). That is wrong in two ways
and racy in a third.

Ownership was inferred from "some runtime has a wrapper for this object", but a
wrapper only records that the instance crossed into that isolate. An instance
created by one runtime and later passed into another exists in both maps, so a
call could dispatch into an isolate that holds a wrapper but not the user's JS
implementation. The scan also reads other runtimes' strongJavaObjectToID /
weakJavaObjectToID from a foreign thread; with enableMultithreadedJavascript
off (the default) those are plain HashMap/NativeScriptHashMap being mutated
concurrently by their owning threads.

Generated classes now implement com.tns.NativeScriptRuntimeBound and carry the
id of the runtime that registered them. initInstance stamps it once - later
registrations by other runtimes must not overwrite it, since only the creating
runtime holds the JS implementation behind the generated overrides. Runtime ids
come from a monotonic counter and are never reused, so a stale id can never
match a newer runtime. Instances generated before this interface existed are
tracked in a weak, identity-keyed side map instead, and fall back to the old
resolution when they predate even that.

A call with nowhere left to run is now dropped and logged rather than executed
against an unrelated runtime. These arrive on Android callbacks - lifecycle,
listeners, draw - so throwing would take down the process because a worker
ended; the loss stays contained to the one call. Primitive returns reuse the
existing default-value substitution so the generated cast can still unbox.

  - callJSMethod against a terminated owner drops instead of scanning and
    landing on whichever runtime happens to hold a wrapper.
  - dispatchCallJSMethodNative ignored the result of threadScheduler.post(); a
    post to a quitting worker looper already returned null silently, and now
    says so in the log.

initInstance is the one case that still throws: it dereferenced a null runtime,
so constructing a binding off a runtime thread produced a bare NPE. Dropping
there would leave an unregistered instance whose every later call fails anyway,
further from the cause, so it reports instead.

passSuppressedExceptionToJs routed by calling thread, so an exception suppressed
on behalf of another runtime was reported to the wrong one - and the message it
built was never passed to passDiscardedExceptionToJs. It now takes the instance,
resolves the same owner, and reports on that runtime's own thread without
blocking. The two-argument overload stays for already-generated bindings.

Costs two methods and one int field per generated class; noted for dex budgets.

Author: edusperoni

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/Generator.java

@@ -448,6 +448,8 @@ private void writeFieldsToWriter(Writer writer, JavaClass clazz) {
             String normalizedClassName = BcelNamingUtil.resolveClassName(clazz.getClassName());
             fieldsWriter.writeStaticThizField(normalizedClassName);
         }
+
+        fieldsWriter.writeRuntimeIdField();
     }
 
     private void writeConstructorsToWriter(Writer writer, JavaClass clazz, DataRow dataRow, String generatedClassName, GenericHierarchyView genericHierarchyView) {
@@ -523,6 +525,7 @@ private void writeMethodsToWriter(Writer writer, GenericHierarchyView genericHie
 
         methodsWriter.writeInternalRuntimeHashCodeMethod();
         methodsWriter.writeInternalRuntimeEqualsMethod();
+        methodsWriter.writeInternalRuntimeIdAccessorMethods();
     }
 
     /**

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/generating/writing/FieldsWriter.java

@@ -2,4 +2,5 @@
 
 public interface FieldsWriter extends JavaCodeWriter {
     void writeStaticThizField(String className);
+    void writeRuntimeIdField();
 }

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/generating/writing/MethodsWriter.java

@@ -8,5 +8,6 @@ public interface MethodsWriter extends JavaCodeWriter {
     void writeGetInstanceMethod(String className);
     void writeInternalRuntimeEqualsMethod();
     void writeInternalRuntimeHashCodeMethod();
+    void writeInternalRuntimeIdAccessorMethods();
     void writeInternalServiceOnCreateMethod();
 }

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/generating/writing/impl/ClassWriterImpl.java

@@ -11,6 +11,7 @@ public class ClassWriterImpl implements ClassWriter {
     private static final String PUBLIC_CLASS_KEYWORD = "public class";
     private static final String JAVASCRIPT_IMPLEMENTATION_FILE_NAME_PATTERN = "@com.tns.JavaScriptImplementation(javaScriptFile = \"./%s\")";
     private static final String NATIVESCRIPT_HASHCODE_PROVIDER_INTERFACE_NAME = "com.tns.NativeScriptHashCodeProvider";
+    private static final String NATIVESCRIPT_RUNTIME_BOUND_INTERFACE_NAME = "com.tns.NativeScriptRuntimeBound";
     private static final String NOT_EXTENDING_ANY_CLASS_MESSAGE = "Not extending any class!";
 
     private final Writer writer;
@@ -42,6 +43,9 @@ public void writeBeginningOfChildClass(String className, String extendedClassNam
         writer.write(IMPLEMENTS_KEYWORD);
         writer.write(SPACE_LITERAL);
         writer.write(NATIVESCRIPT_HASHCODE_PROVIDER_INTERFACE_NAME);
+        writer.write(COMMA_LITERAL);
+        writer.write(SPACE_LITERAL);
+        writer.write(NATIVESCRIPT_RUNTIME_BOUND_INTERFACE_NAME);
 
         if (!isEmpty(implementedInterfacesNames) && !isEmpty(implementedInterfacesNames.get(0))) {
             writer.write(COMMA_LITERAL);

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/generating/writing/impl/FieldsWriterImpl.java

@@ -7,13 +7,21 @@ public class FieldsWriterImpl implements FieldsWriter {
 
 
     private static final String THIZ_KEYWORD = "thiz";
+    private static final String RUNTIME_ID_FIELD_DECLARATION = "private int runtimeId__ns = com.tns.NativeScriptRuntimeBound.INVALID_RUNTIME_ID;";
 
     private final Writer writer;
 
     public FieldsWriterImpl(final Writer writer) {
         this.writer = writer;
     }
 
+    @Override
+    public void writeRuntimeIdField() {
+        writer.write(TABULATION_LITERAL);
+        writer.writeln(RUNTIME_ID_FIELD_DECLARATION);
+        writer.writeln();
+    }
+
     @Override
     public void writeStaticThizField(String className) {
         writer.write(TABULATION_LITERAL);

test-app/build-tools/static-binding-generator/src/main/java/org/nativescript/staticbindinggenerator/generating/writing/impl/MethodsWriterImpl.java

@@ -47,6 +47,10 @@ public class MethodsWriterImpl implements MethodsWriter {
 
     private static final String INTERNAL_RUNTIME_EQUALS_METHOD_SIGNATURE = "public boolean equals__super(java.lang.Object other)";
     private static final String INTERNAL_RUNTIME_HASHCODE_METHOD_SIGNATURE = "public int hashCode__super()";
+    private static final String INTERNAL_RUNTIME_GET_RUNTIME_ID_METHOD_SIGNATURE = "public int getRuntimeId__ns()";
+    private static final String INTERNAL_RUNTIME_GET_RUNTIME_ID_RETURN_STATEMENT = "return runtimeId__ns;";
+    private static final String INTERNAL_RUNTIME_SET_RUNTIME_ID_METHOD_SIGNATURE = "public void setRuntimeId__ns(int runtimeId)";
+    private static final String INTERNAL_RUNTIME_SET_RUNTIME_ID_ASSIGNMENT = "runtimeId__ns = runtimeId;";
     private static final String INTERNAL_SERVICES_ONCREATE_METHOD_SIGNATURE = "public void " + ON_CREATE_METHOD_NAME + "()";
 
     private static final String RETURN_KEYWORD = "return";
@@ -369,7 +373,7 @@ private void writeCallJsMethodExceptionsSuppressBlockClosingIfNecessary(Type ret
         if (shouldSuppressCallJsMethodExceptions) {
             writer.write(CLOSING_CURLY_BRACKET_LITERAL);
             writer.write(GENERIC_CATCH_BLOCK_BEGINNING);
-            writer.writeln("\t\t\tcom.tns.Runtime.passSuppressedExceptionToJs(throwable, \"" + methodName + "\");");
+            writer.writeln("\t\t\tcom.tns.Runtime.passSuppressedExceptionToJs(this, throwable, \"" + methodName + "\");");
             writer.writeln(ANDROID_LOG_METHOD_CALL_STATEMENT);
 
             if (!returnType.equals(Type.VOID)) {
@@ -398,6 +402,12 @@ public void writeInternalRuntimeHashCodeMethod() {
         writeInternalRuntimeMethod(INTERNAL_RUNTIME_HASHCODE_METHOD_SIGNATURE, INTERNAL_RUNTIME_HASHCODE_METHOD_RETURN_STATEMENT);
     }
 
+    @Override
+    public void writeInternalRuntimeIdAccessorMethods() {
+        writeInternalRuntimeMethod(INTERNAL_RUNTIME_GET_RUNTIME_ID_METHOD_SIGNATURE, INTERNAL_RUNTIME_GET_RUNTIME_ID_RETURN_STATEMENT);
+        writeInternalRuntimeMethod(INTERNAL_RUNTIME_SET_RUNTIME_ID_METHOD_SIGNATURE, INTERNAL_RUNTIME_SET_RUNTIME_ID_ASSIGNMENT);
+    }
+
     private void writeInternalRuntimeMethod(String signature, String returnStatement) {
         writer.write(signature);
         writer.write(OPENING_CURLY_BRACKET_LITERAL);

test-app/build-tools/static-binding-generator/src/test/java/android/util/Log.java

@@ -0,0 +1,11 @@
+package android.util;
+
+/**
+ * Stub for compiling generated bindings in tests: the exception-suppressing
+ * variant emits a call to android.util.Log, which is not on the test classpath.
+ */
+public class Log {
+    public static int w(String tag, String msg) {
+        return 0;
+    }
+}

test-app/build-tools/static-binding-generator/src/test/java/com/tns/NativeScriptRuntimeBound.java

@@ -0,0 +1,9 @@
+package com.tns;
+
+public interface NativeScriptRuntimeBound {
+    int INVALID_RUNTIME_ID = -1;
+
+    int getRuntimeId__ns();
+
+    void setRuntimeId__ns(int runtimeId);
+}

test-app/build-tools/static-binding-generator/src/test/java/com/tns/Runtime.java

@@ -5,4 +5,5 @@ public static void initInstance(Object instance) {}
     public static Object callJSMethod(Object javaObject, String methodName, Class<?> retType, Object... args) {
         return null;
     }
+    public static void passSuppressedExceptionToJs(Object instance, Throwable ex, String methodName) {}
 }

test-app/build-tools/static-binding-generator/src/test/java/org/nativescript/staticbindinggenerator/test/GeneratorTest.java

@@ -53,7 +53,50 @@ public void testCanCompileBinding() throws Exception {
         Class<?> helloClass = InMemoryJavaCompiler.compile(binding.getClassname(), sourceCode.toString(), options);
 
         Assert.assertNotNull(helloClass);
-        Assert.assertEquals(3, helloClass.getDeclaredMethods().length);
+        Assert.assertEquals(5, helloClass.getDeclaredMethods().length);
+    }
+
+    @Test
+    public void testCanCompileBindingWithSuppressedCallJsMethodExceptions() throws Exception {
+        List<String> lines = Utils.getDataRowsFromResource("datarow-named-extend.txt");
+        DataRow dataRow = new DataRow(lines.get(0));
+
+        File outputDir = null;
+        List<DataRow> libs = new ArrayList<>();
+        Generator generator = new Generator(outputDir, libs, true);
+        Binding binding = generator.generateBinding(dataRow);
+        Assert.assertNotNull(binding);
+
+        String sourceCode = binding.getContent();
+        Assert.assertTrue(sourceCode.contains("com.tns.Runtime.passSuppressedExceptionToJs(this,"));
+
+        Iterable<String> options = new ArrayList<String>(Arrays.asList("-cp", dependenciesDir));
+        Class<?> helloClass = InMemoryJavaCompiler.compile(binding.getClassname(), sourceCode, options);
+
+        Assert.assertNotNull(helloClass);
+    }
+
+    @Test
+    public void testBindingCarriesItsOwningRuntimeId() throws Exception {
+        List<String> lines = Utils.getDataRowsFromResource("datarow-named-extend.txt");
+        DataRow dataRow = new DataRow(lines.get(0));
+
+        File outputDir = null;
+        List<DataRow> libs = new ArrayList<>();
+        Generator generator = new Generator(outputDir, libs);
+        Binding binding = generator.generateBinding(dataRow);
+        Assert.assertNotNull(binding);
+
+        Iterable<String> options = new ArrayList<String>(Arrays.asList("-cp", dependenciesDir));
+        Class<?> boundClass = InMemoryJavaCompiler.compile(binding.getClassname(), binding.getContent(), options);
+
+        Assert.assertTrue(com.tns.NativeScriptRuntimeBound.class.isAssignableFrom(boundClass));
+
+        com.tns.NativeScriptRuntimeBound instance = (com.tns.NativeScriptRuntimeBound) boundClass.newInstance();
+        Assert.assertEquals(com.tns.NativeScriptRuntimeBound.INVALID_RUNTIME_ID, instance.getRuntimeId__ns());
+
+        instance.setRuntimeId__ns(7);
+        Assert.assertEquals(7, instance.getRuntimeId__ns());
     }
 
     @Test
@@ -79,7 +122,7 @@ public void testCanCompileBindingOfInterfaceWithStaticInitializer() throws Excep
         Class<?> helloClass = InMemoryJavaCompiler.compile("com.tns.gen.com.example.MyInterface", sourceCode.toString(), options);
 
         Assert.assertNotNull(helloClass);
-        Assert.assertEquals(3, helloClass.getDeclaredMethods().length);  // 3 methods (includes 'hashCode__super' and 'equals__super')
+        Assert.assertEquals(5, helloClass.getDeclaredMethods().length);  // 5 methods (includes 'hashCode__super', 'equals__super', 'getRuntimeId__ns' and 'setRuntimeId__ns')
     }
 
     @Test
@@ -100,7 +143,7 @@ public void testCanCompileBindingClassImplementingMultipleInterfaces() throws Ex
         Class<?> ComplexClass = InMemoryJavaCompiler.compile(binding.getClassname(), sourceCode.toString(), options);
 
         Assert.assertNotNull(ComplexClass);
-        Assert.assertEquals(3, ComplexClass.getInterfaces().length); // 2 + 1 (hashcodeprovider)
+        Assert.assertEquals(4, ComplexClass.getInterfaces().length); // 2 + hashcodeprovider + runtimebound
     }
 
     @Test
@@ -127,7 +170,7 @@ public void testCanCompileBindingClassExtendingAnExtendedClassWithMethodsWithThe
         Class<?> ComplexClass = InMemoryJavaCompiler.compile(binding.getClassname(), sourceCode.toString(), options);
 
         Assert.assertNotNull(ComplexClass);
-        Assert.assertEquals(4, ComplexClass.getDeclaredMethods().length); // 1 + constructor + (equals + hashcode)
+        Assert.assertEquals(6, ComplexClass.getDeclaredMethods().length); // 1 + constructor + (equals + hashcode) + (getRuntimeId__ns + setRuntimeId__ns)
     }
 
     @Test