build: apply the release compile flags to nativescript-regular

The non-optimized branch of the runtime CMakeLists was treated as a
local-debug-only path, but it is also what builds
runtime-regular-release.aar, published as nativescript-regular.aar.
test-app/app/build.gradle switches an app onto that artifact whenever
its package.json sets android.useV8Symbols or any NativeScript
dependency declares nativescript.useV8Symbols, so apps that need V8's
symbols exported were shipping a runtime built without
-fvisibility=hidden, -ffunction-sections or -fno-data-sections.

Gate the branch on CMAKE_BUILD_TYPE instead: AGP passes Debug for the
debug variant and RelWithDebInfo for release, so local native debugging
keeps plain -g while every shipped flavour gets the release flags. Also
drops the stale commented-out duplicate of the optimized flag line.

Author: edusperoni

test-app/runtime/CMakeLists.txt

@@ -58,11 +58,13 @@ include_directories(
         src/main/cpp/ada
 )
 
-if (OPTIMIZED_BUILD OR OPTIMIZED_WITH_INSPECTOR_BUILD)
+# This branch also produces runtime-regular-release.aar, shipped as
+# nativescript-regular.aar and selected for apps that set useV8Symbols, so it
+# must carry the release flags. Only a local Debug build keeps plain -g.
+if (OPTIMIZED_BUILD OR OPTIMIZED_WITH_INSPECTOR_BUILD OR NOT CMAKE_BUILD_TYPE STREQUAL "Debug")
     set(CMAKE_CXX_FLAGS "${COMMON_CMAKE_ARGUMENTS} -O3 -fvisibility=hidden -ffunction-sections -fno-data-sections")
 else ()
     set(CMAKE_CXX_FLAGS "${COMMON_CMAKE_ARGUMENTS} -g")
-#    set(CMAKE_CXX_FLAGS "${COMMON_CMAKE_ARGUMENTS} -O3 -fvisibility=hidden -ffunction-sections -fno-data-sections")
 endif ()
 
 if (NOT OPTIMIZED_BUILD OR OPTIMIZED_WITH_INSPECTOR_BUILD)