Skip to content

Commit 56702b4

Browse files
committed
ci(runtime): isolate stacked engine benchmarks
1 parent 7799ec9 commit 56702b4

3 files changed

Lines changed: 14 additions & 2 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,18 @@ jobs:
157157
158158
- name: Build base CLI
159159
run: |
160+
# Candidate and base can pin different engine releases and CMake
161+
# layouts. Their ignored build/framework outputs must not bleed into
162+
# one another when both revisions are built in this checkout.
163+
rm -rf ./dist/intermediates/macos ./dist/NativeScript.xcframework
164+
case "${ENGINE}" in
165+
v8)
166+
rm -rf ./Frameworks/libv8_monolith.xcframework
167+
;;
168+
hermes)
169+
rm -rf ./Frameworks/hermes.xcframework ./Frameworks/hermes-headers
170+
;;
171+
esac
160172
git checkout --detach "${BASE_SHA}"
161173
git submodule update --init --recursive
162174
npm install

‎platforms/apple/test/runtime/runner/app/tests/Timers.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ describe("native timer", () => {
212212
pending("Timer cleanup introspection is unavailable in this JSC runtime configuration.");
213213
done();
214214
} else {
215-
expectWeakRefCleared(weakRef, done, isIOS && isJSC ? 10000 : 1500);
215+
expectWeakRefCleared(weakRef, done, isJSC ? 10000 : 1500);
216216
}
217217
});
218218
}, 200);

‎scripts/download_hermes.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ HERMES_ANDROID_ASSET="hermes-android.tar.gz"
1919
HERMES_RELEASE_URL="https://github.com/ammarahm-ed/build-hermes/releases/download/$HERMES_VERSION"
2020

2121
REPO_ROOT="$(cd "$(dirname "$0")/.." && pwd -P)"
22-
DL_DIR="${HERMES_DOWNLOAD_DIR:-/tmp/hermes-dl}"
22+
DL_DIR="${HERMES_DOWNLOAD_DIR:-/tmp/hermes-dl/$HERMES_VERSION}"
2323

2424
# Shared headers, used by both platforms.
2525
HERMES_HEADERS_DIR="$REPO_ROOT/vendor/hermes/include"

0 commit comments

Comments
 (0)