From 92e055349f53e689744bef5dfb05f7624c06d48e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B6=81=EA=B2=BD=EB=AF=B8?= Date: Thu, 27 Aug 2026 21:32:57 +0900 Subject: [PATCH 1/4] [#24] fix: remove type: module for CJS compat MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 4개 패키지(core/hono/koa/next)의 "type": "module" 제거. type: module 선언과 CJS 산출물(dist/cjs/*.js) 조합이 Node require()에서 exports is not defined 유발. ESM 산출물은 .mjs라 영향 없음. 타입 매핑을 빌드 산출물(index.d.mts / cjs index.d.ts)에 맞게 갱신. Refs #24 --- packages/core/package.json | 7 +++---- packages/hono/package.json | 7 +++---- packages/koa/package.json | 7 +++---- packages/next/package.json | 7 +++---- 4 files changed, 12 insertions(+), 16 deletions(-) diff --git a/packages/core/package.json b/packages/core/package.json index b9b4a78..fdf69a8 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -14,15 +14,14 @@ }, "author": "oneweek-lee", "sideEffects": false, - "type": "module", "exports": { ".": { "import": { - "types": "./dist/esm/index.d.ts", + "types": "./dist/esm/index.d.mts", "default": "./dist/esm/index.mjs" }, "require": { - "types": "./dist/cjs/index.d.cts", + "types": "./dist/cjs/index.d.ts", "default": "./dist/cjs/index.js" } }, @@ -30,7 +29,7 @@ }, "main": "./dist/cjs/index.js", "module": "./dist/esm/index.mjs", - "types": "./dist/esm/index.d.ts", + "types": "./dist/esm/index.d.mts", "files": [ "dist" ], diff --git a/packages/hono/package.json b/packages/hono/package.json index 121fb25..af8dc03 100644 --- a/packages/hono/package.json +++ b/packages/hono/package.json @@ -16,15 +16,14 @@ }, "author": "oneweek-lee", "sideEffects": false, - "type": "module", "exports": { ".": { "import": { - "types": "./dist/esm/index.d.ts", + "types": "./dist/esm/index.d.mts", "default": "./dist/esm/index.mjs" }, "require": { - "types": "./dist/cjs/index.d.cts", + "types": "./dist/cjs/index.d.ts", "default": "./dist/cjs/index.js" } }, @@ -32,7 +31,7 @@ }, "main": "./dist/cjs/index.js", "module": "./dist/esm/index.mjs", - "types": "./dist/esm/index.d.ts", + "types": "./dist/esm/index.d.mts", "files": [ "dist" ], diff --git a/packages/koa/package.json b/packages/koa/package.json index 4f1b6c8..1e727db 100644 --- a/packages/koa/package.json +++ b/packages/koa/package.json @@ -16,15 +16,14 @@ }, "author": "oneweek-lee", "sideEffects": false, - "type": "module", "exports": { ".": { "import": { - "types": "./dist/esm/index.d.ts", + "types": "./dist/esm/index.d.mts", "default": "./dist/esm/index.mjs" }, "require": { - "types": "./dist/cjs/index.d.cts", + "types": "./dist/cjs/index.d.ts", "default": "./dist/cjs/index.js" } }, @@ -32,7 +31,7 @@ }, "main": "./dist/cjs/index.js", "module": "./dist/esm/index.mjs", - "types": "./dist/esm/index.d.ts", + "types": "./dist/esm/index.d.mts", "files": [ "dist" ], diff --git a/packages/next/package.json b/packages/next/package.json index 369afa1..be50d82 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -15,15 +15,14 @@ }, "author": "oneweek-lee", "sideEffects": false, - "type": "module", "exports": { ".": { "import": { - "types": "./dist/esm/index.d.ts", + "types": "./dist/esm/index.d.mts", "default": "./dist/esm/index.mjs" }, "require": { - "types": "./dist/cjs/index.d.cts", + "types": "./dist/cjs/index.d.ts", "default": "./dist/cjs/index.js" } }, @@ -31,7 +30,7 @@ }, "main": "./dist/cjs/index.js", "module": "./dist/esm/index.mjs", - "types": "./dist/esm/index.d.ts", + "types": "./dist/esm/index.d.mts", "files": [ "dist" ], From fd828854febaa3d48e0180eeb7e5fed3012a4f42 Mon Sep 17 00:00:00 2001 From: Koong Kyungmi Date: Thu, 27 Aug 2026 21:39:12 +0900 Subject: [PATCH 2/4] Add changeset for compatibility fix in modules Removed 'type: module' for Node require() compatibility. --- .changeset/early-hands-float.md | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 .changeset/early-hands-float.md diff --git a/.changeset/early-hands-float.md b/.changeset/early-hands-float.md new file mode 100644 index 0000000..4590882 --- /dev/null +++ b/.changeset/early-hands-float.md @@ -0,0 +1,10 @@ +--- +"@naverpay/prometheus-core": patch +"@naverpay/prometheus-hono": patch +"@naverpay/prometheus-koa": patch +"@naverpay/prometheus-next": patch +--- + +[#24] fix: type: module 제거로 Node require() 호환성 해결 + +PR: [[#24] fix: type: module 제거로 Node require() 호환성 해결](https://github.com/NaverPayDev/prometheus/pull/25) From 7481f7ebcbcff6b9cc29bcd7a5b2b0266a881e10 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B6=81=EA=B2=BD=EB=AF=B8?= Date: Thu, 27 Aug 2026 22:09:01 +0900 Subject: [PATCH 3/4] =?UTF-8?q?[#24]=20fix:=20package.json=EC=97=90=20type?= =?UTF-8?q?=20commonjs=20=EB=AA=85=EC=8B=9C?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit type: module 제거 후 기본값에 의존하던 것을 명시적 type: commonjs 로 확정. - require-type eslint 규칙 충족 (type 필수) - dist/cjs/*.js -> CommonJS, dist/esm/*.mjs -> ESM 확정 해석 (닫기: exports is not defined) Refs #24 --- packages/core/package.json | 1 + packages/hono/package.json | 1 + packages/koa/package.json | 1 + packages/next/package.json | 1 + 4 files changed, 4 insertions(+) diff --git a/packages/core/package.json b/packages/core/package.json index fdf69a8..e831bdb 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -14,6 +14,7 @@ }, "author": "oneweek-lee", "sideEffects": false, + "type": "commonjs", "exports": { ".": { "import": { diff --git a/packages/hono/package.json b/packages/hono/package.json index af8dc03..9f334a4 100644 --- a/packages/hono/package.json +++ b/packages/hono/package.json @@ -16,6 +16,7 @@ }, "author": "oneweek-lee", "sideEffects": false, + "type": "commonjs", "exports": { ".": { "import": { diff --git a/packages/koa/package.json b/packages/koa/package.json index 1e727db..4a492ae 100644 --- a/packages/koa/package.json +++ b/packages/koa/package.json @@ -16,6 +16,7 @@ }, "author": "oneweek-lee", "sideEffects": false, + "type": "commonjs", "exports": { ".": { "import": { diff --git a/packages/next/package.json b/packages/next/package.json index be50d82..516096a 100644 --- a/packages/next/package.json +++ b/packages/next/package.json @@ -15,6 +15,7 @@ }, "author": "oneweek-lee", "sideEffects": false, + "type": "commonjs", "exports": { ".": { "import": { From 3c5ebc202fd4bdcf75d46cad57d6971ae50726d7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=EA=B6=81=EA=B2=BD=EB=AF=B8?= Date: Thu, 27 Aug 2026 22:19:48 +0900 Subject: [PATCH 4/4] =?UTF-8?q?[#24]=20ci:=20packages=5Fdir=EC=9D=84=20'pa?= =?UTF-8?q?ckages'=EB=A1=9C=20=EB=B3=80=EA=B2=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .github/workflows/release.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index c54a763..a4fabd7 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -87,7 +87,7 @@ jobs: github_token: ${{ secrets.ACTION_TOKEN }} npm_tag: canary publish_script: pnpm run release:canary - packages_dir: '.' + packages_dir: 'packages' excludes: '.turbo,.github' version_template: '{VERSION}-canary.{DATE}-{COMMITID7}' @@ -98,7 +98,7 @@ jobs: github_token: ${{ secrets.ACTION_TOKEN }} npm_tag: rc publish_script: pnpm run release:canary - packages_dir: '.' + packages_dir: 'packages' excludes: '.turbo,.github' version_template: '{VERSION}-rc.{DATE}-{COMMITID7}' create_release: true