[CSTACKEX-204] Change the frequency min limit to 3 hours

Author: Gupta, Surya

plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapStorageConstants.java

@@ -171,7 +171,7 @@ public class OntapStorageConstants {
     public static final String ASUP_ENABLED_CONFIG_KEY = "ontap.asup.enabled";
     public static final String ASUP_ENABLED_DEFAULT = "true";
     public static final String ASUP_INTERVAL_CONFIG_KEY = "ontap.asup.interval";
-    public static final int ASUP_MIN_INTERVAL_HOURS = 1; // 1 hour (demo; production is 3)
+    public static final int ASUP_MIN_INTERVAL_HOURS = 3;
     public static final int ASUP_MAX_INTERVAL_HOURS = 24;
     public static final int ASUP_DEFAULT_INTERVAL_HOURS = 12;
 

plugins/storage/volume/ontap/src/test/java/org/apache/cloudstack/storage/asup/OntapAsupManagerTest.java

@@ -540,6 +540,7 @@ void validateAsupInterval_acceptsMinMaxAndDefault() {
 
     @Test
     void validateAsupInterval_rejectsOutOfRangeAndNonInteger() {
+        assertThrows(InvalidParameterValueException.class, () -> OntapConfigurationManager.AsupIntervalHours.validateValue("2"));
         assertThrows(InvalidParameterValueException.class, () -> OntapConfigurationManager.AsupIntervalHours.validateValue("0"));
         assertThrows(InvalidParameterValueException.class, () -> OntapConfigurationManager.AsupIntervalHours.validateValue("25"));
         assertThrows(InvalidParameterValueException.class, () -> OntapConfigurationManager.AsupIntervalHours.validateValue("abc"));
@@ -552,7 +553,7 @@ void getAsupIntervalHours_fallsBackOutsideRange() {
                 asupManager.getAsupIntervalHours(null));
         assertEquals(OntapStorageConstants.ASUP_DEFAULT_INTERVAL_HOURS,
                 asupManager.getAsupIntervalHours(0));
-        assertEquals(2,
+        assertEquals(OntapStorageConstants.ASUP_DEFAULT_INTERVAL_HOURS,
                 asupManager.getAsupIntervalHours(2));
         assertEquals(OntapStorageConstants.ASUP_DEFAULT_INTERVAL_HOURS,
                 asupManager.getAsupIntervalHours(25));