From 60477eae0d2c824ee2aa0b16d1e74e8a56359e68 Mon Sep 17 00:00:00 2001 From: erwan-joly Date: Mon, 31 Aug 2026 02:13:53 +1200 Subject: [PATCH] chore: drop the dead PrintHeader catch NosCore.Shared 6.0.2 gives PrintHeader a width to fall back on when no console can answer, so nothing reaches the catch that was swallowing it. Tested: builds with 0 warnings, tests green (5 tests). --- src/NosCore.ParserInputGenerator.Launcher/Worker.cs | 9 +-------- .../NosCore.ParserInputGenerator.csproj | 2 +- 2 files changed, 2 insertions(+), 9 deletions(-) diff --git a/src/NosCore.ParserInputGenerator.Launcher/Worker.cs b/src/NosCore.ParserInputGenerator.Launcher/Worker.cs index 7acd580..bde1097 100644 --- a/src/NosCore.ParserInputGenerator.Launcher/Worker.cs +++ b/src/NosCore.ParserInputGenerator.Launcher/Worker.cs @@ -71,14 +71,7 @@ public Worker(ILogger logger, IClientDownloader client, IExtractor extra /// A task representing the asynchronous operation. protected override async Task ExecuteAsync(CancellationToken stoppingToken) { - try - { - Logger.PrintHeader(ConsoleText); - } - catch - { - // ignored as header is not important - } + Logger.PrintHeader(ConsoleText); var manifest = await _client.DownloadManifest(); var requestedFiles = _parserInputFiles.ToHashSet(System.StringComparer.OrdinalIgnoreCase); diff --git a/src/NosCore.ParserInputGenerator/NosCore.ParserInputGenerator.csproj b/src/NosCore.ParserInputGenerator/NosCore.ParserInputGenerator.csproj index e2cb596..2f08d28 100644 --- a/src/NosCore.ParserInputGenerator/NosCore.ParserInputGenerator.csproj +++ b/src/NosCore.ParserInputGenerator/NosCore.ParserInputGenerator.csproj @@ -42,7 +42,7 @@ - +