Skip to content

Update Pako library to the latest version #15

Description

@alex-titarenko

Apparently Pako v2.* has some breaking changes that prevent us from updating it without deep investigation.

Problematic code in this library:

inflator.push(chunk, false)
if (inflator.err) {
throw new InternalError(`Pako error: ${inflator.msg}`)
}

Problematic code on pako library:
https://github.com/nodeca/pako/blob/174a1d12b68dfbd531a572eaaea0937491b36f55/lib/inflate.js#L237-L245

// Skip snyc markers if more data follows and not raw mode
while (strm.avail_in > 0 &&
       status === Z_STREAM_END &&
       strm.state.wrap > 0 &&
       data[strm.next_in] !== 0)
{
  zlib_inflate.inflateReset(strm);
  status = zlib_inflate.inflate(strm, _flush_mode);
}

this does not exist in Pako v1.* and causes the following error in Inflator
Err: -3, msg: 'incorrect header check'

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions