Skip to content

Change logs are not recording all relevant commits #2479

Description

@bowd

For reasons beyond me, I've been looking through the CHANGELOG.md and I'm seeing a lot of empty versions. Looking at v2.111.14 in particular you can see there's something in the commit diff that seams relevant.

I've traced it back to the change log generation script, which contains the following relevant bits:

# If the subject contains "Merge pull request #xxxxx" then it is deemed a pull request
if pull_request=$( grep -Eo "Merge pull request #[[:digit:]]+" <<< "$subject" );then
	# Process merge commits from PRs
	...
fi

if grep -qEo "[[:alpha:]]+:" <<< "$subject"; then
    # Process conventional commits
    ...
fi

It seams to me that the implied standard of this tooling is that you have to either:
a) Use normal merge commits instead of squash commits, or
b) Use the standard <type>: description commit naming structure for the squash commit.

So my assumption is that you're doing (b) without the naming structured and that's making the change logs less valuable.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions