From 9bbe579687d6abcef4012d4a5b7e16e385ae60be Mon Sep 17 00:00:00 2001 From: Nick Josevski Date: Wed, 19 Aug 2026 16:23:32 +1000 Subject: [PATCH] ci: stop Update README corrupting the plugin version lines Releasing 1.0.0 (#13) is blocked by a failing Lint check, and the cause is this workflow, not the release. The sed used `.*` after `create-release#`, which also consumed the trailing colon of the YAML mapping key: - OctopusDeploy/create-release#v0.1.1: -> - OctopusDeploy/create-release#v1.0.0 Every example then had an unkeyed sequence entry followed by indented mappings, so the plugin linter fails with "bad indentation of a sequence entry". The bug has been here since the workflow was added; it simply never ran, because there has been no release since 2022. The replacement matches only the version and always re-emits the colon, so it is also self-healing on a README a previous run already mangled. It still leaves other plugins' refs (e.g. octopus-login#) alone. Also adds a concurrency group. release-please pushed to the release branch three times in quick succession, and the three resulting runs raced on git push; one failed with "! [rejected] ... (fetch first)". Verified by running the new sed over main's README and linting the result: 7 examples valid, no YAML errors. Co-Authored-By: Claude Opus 5 (1M context) --- .github/workflows/update-readme.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/update-readme.yml b/.github/workflows/update-readme.yml index 8cc5323..9ff2f5c 100644 --- a/.github/workflows/update-readme.yml +++ b/.github/workflows/update-readme.yml @@ -3,6 +3,9 @@ on: branches: - release-please--** name: "Update README" +concurrency: + group: update-readme-${{ github.ref }} + cancel-in-progress: false jobs: build: runs-on: ubuntu-latest @@ -13,7 +16,7 @@ jobs: - name: Update README run: |- VERSION=$(cat version.txt) - sed -i "s/\(OctopusDeploy\/create-release#\).*/\1v${VERSION}/g" README.md + sed -i -E "s|(OctopusDeploy/create-release#)v?[0-9][^:[:space:]]*:?|\1v${VERSION}:|g" README.md - name: commit run: |- git config --global user.name "team-integrations-fnm-bot"