From b8e5d134b959208527a9ec58cb25cf186b2f729b Mon Sep 17 00:00:00 2001 From: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Date: Sat, 10 Oct 2026 01:06:00 +0000 Subject: [PATCH] fix(libraries): declare DiagramLayout, IdentityMetadata, MigrationMetadata and SysMLValidation as library package Co-Authored-By: jason.han --- README.md | 7 +++---- libraries/DiagramLayout.sysml | 2 +- libraries/IdentityMetadata.sysml | 2 +- libraries/MigrationMetadata.sysml | 2 +- libraries/SysMLValidation.sysml | 2 +- scripts/validate-libraries.sh | 2 +- validation/allowed-warnings.txt | 10 ++-------- 7 files changed, 10 insertions(+), 17 deletions(-) diff --git a/README.md b/README.md index 6efb352..479b66b 100644 --- a/README.md +++ b/README.md @@ -101,10 +101,9 @@ the manifest against the base and fails on unannounced breaking changes. `./scripts/validate-libraries.sh` runs the pinned OMG pilot batch validator (`scripts/pilot-pin.sh`) over `libraries/` and requires zero errors and zero -warnings. Four warnings are temporarily allow-listed in -`validation/allowed-warnings.txt` — the four files that still declare -`standard library package`; an upstream change to `library package` is being -ported and those entries will be deleted. The allow-list only shrinks. +warnings. `validation/allowed-warnings.txt` is empty: no warning is +allow-listed, and the ratchet fails on any allow-list entry the validator no +longer emits. ## License diff --git a/libraries/DiagramLayout.sysml b/libraries/DiagramLayout.sysml index 3fc5f80..fdf0b1a 100644 --- a/libraries/DiagramLayout.sysml +++ b/libraries/DiagramLayout.sysml @@ -1,4 +1,4 @@ -standard library package DiagramLayout { +library package DiagramLayout { doc /* Diagram geometry in notation: where a view draws an element, the * waypoints an edge is drawn through and the extent of the drawing * surface. Units are pixels, y down, origin at the top left. diff --git a/libraries/IdentityMetadata.sysml b/libraries/IdentityMetadata.sysml index 815716a..e11b564 100644 --- a/libraries/IdentityMetadata.sysml +++ b/libraries/IdentityMetadata.sysml @@ -1,4 +1,4 @@ -standard library package IdentityMetadata { +library package IdentityMetadata { doc /* Binds notation to repository identity. Non-normative OpenSysML * extension, proposed for standardization; see the design record. */ diff --git a/libraries/MigrationMetadata.sysml b/libraries/MigrationMetadata.sysml index 1537f13..169dd88 100644 --- a/libraries/MigrationMetadata.sysml +++ b/libraries/MigrationMetadata.sysml @@ -1,4 +1,4 @@ -standard library package MigrationMetadata { +library package MigrationMetadata { doc /* What a migration from another modeling language had to make up * because its source left it unstated. Non-normative OpenSysML * extension, proposed for standardization; see the design record. */ diff --git a/libraries/SysMLValidation.sysml b/libraries/SysMLValidation.sysml index 56ce94d..c7f709b 100644 --- a/libraries/SysMLValidation.sysml +++ b/libraries/SysMLValidation.sysml @@ -1,4 +1,4 @@ -standard library package SysMLValidation { +library package SysMLValidation { doc /* * Validation constraints of the KerML and SysML abstract syntax, stated over diff --git a/scripts/validate-libraries.sh b/scripts/validate-libraries.sh index f2036a9..581bce2 100755 --- a/scripts/validate-libraries.sh +++ b/scripts/validate-libraries.sh @@ -67,4 +67,4 @@ if [[ "$fail" -ne 0 ]]; then fi count="$(grep -cE '^[^:]+:[0-9]+:[0-9]+: (error|warning): ' <<<"$diagnostics" || true)" -echo "Validation clean: 0 errors, $count allow-listed warning(s)" +echo "Validation clean: 0 errors, $count warning(s)" diff --git a/validation/allowed-warnings.txt b/validation/allowed-warnings.txt index 906bd3c..8f3342f 100644 --- a/validation/allowed-warnings.txt +++ b/validation/allowed-warnings.txt @@ -1,11 +1,5 @@ # Warnings the pinned OMG pilot validator emits over libraries/ that the gate # accepts for now, exactly as the validator prints them. # -# These four files declare `standard library package`; an open -# Open-MBEE/OpenSysML pull request changes them to `library package`. Once it -# merges, the change is ported here and these entries are deleted. This list -# may only shrink: an entry the validator stops emitting fails the gate. -DiagramLayout.sysml:1:1: warning: User library packages should not be marked as standard -IdentityMetadata.sysml:1:1: warning: User library packages should not be marked as standard -MigrationMetadata.sysml:1:1: warning: User library packages should not be marked as standard -SysMLValidation.sysml:1:1: warning: User library packages should not be marked as standard +# Currently empty: no warning is allow-listed. This list may only shrink: an +# entry the validator stops emitting fails the gate.