From 2f9eb9be823d26ce7a993d37fe0e4c39ffc9752e Mon Sep 17 00:00:00 2001 From: shubham Date: Thu, 11 Jun 2026 00:37:12 +0530 Subject: [PATCH 1/2] fix: add object.__init__() call in MFDatasetCommonDims and WebMapService classes --- mslib/utils/netCDF4tools.py | 4 +++- mslib/utils/ogcwms.py | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/mslib/utils/netCDF4tools.py b/mslib/utils/netCDF4tools.py index 1e19eae6f..6fa39e612 100644 --- a/mslib/utils/netCDF4tools.py +++ b/mslib/utils/netCDF4tools.py @@ -237,12 +237,14 @@ def __init__(self, files, exclude=None, skip_dim_check=None, """ # Open the master file in the base class, so that the CDFMF instance # can be used like a CDF instance. - exclude = exclude or [] skip_dim_check = skip_dim_check or [] if isinstance(files, str): files = sorted(glob.glob(files)) + # Call parent class __init__ + super().__init__(files, exclude=exclude) + master = files[0] # Open the master again, this time as a classic CDF instance. This will avoid diff --git a/mslib/utils/ogcwms.py b/mslib/utils/ogcwms.py index f9b2bdcc2..634d415bd 100644 --- a/mslib/utils/ogcwms.py +++ b/mslib/utils/ogcwms.py @@ -172,6 +172,9 @@ def __init__(self, url, version=None, xml=None, username=None, password=None, timeout=config_loader(dataset="WMS_request_timeout"), auth=None): """Initialize.""" + super().__init__(url=url, version=version, xml=xml, username=username, + password=password, parse_remote_metadata=parse_remote_metadata, + headers=headers, auth=auth) if auth: if username: From c997fc89316e491d4ca6427cca50644c0dd67cc9 Mon Sep 17 00:00:00 2001 From: shubham Date: Sun, 14 Jun 2026 23:04:25 +0530 Subject: [PATCH 2/2] revert: remove object.__init__() calls causing test failures in CI --- mslib/utils/netCDF4tools.py | 2 +- mslib/utils/ogcwms.py | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/mslib/utils/netCDF4tools.py b/mslib/utils/netCDF4tools.py index 6fa39e612..49092cb40 100644 --- a/mslib/utils/netCDF4tools.py +++ b/mslib/utils/netCDF4tools.py @@ -243,7 +243,7 @@ def __init__(self, files, exclude=None, skip_dim_check=None, files = sorted(glob.glob(files)) # Call parent class __init__ - super().__init__(files, exclude=exclude) + master = files[0] diff --git a/mslib/utils/ogcwms.py b/mslib/utils/ogcwms.py index 634d415bd..96b1b8c1b 100644 --- a/mslib/utils/ogcwms.py +++ b/mslib/utils/ogcwms.py @@ -172,9 +172,8 @@ def __init__(self, url, version=None, xml=None, username=None, password=None, timeout=config_loader(dataset="WMS_request_timeout"), auth=None): """Initialize.""" - super().__init__(url=url, version=version, xml=xml, username=username, - password=password, parse_remote_metadata=parse_remote_metadata, - headers=headers, auth=auth) + + if auth: if username: