Avoid Java 8 launcher warnings in checked JNI test processes

Author: peter-lawrey

affinity/src/test/java/net/openhft/affinity/AffinityInitializationTest.java

@@ -58,7 +58,7 @@ protected Class<?> loadClass(String name, boolean resolve) throws ClassNotFoundE
     }
 
     public static void main(String[] args) throws Exception {
-        String scenario = args[0];
+        String scenario = System.getProperty("affinity.test.scenario");
         ClassLoader loader = AffinityInitializationTest.class.getClassLoader();
         if (scenario.equals("absent")) {
             assertThrows(ClassNotFoundException.class, () -> Class.forName("com.sun.jna.Native", false, loader));

affinity/src/test/java/net/openhft/affinity/AffinityTestProcess.java

@@ -33,10 +33,11 @@ void runProbe(Class<?> probe, String scenario, boolean withJna, String... option
         List<String> command = new ArrayList<>();
         command.add(new File(System.getProperty("java.home"), "bin/java").getAbsolutePath());
         command.addAll(Arrays.asList(options));
+        // Avoid Java 8 launcher argument-conversion warnings before the checked JNI calls.
+        command.add("-Daffinity.test.scenario=" + scenario);
         command.add("-cp");
         command.add(classpath);
         command.add(probe.getName());
-        command.add(scenario);
         Process process = new ProcessBuilder(command).redirectErrorStream(true).redirectOutput(output.toFile()).start();
         boolean finished;
         try {

affinity/src/test/java/net/openhft/affinity/NativeAffinityIntegrationTest.java

@@ -52,7 +52,7 @@ private void runNativeProbe(String scenario) throws Exception {
     }
 
     public static void main(String[] args) {
-        String scenario = args[0];
+        String scenario = System.getProperty("affinity.test.scenario");
         assertTrue(NativeAffinity.LOADED, "The library built by this checkout must load");
         NativeAffinity nativeAffinity = NativeAffinity.INSTANCE;
         BitSet original = nativeAffinity.getAffinity();