Skip to content

[OMPD] The LLVM OMPD ompd_device_initialize() function has a few problems #63

Description

@jdelsign

The LLVM OMPD ompd_device_initialize() has a few problems for NVIDIA devices (based on a brief review I did of the sources):

  • It does not check the kind argument to make sure that it is OMPD_DEVICE_KIND_CUDA.
  • It does not check that the sizeof_id is 8.
  • It assumes that (*id) is 64-bit aligned, though that's probably OK if the size is 8.
  • It saves the id argument in ompd_address_space_handle_t::id, which is the pointer to the 64-bit context, not context value itself. But, I'm not sure that field is used anywhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions