From 9a9ef48f7597149cafec22bc9fac84eb2a230fd8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Wed, 1 Apr 2026 11:08:39 +0200 Subject: [PATCH 01/16] add BlSimpleShadowEffect --- .../PyramidBackgroundBlocPlugin.class.st | 68 ++++++++++++++++++- .../PyramidSaveModelVerifier.class.st | 5 +- .../PyramidShadowColorCommand.class.st | 21 ++++++ .../PyramidShadowCommand.class.st | 17 +++++ .../PyramidShadowOffsetCommand.class.st | 24 +++++++ 5 files changed, 132 insertions(+), 3 deletions(-) create mode 100644 src/Pyramid-Bloc/PyramidShadowColorCommand.class.st create mode 100644 src/Pyramid-Bloc/PyramidShadowCommand.class.st create mode 100644 src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index e2702d10..163a2f2e 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -671,6 +671,67 @@ PyramidBackgroundBlocPlugin class >> outskirts [ ^ property ] +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadow [ + + | property | + property := PyramidProperty new + name: 'Shadow Effect'; + command: PyramidShadowCommand new; + inputPresenterClass: PyramidMagicButtonsInputPresenter; + yourself. + property inputPresenterModel + addButtonModel: (PyramidMagicButtonModel new + icon: (Smalltalk ui icons iconNamed: #blank); + helpSelected: 'No shadow.'; + helpNotSelected: 'Remove shadow.'; + label: 'None'; + inputValue: [ BlNullEffect new]; + inputValidation: [ :value | value class = BlNullEffect]; + yourself); + addButtonModel: (PyramidMagicButtonModel new + icon: (Smalltalk ui icons iconNamed: #menuPin); + helpSelected: 'Shadow type is simple.'; + helpNotSelected: 'Set shadow type to simple.'; + label: 'Simple'; + inputValue: [ + BlSimpleShadowEffect color: Color random offset: 2 @ 2 ]; + inputValidation: [ :value | value class = BlSimpleShadowEffect ]; + yourself); + yourself. + ^ property +] + +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadowColor [ + + | property | + property := PyramidProperty new + name: 'Shadow Color'; + command: PyramidShadowColorCommand new; + inputPresenterClass: + PyramidColorInputSingleLineWithPickupButtonPresenter; + yourself. + ^ property + + +] + +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadowOffset [ + + | property | + property := PyramidProperty new + name: 'Shadow Offset'; + command: PyramidShadowOffsetCommand new; + inputPresenterClass: + PyramidPointInputPresenter; + yourself. + property inputPresenterModel help: + 'Set the position x and y for the shadow offset'. + ^ property +] + { #category : #adding } PyramidBackgroundBlocPlugin >> addPanelsOn: aPyramidSimpleWindow [ @@ -747,7 +808,12 @@ PyramidBackgroundBlocPlugin >> initialize [ propertiesManager addProperty: self class borderRadialInnerCenter. propertiesManager addProperty: self class borderRadialInnerRadius. propertiesManager addProperty: self class borderRadialOuterCenter. - propertiesManager addProperty: self class borderRadialOuterRadius + propertiesManager addProperty: self class borderRadialOuterRadius. + + "Shadow" + propertiesManager addProperty: self class shadow. + propertiesManager addProperty: self class shadowColor. + propertiesManager addProperty: self class shadowOffset ] { #category : #adding } diff --git a/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st b/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st index d8425326..6374cc47 100644 --- a/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st +++ b/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st @@ -47,9 +47,10 @@ PyramidSaveModelVerifier class >> classPackageIsEqual [ PyramidSaveModelVerifier class >> methodIsValid [ ^ self new - verifyBlock: [ :model | model savingMethodName isValidSelector ]; + verifyBlock: [ :model | + OCScanner isSelector: model savingMethodName ]; showBlock: [ :view | view showMethodIsNotValidError ]; - yourself. + yourself ] { #category : #constructor } diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st new file mode 100644 index 00000000..d9c6793e --- /dev/null +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -0,0 +1,21 @@ +Class { + #name : #PyramidShadowColorCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #testing } +PyramidShadowColorCommand >> canBeUsedFor: anObject [ + ^ (super canBeUsedFor: anObject) and: [ + anObject effect isKindOf: BlShadowEffect ] +] + +{ #category : #'as yet unclassified' } +PyramidShadowColorCommand >> getValueFor: aBlElement [ + ^ aBlElement effect color +] + +{ #category : #initialization } +PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ + aBlElement effect: (aBlElement effect copyWithColor: aColor) +] diff --git a/src/Pyramid-Bloc/PyramidShadowCommand.class.st b/src/Pyramid-Bloc/PyramidShadowCommand.class.st new file mode 100644 index 00000000..4999233d --- /dev/null +++ b/src/Pyramid-Bloc/PyramidShadowCommand.class.st @@ -0,0 +1,17 @@ +Class { + #name : #PyramidShadowCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #'as yet unclassified' } +PyramidShadowCommand >> getValueFor: aBlElement [ + + ^ aBlElement effect +] + +{ #category : #'as yet unclassified' } +PyramidShadowCommand >> setValueFor: aBlElement with: anArgument [ + + aBlElement effect: anArgument +] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st new file mode 100644 index 00000000..225f9660 --- /dev/null +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -0,0 +1,24 @@ +Class { + #name : #PyramidShadowOffsetCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #testing } +PyramidShadowOffsetCommand >> canBeUsedFor: anObject [ + + ^ (super canBeUsedFor: anObject) and: [ + anObject effect isKindOf: BlShadowEffect ] +] + +{ #category : #'as yet unclassified' } +PyramidShadowOffsetCommand >> getValueFor: aBlElement [ + + ^ aBlElement effect offset +] + +{ #category : #'as yet unclassified' } +PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ + + aBlElement effect: (aBlElement effect copyWithOffset: aPoint) +] From b862d3defc7660a2581e0a1a2ead1484ea28298e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Wed, 1 Apr 2026 14:52:03 +0200 Subject: [PATCH 02/16] add BlGaussianShadow and its properties --- .../PyramidBackgroundBlocPlugin.class.st | 29 +++++++++++++++++-- ...PyramidGaussianShadowWidthCommand.class.st | 24 +++++++++++++++ 2 files changed, 50 insertions(+), 3 deletions(-) create mode 100644 src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index 163a2f2e..2d9ede16 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -618,6 +618,19 @@ PyramidBackgroundBlocPlugin class >> borderWidth [ ^ property ] +{ #category : #'as yet unclassified' } +PyramidBackgroundBlocPlugin class >> gaussianShadowWidth [ + + | property | + property := PyramidProperty new + name: 'Shadow Width'; + command: PyramidGaussianShadowWidthCommand new; + inputPresenterClass: PyramidNumberInputPresenter; + yourself. + property inputPresenterModel help: 'Set the width value'. + ^ property +] + { #category : #accessing } PyramidBackgroundBlocPlugin class >> opacity [ @@ -686,8 +699,8 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'No shadow.'; helpNotSelected: 'Remove shadow.'; label: 'None'; - inputValue: [ BlNullEffect new]; - inputValidation: [ :value | value class = BlNullEffect]; + inputValue: [ BlNullEffect new ]; + inputValidation: [ :value | value class = BlNullEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new icon: (Smalltalk ui icons iconNamed: #menuPin); @@ -698,6 +711,15 @@ PyramidBackgroundBlocPlugin class >> shadow [ BlSimpleShadowEffect color: Color random offset: 2 @ 2 ]; inputValidation: [ :value | value class = BlSimpleShadowEffect ]; yourself); + addButtonModel: (PyramidMagicButtonModel new + icon: (Smalltalk ui icons iconNamed: #menuPin); + helpSelected: 'Shadow type is gaussian.'; + helpNotSelected: 'Set shadow type to gaussian.'; + label: 'Gaussian'; + inputValue: [ + BlGaussianShadowEffect color: Color random width: 2 offset: 2 @ 2 ]; + inputValidation: [ :value | value class = BlGaussianShadowEffect ]; + yourself); yourself. ^ property ] @@ -813,7 +835,8 @@ PyramidBackgroundBlocPlugin >> initialize [ "Shadow" propertiesManager addProperty: self class shadow. propertiesManager addProperty: self class shadowColor. - propertiesManager addProperty: self class shadowOffset + propertiesManager addProperty: self class shadowOffset. + propertiesManager addProperty: self class gaussianShadowWidth ] { #category : #adding } diff --git a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st new file mode 100644 index 00000000..e71d80dc --- /dev/null +++ b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st @@ -0,0 +1,24 @@ +Class { + #name : #PyramidGaussianShadowWidthCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #testing } +PyramidGaussianShadowWidthCommand >> canBeUsedFor: anObject [ + + ^ (super canBeUsedFor: anObject) and: [ + anObject effect isKindOf: BlGaussianShadowEffect ] +] + +{ #category : #'as yet unclassified' } +PyramidGaussianShadowWidthCommand >> getValueFor: aBlElement [ + + ^ aBlElement effect width +] + +{ #category : #'as yet unclassified' } +PyramidGaussianShadowWidthCommand >> setValueFor: aBlElement with: aValue [ + + aBlElement effect: (aBlElement effect copyWithWidth: aValue) +] From 0e5367d2c5cadbb9bfd27d36b4cc710255dad59c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Mon, 13 Apr 2026 13:55:21 +0200 Subject: [PATCH 03/16] icon changes for BlShadowEffect --- src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index 2d9ede16..c2810361 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -703,7 +703,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ inputValidation: [ :value | value class = BlNullEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new - icon: (Smalltalk ui icons iconNamed: #menuPin); + icon: (Smalltalk ui icons iconNamed: #windowMaximize); helpSelected: 'Shadow type is simple.'; helpNotSelected: 'Set shadow type to simple.'; label: 'Simple'; @@ -712,12 +712,15 @@ PyramidBackgroundBlocPlugin class >> shadow [ inputValidation: [ :value | value class = BlSimpleShadowEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new - icon: (Smalltalk ui icons iconNamed: #menuPin); + icon: (Smalltalk ui icons iconNamed: #radioButtonUnselected); helpSelected: 'Shadow type is gaussian.'; helpNotSelected: 'Set shadow type to gaussian.'; label: 'Gaussian'; inputValue: [ - BlGaussianShadowEffect color: Color random width: 2 offset: 2 @ 2 ]; + BlGaussianShadowEffect + color: Color random + width: 2 + offset: 2 @ 2 ]; inputValidation: [ :value | value class = BlGaussianShadowEffect ]; yourself); yourself. From 66d84f430541cda5311305a55dcde3dda7779099 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 14 Apr 2026 10:59:02 +0200 Subject: [PATCH 04/16] Add support for saving the previous state of the shadow --- .../PyramidBackgroundBlocPlugin.class.st | 23 ++++++---- ...PyramidGaussianShadowWidthCommand.class.st | 5 ++- .../PyramidShadowColorCommand.class.st | 4 +- .../PyramidShadowCommand.class.st | 44 +++++++++++++++++++ .../PyramidShadowOffsetCommand.class.st | 4 +- 5 files changed, 66 insertions(+), 14 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index c2810361..3f1581a5 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -6,6 +6,9 @@ Class { #instVars : [ 'propertiesManager' ], + #classInstVars : [ + 'shadowCommand' + ], #category : #'Pyramid-Bloc-plugin-bloc-visuals' } @@ -685,12 +688,18 @@ PyramidBackgroundBlocPlugin class >> outskirts [ ] { #category : #accessing } -PyramidBackgroundBlocPlugin class >> shadow [ +PyramidBackgroundBlocPlugin class >> resetShadowCommand [ + shadowCommand := nil +] +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadow [ | property | + shadowCommand ifNil: [ shadowCommand := PyramidShadowCommand new ]. + PyramidShadowCommand current: shadowCommand. property := PyramidProperty new name: 'Shadow Effect'; - command: PyramidShadowCommand new; + command: shadowCommand; inputPresenterClass: PyramidMagicButtonsInputPresenter; yourself. property inputPresenterModel @@ -707,8 +716,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'Shadow type is simple.'; helpNotSelected: 'Set shadow type to simple.'; label: 'Simple'; - inputValue: [ - BlSimpleShadowEffect color: Color random offset: 2 @ 2 ]; + inputValue: [ shadowCommand lastSimpleShadow ]; inputValidation: [ :value | value class = BlSimpleShadowEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new @@ -716,11 +724,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'Shadow type is gaussian.'; helpNotSelected: 'Set shadow type to gaussian.'; label: 'Gaussian'; - inputValue: [ - BlGaussianShadowEffect - color: Color random - width: 2 - offset: 2 @ 2 ]; + inputValue: [ shadowCommand lastGaussianShadow ]; inputValidation: [ :value | value class = BlGaussianShadowEffect ]; yourself); yourself. @@ -836,6 +840,7 @@ PyramidBackgroundBlocPlugin >> initialize [ propertiesManager addProperty: self class borderRadialOuterRadius. "Shadow" + self class resetShadowCommand. propertiesManager addProperty: self class shadow. propertiesManager addProperty: self class shadowColor. propertiesManager addProperty: self class shadowOffset. diff --git a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st index e71d80dc..d134185b 100644 --- a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st +++ b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st @@ -18,7 +18,8 @@ PyramidGaussianShadowWidthCommand >> getValueFor: aBlElement [ ] { #category : #'as yet unclassified' } -PyramidGaussianShadowWidthCommand >> setValueFor: aBlElement with: aValue [ +PyramidGaussianShadowWidthCommand >> setValueFor: aBlElement with: aWidth [ - aBlElement effect: (aBlElement effect copyWithWidth: aValue) + aBlElement effect: (aBlElement effect copyWithWidth: aWidth). + PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st index d9c6793e..8faeb5cd 100644 --- a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -17,5 +17,7 @@ PyramidShadowColorCommand >> getValueFor: aBlElement [ { #category : #initialization } PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ - aBlElement effect: (aBlElement effect copyWithColor: aColor) + + aBlElement effect: (aBlElement effect copyWithColor: aColor). + PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowCommand.class.st b/src/Pyramid-Bloc/PyramidShadowCommand.class.st index 4999233d..b873244e 100644 --- a/src/Pyramid-Bloc/PyramidShadowCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowCommand.class.st @@ -1,17 +1,61 @@ Class { #name : #PyramidShadowCommand, #superclass : #PyramidAbstractBlocCommand, + #instVars : [ + 'lastSimpleShadow', + 'lastGaussianShadow' + ], + #classInstVars : [ + 'current' + ], #category : #'Pyramid-Bloc-plugin-bloc-visuals' } +{ #category : #accessing } +PyramidShadowCommand class >> current [ + ^ current + + +] + +{ #category : #accessing } +PyramidShadowCommand class >> current: anInstance [ + current := anInstance +] + { #category : #'as yet unclassified' } PyramidShadowCommand >> getValueFor: aBlElement [ ^ aBlElement effect ] +{ #category : #accessing } +PyramidShadowCommand >> lastGaussianShadow [ + ^ lastGaussianShadow ifNil: [ BlGaussianShadowEffect color: Color black width: 2 offset: 2 @ 2 ] +] + +{ #category : #accessing } +PyramidShadowCommand >> lastSimpleShadow [ + + ^ lastSimpleShadow ifNil: [ + BlSimpleShadowEffect color: Color black offset: 2 @ 2 ] +] + { #category : #'as yet unclassified' } PyramidShadowCommand >> setValueFor: aBlElement with: anArgument [ + anArgument class = BlSimpleShadowEffect ifTrue: [ + lastSimpleShadow := anArgument ]. + anArgument class = BlGaussianShadowEffect ifTrue: [ + lastGaussianShadow := anArgument ]. aBlElement effect: anArgument ] + +{ #category : #'as yet unclassified' } +PyramidShadowCommand >> syncFromElement: aBlElement [ + + aBlElement effect class = BlSimpleShadowEffect ifTrue: [ + lastSimpleShadow := aBlElement effect ]. + aBlElement effect class = BlGaussianShadowEffect ifTrue: [ + lastGaussianShadow := aBlElement effect ] +] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st index 225f9660..0448d0ee 100644 --- a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -19,6 +19,6 @@ PyramidShadowOffsetCommand >> getValueFor: aBlElement [ { #category : #'as yet unclassified' } PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ - - aBlElement effect: (aBlElement effect copyWithOffset: aPoint) + aBlElement effect: (aBlElement effect copyWithOffset: aPoint). + PyramidShadowCommand current syncFromElement: aBlElement ] From c9a7df289659b4ab25465250a6dbc4dc56a2f8d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 14 Apr 2026 14:16:34 +0200 Subject: [PATCH 05/16] Remove the shadowCommand class variable --- .../PyramidBackgroundBlocPlugin.class.st | 19 +++++-------------- .../PyramidShadowCommand.class.st | 10 +++++----- 2 files changed, 10 insertions(+), 19 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index 3f1581a5..c89c96ac 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -6,9 +6,6 @@ Class { #instVars : [ 'propertiesManager' ], - #classInstVars : [ - 'shadowCommand' - ], #category : #'Pyramid-Bloc-plugin-bloc-visuals' } @@ -687,19 +684,13 @@ PyramidBackgroundBlocPlugin class >> outskirts [ ^ property ] -{ #category : #accessing } -PyramidBackgroundBlocPlugin class >> resetShadowCommand [ - shadowCommand := nil -] - { #category : #accessing } PyramidBackgroundBlocPlugin class >> shadow [ + | property | - shadowCommand ifNil: [ shadowCommand := PyramidShadowCommand new ]. - PyramidShadowCommand current: shadowCommand. property := PyramidProperty new name: 'Shadow Effect'; - command: shadowCommand; + command: PyramidShadowCommand current; inputPresenterClass: PyramidMagicButtonsInputPresenter; yourself. property inputPresenterModel @@ -716,7 +707,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'Shadow type is simple.'; helpNotSelected: 'Set shadow type to simple.'; label: 'Simple'; - inputValue: [ shadowCommand lastSimpleShadow ]; + inputValue: [ PyramidShadowCommand current lastSimpleShadow ]; inputValidation: [ :value | value class = BlSimpleShadowEffect ]; yourself); addButtonModel: (PyramidMagicButtonModel new @@ -724,7 +715,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ helpSelected: 'Shadow type is gaussian.'; helpNotSelected: 'Set shadow type to gaussian.'; label: 'Gaussian'; - inputValue: [ shadowCommand lastGaussianShadow ]; + inputValue: [ PyramidShadowCommand current lastGaussianShadow ]; inputValidation: [ :value | value class = BlGaussianShadowEffect ]; yourself); yourself. @@ -840,7 +831,7 @@ PyramidBackgroundBlocPlugin >> initialize [ propertiesManager addProperty: self class borderRadialOuterRadius. "Shadow" - self class resetShadowCommand. + PyramidShadowCommand resetShadowCommand. propertiesManager addProperty: self class shadow. propertiesManager addProperty: self class shadowColor. propertiesManager addProperty: self class shadowOffset. diff --git a/src/Pyramid-Bloc/PyramidShadowCommand.class.st b/src/Pyramid-Bloc/PyramidShadowCommand.class.st index b873244e..8c407cec 100644 --- a/src/Pyramid-Bloc/PyramidShadowCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowCommand.class.st @@ -13,14 +13,14 @@ Class { { #category : #accessing } PyramidShadowCommand class >> current [ - ^ current - - + current ifNil: [ current := self new ]. + ^ current ] { #category : #accessing } -PyramidShadowCommand class >> current: anInstance [ - current := anInstance +PyramidShadowCommand class >> resetShadowCommand [ + + current := nil ] { #category : #'as yet unclassified' } From 83d157c4c42217c3b0583f9141f530cefacc0148 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 14 Apr 2026 15:50:28 +0200 Subject: [PATCH 06/16] fix problem with move index child --- .../PyramidMoveChildInParentPlugin.class.st | 31 +++++++++---------- 1 file changed, 15 insertions(+), 16 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st index 74b2a560..2b1489c1 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st @@ -46,22 +46,21 @@ PyramidMoveChildInParentPlugin >> contextMenuMoveChildInParent: aBuilder [ aBuilder addGroupSingleSelection: [ :group :single | - group - addItem: [ :item | - item - icon: (Smalltalk ui icons iconNamed: #up); - name: 'Move index child up'; - action: [ self moveChildIndexUpInParent ]; - yourself ]; - - addItem: [ :item | - item - icon: (Smalltalk ui icons iconNamed: #down); - name: 'Move index child down'; - action: [ self moveChildIndexDownInParent ]; - yourself ]; - yourself ] - order: 10. + group + addItem: [ :item | + item + icon: (Smalltalk ui icons iconNamed: #up); + name: 'Move child up'; + action: [ self moveChildIndexDownInParent ]; + yourself ]; + addItem: [ :item | + item + icon: (Smalltalk ui icons iconNamed: #down); + name: 'Move child down'; + action: [self moveChildIndexUpInParent]; + yourself ]; + yourself ] + order: 10 ] { #category : #accessing } From 649bd552218b152367260be676a46c3e9b7997e3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 14 Apr 2026 17:30:12 +0200 Subject: [PATCH 07/16] fix error messages for moving a child --- .../PyramidMoveChildInParentPlugin.class.st | 60 ++++++++----------- 1 file changed, 26 insertions(+), 34 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st index 2b1489c1..5205f082 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st @@ -90,28 +90,24 @@ PyramidMoveChildInParentPlugin >> moveChildIndexDownCommand: aBlElementParent wi PyramidMoveChildInParentPlugin >> moveChildIndexDownInParent [ | childToMoveCollection childToMove childIndexToMove parentChild navigationSelectionPanel | - childToMoveCollection := projectModel selection collection. - navigationSelectionPanel := navigationPlugin navigation selectionPanel. - - childToMoveCollection size = 1 - ifFalse: [ ^ self ]. + navigationSelectionPanel := navigationPlugin navigation + selectionPanel. + + childToMoveCollection size = 1 ifFalse: [ ^ self ]. childToMove := childToMoveCollection first. - - childToMove hasParent - ifFalse: [ ^ self ]. + + childToMove hasParent ifFalse: [ ^ self ]. parentChild := childToMove parent. - - childIndexToMove := (parentChild childIndexOf: childToMove). - - childIndexToMove > 1 - ifTrue: [ self moveChildIndexDownCommand: parentChild with: childToMove. - self refreshTreeTable ] - ifFalse: [ self inform: 'Cannot move down' ]. - - + childIndexToMove := parentChild childIndexOf: childToMove. + childIndexToMove > 1 + ifTrue: [ + self moveChildIndexDownCommand: parentChild with: childToMove. + self refreshTreeTable ] + ifFalse: [ + self inform: 'Cannot move up' ] "cannot move the child up and the index down" ] { #category : #'as yet unclassified' } @@ -128,27 +124,23 @@ PyramidMoveChildInParentPlugin >> moveChildIndexUpCommand: aBlElementParent with PyramidMoveChildInParentPlugin >> moveChildIndexUpInParent [ | childToMoveCollection childToMove childIndexToMove parentChild navigationSelectionPanel | - childToMoveCollection := projectModel selection collection. - navigationSelectionPanel := navigationPlugin navigation selectionPanel. - - childToMoveCollection size = 1 - ifFalse: [ ^ self ]. + navigationSelectionPanel := navigationPlugin navigation + selectionPanel. + + childToMoveCollection size = 1 ifFalse: [ ^ self ]. childToMove := childToMoveCollection first. - - childToMove hasParent - ifFalse: [ ^ self ]. + + childToMove hasParent ifFalse: [ ^ self ]. parentChild := childToMove parent. - - childIndexToMove := (parentChild childIndexOf: childToMove). - - childIndexToMove < (parentChild children size) - ifTrue: [ self moveChildIndexUpCommand: parentChild with: childToMove. - self refreshTreeTable ] - ifFalse: [ self inform: 'Cannot move up' ]. - - + childIndexToMove := parentChild childIndexOf: childToMove. + + childIndexToMove < parentChild children size + ifTrue: [ + self moveChildIndexUpCommand: parentChild with: childToMove. + self refreshTreeTable ] + ifFalse: [ self inform: 'Cannot move down' ] "cannot move the child down and the index up" ] { #category : #accessing } From 1888659367a30c3d8cbce287d44a2a7a207170db Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Wed, 15 Apr 2026 10:01:34 +0200 Subject: [PATCH 08/16] fix error OCScanner --- src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st b/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st index 6374cc47..d8425326 100644 --- a/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st +++ b/src/Pyramid-Bloc/PyramidSaveModelVerifier.class.st @@ -47,10 +47,9 @@ PyramidSaveModelVerifier class >> classPackageIsEqual [ PyramidSaveModelVerifier class >> methodIsValid [ ^ self new - verifyBlock: [ :model | - OCScanner isSelector: model savingMethodName ]; + verifyBlock: [ :model | model savingMethodName isValidSelector ]; showBlock: [ :view | view showMethodIsNotValidError ]; - yourself + yourself. ] { #category : #constructor } From 53f2c19cc434ac62113aeb3c5fd613d46ae4666e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Thu, 16 Apr 2026 15:22:28 +0200 Subject: [PATCH 09/16] add tests and update devShadow --- .../PyramidBackgroundBlocPlugin.class.st | 31 +++-- ...PyramidGaussianShadowWidthCommand.class.st | 25 ---- .../PyramidMoveChildInParentPlugin.class.st | 13 +- .../PyramidShadowColorCommand.class.st | 14 ++- .../PyramidShadowCommand.class.st | 8 +- ...PyramidShadowGaussianWidthCommand.class.st | 28 +++++ .../PyramidShadowOffsetCommand.class.st | 12 +- .../PyramidShadowColorCommandTest.class.st | 35 ++++++ .../PyramidShadowCommandTest.class.st | 114 ++++++++++++++++++ .../PyramidShadowGaussianWidthTest.class.st | 36 ++++++ .../PyramidShadowOffsetCommandTest.class.st | 35 ++++++ 11 files changed, 290 insertions(+), 61 deletions(-) delete mode 100644 src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st create mode 100644 src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st create mode 100644 src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st create mode 100644 src/Pyramid-Tests/PyramidShadowCommandTest.class.st create mode 100644 src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st create mode 100644 src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st diff --git a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st index c89c96ac..1f36a867 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundBlocPlugin.class.st @@ -618,19 +618,6 @@ PyramidBackgroundBlocPlugin class >> borderWidth [ ^ property ] -{ #category : #'as yet unclassified' } -PyramidBackgroundBlocPlugin class >> gaussianShadowWidth [ - - | property | - property := PyramidProperty new - name: 'Shadow Width'; - command: PyramidGaussianShadowWidthCommand new; - inputPresenterClass: PyramidNumberInputPresenter; - yourself. - property inputPresenterModel help: 'Set the width value'. - ^ property -] - { #category : #accessing } PyramidBackgroundBlocPlugin class >> opacity [ @@ -717,8 +704,7 @@ PyramidBackgroundBlocPlugin class >> shadow [ label: 'Gaussian'; inputValue: [ PyramidShadowCommand current lastGaussianShadow ]; inputValidation: [ :value | value class = BlGaussianShadowEffect ]; - yourself); - yourself. + yourself). ^ property ] @@ -752,6 +738,19 @@ PyramidBackgroundBlocPlugin class >> shadowOffset [ ^ property ] +{ #category : #accessing } +PyramidBackgroundBlocPlugin class >> shadowWidthGaussian [ + + | property | + property := PyramidProperty new + name: 'Shadow Width'; + command: PyramidShadowGaussianWidthCommand new; + inputPresenterClass: PyramidNumberInputPresenter; + yourself. + property inputPresenterModel help: 'Set the width value'. + ^ property +] + { #category : #adding } PyramidBackgroundBlocPlugin >> addPanelsOn: aPyramidSimpleWindow [ @@ -835,7 +834,7 @@ PyramidBackgroundBlocPlugin >> initialize [ propertiesManager addProperty: self class shadow. propertiesManager addProperty: self class shadowColor. propertiesManager addProperty: self class shadowOffset. - propertiesManager addProperty: self class gaussianShadowWidth + propertiesManager addProperty: self class shadowWidthGaussian ] { #category : #adding } diff --git a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st b/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st deleted file mode 100644 index d134185b..00000000 --- a/src/Pyramid-Bloc/PyramidGaussianShadowWidthCommand.class.st +++ /dev/null @@ -1,25 +0,0 @@ -Class { - #name : #PyramidGaussianShadowWidthCommand, - #superclass : #PyramidAbstractBlocCommand, - #category : #'Pyramid-Bloc-plugin-bloc-visuals' -} - -{ #category : #testing } -PyramidGaussianShadowWidthCommand >> canBeUsedFor: anObject [ - - ^ (super canBeUsedFor: anObject) and: [ - anObject effect isKindOf: BlGaussianShadowEffect ] -] - -{ #category : #'as yet unclassified' } -PyramidGaussianShadowWidthCommand >> getValueFor: aBlElement [ - - ^ aBlElement effect width -] - -{ #category : #'as yet unclassified' } -PyramidGaussianShadowWidthCommand >> setValueFor: aBlElement with: aWidth [ - - aBlElement effect: (aBlElement effect copyWithWidth: aWidth). - PyramidShadowCommand current syncFromElement: aBlElement -] diff --git a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st index 5205f082..4fe6a43b 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildInParentPlugin.class.st @@ -91,8 +91,7 @@ PyramidMoveChildInParentPlugin >> moveChildIndexDownInParent [ | childToMoveCollection childToMove childIndexToMove parentChild navigationSelectionPanel | childToMoveCollection := projectModel selection collection. - navigationSelectionPanel := navigationPlugin navigation - selectionPanel. + navigationSelectionPanel := navigationPlugin navigation selectionPanel. childToMoveCollection size = 1 ifFalse: [ ^ self ]. childToMove := childToMoveCollection first. @@ -106,8 +105,8 @@ PyramidMoveChildInParentPlugin >> moveChildIndexDownInParent [ ifTrue: [ self moveChildIndexDownCommand: parentChild with: childToMove. self refreshTreeTable ] - ifFalse: [ - self inform: 'Cannot move up' ] "cannot move the child up and the index down" + ifFalse: [ "cannot move the child up and the index down" + self inform: 'Cannot move up' ] ] { #category : #'as yet unclassified' } @@ -125,8 +124,7 @@ PyramidMoveChildInParentPlugin >> moveChildIndexUpInParent [ | childToMoveCollection childToMove childIndexToMove parentChild navigationSelectionPanel | childToMoveCollection := projectModel selection collection. - navigationSelectionPanel := navigationPlugin navigation - selectionPanel. + navigationSelectionPanel := navigationPlugin navigation selectionPanel. childToMoveCollection size = 1 ifFalse: [ ^ self ]. childToMove := childToMoveCollection first. @@ -140,7 +138,8 @@ PyramidMoveChildInParentPlugin >> moveChildIndexUpInParent [ ifTrue: [ self moveChildIndexUpCommand: parentChild with: childToMove. self refreshTreeTable ] - ifFalse: [ self inform: 'Cannot move down' ] "cannot move the child down and the index up" + ifFalse: [ "cannot move the child down and the index up" + self inform: 'Cannot move down' ] ] { #category : #accessing } diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st index 8faeb5cd..550930a1 100644 --- a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -10,14 +10,20 @@ PyramidShadowColorCommand >> canBeUsedFor: anObject [ anObject effect isKindOf: BlShadowEffect ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowColorCommand >> getValueFor: aBlElement [ - ^ aBlElement effect color + + (aBlElement effect isKindOf: BlShadowEffect) + ifTrue: [ ^ aBlElement effect color ] + ifFalse: [ ^ self ] ] -{ #category : #initialization } +{ #category : #accessing } PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ - aBlElement effect: (aBlElement effect copyWithColor: aColor). + (aBlElement effect isKindOf: BlShadowEffect) + ifTrue: [ + aBlElement effect: (aBlElement effect copyWithColor: aColor) ] + ifFalse: [ ^ self ]. PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowCommand.class.st b/src/Pyramid-Bloc/PyramidShadowCommand.class.st index 8c407cec..6734091f 100644 --- a/src/Pyramid-Bloc/PyramidShadowCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowCommand.class.st @@ -23,10 +23,10 @@ PyramidShadowCommand class >> resetShadowCommand [ current := nil ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowCommand >> getValueFor: aBlElement [ - ^ aBlElement effect + ^ aBlElement effect ] { #category : #accessing } @@ -41,7 +41,7 @@ PyramidShadowCommand >> lastSimpleShadow [ BlSimpleShadowEffect color: Color black offset: 2 @ 2 ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowCommand >> setValueFor: aBlElement with: anArgument [ anArgument class = BlSimpleShadowEffect ifTrue: [ @@ -51,7 +51,7 @@ PyramidShadowCommand >> setValueFor: aBlElement with: anArgument [ aBlElement effect: anArgument ] -{ #category : #'as yet unclassified' } +{ #category : #updating } PyramidShadowCommand >> syncFromElement: aBlElement [ aBlElement effect class = BlSimpleShadowEffect ifTrue: [ diff --git a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st new file mode 100644 index 00000000..9b0108f1 --- /dev/null +++ b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st @@ -0,0 +1,28 @@ +Class { + #name : #PyramidShadowGaussianWidthCommand, + #superclass : #PyramidAbstractBlocCommand, + #category : #'Pyramid-Bloc-plugin-bloc-visuals' +} + +{ #category : #testing } +PyramidShadowGaussianWidthCommand >> canBeUsedFor: anObject [ + + ^ (super canBeUsedFor: anObject) and: [ + anObject effect isKindOf: BlGaussianShadowEffect ] +] + +{ #category : #accessing } +PyramidShadowGaussianWidthCommand >> getValueFor: aBlElement [ + + ^ (aBlElement effect isKindOf: BlGaussianShadowEffect) ifTrue: [aBlElement effect width] ifFalse: [ ^ self ] +] + +{ #category : #accessing } +PyramidShadowGaussianWidthCommand >> setValueFor: aBlElement with: aWidth [ + + (aBlElement effect isKindOf: BlGaussianShadowEffect) + ifTrue: [ + aBlElement effect: (aBlElement effect copyWithWidth: aWidth) ] + ifFalse: [ ^ self ]. + PyramidShadowCommand current syncFromElement: aBlElement +] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st index 0448d0ee..76ef190e 100644 --- a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -11,14 +11,16 @@ PyramidShadowOffsetCommand >> canBeUsedFor: anObject [ anObject effect isKindOf: BlShadowEffect ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowOffsetCommand >> getValueFor: aBlElement [ - ^ aBlElement effect offset + ^ (aBlElement effect isKindOf: BlShadowEffect) ifTrue: [aBlElement effect offset] ifFalse: [ ^ self ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ - aBlElement effect: (aBlElement effect copyWithOffset: aPoint). - PyramidShadowCommand current syncFromElement: aBlElement + + (aBlElement effect isKindOf: BlShadowEffect) + ifTrue: [aBlElement effect: (aBlElement effect copyWithOffset: aPoint)] ifFalse: [^ self] . + PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st new file mode 100644 index 00000000..e5f446a1 --- /dev/null +++ b/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st @@ -0,0 +1,35 @@ +Class { + #name : #PyramidShadowColorCommandTest, + #superclass : #TestCase, + #traits : 'TPyramidCommandTest', + #classTraits : 'TPyramidCommandTest classTrait', + #category : #'Pyramid-Tests-cases-plugin-bloc-visuals' +} + +{ #category : #accessing } +PyramidShadowColorCommandTest >> command [ + + ^ PyramidShadowColorCommand new +] + +{ #category : #'as yet unclassified' } +PyramidShadowColorCommandTest >> targetContainers [ + + ^ { + (PyramidCommandTestContainer + no: (BlElement new effect: BlSimpleShadowEffect new) + with: (BlElement new + effect: (BlSimpleShadowEffect color: Color red offset: 2 @ 2); + yourself) + prop: Color red). + (PyramidCommandTestContainer + no: (BlElement new effect: BlGaussianShadowEffect new) + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: Color blue) } +] diff --git a/src/Pyramid-Tests/PyramidShadowCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowCommandTest.class.st new file mode 100644 index 00000000..2dcdb309 --- /dev/null +++ b/src/Pyramid-Tests/PyramidShadowCommandTest.class.st @@ -0,0 +1,114 @@ +Class { + #name : #PyramidShadowCommandTest, + #superclass : #TestCase, + #traits : 'TPyramidCommandTest', + #classTraits : 'TPyramidCommandTest classTrait', + #category : #'Pyramid-Tests-cases-plugin-bloc-visuals' +} + +{ #category : #tests } +PyramidShadowCommandTest >> assert: anObject hasSamePropertiesAs: anotherObject [ + + self assert: anObject color equals: anotherObject color. + self assert: anObject offset equals: anotherObject offset. + (anObject isKindOf: BlGaussianShadowEffect) ifTrue: [ + self assert: anObject width equals: anotherObject width ] +] + +{ #category : #accessing } +PyramidShadowCommandTest >> command [ + + ^ PyramidShadowCommand new +] + +{ #category : #'as yet unclassified' } +PyramidShadowCommandTest >> targetContainers [ + + ^ { + (PyramidCommandTestContainer + no: BlElement new + with: (BlElement new + effect: (BlSimpleShadowEffect color: Color red offset: 2 @ 2); + yourself) + prop: (BlSimpleShadowEffect color: Color red offset: 2 @ 2)). + (PyramidCommandTestContainer + no: BlElement new + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4)). + (PyramidCommandTestContainer + no: (BlElement new effect: BlOverlayEffect new) + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4)) } +] + +{ #category : #tests } +PyramidShadowCommandTest >> testGetValueFor [ + + self targetsWithValuesAndValues do: [ :each | + self assert: (self command getValueFor: each key) hasSamePropertiesAs: each value ] +] + +{ #category : #tests } +PyramidShadowCommandTest >> testHistory [ + "Do once. + undo + redo + undo + redo" + + | history commandExecutor targets | + targets := self targetsCanBeUsedFor. + history := PyramidHistory new. + commandExecutor := PyramidHistoryCommandExecutor new + history: history; + wrappee: PyramidMainCommandExecutor new; + yourself. + + "Do once" + self argumentsForHistory do: [ :each | + commandExecutor use: self command on: targets with: each ]. + + "Undo all" + self argumentsForHistory reverseDo: [ :argument | + targets do: [ :target | + self assert: (self command getValueFor: target) hasSamePropertiesAs: argument ]. + history canUndo ifTrue: [ history undo ] ]. + + "Redo all" + self argumentsForHistory do: [ :argument | + history canRedo ifTrue: [ history redo ]. + targets do: [ :target | + self assert: (self command getValueFor: target) hasSamePropertiesAs: argument ] ]. + + "Undo all" + self argumentsForHistory reverseDo: [ :argument | + targets do: [ :target | + self assert: (self command getValueFor: target) hasSamePropertiesAs: argument ]. + history canUndo ifTrue: [ history undo ] ]. + + "Redo all" + self argumentsForHistory do: [ :argument | + history canRedo ifTrue: [ history redo ]. + targets do: [ :target | + self assert: (self command getValueFor: target) hasSamePropertiesAs: argument ] ] +] diff --git a/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st b/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st new file mode 100644 index 00000000..a417f5fc --- /dev/null +++ b/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st @@ -0,0 +1,36 @@ +Class { + #name : #PyramidShadowGaussianWidthTest, + #superclass : #TestCase, + #traits : 'TPyramidCommandTest', + #classTraits : 'TPyramidCommandTest classTrait', + #category : #'Pyramid-Tests-cases-plugin-bloc-visuals' +} + +{ #category : #accessing } +PyramidShadowGaussianWidthTest >> command [ + + ^ PyramidShadowGaussianWidthCommand new + +] + +{ #category : #'as yet unclassified' } +PyramidShadowGaussianWidthTest >> targetContainers [ + + ^ { + (PyramidCommandTestContainer + no: (BlElement new effect: BlGaussianShadowEffect new) + with: (BlElement new + effect: (BlGaussianShadowEffect color: Color red width: 5 offset: 2 @ 2); + yourself) + prop: 5). + (PyramidCommandTestContainer + no: (BlElement new effect: BlGaussianShadowEffect new) + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: 10) } +] diff --git a/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st new file mode 100644 index 00000000..a68c8424 --- /dev/null +++ b/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st @@ -0,0 +1,35 @@ +Class { + #name : #PyramidShadowOffsetCommandTest, + #superclass : #TestCase, + #traits : 'TPyramidCommandTest', + #classTraits : 'TPyramidCommandTest classTrait', + #category : #'Pyramid-Tests-cases-plugin-bloc-visuals' +} + +{ #category : #accessing } +PyramidShadowOffsetCommandTest >> command [ + + ^ PyramidShadowOffsetCommand new +] + +{ #category : #'as yet unclassified' } +PyramidShadowOffsetCommandTest >> targetContainers [ + + ^ { + (PyramidCommandTestContainer + no: (BlElement new effect: BlSimpleShadowEffect new) + with: (BlElement new + effect: (BlSimpleShadowEffect color: Color red offset: 2 @ 2); + yourself) + prop: 2@2). + (PyramidCommandTestContainer + no: (BlElement new effect: BlGaussianShadowEffect new) + with: (BlElement new + effect: + (BlGaussianShadowEffect + color: Color blue + width: 10 + offset: 4 @ 4); + yourself) + prop: 4@4) } +] From 29092943da14af147a8c805290eab178d7bb93f7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Thu, 16 Apr 2026 16:17:43 +0200 Subject: [PATCH 10/16] update devShadow --- .../PyramidShadowColorCommand.class.st | 14 ++++++++------ .../PyramidShadowGaussianWidthCommand.class.st | 11 +++++++---- .../PyramidShadowOffsetCommand.class.st | 12 ++++++++---- .../PyramidAddChildCommandTest.class.st | 2 +- .../PyramidBackgroundImageCommandTest.class.st | 4 ++-- .../PyramidBackgroundOpacityCommandTest.class.st | 2 +- ...PyramidBackgroundPaintColorCommandTest.class.st | 4 ++-- .../PyramidBackgroundPaintCommandTest.class.st | 2 +- ...midBackgroundPaintLinearEndCommandTest.class.st | 4 ++-- ...dBackgroundPaintLinearStartCommandTest.class.st | 4 ++-- ...roundPaintRadialInnerCenterCommandTest.class.st | 4 ++-- ...roundPaintRadialInnerRadiusCommandTest.class.st | 4 ++-- ...roundPaintRadialOuterCenterCommandTest.class.st | 4 ++-- ...roundPaintRadialOuterRadiusCommandTest.class.st | 4 ++-- ...PyramidBackgroundPaintStopsCommandTest.class.st | 4 ++-- .../PyramidBackgroundTypeCommandTest.class.st | 2 +- ...ctHorizontalConstraintsBlocCommandTest.class.st | 4 ++-- ...xactVerticalConstraintsBlocCommandTest.class.st | 4 ++-- ...icHorizontalConstraintsBlocCommandTest.class.st | 4 ++-- ...asicVerticalConstraintsBlocCommandTest.class.st | 4 ++-- .../PyramidBorderDashArrayCommandTest.class.st | 2 +- .../PyramidBorderDashOffsetCommandTest.class.st | 2 +- .../PyramidBorderLineCapCommandTest.class.st | 2 +- .../PyramidBorderLineJoinCommandTest.class.st | 2 +- .../PyramidBorderMiterLimitCommandTest.class.st | 2 +- .../PyramidBorderOpacityCommandTest.class.st | 2 +- .../PyramidBorderTypeCommandTest.class.st | 2 +- ...PyramidChangeOrderWithIndexCommandTest.class.st | 4 ++-- .../PyramidChangeTextCommandTest.class.st | 2 +- .../PyramidClipChildrenCommandTest.class.st | 2 +- .../PyramidElementIdCommandTest.class.st | 2 +- .../PyramidFontSizeCommandTest.class.st | 2 +- .../PyramidFontWeightCommandTest.class.st | 2 +- .../PyramidGeometryCommandTest.class.st | 2 +- .../PyramidLayoutBlocCommandTest.class.st | 4 ++-- ...amidLayoutChangeOrientationCommandTest.class.st | 4 ++-- .../PyramidMarginCommandTest.class.st | 2 +- .../PyramidMoveBackwardOrderCommandTest.class.st | 8 ++++---- .../PyramidMoveForwardOrderCommandTest.class.st | 8 ++++---- .../PyramidOnBackgroundOrderCommandTest.class.st | 4 ++-- .../PyramidOnForegroundOrderCommandTest.class.st | 4 ++-- .../PyramidOpacityCommandTest.class.st | 2 +- .../PyramidPaddingCommandTest.class.st | 2 +- .../PyramidPositionCommandTest.class.st | 2 +- .../PyramidPositionOffsetCommandTest.class.st | 2 +- ...ionnalHorizontalConstraintsCommandTest.class.st | 4 ++-- ...rtionnalVerticalConstraintsCommandTest.class.st | 4 ++-- .../PyramidRemoveChildCommandTest.class.st | 2 +- .../PyramidRemoveSelectionCommandTest.class.st | 2 +- ...RoundedRectangleCornerRadiiCommandTest.class.st | 4 ++-- .../PyramidShadowColorCommandTest.class.st | 2 +- .../PyramidShadowCommandTest.class.st | 2 +- .../PyramidShadowGaussianWidthTest.class.st | 2 +- .../PyramidShadowOffsetCommandTest.class.st | 2 +- .../PyramidTextForegroundCommandTest.class.st | 2 +- .../PyramidVisibilityCommandTest.class.st | 2 +- .../PyramidWeightConstraintsCommandTest.class.st | 4 ++-- .../PyramidZIndexCommandTest.class.st | 2 +- src/Pyramid-Tests/TPyramidCommandTest.trait.st | 8 ++++---- .../PyramidStampCommandTest.class.st | 2 +- 60 files changed, 111 insertions(+), 102 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st index 550930a1..ec8cae3b 100644 --- a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -6,24 +6,26 @@ Class { { #category : #testing } PyramidShadowColorCommand >> canBeUsedFor: anObject [ - ^ (super canBeUsedFor: anObject) and: [ - anObject effect isKindOf: BlShadowEffect ] + + ^ (super canBeUsedFor: anObject) and: [ + anObject effect class = BlSimpleShadowEffect or: [ + anObject effect class = BlGaussianShadowEffect ] ] ] { #category : #accessing } PyramidShadowColorCommand >> getValueFor: aBlElement [ - (aBlElement effect isKindOf: BlShadowEffect) + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) ifTrue: [ ^ aBlElement effect color ] - ifFalse: [ ^ self ] + ifFalse: [ ^ nil ] ] { #category : #accessing } PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ - (aBlElement effect isKindOf: BlShadowEffect) + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class= BlGaussianShadowEffect]) ifTrue: [ aBlElement effect: (aBlElement effect copyWithColor: aColor) ] - ifFalse: [ ^ self ]. + ifFalse: [ ^ nil ]. PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st index 9b0108f1..08272272 100644 --- a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st @@ -8,21 +8,24 @@ Class { PyramidShadowGaussianWidthCommand >> canBeUsedFor: anObject [ ^ (super canBeUsedFor: anObject) and: [ - anObject effect isKindOf: BlGaussianShadowEffect ] + anObject effect class = BlGaussianShadowEffect ] ] { #category : #accessing } PyramidShadowGaussianWidthCommand >> getValueFor: aBlElement [ - ^ (aBlElement effect isKindOf: BlGaussianShadowEffect) ifTrue: [aBlElement effect width] ifFalse: [ ^ self ] + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) + ifTrue: [ ^ aBlElement effect width ] + ifFalse: [ ^ nil ] ] { #category : #accessing } PyramidShadowGaussianWidthCommand >> setValueFor: aBlElement with: aWidth [ - (aBlElement effect isKindOf: BlGaussianShadowEffect) + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) ifTrue: [ aBlElement effect: (aBlElement effect copyWithWidth: aWidth) ] - ifFalse: [ ^ self ]. + ifFalse: [ ^ nil ]. PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st index 76ef190e..a4388e2b 100644 --- a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -8,19 +8,23 @@ Class { PyramidShadowOffsetCommand >> canBeUsedFor: anObject [ ^ (super canBeUsedFor: anObject) and: [ - anObject effect isKindOf: BlShadowEffect ] + anObject effect class = BlSimpleShadowEffect or: [anObject effect class = BlGaussianShadowEffect] ] ] { #category : #accessing } PyramidShadowOffsetCommand >> getValueFor: aBlElement [ - ^ (aBlElement effect isKindOf: BlShadowEffect) ifTrue: [aBlElement effect offset] ifFalse: [ ^ self ] + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) + ifTrue: [ ^ aBlElement effect offset ] + ifFalse: [ ^ nil ] ] { #category : #accessing } PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ - (aBlElement effect isKindOf: BlShadowEffect) - ifTrue: [aBlElement effect: (aBlElement effect copyWithOffset: aPoint)] ifFalse: [^ self] . + (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) + ifTrue: [ + aBlElement effect: (aBlElement effect copyWithOffset: aPoint) ] + ifFalse: [ ^ nil ]. PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Tests/PyramidAddChildCommandTest.class.st b/src/Pyramid-Tests/PyramidAddChildCommandTest.class.st index ad54c577..39710d5d 100644 --- a/src/Pyramid-Tests/PyramidAddChildCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidAddChildCommandTest.class.st @@ -12,7 +12,7 @@ PyramidAddChildCommandTest >> command [ ^ PyramidAddChildCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidAddChildCommandTest >> targetsCanBeUsedFor [ ^ { BlElement new . BlElement new addChild: BlElement new; yourself } diff --git a/src/Pyramid-Tests/PyramidBackgroundImageCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundImageCommandTest.class.st index f5308c6b..d1c49058 100644 --- a/src/Pyramid-Tests/PyramidBackgroundImageCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundImageCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundImageCommandTest >> command [ ^ PyramidBackgroundImageCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundImageCommandTest >> targetContainers [ ^ { @@ -34,7 +34,7 @@ PyramidBackgroundImageCommandTest >> targetContainers [ prop: (Smalltalk ui icons iconNamed: #pharoBig)) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundImageCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundOpacityCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundOpacityCommandTest.class.st index 6f01df3d..32d70ba5 100644 --- a/src/Pyramid-Tests/PyramidBackgroundOpacityCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundOpacityCommandTest.class.st @@ -26,7 +26,7 @@ PyramidBackgroundOpacityCommandTest >> isBlBackgroundEqualityFix [ ^ e background == b2 ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundOpacityCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintColorCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintColorCommandTest.class.st index ea72a86d..8312b04b 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintColorCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintColorCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintColorCommandTest >> command [ ^ PyramidBackgroundPaintColorCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintColorCommandTest >> targetContainers [ ^ { @@ -35,7 +35,7 @@ PyramidBackgroundPaintColorCommandTest >> targetContainers [ } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintColorCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintCommandTest.class.st index 949a9ab7..fcbb4cbc 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintCommandTest >> command [ ^ PyramidBackgroundPaintCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintCommandTest >> targetContainers [ ^ {(PyramidCommandTestContainer diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintLinearEndCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintLinearEndCommandTest.class.st index 116912ab..f2a1768b 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintLinearEndCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintLinearEndCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintLinearEndCommandTest >> command [ ^ PyramidBackgroundPaintLinearEndCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintLinearEndCommandTest >> targetContainers [ ^ { @@ -58,7 +58,7 @@ PyramidBackgroundPaintLinearEndCommandTest >> targetContainers [ prop: 0 @ 0) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintLinearEndCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintLinearStartCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintLinearStartCommandTest.class.st index 31caf284..b6f99ab7 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintLinearStartCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintLinearStartCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintLinearStartCommandTest >> command [ ^ PyramidBackgroundPaintLinearStartCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintLinearStartCommandTest >> targetContainers [ ^ { @@ -58,7 +58,7 @@ PyramidBackgroundPaintLinearStartCommandTest >> targetContainers [ prop: 0 @ 10) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintLinearStartCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerCenterCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerCenterCommandTest.class.st index aac47749..402c74b6 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerCenterCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerCenterCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintRadialInnerCenterCommandTest >> command [ ^ PyramidBackgroundPaintRadialInnerCenterCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialInnerCenterCommandTest >> targetContainers [ ^ { @@ -66,7 +66,7 @@ PyramidBackgroundPaintRadialInnerCenterCommandTest >> targetContainers [ prop: 500 asPoint) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialInnerCenterCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerRadiusCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerRadiusCommandTest.class.st index b9bfbd44..63231a90 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerRadiusCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintRadialInnerRadiusCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintRadialInnerRadiusCommandTest >> command [ ^ PyramidBackgroundPaintRadialInnerRadiusCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialInnerRadiusCommandTest >> targetContainers [ ^ { @@ -66,7 +66,7 @@ PyramidBackgroundPaintRadialInnerRadiusCommandTest >> targetContainers [ prop: 600) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialInnerRadiusCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterCenterCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterCenterCommandTest.class.st index ba329f0d..2d8175df 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterCenterCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterCenterCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintRadialOuterCenterCommandTest >> command [ ^ PyramidBackgroundPaintRadialOuterCenterCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialOuterCenterCommandTest >> targetContainers [ ^ { @@ -66,7 +66,7 @@ PyramidBackgroundPaintRadialOuterCenterCommandTest >> targetContainers [ prop: 500 asPoint) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialOuterCenterCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterRadiusCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterRadiusCommandTest.class.st index 742ef40e..179e1144 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterRadiusCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintRadialOuterRadiusCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintRadialOuterRadiusCommandTest >> command [ ^ PyramidBackgroundPaintRadialOuterRadiusCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialOuterRadiusCommandTest >> targetContainers [ ^ { @@ -58,7 +58,7 @@ PyramidBackgroundPaintRadialOuterRadiusCommandTest >> targetContainers [ prop: 600) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintRadialOuterRadiusCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundPaintStopsCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundPaintStopsCommandTest.class.st index 284afe89..d8ed51e3 100644 --- a/src/Pyramid-Tests/PyramidBackgroundPaintStopsCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundPaintStopsCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintStopsCommandTest >> command [ ^ PyramidBackgroundPaintStopsCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintStopsCommandTest >> targetContainers [ ^ { @@ -87,7 +87,7 @@ PyramidBackgroundPaintStopsCommandTest >> targetContainers [ } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundPaintStopsCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBackgroundTypeCommandTest.class.st b/src/Pyramid-Tests/PyramidBackgroundTypeCommandTest.class.st index b3c75e7b..b8f703c7 100644 --- a/src/Pyramid-Tests/PyramidBackgroundTypeCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBackgroundTypeCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBackgroundTypeCommandTest >> command [ ^ PyramidBackgroundTypeCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBackgroundTypeCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBasicExactHorizontalConstraintsBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidBasicExactHorizontalConstraintsBlocCommandTest.class.st index ddb32c3c..c5252455 100644 --- a/src/Pyramid-Tests/PyramidBasicExactHorizontalConstraintsBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBasicExactHorizontalConstraintsBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBasicExactHorizontalConstraintsBlocCommandTest >> command [ ^ PyramidBasicExactHorizontalConstraintsBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicExactHorizontalConstraintsBlocCommandTest >> targetContainers [ | p1 a1 b1 p2 a2 b2 | @@ -42,7 +42,7 @@ PyramidBasicExactHorizontalConstraintsBlocCommandTest >> targetContainers [ (PyramidCommandTestContainer no: a2 with: b2 prop: 600) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicExactHorizontalConstraintsBlocCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBasicExactVerticalConstraintsBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidBasicExactVerticalConstraintsBlocCommandTest.class.st index a1165f8e..db990f7f 100644 --- a/src/Pyramid-Tests/PyramidBasicExactVerticalConstraintsBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBasicExactVerticalConstraintsBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBasicExactVerticalConstraintsBlocCommandTest >> command [ ^ PyramidBasicExactVerticalConstraintsBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicExactVerticalConstraintsBlocCommandTest >> targetContainers [ | p1 a1 b1 p2 a2 b2 | @@ -44,7 +44,7 @@ PyramidBasicExactVerticalConstraintsBlocCommandTest >> targetContainers [ (PyramidCommandTestContainer no: a2 with: b2 prop: 100) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicExactVerticalConstraintsBlocCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBasicHorizontalConstraintsBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidBasicHorizontalConstraintsBlocCommandTest.class.st index 0c34c59c..1acbfbab 100644 --- a/src/Pyramid-Tests/PyramidBasicHorizontalConstraintsBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBasicHorizontalConstraintsBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBasicHorizontalConstraintsBlocCommandTest >> command [ ^ PyramidBasicHorizontalConstraintsBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicHorizontalConstraintsBlocCommandTest >> targetContainers [ | p1 a1 b1 c1 d1 p2 a2 b2 c2 d2 | @@ -56,7 +56,7 @@ PyramidBasicHorizontalConstraintsBlocCommandTest >> targetContainers [ (PyramidCommandTestContainer no: a2 with: d2 prop: #matchParent) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicHorizontalConstraintsBlocCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBasicVerticalConstraintsBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidBasicVerticalConstraintsBlocCommandTest.class.st index 6bd1493e..aca41fd1 100644 --- a/src/Pyramid-Tests/PyramidBasicVerticalConstraintsBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBasicVerticalConstraintsBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBasicVerticalConstraintsBlocCommandTest >> command [ ^ PyramidBasicVerticalConstraintsBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicVerticalConstraintsBlocCommandTest >> targetContainers [ | p1 a1 b1 c1 d1 p2 a2 b2 c2 d2 | @@ -56,7 +56,7 @@ PyramidBasicVerticalConstraintsBlocCommandTest >> targetContainers [ (PyramidCommandTestContainer no: a2 with: d2 prop: #matchParent) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBasicVerticalConstraintsBlocCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidBorderDashArrayCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderDashArrayCommandTest.class.st index 618ef42f..64e5d04c 100644 --- a/src/Pyramid-Tests/PyramidBorderDashArrayCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderDashArrayCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderDashArrayCommandTest >> command [ ^ PyramidBorderDashArrayCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderDashArrayCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderDashOffsetCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderDashOffsetCommandTest.class.st index a7d65f33..ce8b116c 100644 --- a/src/Pyramid-Tests/PyramidBorderDashOffsetCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderDashOffsetCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderDashOffsetCommandTest >> command [ ^ PyramidBorderDashOffsetCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderDashOffsetCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderLineCapCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderLineCapCommandTest.class.st index dce90ad7..9567d36d 100644 --- a/src/Pyramid-Tests/PyramidBorderLineCapCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderLineCapCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderLineCapCommandTest >> command [ ^ PyramidBorderLineCapCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderLineCapCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderLineJoinCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderLineJoinCommandTest.class.st index fef84f1f..8b25b0e1 100644 --- a/src/Pyramid-Tests/PyramidBorderLineJoinCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderLineJoinCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderLineJoinCommandTest >> command [ ^ PyramidBorderLineJoinCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderLineJoinCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderMiterLimitCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderMiterLimitCommandTest.class.st index f4ddb511..c97c1afa 100644 --- a/src/Pyramid-Tests/PyramidBorderMiterLimitCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderMiterLimitCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderMiterLimitCommandTest >> command [ ^ PyramidBorderMiterLimitCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderMiterLimitCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderOpacityCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderOpacityCommandTest.class.st index 77ba3328..e6cdffb0 100644 --- a/src/Pyramid-Tests/PyramidBorderOpacityCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderOpacityCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderOpacityCommandTest >> command [ ^ PyramidBorderOpacityCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderOpacityCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidBorderTypeCommandTest.class.st b/src/Pyramid-Tests/PyramidBorderTypeCommandTest.class.st index cc091120..72f3111e 100644 --- a/src/Pyramid-Tests/PyramidBorderTypeCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidBorderTypeCommandTest.class.st @@ -12,7 +12,7 @@ PyramidBorderTypeCommandTest >> command [ ^ PyramidBorderPaintCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidBorderTypeCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidChangeOrderWithIndexCommandTest.class.st b/src/Pyramid-Tests/PyramidChangeOrderWithIndexCommandTest.class.st index 3f304800..046812b1 100644 --- a/src/Pyramid-Tests/PyramidChangeOrderWithIndexCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidChangeOrderWithIndexCommandTest.class.st @@ -35,7 +35,7 @@ PyramidChangeOrderWithIndexCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidChangeOrderWithIndexCommandTest >> targetContainers [ | test1 test2 test3 test4 test5 test6 | @@ -73,7 +73,7 @@ PyramidChangeOrderWithIndexCommandTest >> targetContainers [ prop: 1) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidChangeOrderWithIndexCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | diff --git a/src/Pyramid-Tests/PyramidChangeTextCommandTest.class.st b/src/Pyramid-Tests/PyramidChangeTextCommandTest.class.st index 18dd1eb5..bb1b4974 100644 --- a/src/Pyramid-Tests/PyramidChangeTextCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidChangeTextCommandTest.class.st @@ -12,7 +12,7 @@ PyramidChangeTextCommandTest >> command [ ^ PyramidChangeTextCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidChangeTextCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidClipChildrenCommandTest.class.st b/src/Pyramid-Tests/PyramidClipChildrenCommandTest.class.st index 07f02a09..c3ddf1e5 100644 --- a/src/Pyramid-Tests/PyramidClipChildrenCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidClipChildrenCommandTest.class.st @@ -12,7 +12,7 @@ PyramidClipChildrenCommandTest >> command [ ^ PyramidClipChildrenCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidClipChildrenCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidElementIdCommandTest.class.st b/src/Pyramid-Tests/PyramidElementIdCommandTest.class.st index b235dc3b..4b3d132a 100644 --- a/src/Pyramid-Tests/PyramidElementIdCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidElementIdCommandTest.class.st @@ -12,7 +12,7 @@ PyramidElementIdCommandTest >> command [ ^ PyramidElementIdCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidElementIdCommandTest >> targetContainers [ diff --git a/src/Pyramid-Tests/PyramidFontSizeCommandTest.class.st b/src/Pyramid-Tests/PyramidFontSizeCommandTest.class.st index effab2f4..343ce6e3 100644 --- a/src/Pyramid-Tests/PyramidFontSizeCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidFontSizeCommandTest.class.st @@ -18,7 +18,7 @@ PyramidFontSizeCommandTest >> command [ ^ PyramidFontSizeCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidFontSizeCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidFontWeightCommandTest.class.st b/src/Pyramid-Tests/PyramidFontWeightCommandTest.class.st index ca2f6b2e..1b5bfb98 100644 --- a/src/Pyramid-Tests/PyramidFontWeightCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidFontWeightCommandTest.class.st @@ -18,7 +18,7 @@ PyramidFontWeightCommandTest >> command [ ^ PyramidFontWeightCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidFontWeightCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidGeometryCommandTest.class.st b/src/Pyramid-Tests/PyramidGeometryCommandTest.class.st index 070c4ad8..1cefa683 100644 --- a/src/Pyramid-Tests/PyramidGeometryCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidGeometryCommandTest.class.st @@ -12,7 +12,7 @@ PyramidGeometryCommandTest >> command [ ^ PyramidGeometryCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidGeometryCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidLayoutBlocCommandTest.class.st b/src/Pyramid-Tests/PyramidLayoutBlocCommandTest.class.st index 9da98d0b..a1c5f317 100644 --- a/src/Pyramid-Tests/PyramidLayoutBlocCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidLayoutBlocCommandTest.class.st @@ -12,7 +12,7 @@ PyramidLayoutBlocCommandTest >> command [ ^ PyramidLayoutBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidLayoutBlocCommandTest >> targetContainers [ | flowLayoutVertical basicLayout proportionalLayout | @@ -43,7 +43,7 @@ PyramidLayoutBlocCommandTest >> targetContainers [ prop: proportionalLayout) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidLayoutBlocCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers collect: [ :each | each targetNoProp ]. diff --git a/src/Pyramid-Tests/PyramidLayoutChangeOrientationCommandTest.class.st b/src/Pyramid-Tests/PyramidLayoutChangeOrientationCommandTest.class.st index b0e2e9e5..20cc4bcf 100644 --- a/src/Pyramid-Tests/PyramidLayoutChangeOrientationCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidLayoutChangeOrientationCommandTest.class.st @@ -12,7 +12,7 @@ PyramidLayoutChangeOrientationCommandTest >> command [ ^ PyramidLayoutChangeOrientationCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidLayoutChangeOrientationCommandTest >> targetContainers [ ^ { (PyramidCommandTestContainer @@ -49,7 +49,7 @@ PyramidLayoutChangeOrientationCommandTest >> targetContainers [ prop: BlLayoutOrientation horizontal) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidLayoutChangeOrientationCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidMarginCommandTest.class.st b/src/Pyramid-Tests/PyramidMarginCommandTest.class.st index 1ff7ea4b..5f6771c5 100644 --- a/src/Pyramid-Tests/PyramidMarginCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidMarginCommandTest.class.st @@ -12,7 +12,7 @@ PyramidMarginCommandTest >> command [ ^ PyramidMarginCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMarginCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidMoveBackwardOrderCommandTest.class.st b/src/Pyramid-Tests/PyramidMoveBackwardOrderCommandTest.class.st index beae1f5e..9c0a4d77 100644 --- a/src/Pyramid-Tests/PyramidMoveBackwardOrderCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidMoveBackwardOrderCommandTest.class.st @@ -6,7 +6,7 @@ Class { #category : #'Pyramid-Tests-cases-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveBackwardOrderCommandTest >> argumentsForHistory [ ^ { 3. 2. 1 } @@ -30,7 +30,7 @@ PyramidMoveBackwardOrderCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveBackwardOrderCommandTest >> targetContainers [ | test1 test2 test3 | @@ -53,7 +53,7 @@ PyramidMoveBackwardOrderCommandTest >> targetContainers [ prop: 3) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveBackwardOrderCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | @@ -61,7 +61,7 @@ PyramidMoveBackwardOrderCommandTest >> targetsCanBeUsedFor [ each targetNoProp } ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveBackwardOrderCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidMoveForwardOrderCommandTest.class.st b/src/Pyramid-Tests/PyramidMoveForwardOrderCommandTest.class.st index 876ebefa..0cbc4141 100644 --- a/src/Pyramid-Tests/PyramidMoveForwardOrderCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidMoveForwardOrderCommandTest.class.st @@ -6,7 +6,7 @@ Class { #category : #'Pyramid-Tests-cases-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveForwardOrderCommandTest >> argumentsForHistory [ ^ { 1 . 2 . 3 } @@ -30,7 +30,7 @@ PyramidMoveForwardOrderCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveForwardOrderCommandTest >> targetContainers [ | test1 test2 test3 | @@ -53,7 +53,7 @@ PyramidMoveForwardOrderCommandTest >> targetContainers [ prop: 3) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveForwardOrderCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | @@ -61,7 +61,7 @@ PyramidMoveForwardOrderCommandTest >> targetsCanBeUsedFor [ each targetNoProp } ] ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidMoveForwardOrderCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidOnBackgroundOrderCommandTest.class.st b/src/Pyramid-Tests/PyramidOnBackgroundOrderCommandTest.class.st index 0e57fc9e..5af89655 100644 --- a/src/Pyramid-Tests/PyramidOnBackgroundOrderCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidOnBackgroundOrderCommandTest.class.st @@ -35,7 +35,7 @@ PyramidOnBackgroundOrderCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOnBackgroundOrderCommandTest >> targetContainers [ | test1 test2 test3 | @@ -58,7 +58,7 @@ PyramidOnBackgroundOrderCommandTest >> targetContainers [ prop: 1) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOnBackgroundOrderCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | diff --git a/src/Pyramid-Tests/PyramidOnForegroundOrderCommandTest.class.st b/src/Pyramid-Tests/PyramidOnForegroundOrderCommandTest.class.st index dfd10ec8..329c9857 100644 --- a/src/Pyramid-Tests/PyramidOnForegroundOrderCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidOnForegroundOrderCommandTest.class.st @@ -35,7 +35,7 @@ PyramidOnForegroundOrderCommandTest >> makeElementWithChildren [ ^ parent ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOnForegroundOrderCommandTest >> targetContainers [ | test1 test2 test3 | @@ -58,7 +58,7 @@ PyramidOnForegroundOrderCommandTest >> targetContainers [ prop: 3) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOnForegroundOrderCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | diff --git a/src/Pyramid-Tests/PyramidOpacityCommandTest.class.st b/src/Pyramid-Tests/PyramidOpacityCommandTest.class.st index 15abba92..90043941 100644 --- a/src/Pyramid-Tests/PyramidOpacityCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidOpacityCommandTest.class.st @@ -12,7 +12,7 @@ PyramidOpacityCommandTest >> command [ ^ PyramidOpacityCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidOpacityCommandTest >> targetContainers [ | e1 e2 | diff --git a/src/Pyramid-Tests/PyramidPaddingCommandTest.class.st b/src/Pyramid-Tests/PyramidPaddingCommandTest.class.st index 842a6e73..25058fe6 100644 --- a/src/Pyramid-Tests/PyramidPaddingCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidPaddingCommandTest.class.st @@ -12,7 +12,7 @@ PyramidPaddingCommandTest >> command [ ^ PyramidPaddingCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidPaddingCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidPositionCommandTest.class.st b/src/Pyramid-Tests/PyramidPositionCommandTest.class.st index 596e92eb..0d5784d3 100644 --- a/src/Pyramid-Tests/PyramidPositionCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidPositionCommandTest.class.st @@ -12,7 +12,7 @@ PyramidPositionCommandTest >> command [ ^ PyramidPositionCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidPositionCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidPositionOffsetCommandTest.class.st b/src/Pyramid-Tests/PyramidPositionOffsetCommandTest.class.st index 34285057..bf3c08a8 100644 --- a/src/Pyramid-Tests/PyramidPositionOffsetCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidPositionOffsetCommandTest.class.st @@ -12,7 +12,7 @@ PyramidPositionOffsetCommandTest >> command [ ^ PyramidPositionOffsetCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidPositionOffsetCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidProportionnalHorizontalConstraintsCommandTest.class.st b/src/Pyramid-Tests/PyramidProportionnalHorizontalConstraintsCommandTest.class.st index 40e93624..1da847b8 100644 --- a/src/Pyramid-Tests/PyramidProportionnalHorizontalConstraintsCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidProportionnalHorizontalConstraintsCommandTest.class.st @@ -12,7 +12,7 @@ PyramidProportionnalHorizontalConstraintsCommandTest >> command [ ^ PyramidProportionalHorizontalConstraintsCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidProportionnalHorizontalConstraintsCommandTest >> targetContainers [ | parent e1 e2 | @@ -31,7 +31,7 @@ PyramidProportionnalHorizontalConstraintsCommandTest >> targetContainers [ prop: 0.2 @ 0.4)} ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidProportionnalHorizontalConstraintsCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidProportionnalVerticalConstraintsCommandTest.class.st b/src/Pyramid-Tests/PyramidProportionnalVerticalConstraintsCommandTest.class.st index 81496cc8..7797a248 100644 --- a/src/Pyramid-Tests/PyramidProportionnalVerticalConstraintsCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidProportionnalVerticalConstraintsCommandTest.class.st @@ -12,7 +12,7 @@ PyramidProportionnalVerticalConstraintsCommandTest >> command [ ^ PyramidProportionalVerticalConstraintsCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidProportionnalVerticalConstraintsCommandTest >> targetContainers [ | parent e1 e2 | @@ -35,7 +35,7 @@ PyramidProportionnalVerticalConstraintsCommandTest >> targetContainers [ ^ { (PyramidCommandTestContainer no: e1 with: e2 prop: 0.3 @ 0.6) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidProportionnalVerticalConstraintsCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidRemoveChildCommandTest.class.st b/src/Pyramid-Tests/PyramidRemoveChildCommandTest.class.st index 30f24257..923c5ca1 100644 --- a/src/Pyramid-Tests/PyramidRemoveChildCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidRemoveChildCommandTest.class.st @@ -12,7 +12,7 @@ PyramidRemoveChildCommandTest >> command [ ^ PyramidRemoveChildCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidRemoveChildCommandTest >> targetsCanBeUsedFor [ ^ { BlElement new . BlElement new addChild: BlElement new; yourself } diff --git a/src/Pyramid-Tests/PyramidRemoveSelectionCommandTest.class.st b/src/Pyramid-Tests/PyramidRemoveSelectionCommandTest.class.st index 18aa0bb1..c2e6a27b 100644 --- a/src/Pyramid-Tests/PyramidRemoveSelectionCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidRemoveSelectionCommandTest.class.st @@ -116,7 +116,7 @@ PyramidRemoveSelectionCommandTest >> parentsAndElements [ ^ parents -> elements ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidRemoveSelectionCommandTest >> targetsCanBeUsedFor [ ^ { diff --git a/src/Pyramid-Tests/PyramidRoundedRectangleCornerRadiiCommandTest.class.st b/src/Pyramid-Tests/PyramidRoundedRectangleCornerRadiiCommandTest.class.st index 68db7048..38d349a6 100644 --- a/src/Pyramid-Tests/PyramidRoundedRectangleCornerRadiiCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidRoundedRectangleCornerRadiiCommandTest.class.st @@ -12,7 +12,7 @@ PyramidRoundedRectangleCornerRadiiCommandTest >> command [ ^ PyramidRoundedRectangleCornerRadiiCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidRoundedRectangleCornerRadiiCommandTest >> targetContainers [ ^ { @@ -30,7 +30,7 @@ PyramidRoundedRectangleCornerRadiiCommandTest >> targetContainers [ prop: (BlCornerRadii radius: 20)) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidRoundedRectangleCornerRadiiCommandTest >> targetsCannotBeUsedFor [ "override if needed" diff --git a/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st index e5f446a1..fcd6eddd 100644 --- a/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidShadowColorCommandTest.class.st @@ -12,7 +12,7 @@ PyramidShadowColorCommandTest >> command [ ^ PyramidShadowColorCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowColorCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidShadowCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowCommandTest.class.st index 2dcdb309..0e96a6e3 100644 --- a/src/Pyramid-Tests/PyramidShadowCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidShadowCommandTest.class.st @@ -21,7 +21,7 @@ PyramidShadowCommandTest >> command [ ^ PyramidShadowCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st b/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st index a417f5fc..bf2b5df0 100644 --- a/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st +++ b/src/Pyramid-Tests/PyramidShadowGaussianWidthTest.class.st @@ -13,7 +13,7 @@ PyramidShadowGaussianWidthTest >> command [ ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowGaussianWidthTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st b/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st index a68c8424..2825bb4d 100644 --- a/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidShadowOffsetCommandTest.class.st @@ -12,7 +12,7 @@ PyramidShadowOffsetCommandTest >> command [ ^ PyramidShadowOffsetCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidShadowOffsetCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidTextForegroundCommandTest.class.st b/src/Pyramid-Tests/PyramidTextForegroundCommandTest.class.st index 36b77372..457a78b1 100644 --- a/src/Pyramid-Tests/PyramidTextForegroundCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidTextForegroundCommandTest.class.st @@ -18,7 +18,7 @@ PyramidTextForegroundCommandTest >> command [ ^ PyramidTextForegroundCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidTextForegroundCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidVisibilityCommandTest.class.st b/src/Pyramid-Tests/PyramidVisibilityCommandTest.class.st index abca3c83..028dad1c 100644 --- a/src/Pyramid-Tests/PyramidVisibilityCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidVisibilityCommandTest.class.st @@ -12,7 +12,7 @@ PyramidVisibilityCommandTest >> command [ ^ PyramidVisibilityCommand new. ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidVisibilityCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/PyramidWeightConstraintsCommandTest.class.st b/src/Pyramid-Tests/PyramidWeightConstraintsCommandTest.class.st index 3af4cf20..7680fbde 100644 --- a/src/Pyramid-Tests/PyramidWeightConstraintsCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidWeightConstraintsCommandTest.class.st @@ -12,7 +12,7 @@ PyramidWeightConstraintsCommandTest >> command [ ^ PyramidWeightConstraintsCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidWeightConstraintsCommandTest >> targetContainers [ | parentLinear e1Linear e2Linear parentFlow e1Flow e2Flow | @@ -41,7 +41,7 @@ PyramidWeightConstraintsCommandTest >> targetContainers [ ^ { (PyramidCommandTestContainer no: e1Linear with: e2Linear prop: 0.5) . (PyramidCommandTestContainer no: e1Flow with: e2Flow prop: 0.5) } ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidWeightConstraintsCommandTest >> targetsCannotBeUsedFor [ "override if needed" | parent child | diff --git a/src/Pyramid-Tests/PyramidZIndexCommandTest.class.st b/src/Pyramid-Tests/PyramidZIndexCommandTest.class.st index ccb5fe23..13a1594a 100644 --- a/src/Pyramid-Tests/PyramidZIndexCommandTest.class.st +++ b/src/Pyramid-Tests/PyramidZIndexCommandTest.class.st @@ -12,7 +12,7 @@ PyramidZIndexCommandTest >> command [ ^ PyramidZIndexCommand new. ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidZIndexCommandTest >> targetContainers [ ^ { diff --git a/src/Pyramid-Tests/TPyramidCommandTest.trait.st b/src/Pyramid-Tests/TPyramidCommandTest.trait.st index fb408590..c7f62f97 100644 --- a/src/Pyramid-Tests/TPyramidCommandTest.trait.st +++ b/src/Pyramid-Tests/TPyramidCommandTest.trait.st @@ -3,7 +3,7 @@ Trait { #category : #'Pyramid-Tests-cases-command' } -{ #category : #'as yet unclassified' } +{ #category : #accessing } TPyramidCommandTest >> argumentsForHistory [ @@ -16,19 +16,19 @@ TPyramidCommandTest >> command [ ^ self shouldBeImplemented ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } TPyramidCommandTest >> targetContainers [ ^ self shouldBeImplemented ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } TPyramidCommandTest >> targetsCanBeUsedFor [ ^ self targetContainers flatCollect: [ :each | { each targetNoProp . each targetWithProp } ]. ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } TPyramidCommandTest >> targetsCannotBeUsedFor [ "override if needed" ^ { nil . false . 0 . $a } diff --git a/src/Pyramid-Toplo-Tests/PyramidStampCommandTest.class.st b/src/Pyramid-Toplo-Tests/PyramidStampCommandTest.class.st index b27c592e..f7143ce0 100644 --- a/src/Pyramid-Toplo-Tests/PyramidStampCommandTest.class.st +++ b/src/Pyramid-Toplo-Tests/PyramidStampCommandTest.class.st @@ -12,7 +12,7 @@ PyramidStampCommandTest >> command [ ^ PyramidStampCommand new stamp: #test; yourself ] -{ #category : #'as yet unclassified' } +{ #category : #accessing } PyramidStampCommandTest >> targetContainers [ ^ { From 1ea94f5ea541c05aaf0a8402178a677d4e2810f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Thu, 16 Apr 2026 16:39:45 +0200 Subject: [PATCH 11/16] update devStage_shadow --- src/Pyramid-Bloc/PyramidShadowColorCommand.class.st | 13 ++++++------- .../PyramidShadowGaussianWidthCommand.class.st | 12 +++++------- .../PyramidShadowOffsetCommand.class.st | 13 ++++++------- 3 files changed, 17 insertions(+), 21 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st index ec8cae3b..52bfd00c 100644 --- a/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowColorCommand.class.st @@ -15,17 +15,16 @@ PyramidShadowColorCommand >> canBeUsedFor: anObject [ { #category : #accessing } PyramidShadowColorCommand >> getValueFor: aBlElement [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) - ifTrue: [ ^ aBlElement effect color ] - ifFalse: [ ^ nil ] + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + ^ aBlElement effect color ] { #category : #accessing } PyramidShadowColorCommand >> setValueFor: aBlElement with: aColor [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class= BlGaussianShadowEffect]) - ifTrue: [ - aBlElement effect: (aBlElement effect copyWithColor: aColor) ] - ifFalse: [ ^ nil ]. + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + aBlElement effect: (aBlElement effect copyWithColor: aColor). PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st index 08272272..c9e8984b 100644 --- a/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowGaussianWidthCommand.class.st @@ -15,17 +15,15 @@ PyramidShadowGaussianWidthCommand >> canBeUsedFor: anObject [ PyramidShadowGaussianWidthCommand >> getValueFor: aBlElement [ (aBlElement effect class = BlSimpleShadowEffect or: [ - aBlElement effect class = BlGaussianShadowEffect ]) - ifTrue: [ ^ aBlElement effect width ] - ifFalse: [ ^ nil ] + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + ^ aBlElement effect width ] { #category : #accessing } PyramidShadowGaussianWidthCommand >> setValueFor: aBlElement with: aWidth [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) - ifTrue: [ - aBlElement effect: (aBlElement effect copyWithWidth: aWidth) ] - ifFalse: [ ^ nil ]. + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + aBlElement effect: (aBlElement effect copyWithWidth: aWidth). PyramidShadowCommand current syncFromElement: aBlElement ] diff --git a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st index a4388e2b..73737e5e 100644 --- a/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidShadowOffsetCommand.class.st @@ -14,17 +14,16 @@ PyramidShadowOffsetCommand >> canBeUsedFor: anObject [ { #category : #accessing } PyramidShadowOffsetCommand >> getValueFor: aBlElement [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) - ifTrue: [ ^ aBlElement effect offset ] - ifFalse: [ ^ nil ] + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + ^ aBlElement effect offset ] { #category : #accessing } PyramidShadowOffsetCommand >> setValueFor: aBlElement with: aPoint [ - (aBlElement effect class = BlSimpleShadowEffect or: [aBlElement effect class = BlGaussianShadowEffect]) - ifTrue: [ - aBlElement effect: (aBlElement effect copyWithOffset: aPoint) ] - ifFalse: [ ^ nil ]. + (aBlElement effect class = BlSimpleShadowEffect or: [ + aBlElement effect class = BlGaussianShadowEffect ]) ifFalse: [ ^ nil ]. + aBlElement effect: (aBlElement effect copyWithOffset: aPoint). PyramidShadowCommand current syncFromElement: aBlElement ] From 8550b54e3b83d5f588c30563407e3c072483b76f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 21 Apr 2026 14:43:54 +0200 Subject: [PATCH 12/16] =?UTF-8?q?fix=20issue=20:=20Undo=20of=20remove=20el?= =?UTF-8?q?ement=20doesn=E2=80=99t=20put=20it=20back=20in=20the=20same=20p?= =?UTF-8?q?osition=20#187?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../PyramidAddChildCommand.class.st | 7 +- .../PyramidAddChildrenCommand.class.st | 4 +- ...amidRemoveSelectedElementsCommand.class.st | 29 ++++--- ...PyramidUndoRemoveChildCommandTest.class.st | 87 +++++++++++++++++++ src/Pyramid/PyramidCompositeMemento.class.st | 7 +- 5 files changed, 117 insertions(+), 17 deletions(-) create mode 100644 src/Pyramid-Tests/PyramidUndoRemoveChildCommandTest.class.st diff --git a/src/Pyramid-Bloc/PyramidAddChildCommand.class.st b/src/Pyramid-Bloc/PyramidAddChildCommand.class.st index 5b13af98..05e2cb54 100644 --- a/src/Pyramid-Bloc/PyramidAddChildCommand.class.st +++ b/src/Pyramid-Bloc/PyramidAddChildCommand.class.st @@ -12,6 +12,9 @@ PyramidAddChildCommand >> commandInverse [ { #category : #'as yet unclassified' } PyramidAddChildCommand >> setValueFor: aBlElement with: aChildToAdd [ - - aBlElement addChild: aChildToAdd + | index | + index := aChildToAdd userData at: #removedAtIndex ifAbsent: [ 0 ]. + (index = 0 or: [ index > aBlElement children size ]) + ifTrue: [ aBlElement addChild: aChildToAdd ] + ifFalse: [ aBlElement addChild: aChildToAdd at: index ] ] diff --git a/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st b/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st index 1c146561..520fe7cd 100644 --- a/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st +++ b/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st @@ -12,6 +12,6 @@ PyramidAddChildrenCommand >> commandInverse [ { #category : #'as yet unclassified' } PyramidAddChildrenCommand >> setValueFor: aBlElement with: aChildrenToAdd [ - - aBlElement addChildren: aChildrenToAdd + aChildrenToAdd do: [ :child | + aBlElement addChild: child ] ] diff --git a/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st b/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st index 2beae596..9e281af1 100644 --- a/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st @@ -15,18 +15,23 @@ PyramidRemoveSelectedElementsCommand >> getValueFor: anElementOfSelection [ { #category : #'as yet unclassified' } PyramidRemoveSelectedElementsCommand >> mementoFor: anElement withArguments: anArgument [ - - (anArgument includes: anElement) ifTrue: [ - ^ PyramidCommandMemento new - command: PyramidRemoveFromCollectionCommand new commandInverse; - target: anArgument; - arguments: anElement; - yourself ]. - ^ PyramidCommandMemento new - command: PyramidRemoveChildCommand new commandInverse; - target: anElement parent; - arguments: anElement; - yourself + | index | + "Save index before removing" + index := anElement parent + ifNotNil: [ :p | p children indexOf: anElement ] + ifNil: [ 0 ]. + anElement userData at: #removedAtIndex put: index. + (anArgument includes: anElement) ifTrue: [ + ^ PyramidCommandMemento new + command: PyramidRemoveFromCollectionCommand new commandInverse; + target: anArgument; + arguments: anElement; + yourself ]. + ^ PyramidCommandMemento new + command: PyramidRemoveChildCommand new commandInverse; + target: anElement parent; + arguments: anElement; + yourself ] { #category : #accessing } diff --git a/src/Pyramid-Tests/PyramidUndoRemoveChildCommandTest.class.st b/src/Pyramid-Tests/PyramidUndoRemoveChildCommandTest.class.st new file mode 100644 index 00000000..76ffedc0 --- /dev/null +++ b/src/Pyramid-Tests/PyramidUndoRemoveChildCommandTest.class.st @@ -0,0 +1,87 @@ +Class { + #name : #PyramidUndoRemoveChildCommandTest, + #superclass : #TestCase, + #category : #'Pyramid-Tests-cases-plugin-bloc' +} + +{ #category : #tests } +PyramidUndoRemoveChildCommandTest >> testUndoRemoveAllChildrenRestoresIndex [ + + | history commandExecutor parent child1 child2 child3 child4| + parent := BlElement new. + child1 := BlElement new. + child2 := BlElement new. + child3 := BlElement new. + child4 := BlElement new. + parent addChildren: {child1. child2 .child3. child4}. + + history := PyramidHistory new. + commandExecutor := PyramidHistoryCommandExecutor new + history: history; + wrappee: PyramidMainCommandExecutor new; + yourself. + commandExecutor + use: PyramidRemoveSelectedElementsCommand new + on: { + child4. + child2. + child1 } + with: { parent }. + + self deny: (parent children includes: child2). + self deny: (parent children includes: child1). + self deny: (parent children includes: child4). + + "Undo" + history undo. + + self assert: (parent children includes: child1). + self assert: (parent children includes: child2). + self assert: (parent children indexOf: child1) equals: 1. + self assert: (parent children indexOf: child2) equals: 2. + self assert: (parent children indexOf: child4) equals: 4 +] + +{ #category : #tests } +PyramidUndoRemoveChildCommandTest >> testUndoRemoveChildRestoresIndex [ + + | history commandExecutor parent child1 child2 child3 | + + parent := BlElement new. + child1 := BlElement new. + child2 := BlElement new. + child3 := BlElement new. + parent addChild: child1. + parent addChild: child2. + parent addChild: child3. + + history := PyramidHistory new. + commandExecutor := PyramidHistoryCommandExecutor new + history: history; + wrappee: PyramidMainCommandExecutor new; + yourself. + + commandExecutor + use: PyramidRemoveSelectedElementsCommand new + on: { child2 } + with: { parent }. + + self deny: (parent children includes: child2). + + "Undo" + history undo. + + self assert: (parent children includes: child2). + self assert: (parent children indexOf: child2) equals: 2. + + "Redo" + history redo. + + self deny: (parent children includes: child2). + + "Undo" + history undo. + + self assert: (parent children includes: child2). + self assert: (parent children indexOf: child2) equals: 2 +] diff --git a/src/Pyramid/PyramidCompositeMemento.class.st b/src/Pyramid/PyramidCompositeMemento.class.st index f3eb07f9..8ec74569 100644 --- a/src/Pyramid/PyramidCompositeMemento.class.st +++ b/src/Pyramid/PyramidCompositeMemento.class.st @@ -34,5 +34,10 @@ PyramidCompositeMemento >> mementos: anObject [ { #category : #'window management' } PyramidCompositeMemento >> restore [ - self mementos do: [ :each | each restore ] + (self mementos allSatisfy: [ :m | m arguments isKindOf: BlElement ]) + ifFalse: [ self mementos do: [ :each | each restore ]. ^ self ]. + (self mementos asSortedCollection: [ :a :b | + (a arguments userData at: #removedAtIndex ifAbsent: [ 0 ]) + < (b arguments userData at: #removedAtIndex ifAbsent: [ 0 ]) ]) + do: [ :each | each restore ] ] From 4e82ec8a0a53bdc6a6c79189f207fd69e4f0d5c6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Thu, 23 Apr 2026 14:48:56 +0200 Subject: [PATCH 13/16] update devStage_fixIssueUndo187 --- src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st b/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st index 520fe7cd..24c741a9 100644 --- a/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st +++ b/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st @@ -12,6 +12,6 @@ PyramidAddChildrenCommand >> commandInverse [ { #category : #'as yet unclassified' } PyramidAddChildrenCommand >> setValueFor: aBlElement with: aChildrenToAdd [ - aChildrenToAdd do: [ :child | - aBlElement addChild: child ] + + aBlElement addChildren: aChildrenToAdd ] From d425f9fdf45dd7e02fa24ead3ddd1fdce91adefc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 28 Apr 2026 14:26:17 +0200 Subject: [PATCH 14/16] =?UTF-8?q?update=20fix=20issue=20:=20Undo=20of=20re?= =?UTF-8?q?move=20element=20doesn=E2=80=99t=20put=20it=20back=20in=20the?= =?UTF-8?q?=20same=20position=20#187?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../PyramidAbstractBorderCommand.class.st | 2 +- ...midAbstractChangeDrawOrderCommand.class.st | 2 +- .../PyramidAddChildCommand.class.st | 23 ++++++--- .../PyramidAddChildrenCommand.class.st | 4 +- .../PyramidBackgroundImageCommand.class.st | 4 +- .../PyramidBackgroundOpacityCommand.class.st | 4 +- ...yramidBackgroundPaintColorCommand.class.st | 4 +- .../PyramidBackgroundPaintCommand.class.st | 6 +-- ...idBackgroundPaintLinearEndCommand.class.st | 4 +- ...BackgroundPaintLinearStartCommand.class.st | 4 +- ...oundPaintRadialInnerCenterCommand.class.st | 4 +- ...oundPaintRadialInnerRadiusCommand.class.st | 4 +- ...oundPaintRadialOuterCenterCommand.class.st | 4 +- ...oundPaintRadialOuterRadiusCommand.class.st | 4 +- ...yramidBackgroundPaintStopsCommand.class.st | 4 +- .../PyramidBackgroundTypeCommand.class.st | 6 +-- ...tHorizontalConstraintsBlocCommand.class.st | 4 +- ...actVerticalConstraintsBlocCommand.class.st | 4 +- ...cHorizontalConstraintsBlocCommand.class.st | 6 +-- ...sicVerticalConstraintsBlocCommand.class.st | 6 +-- .../PyramidBorderDashArrayCommand.class.st | 2 +- .../PyramidBorderDashOffsetCommand.class.st | 2 +- .../PyramidBorderLineCapCommand.class.st | 2 +- .../PyramidBorderLineJoinCommand.class.st | 2 +- .../PyramidBorderMiterLimitCommand.class.st | 2 +- .../PyramidBorderOpacityCommand.class.st | 2 +- .../PyramidBorderPaintColorCommand.class.st | 2 +- .../PyramidBorderPaintCommand.class.st | 2 +- ...derPaintLinearDirectionEndCommand.class.st | 2 +- ...rPaintLinearDirectionStartCommand.class.st | 2 +- ...rderPaintRadialInnerCenterCommand.class.st | 2 +- ...rderPaintRadialInnerRadiusCommand.class.st | 2 +- ...rderPaintRadialOuterCenterCommand.class.st | 2 +- ...rderPaintRadialOuterRadiusCommand.class.st | 2 +- .../PyramidBorderPaintStopsCommand.class.st | 2 +- .../PyramidBorderWidthCommand.class.st | 2 +- ...yramidChangeOrderWithIndexCommand.class.st | 2 +- .../PyramidChangeTextCommand.class.st | 4 +- .../PyramidChildrenCommand.class.st | 4 +- .../PyramidClipChildrenCommand.class.st | 4 +- .../PyramidDynamicResizeCommand.class.st | 8 ++-- .../PyramidElementIdCommand.class.st | 4 +- .../PyramidFontSizeCommand.class.st | 4 +- .../PyramidFontWeightCommand.class.st | 4 +- ...FrameHorizontalConstraintsCommand.class.st | 4 +- ...idFrameVerticalConstraintsCommand.class.st | 4 +- .../PyramidGeometryCommand.class.st | 4 +- src/Pyramid-Bloc/PyramidGroupCommand.class.st | 10 ++-- .../PyramidLayoutBlocCommand.class.st | 4 +- ...midLayoutChangeOrientationCommand.class.st | 4 +- .../PyramidMarginCommand.class.st | 4 +- .../PyramidMoveBackwardOrderCommand.class.st | 4 +- .../PyramidMoveChildInParentCommand.class.st | 4 +- .../PyramidMoveChildIndexDownCommand.class.st | 4 +- .../PyramidMoveChildIndexUpCommand.class.st | 4 +- .../PyramidMoveForwardOrderCommand.class.st | 4 +- .../PyramidOnBackgroundOrderCommand.class.st | 4 +- .../PyramidOnForegroundOrderCommand.class.st | 4 +- .../PyramidOpacityCommand.class.st | 4 +- .../PyramidOutskirtsCommand.class.st | 4 +- .../PyramidPaddingCommand.class.st | 4 +- .../PyramidPositionCommand.class.st | 4 +- .../PyramidPositionOffsetCommand.class.st | 8 ++-- ...ionalHorizontalConstraintsCommand.class.st | 4 +- ...rtionalVerticalConstraintsCommand.class.st | 4 +- .../PyramidRedoGroupCommand.class.st | 6 +-- .../PyramidRemoveChildCommand.class.st | 4 +- .../PyramidRemoveChildrenCommand.class.st | 4 +- ...amidRemoveSelectedElementsCommand.class.st | 48 +++++++++++-------- ...oundedRectangleCornerRadiiCommand.class.st | 4 +- .../PyramidTextForegroundCommand.class.st | 4 +- ...ramidUndoDynamicResizeBlocCommand.class.st | 6 +-- .../PyramidUndoGroupCommand.class.st | 6 +-- .../PyramidVisibilityCommand.class.st | 4 +- .../PyramidWeightConstraintsCommand.class.st | 4 +- .../PyramidZIndexCommand.class.st | 4 +- .../PyramidDecreaseMockCommand.class.st | 6 +-- .../PyramidIncreaseMockCommand.class.st | 6 +-- .../PyramidSimpleMockCommand.class.st | 4 +- .../PyramidSimpleMockGroupedCommand.class.st | 2 +- .../PyramidStampCommand.class.st | 4 +- .../PyramidThemeCommand.class.st | 4 +- .../PyramidAddAllToCollectionCommand.class.st | 6 +-- .../PyramidAddToCollectionCommand.class.st | 6 +-- src/Pyramid/PyramidCollectionCommand.class.st | 2 +- src/Pyramid/PyramidCommand.class.st | 18 +++---- ...midRemoveAllFromCollectionCommand.class.st | 6 +-- ...yramidRemoveFromCollectionCommand.class.st | 6 +-- 88 files changed, 221 insertions(+), 206 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidAbstractBorderCommand.class.st b/src/Pyramid-Bloc/PyramidAbstractBorderCommand.class.st index d95e6834..d355e19a 100644 --- a/src/Pyramid-Bloc/PyramidAbstractBorderCommand.class.st +++ b/src/Pyramid-Bloc/PyramidAbstractBorderCommand.class.st @@ -20,7 +20,7 @@ PyramidAbstractBorderCommand >> borderBuilderOf: aBlElement [ ^ builder ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidAbstractBorderCommand >> setValueFor: aBlElement with: anArgument [ | builder | diff --git a/src/Pyramid-Bloc/PyramidAbstractChangeDrawOrderCommand.class.st b/src/Pyramid-Bloc/PyramidAbstractChangeDrawOrderCommand.class.st index 38ee07cb..a6616327 100644 --- a/src/Pyramid-Bloc/PyramidAbstractChangeDrawOrderCommand.class.st +++ b/src/Pyramid-Bloc/PyramidAbstractChangeDrawOrderCommand.class.st @@ -16,7 +16,7 @@ PyramidAbstractChangeDrawOrderCommand >> canBeUsedFor: anObject [ ^ (super canBeUsedFor: anObject) and: [ anObject hasParent] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidAbstractChangeDrawOrderCommand >> getValueFor: aBlElement [ "return current index for testing." diff --git a/src/Pyramid-Bloc/PyramidAddChildCommand.class.st b/src/Pyramid-Bloc/PyramidAddChildCommand.class.st index 05e2cb54..40ae11b1 100644 --- a/src/Pyramid-Bloc/PyramidAddChildCommand.class.st +++ b/src/Pyramid-Bloc/PyramidAddChildCommand.class.st @@ -4,17 +4,26 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidAddChildCommand >> commandInverse [ ^ PyramidRemoveChildCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #private } +PyramidAddChildCommand >> savedIndexFor: aChild in: aParent [ + + | index | + index := aChild userData at: #removedAtIndex ifAbsent: [ 0 ]. + (index = 0 or: [ index > aParent children size ]) + ifTrue: [ ^ aParent children size + 1 ] + ifFalse: [ ^ index ] +] + +{ #category : #setter } PyramidAddChildCommand >> setValueFor: aBlElement with: aChildToAdd [ - | index | - index := aChildToAdd userData at: #removedAtIndex ifAbsent: [ 0 ]. - (index = 0 or: [ index > aBlElement children size ]) - ifTrue: [ aBlElement addChild: aChildToAdd ] - ifFalse: [ aBlElement addChild: aChildToAdd at: index ] + + aBlElement + addChild: aChildToAdd + at: (self savedIndexFor: aChildToAdd in: aBlElement) ] diff --git a/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st b/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st index 520fe7cd..34df84a2 100644 --- a/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st +++ b/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidAddChildrenCommand >> commandInverse [ ^ PyramidRemoveChildrenCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidAddChildrenCommand >> setValueFor: aBlElement with: aChildrenToAdd [ aChildrenToAdd do: [ :child | aBlElement addChild: child ] diff --git a/src/Pyramid-Bloc/PyramidBackgroundImageCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundImageCommand.class.st index e8d958a4..42bda929 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundImageCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundImageCommand.class.st @@ -11,13 +11,13 @@ PyramidBackgroundImageCommand >> canBeUsedFor: anObject [ anObject background isKindOf: BlImageBackground ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundImageCommand >> getValueFor: aBlElement [ ^ aBlElement background image ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundImageCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background: (BlBackground image: anArgument) diff --git a/src/Pyramid-Bloc/PyramidBackgroundOpacityCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundOpacityCommand.class.st index f5093b8e..5521f475 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundOpacityCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundOpacityCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundOpacityCommand >> getValueFor: aBlElement [ ^ aBlElement background opacity ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundOpacityCommand >> setValueFor: aBlElement with: anArgument [ | background | diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintColorCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintColorCommand.class.st index d2249ff9..0a63dd0d 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintColorCommand.class.st @@ -12,13 +12,13 @@ PyramidBackgroundPaintColorCommand >> canBeUsedFor: anObject [ anObject background paint isKindOf: BlColorPaint ] ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintColorCommand >> getValueFor: aBlElement [ ^ aBlElement background paint color ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintColorCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background: (BlBackground paint: anArgument asBlPaint) diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintCommand.class.st index 95c0fd85..45a5f776 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintCommand.class.st @@ -11,19 +11,19 @@ PyramidBackgroundPaintCommand >> canBeUsedFor: anObject [ anObject background isKindOf: BlPaintBackground ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintCommand >> getGroupedValueFor: aBlElement [ ^ aBlElement background paint class ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintCommand >> getValueFor: aBlElement [ ^ aBlElement background paint ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background: (BlBackground paint: anArgument value) diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintLinearEndCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintLinearEndCommand.class.st index 4201cb78..54897472 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintLinearEndCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintLinearEndCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintLinearEndCommand >> getValueFor: aBlElement [ ^ aBlElement background paint end ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintLinearEndCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background paint end: anArgument diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintLinearStartCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintLinearStartCommand.class.st index c62bbd9f..317cd3a6 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintLinearStartCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintLinearStartCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintLinearStartCommand >> getValueFor: aBlElement [ ^ aBlElement background paint start ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintLinearStartCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background paint start: anArgument diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerCenterCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerCenterCommand.class.st index e85efec8..3e5181ee 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerCenterCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerCenterCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintRadialInnerCenterCommand >> getValueFor: aBlElement [ ^ aBlElement background paint innerCenter ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintRadialInnerCenterCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background paint innerCenter: anArgument diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerRadiusCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerRadiusCommand.class.st index a2c2888d..2416e8c1 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerRadiusCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintRadialInnerRadiusCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintRadialInnerRadiusCommand >> getValueFor: aBlElement [ ^ aBlElement background paint innerRadius ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintRadialInnerRadiusCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background paint innerRadius: anArgument diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterCenterCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterCenterCommand.class.st index 8d8deac9..352d4e4c 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterCenterCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterCenterCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintRadialOuterCenterCommand >> getValueFor: aBlElement [ ^ aBlElement background paint outerCenter ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintRadialOuterCenterCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background paint outerCenter: anArgument diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterRadiusCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterRadiusCommand.class.st index f1ba79b4..c313f420 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterRadiusCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintRadialOuterRadiusCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintRadialOuterRadiusCommand >> getValueFor: aBlElement [ ^ aBlElement background paint outerRadius ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintRadialOuterRadiusCommand >> setValueFor: aBlElement with: anArgument [ aBlElement background paint outerRadius: anArgument diff --git a/src/Pyramid-Bloc/PyramidBackgroundPaintStopsCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundPaintStopsCommand.class.st index faebbb2a..57073903 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundPaintStopsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundPaintStopsCommand.class.st @@ -12,7 +12,7 @@ PyramidBackgroundPaintStopsCommand >> canBeUsedFor: anObject [ anObject background paint isKindOf: BlGradientPaint ] ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundPaintStopsCommand >> getValueFor: aBlElement [ "We ensure that we are working with a copy of the associations." @@ -20,7 +20,7 @@ PyramidBackgroundPaintStopsCommand >> getValueFor: aBlElement [ asso key copy -> asso value copy ] ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundPaintStopsCommand >> setValueFor: aBlElement with: anArgument [ "We ensure that we are working with a copy of the associations." diff --git a/src/Pyramid-Bloc/PyramidBackgroundTypeCommand.class.st b/src/Pyramid-Bloc/PyramidBackgroundTypeCommand.class.st index 9031fa54..77e77faa 100644 --- a/src/Pyramid-Bloc/PyramidBackgroundTypeCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBackgroundTypeCommand.class.st @@ -4,19 +4,19 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundTypeCommand >> getGroupedValueFor: aBlElement [ ^ aBlElement background class ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBackgroundTypeCommand >> getValueFor: aBlElement [ ^ aBlElement background ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBackgroundTypeCommand >> setValueFor: aBlElement with: anArgument [ "Must be a blockClosure to ensure no background are created." diff --git a/src/Pyramid-Bloc/PyramidBasicExactHorizontalConstraintsBlocCommand.class.st b/src/Pyramid-Bloc/PyramidBasicExactHorizontalConstraintsBlocCommand.class.st index 0988c930..cbd6cff3 100644 --- a/src/Pyramid-Bloc/PyramidBasicExactHorizontalConstraintsBlocCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBasicExactHorizontalConstraintsBlocCommand.class.st @@ -11,13 +11,13 @@ PyramidBasicExactHorizontalConstraintsBlocCommand >> canBeUsedFor: anObject [ anObject constraints horizontal resizer isExact ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBasicExactHorizontalConstraintsBlocCommand >> getValueFor: anObject [ ^ anObject constraints horizontal resizer size ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBasicExactHorizontalConstraintsBlocCommand >> setValueFor: anObject with: anArgument [ ^ anObject constraintsDo: [ :c | c horizontal exact: anArgument ] diff --git a/src/Pyramid-Bloc/PyramidBasicExactVerticalConstraintsBlocCommand.class.st b/src/Pyramid-Bloc/PyramidBasicExactVerticalConstraintsBlocCommand.class.st index 664cf61e..34b3f184 100644 --- a/src/Pyramid-Bloc/PyramidBasicExactVerticalConstraintsBlocCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBasicExactVerticalConstraintsBlocCommand.class.st @@ -11,13 +11,13 @@ PyramidBasicExactVerticalConstraintsBlocCommand >> canBeUsedFor: anObject [ anObject constraints vertical resizer isExact ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBasicExactVerticalConstraintsBlocCommand >> getValueFor: anObject [ ^ anObject constraints vertical resizer size ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBasicExactVerticalConstraintsBlocCommand >> setValueFor: anObject with: anArgument [ ^ anObject constraintsDo: [ :c | c vertical exact: anArgument ] diff --git a/src/Pyramid-Bloc/PyramidBasicHorizontalConstraintsBlocCommand.class.st b/src/Pyramid-Bloc/PyramidBasicHorizontalConstraintsBlocCommand.class.st index 1c1af430..3286df52 100644 --- a/src/Pyramid-Bloc/PyramidBasicHorizontalConstraintsBlocCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBasicHorizontalConstraintsBlocCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBasicHorizontalConstraintsBlocCommand >> getValueFor: anObject [ ^ anObject constraints horizontal ] -{ #category : #'as yet unclassified' } +{ #category : #private } PyramidBasicHorizontalConstraintsBlocCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: anArguments [ | mementos | @@ -26,7 +26,7 @@ PyramidBasicHorizontalConstraintsBlocCommand >> saveStatesOf: aCollection withCo yourself ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBasicHorizontalConstraintsBlocCommand >> setValueFor: anObject with: anArgument [ anArgument isSymbol diff --git a/src/Pyramid-Bloc/PyramidBasicVerticalConstraintsBlocCommand.class.st b/src/Pyramid-Bloc/PyramidBasicVerticalConstraintsBlocCommand.class.st index b68c7202..db8daf3f 100644 --- a/src/Pyramid-Bloc/PyramidBasicVerticalConstraintsBlocCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBasicVerticalConstraintsBlocCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBasicVerticalConstraintsBlocCommand >> getValueFor: anObject [ ^ anObject constraints vertical ] -{ #category : #'as yet unclassified' } +{ #category : #private } PyramidBasicVerticalConstraintsBlocCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: anArguments [ | mementos | @@ -27,7 +27,7 @@ PyramidBasicVerticalConstraintsBlocCommand >> saveStatesOf: aCollection withComm yourself ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidBasicVerticalConstraintsBlocCommand >> setValueFor: anObject with: anArgument [ anArgument isSymbol diff --git a/src/Pyramid-Bloc/PyramidBorderDashArrayCommand.class.st b/src/Pyramid-Bloc/PyramidBorderDashArrayCommand.class.st index c8d064ae..009c994b 100644 --- a/src/Pyramid-Bloc/PyramidBorderDashArrayCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderDashArrayCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderDashArrayCommand >> getValueFor: aBlElement [ ^ aBlElement border style dashArray diff --git a/src/Pyramid-Bloc/PyramidBorderDashOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidBorderDashOffsetCommand.class.st index a30514b4..ca51c9d2 100644 --- a/src/Pyramid-Bloc/PyramidBorderDashOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderDashOffsetCommand.class.st @@ -11,7 +11,7 @@ PyramidBorderDashOffsetCommand >> canBeUsedFor: anObject [ anObject border style dashArray isNotEmpty ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderDashOffsetCommand >> getValueFor: aBlElement [ ^ aBlElement border style dashOffset diff --git a/src/Pyramid-Bloc/PyramidBorderLineCapCommand.class.st b/src/Pyramid-Bloc/PyramidBorderLineCapCommand.class.st index 90ae60e9..f9c10852 100644 --- a/src/Pyramid-Bloc/PyramidBorderLineCapCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderLineCapCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderLineCapCommand >> getValueFor: aBlElement [ ^ aBlElement border style lineCap diff --git a/src/Pyramid-Bloc/PyramidBorderLineJoinCommand.class.st b/src/Pyramid-Bloc/PyramidBorderLineJoinCommand.class.st index 3ea1dbb1..3b461432 100644 --- a/src/Pyramid-Bloc/PyramidBorderLineJoinCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderLineJoinCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderLineJoinCommand >> getValueFor: aBlElement [ ^ aBlElement border style lineJoin diff --git a/src/Pyramid-Bloc/PyramidBorderMiterLimitCommand.class.st b/src/Pyramid-Bloc/PyramidBorderMiterLimitCommand.class.st index e70e6d41..c6f86446 100644 --- a/src/Pyramid-Bloc/PyramidBorderMiterLimitCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderMiterLimitCommand.class.st @@ -11,7 +11,7 @@ PyramidBorderMiterLimitCommand >> canBeUsedFor: anObject [ (anObject border style lineJoin isKindOf: BlStrokeLineMiterJoin) ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderMiterLimitCommand >> getValueFor: aBlElement [ ^ aBlElement border style miterLimit diff --git a/src/Pyramid-Bloc/PyramidBorderOpacityCommand.class.st b/src/Pyramid-Bloc/PyramidBorderOpacityCommand.class.st index e1d6b44e..5c818acf 100644 --- a/src/Pyramid-Bloc/PyramidBorderOpacityCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderOpacityCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderOpacityCommand >> getValueFor: aBlElement [ ^ aBlElement border opacity diff --git a/src/Pyramid-Bloc/PyramidBorderPaintColorCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintColorCommand.class.st index 10eeb2d7..de5ff490 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintColorCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintColorCommand.class.st @@ -11,7 +11,7 @@ PyramidBorderPaintColorCommand >> canBeUsedFor: anObject [ anObject border paint isKindOf: BlColorPaint ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintColorCommand >> getValueFor: aBlElement [ ^ aBlElement border paint color diff --git a/src/Pyramid-Bloc/PyramidBorderPaintCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintCommand.class.st index 44fb1a6d..85ac677c 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintCommand >> getValueFor: aBlElement [ ^ aBlElement border paint diff --git a/src/Pyramid-Bloc/PyramidBorderPaintLinearDirectionEndCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintLinearDirectionEndCommand.class.st index 1b18eb86..5b30c8b9 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintLinearDirectionEndCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintLinearDirectionEndCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintLinearDirectionEndCommand >> getValueFor: aBlElement [ ^ aBlElement border paint end diff --git a/src/Pyramid-Bloc/PyramidBorderPaintLinearDirectionStartCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintLinearDirectionStartCommand.class.st index 4f08a8a9..ca09f43d 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintLinearDirectionStartCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintLinearDirectionStartCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintLinearDirectionStartCommand >> getValueFor: aBlElement [ ^ aBlElement border paint start diff --git a/src/Pyramid-Bloc/PyramidBorderPaintRadialInnerCenterCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintRadialInnerCenterCommand.class.st index bdb47e7b..e95c8e32 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintRadialInnerCenterCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintRadialInnerCenterCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintRadialInnerCenterCommand >> getValueFor: aBlElement [ ^ aBlElement border paint innerCenter diff --git a/src/Pyramid-Bloc/PyramidBorderPaintRadialInnerRadiusCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintRadialInnerRadiusCommand.class.st index 8f6a2812..a2f83c29 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintRadialInnerRadiusCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintRadialInnerRadiusCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintRadialInnerRadiusCommand >> getValueFor: aBlElement [ ^ aBlElement border paint innerRadius diff --git a/src/Pyramid-Bloc/PyramidBorderPaintRadialOuterCenterCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintRadialOuterCenterCommand.class.st index 5a32a29a..9cc5cc8d 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintRadialOuterCenterCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintRadialOuterCenterCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintRadialOuterCenterCommand >> getValueFor: aBlElement [ ^ aBlElement border paint outerCenter diff --git a/src/Pyramid-Bloc/PyramidBorderPaintRadialOuterRadiusCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintRadialOuterRadiusCommand.class.st index 43c5b541..95a573e0 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintRadialOuterRadiusCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintRadialOuterRadiusCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintRadialOuterRadiusCommand >> getValueFor: aBlElement [ ^ aBlElement border paint outerRadius diff --git a/src/Pyramid-Bloc/PyramidBorderPaintStopsCommand.class.st b/src/Pyramid-Bloc/PyramidBorderPaintStopsCommand.class.st index 2626a3dd..da994230 100644 --- a/src/Pyramid-Bloc/PyramidBorderPaintStopsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderPaintStopsCommand.class.st @@ -11,7 +11,7 @@ PyramidBorderPaintStopsCommand >> canBeUsedFor: anObject [ anObject border paint isKindOf: BlGradientPaint ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderPaintStopsCommand >> getValueFor: aBlElement [ "We ensure that we are working with a copy of the associations." diff --git a/src/Pyramid-Bloc/PyramidBorderWidthCommand.class.st b/src/Pyramid-Bloc/PyramidBorderWidthCommand.class.st index b943532a..f7ed7450 100644 --- a/src/Pyramid-Bloc/PyramidBorderWidthCommand.class.st +++ b/src/Pyramid-Bloc/PyramidBorderWidthCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidBorderWidthCommand >> getValueFor: aBlElement [ ^ aBlElement border width diff --git a/src/Pyramid-Bloc/PyramidChangeOrderWithIndexCommand.class.st b/src/Pyramid-Bloc/PyramidChangeOrderWithIndexCommand.class.st index f314fb83..9db79209 100644 --- a/src/Pyramid-Bloc/PyramidChangeOrderWithIndexCommand.class.st +++ b/src/Pyramid-Bloc/PyramidChangeOrderWithIndexCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidChangeOrderWithIndexCommand >> setValueFor: aBlElement with: anArgument [ | currentIndex parent | diff --git a/src/Pyramid-Bloc/PyramidChangeTextCommand.class.st b/src/Pyramid-Bloc/PyramidChangeTextCommand.class.st index 93a2bbda..228a26b3 100644 --- a/src/Pyramid-Bloc/PyramidChangeTextCommand.class.st +++ b/src/Pyramid-Bloc/PyramidChangeTextCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-text' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidChangeTextCommand >> getValueFor: aBlTextElement [ ^ aBlTextElement text asString ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidChangeTextCommand >> setValueFor: aBlTextElement with: aString [ | attributes rope | diff --git a/src/Pyramid-Bloc/PyramidChildrenCommand.class.st b/src/Pyramid-Bloc/PyramidChildrenCommand.class.st index 0331d157..d06778ef 100644 --- a/src/Pyramid-Bloc/PyramidChildrenCommand.class.st +++ b/src/Pyramid-Bloc/PyramidChildrenCommand.class.st @@ -10,13 +10,13 @@ PyramidChildrenCommand class >> isAbstract [ ^ self == PyramidChildrenCommand ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidChildrenCommand >> getValueFor: aBlElement [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #private } PyramidChildrenCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: anArguments [ | mementos | diff --git a/src/Pyramid-Bloc/PyramidClipChildrenCommand.class.st b/src/Pyramid-Bloc/PyramidClipChildrenCommand.class.st index a4209f42..df44798a 100644 --- a/src/Pyramid-Bloc/PyramidClipChildrenCommand.class.st +++ b/src/Pyramid-Bloc/PyramidClipChildrenCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidClipChildrenCommand >> getValueFor: aBlElement [ ^ aBlElement clipChildren ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidClipChildrenCommand >> setValueFor: aBlElement with: anArgument [ aBlElement clipChildren: anArgument diff --git a/src/Pyramid-Bloc/PyramidDynamicResizeCommand.class.st b/src/Pyramid-Bloc/PyramidDynamicResizeCommand.class.st index 816bac00..0808cfe1 100644 --- a/src/Pyramid-Bloc/PyramidDynamicResizeCommand.class.st +++ b/src/Pyramid-Bloc/PyramidDynamicResizeCommand.class.st @@ -11,19 +11,19 @@ PyramidDynamicResizeCommand >> canBeUsedFor: anObject [ anObject size ] ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidDynamicResizeCommand >> commandInverse [ ^ PyramidUndoDynamicResizeBlocCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidDynamicResizeCommand >> getValueFor: anObject [ ^ anObject extent ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidDynamicResizeCommand >> saveStatesWithCommandInverseOf: aCollection with: arguments [ | mementos | @@ -39,7 +39,7 @@ PyramidDynamicResizeCommand >> saveStatesWithCommandInverseOf: aCollection with: yourself ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidDynamicResizeCommand >> setValueFor: anObject with: anArgument [ ^ anObject constraintsDo: [ :c | diff --git a/src/Pyramid-Bloc/PyramidElementIdCommand.class.st b/src/Pyramid-Bloc/PyramidElementIdCommand.class.st index 66f89484..f6c48266 100644 --- a/src/Pyramid-Bloc/PyramidElementIdCommand.class.st +++ b/src/Pyramid-Bloc/PyramidElementIdCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidElementIdCommand >> getValueFor: aBlElement [ ^ aBlElement id ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidElementIdCommand >> setValueFor: aBlElement with: anArgument [ aBlElement id: anArgument diff --git a/src/Pyramid-Bloc/PyramidFontSizeCommand.class.st b/src/Pyramid-Bloc/PyramidFontSizeCommand.class.st index 8dbf1c83..ae3786ae 100644 --- a/src/Pyramid-Bloc/PyramidFontSizeCommand.class.st +++ b/src/Pyramid-Bloc/PyramidFontSizeCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-text' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidFontSizeCommand >> getValueFor: aBlTextElement [ aBlTextElement text attributesFinder @@ -14,7 +14,7 @@ PyramidFontSizeCommand >> getValueFor: aBlTextElement [ ^ 10 ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidFontSizeCommand >> setValueFor: aBlTextElement with: aNumber [ aBlTextElement text attribute: (BlFontSizeAttribute size: aNumber). diff --git a/src/Pyramid-Bloc/PyramidFontWeightCommand.class.st b/src/Pyramid-Bloc/PyramidFontWeightCommand.class.st index a7c5ba98..5a175d22 100644 --- a/src/Pyramid-Bloc/PyramidFontWeightCommand.class.st +++ b/src/Pyramid-Bloc/PyramidFontWeightCommand.class.st @@ -4,14 +4,14 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-text' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidFontWeightCommand >> getValueFor: aBlTextElement [ aBlTextElement text attributesFinder findAttributesSuchThat: [ :a | a class = BlFontWeightAttribute ] indicesDo: [ :new :old :a | ^ a weight ]. ^ LogicalFont weightRegular ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidFontWeightCommand >> setValueFor: aBlTextElement with: aNumber [ aBlTextElement text attribute: diff --git a/src/Pyramid-Bloc/PyramidFrameHorizontalConstraintsCommand.class.st b/src/Pyramid-Bloc/PyramidFrameHorizontalConstraintsCommand.class.st index 271f6c0e..62753f9b 100644 --- a/src/Pyramid-Bloc/PyramidFrameHorizontalConstraintsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidFrameHorizontalConstraintsCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidFrameHorizontalConstraintsCommand >> getValueFor: anObject [ ^ anObject constraints frame horizontal alignment ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidFrameHorizontalConstraintsCommand >> setValueFor: anObject with: anArgument [ anObject constraintsDo: [ :c | diff --git a/src/Pyramid-Bloc/PyramidFrameVerticalConstraintsCommand.class.st b/src/Pyramid-Bloc/PyramidFrameVerticalConstraintsCommand.class.st index 99b53c7a..af0b2905 100644 --- a/src/Pyramid-Bloc/PyramidFrameVerticalConstraintsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidFrameVerticalConstraintsCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidFrameVerticalConstraintsCommand >> getValueFor: anObject [ ^ anObject constraints frame vertical alignment ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidFrameVerticalConstraintsCommand >> setValueFor: anObject with: anArgument [ anObject constraintsDo: [ :c | diff --git a/src/Pyramid-Bloc/PyramidGeometryCommand.class.st b/src/Pyramid-Bloc/PyramidGeometryCommand.class.st index 411acf89..ad6277e3 100644 --- a/src/Pyramid-Bloc/PyramidGeometryCommand.class.st +++ b/src/Pyramid-Bloc/PyramidGeometryCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-geometry' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidGeometryCommand >> getValueFor: aBlElement [ ^ aBlElement geometry ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidGeometryCommand >> setValueFor: aBlElement with: anArgument [ aBlElement geometry: anArgument diff --git a/src/Pyramid-Bloc/PyramidGroupCommand.class.st b/src/Pyramid-Bloc/PyramidGroupCommand.class.st index bfb54ab2..e5292bd5 100644 --- a/src/Pyramid-Bloc/PyramidGroupCommand.class.st +++ b/src/Pyramid-Bloc/PyramidGroupCommand.class.st @@ -20,7 +20,7 @@ PyramidGroupCommand >> canBeUsedFor: aCollectionOfBlElements [ each parent = parent ] ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidGroupCommand >> commandInverse [ "Command used to undo the group." @@ -67,7 +67,7 @@ PyramidGroupCommand >> createNewGroupElement: aCollectionOfBlElement [ yourself. ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidGroupCommand >> getValueFor: aBlElement [ ^ self historyCommandArguments @@ -106,7 +106,7 @@ PyramidGroupCommand >> positionGroupElement: groupElement [ child constraints position - (currentLeft @ currentTop) ] ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidGroupCommand >> saveStatesOf: aCollection with: arguments [ ^ self @@ -116,7 +116,7 @@ PyramidGroupCommand >> saveStatesOf: aCollection with: arguments [ (self commandRestaurationArgumentsFor: aCollection and: arguments) ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidGroupCommand >> saveStatesWithCommandInverseOf: aCollection with: arguments [ ^ self @@ -126,7 +126,7 @@ PyramidGroupCommand >> saveStatesWithCommandInverseOf: aCollection with: argumen (self commandInverseArgumentsFor: aCollection and: arguments) ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidGroupCommand >> setValueFor: aCollectionToGroup with: aCollectionOfFirstLevelElements [ | groupInCorrectOrder parent groupElement removedElementFromFirstLevel | diff --git a/src/Pyramid-Bloc/PyramidLayoutBlocCommand.class.st b/src/Pyramid-Bloc/PyramidLayoutBlocCommand.class.st index 880f6ede..fd6180e7 100644 --- a/src/Pyramid-Bloc/PyramidLayoutBlocCommand.class.st +++ b/src/Pyramid-Bloc/PyramidLayoutBlocCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidLayoutBlocCommand >> getValueFor: anObject [ ^ anObject layout ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidLayoutBlocCommand >> setValueFor: anObject with: anArgument [ anObject layout: anArgument diff --git a/src/Pyramid-Bloc/PyramidLayoutChangeOrientationCommand.class.st b/src/Pyramid-Bloc/PyramidLayoutChangeOrientationCommand.class.st index 57cc5aab..26ec48bd 100644 --- a/src/Pyramid-Bloc/PyramidLayoutChangeOrientationCommand.class.st +++ b/src/Pyramid-Bloc/PyramidLayoutChangeOrientationCommand.class.st @@ -11,13 +11,13 @@ PyramidLayoutChangeOrientationCommand >> canBeUsedFor: anObject [ { BlFlowLayout . BlLinearLayout } includes: anObject layout class ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidLayoutChangeOrientationCommand >> getValueFor: anObject [ ^ anObject layout orientation ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidLayoutChangeOrientationCommand >> setValueFor: anObject with: anArgument [ anObject layout orientation: anArgument diff --git a/src/Pyramid-Bloc/PyramidMarginCommand.class.st b/src/Pyramid-Bloc/PyramidMarginCommand.class.st index 40950338..c773ea9a 100644 --- a/src/Pyramid-Bloc/PyramidMarginCommand.class.st +++ b/src/Pyramid-Bloc/PyramidMarginCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidMarginCommand >> getValueFor: aBlElement [ ^ aBlElement margin ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidMarginCommand >> setValueFor: aBlElement with: anArgument [ aBlElement margin: anArgument diff --git a/src/Pyramid-Bloc/PyramidMoveBackwardOrderCommand.class.st b/src/Pyramid-Bloc/PyramidMoveBackwardOrderCommand.class.st index 4fc68ba7..6003f24b 100644 --- a/src/Pyramid-Bloc/PyramidMoveBackwardOrderCommand.class.st +++ b/src/Pyramid-Bloc/PyramidMoveBackwardOrderCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidMoveBackwardOrderCommand >> commandInverse [ ^ PyramidMoveForwardOrderCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidMoveBackwardOrderCommand >> setValueFor: aBlElement with: anArgument [ | currentIndex | diff --git a/src/Pyramid-Bloc/PyramidMoveChildInParentCommand.class.st b/src/Pyramid-Bloc/PyramidMoveChildInParentCommand.class.st index 362a3ca1..df0b5e5a 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildInParentCommand.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildInParentCommand.class.st @@ -7,13 +7,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidMoveChildInParentCommand >> getValueFor: aBlElement [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #private } PyramidMoveChildInParentCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: anArguments [ | mementos | diff --git a/src/Pyramid-Bloc/PyramidMoveChildIndexDownCommand.class.st b/src/Pyramid-Bloc/PyramidMoveChildIndexDownCommand.class.st index be0b637d..5742b92f 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildIndexDownCommand.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildIndexDownCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidMoveChildIndexDownCommand >> commandInverse [ ^ PyramidMoveChildIndexUpCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidMoveChildIndexDownCommand >> setValueFor: aBlElementParent with: aBlElementToMove [ | childIndexToMove | diff --git a/src/Pyramid-Bloc/PyramidMoveChildIndexUpCommand.class.st b/src/Pyramid-Bloc/PyramidMoveChildIndexUpCommand.class.st index 4eabe2dc..bf5c13aa 100644 --- a/src/Pyramid-Bloc/PyramidMoveChildIndexUpCommand.class.st +++ b/src/Pyramid-Bloc/PyramidMoveChildIndexUpCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidMoveChildIndexUpCommand >> commandInverse [ ^ PyramidMoveChildIndexDownCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidMoveChildIndexUpCommand >> setValueFor: aBlElementParent with: aBlElementToMove [ | childIndexToMove | diff --git a/src/Pyramid-Bloc/PyramidMoveForwardOrderCommand.class.st b/src/Pyramid-Bloc/PyramidMoveForwardOrderCommand.class.st index 35008ed9..4eb2ec15 100644 --- a/src/Pyramid-Bloc/PyramidMoveForwardOrderCommand.class.st +++ b/src/Pyramid-Bloc/PyramidMoveForwardOrderCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidMoveForwardOrderCommand >> commandInverse [ ^ PyramidMoveBackwardOrderCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidMoveForwardOrderCommand >> setValueFor: aBlElement with: anArgument [ | currentIndex | diff --git a/src/Pyramid-Bloc/PyramidOnBackgroundOrderCommand.class.st b/src/Pyramid-Bloc/PyramidOnBackgroundOrderCommand.class.st index 257fd1b4..9a671789 100644 --- a/src/Pyramid-Bloc/PyramidOnBackgroundOrderCommand.class.st +++ b/src/Pyramid-Bloc/PyramidOnBackgroundOrderCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidOnBackgroundOrderCommand >> commandInverse [ ^ PyramidChangeOrderWithIndexCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidOnBackgroundOrderCommand >> setValueFor: aBlElement with: anArgument [ | currentIndex parent | diff --git a/src/Pyramid-Bloc/PyramidOnForegroundOrderCommand.class.st b/src/Pyramid-Bloc/PyramidOnForegroundOrderCommand.class.st index dda01bb0..41477cf2 100644 --- a/src/Pyramid-Bloc/PyramidOnForegroundOrderCommand.class.st +++ b/src/Pyramid-Bloc/PyramidOnForegroundOrderCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-order' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidOnForegroundOrderCommand >> commandInverse [ ^ PyramidChangeOrderWithIndexCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidOnForegroundOrderCommand >> setValueFor: aBlElement with: anArgument [ | currentIndex parent | diff --git a/src/Pyramid-Bloc/PyramidOpacityCommand.class.st b/src/Pyramid-Bloc/PyramidOpacityCommand.class.st index 31e02fdb..0b8b82d3 100644 --- a/src/Pyramid-Bloc/PyramidOpacityCommand.class.st +++ b/src/Pyramid-Bloc/PyramidOpacityCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidOpacityCommand >> getValueFor: aBlElement [ ^ aBlElement opacity ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidOpacityCommand >> setValueFor: aBlElement with: anArgument [ aBlElement opacity: anArgument diff --git a/src/Pyramid-Bloc/PyramidOutskirtsCommand.class.st b/src/Pyramid-Bloc/PyramidOutskirtsCommand.class.st index 07421899..288e90ed 100644 --- a/src/Pyramid-Bloc/PyramidOutskirtsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidOutskirtsCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-visuals' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidOutskirtsCommand >> getValueFor: aBlElement [ ^ aBlElement outskirts ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidOutskirtsCommand >> setValueFor: aBlElement with: anArgument [ aBlElement outskirts: anArgument diff --git a/src/Pyramid-Bloc/PyramidPaddingCommand.class.st b/src/Pyramid-Bloc/PyramidPaddingCommand.class.st index 50eb962e..8e5c4c09 100644 --- a/src/Pyramid-Bloc/PyramidPaddingCommand.class.st +++ b/src/Pyramid-Bloc/PyramidPaddingCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidPaddingCommand >> getValueFor: aBlElement [ ^ aBlElement padding ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidPaddingCommand >> setValueFor: aBlElement with: anArgument [ aBlElement padding: anArgument diff --git a/src/Pyramid-Bloc/PyramidPositionCommand.class.st b/src/Pyramid-Bloc/PyramidPositionCommand.class.st index 7f586f75..96f1ac9f 100644 --- a/src/Pyramid-Bloc/PyramidPositionCommand.class.st +++ b/src/Pyramid-Bloc/PyramidPositionCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidPositionCommand >> getValueFor: aBlElement [ ^ aBlElement constraints position ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidPositionCommand >> setValueFor: aBlElement with: anArgument [ anArgument isPoint ifFalse: [ ^ self ]. diff --git a/src/Pyramid-Bloc/PyramidPositionOffsetCommand.class.st b/src/Pyramid-Bloc/PyramidPositionOffsetCommand.class.st index 6abce729..9bef2315 100644 --- a/src/Pyramid-Bloc/PyramidPositionOffsetCommand.class.st +++ b/src/Pyramid-Bloc/PyramidPositionOffsetCommand.class.st @@ -4,25 +4,25 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidPositionOffsetCommand >> commandInverse [ ^ PyramidPositionCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidPositionOffsetCommand >> getValueFor: aBlElement [ ^ aBlElement constraints position ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidPositionOffsetCommand >> saveStatesOf: aCollection with: arguments [ ^ self saveStatesWithCommandInverseOf: aCollection with: arguments ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidPositionOffsetCommand >> setValueFor: aBlElement with: anArgument [ anArgument isPoint ifFalse: [ ^ self ]. diff --git a/src/Pyramid-Bloc/PyramidProportionalHorizontalConstraintsCommand.class.st b/src/Pyramid-Bloc/PyramidProportionalHorizontalConstraintsCommand.class.st index 61b5aafb..ebd5ca24 100644 --- a/src/Pyramid-Bloc/PyramidProportionalHorizontalConstraintsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidProportionalHorizontalConstraintsCommand.class.st @@ -4,14 +4,14 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidProportionalHorizontalConstraintsCommand >> getValueFor: anObject [ ^ anObject constraints proportional horizontal left @ anObject constraints proportional horizontal right ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidProportionalHorizontalConstraintsCommand >> setValueFor: anObject with: anArgument [ anObject constraintsDo: [ :c | diff --git a/src/Pyramid-Bloc/PyramidProportionalVerticalConstraintsCommand.class.st b/src/Pyramid-Bloc/PyramidProportionalVerticalConstraintsCommand.class.st index 466755dd..38324d5f 100644 --- a/src/Pyramid-Bloc/PyramidProportionalVerticalConstraintsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidProportionalVerticalConstraintsCommand.class.st @@ -4,14 +4,14 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-layout' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidProportionalVerticalConstraintsCommand >> getValueFor: anObject [ ^ anObject constraints proportional vertical top @ anObject constraints proportional vertical bottom ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidProportionalVerticalConstraintsCommand >> setValueFor: anObject with: anArgument [ anObject constraintsDo: [ :c | diff --git a/src/Pyramid-Bloc/PyramidRedoGroupCommand.class.st b/src/Pyramid-Bloc/PyramidRedoGroupCommand.class.st index 05c74d6e..a21047ff 100644 --- a/src/Pyramid-Bloc/PyramidRedoGroupCommand.class.st +++ b/src/Pyramid-Bloc/PyramidRedoGroupCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-group' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidRedoGroupCommand >> commandInverse [ ^ PyramidUndoGroupCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidRedoGroupCommand >> getValueFor: aBlElement [ ^ nil @@ -34,7 +34,7 @@ PyramidRedoGroupCommand >> positionGroupElement: groupElement [ child constraints position - (currentLeft @ currentTop) ] ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidRedoGroupCommand >> setValueFor: aCollectionToGroup with: aGroupModel [ | anyElementInFirstLevels | diff --git a/src/Pyramid-Bloc/PyramidRemoveChildCommand.class.st b/src/Pyramid-Bloc/PyramidRemoveChildCommand.class.st index 2288f8f1..dc97608a 100644 --- a/src/Pyramid-Bloc/PyramidRemoveChildCommand.class.st +++ b/src/Pyramid-Bloc/PyramidRemoveChildCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidRemoveChildCommand >> commandInverse [ ^ PyramidAddChildCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidRemoveChildCommand >> setValueFor: aBlElement with: aChildToRemove [ aBlElement removeChild: aChildToRemove diff --git a/src/Pyramid-Bloc/PyramidRemoveChildrenCommand.class.st b/src/Pyramid-Bloc/PyramidRemoveChildrenCommand.class.st index 6d09bbb6..70cdbc18 100644 --- a/src/Pyramid-Bloc/PyramidRemoveChildrenCommand.class.st +++ b/src/Pyramid-Bloc/PyramidRemoveChildrenCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidRemoveChildrenCommand >> commandInverse [ ^ PyramidAddChildrenCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidRemoveChildrenCommand >> setValueFor: aBlElement with: aChildrenToAdd [ aBlElement removeChildren: aChildrenToAdd diff --git a/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st b/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st index 9e281af1..a7545749 100644 --- a/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st @@ -7,7 +7,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidRemoveSelectedElementsCommand >> getValueFor: anElementOfSelection [ ^ nil @@ -15,23 +15,19 @@ PyramidRemoveSelectedElementsCommand >> getValueFor: anElementOfSelection [ { #category : #'as yet unclassified' } PyramidRemoveSelectedElementsCommand >> mementoFor: anElement withArguments: anArgument [ - | index | - "Save index before removing" - index := anElement parent - ifNotNil: [ :p | p children indexOf: anElement ] - ifNil: [ 0 ]. - anElement userData at: #removedAtIndex put: index. - (anArgument includes: anElement) ifTrue: [ - ^ PyramidCommandMemento new - command: PyramidRemoveFromCollectionCommand new commandInverse; - target: anArgument; - arguments: anElement; - yourself ]. - ^ PyramidCommandMemento new - command: PyramidRemoveChildCommand new commandInverse; - target: anElement parent; - arguments: anElement; - yourself + + self saveIndexOf: anElement. + (anArgument includes: anElement) ifTrue: [ + ^ PyramidCommandMemento new + command: PyramidRemoveFromCollectionCommand new commandInverse; + target: anArgument; + arguments: anElement; + yourself ]. + ^ PyramidCommandMemento new + command: PyramidRemoveChildCommand new commandInverse; + target: anElement parent; + arguments: anElement; + yourself ] { #category : #accessing } @@ -46,14 +42,24 @@ PyramidRemoveSelectedElementsCommand >> mementoInverse: anObject [ mementoInverse := anObject ] -{ #category : #'as yet unclassified' } +{ #category : #private } +PyramidRemoveSelectedElementsCommand >> saveIndexOf: anElement [ + + | index | + index := anElement parent + ifNotNil: [ :p | p children indexOf: anElement ] + ifNil: [ 0 ]. + anElement userData at: #removedAtIndex put: index +] + +{ #category : #history } PyramidRemoveSelectedElementsCommand >> saveStatesOf: aCollection with: aRoots [ "We ignore the state recovery for the redo, we will force the inverse of the undo state." ^ self mementoInverse accept: PyramidMementoInverser new. ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidRemoveSelectedElementsCommand >> saveStatesWithCommandInverseOf: aCollection with: aRoots [ | mementos finalMemento | @@ -69,7 +75,7 @@ PyramidRemoveSelectedElementsCommand >> saveStatesWithCommandInverseOf: aCollect ^ finalMemento ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidRemoveSelectedElementsCommand >> setValueFor: aBlElementToRemove with: aRoot [ "Remove the element from its parent" diff --git a/src/Pyramid-Bloc/PyramidRoundedRectangleCornerRadiiCommand.class.st b/src/Pyramid-Bloc/PyramidRoundedRectangleCornerRadiiCommand.class.st index f239660b..a035164b 100644 --- a/src/Pyramid-Bloc/PyramidRoundedRectangleCornerRadiiCommand.class.st +++ b/src/Pyramid-Bloc/PyramidRoundedRectangleCornerRadiiCommand.class.st @@ -11,13 +11,13 @@ PyramidRoundedRectangleCornerRadiiCommand >> canBeUsedFor: anObject [ anObject geometry class = BlRoundedRectangleGeometry ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidRoundedRectangleCornerRadiiCommand >> getValueFor: aBlElement [ ^ aBlElement geometry cornerRadii ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidRoundedRectangleCornerRadiiCommand >> setValueFor: aBlElement with: anArgument [ aBlElement geometry: (BlRoundedRectangleGeometry cornerRadii: anArgument) diff --git a/src/Pyramid-Bloc/PyramidTextForegroundCommand.class.st b/src/Pyramid-Bloc/PyramidTextForegroundCommand.class.st index ac96ad6e..e904f324 100644 --- a/src/Pyramid-Bloc/PyramidTextForegroundCommand.class.st +++ b/src/Pyramid-Bloc/PyramidTextForegroundCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-text' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidTextForegroundCommand >> getValueFor: aBlTextElement [ aBlTextElement text attributesFinder @@ -14,7 +14,7 @@ PyramidTextForegroundCommand >> getValueFor: aBlTextElement [ ^ Color black ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidTextForegroundCommand >> setValueFor: aBlTextElement with: aColor [ aBlTextElement text attribute: diff --git a/src/Pyramid-Bloc/PyramidUndoDynamicResizeBlocCommand.class.st b/src/Pyramid-Bloc/PyramidUndoDynamicResizeBlocCommand.class.st index 6cf5688b..127f7083 100644 --- a/src/Pyramid-Bloc/PyramidUndoDynamicResizeBlocCommand.class.st +++ b/src/Pyramid-Bloc/PyramidUndoDynamicResizeBlocCommand.class.st @@ -11,19 +11,19 @@ PyramidUndoDynamicResizeBlocCommand >> canBeUsedFor: anObject [ anObject size ] ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidUndoDynamicResizeBlocCommand >> commandInverse [ ^ PyramidDynamicResizeCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidUndoDynamicResizeBlocCommand >> getValueFor: anObject [ ^ anObject userData at: #pyramidPreviousDynamicResize ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidUndoDynamicResizeBlocCommand >> setValueFor: anObject with: anArgument [ ^ anObject constraintsDo: [ :c | diff --git a/src/Pyramid-Bloc/PyramidUndoGroupCommand.class.st b/src/Pyramid-Bloc/PyramidUndoGroupCommand.class.st index 8fb36fa9..c6cd082c 100644 --- a/src/Pyramid-Bloc/PyramidUndoGroupCommand.class.st +++ b/src/Pyramid-Bloc/PyramidUndoGroupCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc-group' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidUndoGroupCommand >> commandInverse [ ^ PyramidRedoGroupCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidUndoGroupCommand >> getValueFor: aBlElement [ ^ nil @@ -27,7 +27,7 @@ PyramidUndoGroupCommand >> positionChildrenOfGroupElement: groupElement [ child constraints position + (currentLeft @ currentTop) ] ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidUndoGroupCommand >> setValueFor: aCollectionToGroup with: aGroupModel [ "Remove children of group. Remove children of origin. diff --git a/src/Pyramid-Bloc/PyramidVisibilityCommand.class.st b/src/Pyramid-Bloc/PyramidVisibilityCommand.class.st index bb53e301..fd465919 100644 --- a/src/Pyramid-Bloc/PyramidVisibilityCommand.class.st +++ b/src/Pyramid-Bloc/PyramidVisibilityCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidVisibilityCommand >> getValueFor: aBlElement [ ^ aBlElement visibility ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidVisibilityCommand >> setValueFor: aBlElement with: anArgument [ aBlElement visibility: anArgument diff --git a/src/Pyramid-Bloc/PyramidWeightConstraintsCommand.class.st b/src/Pyramid-Bloc/PyramidWeightConstraintsCommand.class.st index 19f60089..2586c90d 100644 --- a/src/Pyramid-Bloc/PyramidWeightConstraintsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidWeightConstraintsCommand.class.st @@ -12,13 +12,13 @@ PyramidWeightConstraintsCommand >> canBeUsedFor: anObject [ { BlFlowLayout . BlLinearLayout } includes: anObject parent layout class ] ] ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidWeightConstraintsCommand >> getValueFor: anObject [ ^ anObject constraints linear weight ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidWeightConstraintsCommand >> setValueFor: anObject with: anArgument [ anObject constraints linear weight: anArgument. diff --git a/src/Pyramid-Bloc/PyramidZIndexCommand.class.st b/src/Pyramid-Bloc/PyramidZIndexCommand.class.st index 3e09f726..1ce22820 100644 --- a/src/Pyramid-Bloc/PyramidZIndexCommand.class.st +++ b/src/Pyramid-Bloc/PyramidZIndexCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Bloc-plugin-bloc' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidZIndexCommand >> getValueFor: aBlElement [ ^ aBlElement elevation elevation ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidZIndexCommand >> setValueFor: aBlElement with: anArgument [ aBlElement zIndex: anArgument diff --git a/src/Pyramid-Tests/PyramidDecreaseMockCommand.class.st b/src/Pyramid-Tests/PyramidDecreaseMockCommand.class.st index 6e1c22c6..6b72ba7d 100644 --- a/src/Pyramid-Tests/PyramidDecreaseMockCommand.class.st +++ b/src/Pyramid-Tests/PyramidDecreaseMockCommand.class.st @@ -4,19 +4,19 @@ Class { #category : #'Pyramid-Tests-cases-command' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidDecreaseMockCommand >> commandInverse [ ^ PyramidIncreaseMockCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidDecreaseMockCommand >> getValueFor: anObject [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidDecreaseMockCommand >> setValueFor: anObject with: anArgument [ anObject count: anObject count - 1 diff --git a/src/Pyramid-Tests/PyramidIncreaseMockCommand.class.st b/src/Pyramid-Tests/PyramidIncreaseMockCommand.class.st index cd869468..22b48fd0 100644 --- a/src/Pyramid-Tests/PyramidIncreaseMockCommand.class.st +++ b/src/Pyramid-Tests/PyramidIncreaseMockCommand.class.st @@ -4,19 +4,19 @@ Class { #category : #'Pyramid-Tests-cases-command' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidIncreaseMockCommand >> commandInverse [ ^ PyramidDecreaseMockCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidIncreaseMockCommand >> getValueFor: anObject [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidIncreaseMockCommand >> setValueFor: anObject with: anArgument [ anObject count: anObject count + 1 diff --git a/src/Pyramid-Tests/PyramidSimpleMockCommand.class.st b/src/Pyramid-Tests/PyramidSimpleMockCommand.class.st index abf1e620..3160782a 100644 --- a/src/Pyramid-Tests/PyramidSimpleMockCommand.class.st +++ b/src/Pyramid-Tests/PyramidSimpleMockCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Tests-cases-command' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidSimpleMockCommand >> getValueFor: anObject [ ^ anObject count. ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidSimpleMockCommand >> setValueFor: anObject with: anArgument [ anObject count: anArgument diff --git a/src/Pyramid-Tests/PyramidSimpleMockGroupedCommand.class.st b/src/Pyramid-Tests/PyramidSimpleMockGroupedCommand.class.st index 84fcebb0..2a34f662 100644 --- a/src/Pyramid-Tests/PyramidSimpleMockGroupedCommand.class.st +++ b/src/Pyramid-Tests/PyramidSimpleMockGroupedCommand.class.st @@ -4,7 +4,7 @@ Class { #category : #'Pyramid-Tests-cases-command' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidSimpleMockGroupedCommand >> getGroupedValueFor: anObject [ ^ #group diff --git a/src/Pyramid-Toplo/PyramidStampCommand.class.st b/src/Pyramid-Toplo/PyramidStampCommand.class.st index 2ec2f0c1..7bfb5753 100644 --- a/src/Pyramid-Toplo/PyramidStampCommand.class.st +++ b/src/Pyramid-Toplo/PyramidStampCommand.class.st @@ -7,13 +7,13 @@ Class { #category : #'Pyramid-Toplo-plugin-theme-management' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidStampCommand >> getValueFor: anObject [ ^ anObject hasStamp: self stamp ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidStampCommand >> setValueFor: anObject with: aBoolean [ aBoolean diff --git a/src/Pyramid-Toplo/PyramidThemeCommand.class.st b/src/Pyramid-Toplo/PyramidThemeCommand.class.st index 66c4f825..d26dcdc1 100644 --- a/src/Pyramid-Toplo/PyramidThemeCommand.class.st +++ b/src/Pyramid-Toplo/PyramidThemeCommand.class.st @@ -4,13 +4,13 @@ Class { #category : #'Pyramid-Toplo-plugin-theme-management' } -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidThemeCommand >> getValueFor: anObject [ ^ anObject localTheme ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidThemeCommand >> setValueFor: anObject with: nilOrToTheme [ anObject localTheme: nilOrToTheme diff --git a/src/Pyramid/PyramidAddAllToCollectionCommand.class.st b/src/Pyramid/PyramidAddAllToCollectionCommand.class.st index b4a0224b..5bc12e91 100644 --- a/src/Pyramid/PyramidAddAllToCollectionCommand.class.st +++ b/src/Pyramid/PyramidAddAllToCollectionCommand.class.st @@ -4,19 +4,19 @@ Class { #category : #'Pyramid-commands' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidAddAllToCollectionCommand >> commandInverse [ ^ PyramidRemoveAllFromCollectionCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidAddAllToCollectionCommand >> getValueFor: anObject [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidAddAllToCollectionCommand >> setValueFor: anObject with: anArgument [ anObject addAll: anArgument diff --git a/src/Pyramid/PyramidAddToCollectionCommand.class.st b/src/Pyramid/PyramidAddToCollectionCommand.class.st index c1eb5377..fdf034e8 100644 --- a/src/Pyramid/PyramidAddToCollectionCommand.class.st +++ b/src/Pyramid/PyramidAddToCollectionCommand.class.st @@ -4,19 +4,19 @@ Class { #category : #'Pyramid-commands' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidAddToCollectionCommand >> commandInverse [ ^ PyramidRemoveFromCollectionCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidAddToCollectionCommand >> getValueFor: anObject [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidAddToCollectionCommand >> setValueFor: anObject with: anArgument [ anObject add: anArgument diff --git a/src/Pyramid/PyramidCollectionCommand.class.st b/src/Pyramid/PyramidCollectionCommand.class.st index 3a225279..c5700017 100644 --- a/src/Pyramid/PyramidCollectionCommand.class.st +++ b/src/Pyramid/PyramidCollectionCommand.class.st @@ -16,7 +16,7 @@ PyramidCollectionCommand >> canBeUsedFor: anObject [ ^ anObject isCollection ] -{ #category : #'as yet unclassified' } +{ #category : #private } PyramidCollectionCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: anArguments [ | mementos | diff --git a/src/Pyramid/PyramidCommand.class.st b/src/Pyramid/PyramidCommand.class.st index 4bf754c6..46b6692e 100644 --- a/src/Pyramid/PyramidCommand.class.st +++ b/src/Pyramid/PyramidCommand.class.st @@ -27,7 +27,7 @@ PyramidCommand >> canBeUsedFor: anObject [ ^ self shouldBeImplemented ] -{ #category : #'as yet unclassified' } +{ #category : #actions } PyramidCommand >> clusterOf: aCollection [ | users cluster | @@ -40,25 +40,25 @@ PyramidCommand >> clusterOf: aCollection [ ^ cluster ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidCommand >> commandInverse [ ^ self ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidCommand >> getGroupedValueFor: anObject [ ^ self getValueFor: anObject ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidCommand >> getValueFor: anObject [ ^ self shouldBeImplemented ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidCommand >> saveStatesOf: aCollection with: arguments [ ^ self @@ -67,7 +67,7 @@ PyramidCommand >> saveStatesOf: aCollection with: arguments [ withArguments: arguments ] -{ #category : #'as yet unclassified' } +{ #category : #private } PyramidCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: anArguments [ | mementos | @@ -83,19 +83,19 @@ PyramidCommand >> saveStatesOf: aCollection withCommand: aCommand withArguments: yourself ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidCommand >> saveStatesWithCommandInverseOf: aCollection with: arguments [ ^ self saveStatesOf: aCollection withCommand: self commandInverse withArguments: arguments ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidCommand >> setValueFor: anObject with: anArgument [ self shouldBeImplemented ] -{ #category : #'as yet unclassified' } +{ #category : #actions } PyramidCommand >> useOn: aCollection with: anArgument [ aCollection do: [ :each | self setValueFor: each with: anArgument ] diff --git a/src/Pyramid/PyramidRemoveAllFromCollectionCommand.class.st b/src/Pyramid/PyramidRemoveAllFromCollectionCommand.class.st index e039ab4d..91c4cb82 100644 --- a/src/Pyramid/PyramidRemoveAllFromCollectionCommand.class.st +++ b/src/Pyramid/PyramidRemoveAllFromCollectionCommand.class.st @@ -4,19 +4,19 @@ Class { #category : #'Pyramid-commands' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidRemoveAllFromCollectionCommand >> commandInverse [ ^ PyramidAddAllToCollectionCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidRemoveAllFromCollectionCommand >> getValueFor: anObject [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidRemoveAllFromCollectionCommand >> setValueFor: anObject with: anArgument [ anObject removeAll: anArgument diff --git a/src/Pyramid/PyramidRemoveFromCollectionCommand.class.st b/src/Pyramid/PyramidRemoveFromCollectionCommand.class.st index cf9386a4..56c0aafe 100644 --- a/src/Pyramid/PyramidRemoveFromCollectionCommand.class.st +++ b/src/Pyramid/PyramidRemoveFromCollectionCommand.class.st @@ -4,19 +4,19 @@ Class { #category : #'Pyramid-commands' } -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidRemoveFromCollectionCommand >> commandInverse [ ^ PyramidAddToCollectionCommand new ] -{ #category : #'as yet unclassified' } +{ #category : #getter } PyramidRemoveFromCollectionCommand >> getValueFor: anObject [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #setter } PyramidRemoveFromCollectionCommand >> setValueFor: anObject with: anArgument [ anObject remove: anArgument From 40f8dc2cac0b6c40f12aaa416ae745f651d2c95f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 28 Apr 2026 14:52:33 +0200 Subject: [PATCH 15/16] =?UTF-8?q?update=20fix=20issue=20:=20Undo=20of=20re?= =?UTF-8?q?move=20element=20doesn=E2=80=99t=20put=20it=20back=20in=20the?= =?UTF-8?q?=20same=20position=20#187?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st b/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st index 34df84a2..d03a1e21 100644 --- a/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st +++ b/src/Pyramid-Bloc/PyramidAddChildrenCommand.class.st @@ -12,6 +12,6 @@ PyramidAddChildrenCommand >> commandInverse [ { #category : #setter } PyramidAddChildrenCommand >> setValueFor: aBlElement with: aChildrenToAdd [ - aChildrenToAdd do: [ :child | - aBlElement addChild: child ] + + aBlElement addChildren: aChildrenToAdd ] From 4134e5167d3701d48e1cb64cdb242c871a4b7e72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mathieu=20Magu=C3=A9r=C3=A8s?= Date: Tue, 28 Apr 2026 14:55:23 +0200 Subject: [PATCH 16/16] =?UTF-8?q?update=20fix=20issue=20:=20Undo=20of=20re?= =?UTF-8?q?move=20element=20doesn=E2=80=99t=20put=20it=20back=20in=20the?= =?UTF-8?q?=20same=20position=20#187?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st b/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st index a7545749..dee6455b 100644 --- a/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st +++ b/src/Pyramid-Bloc/PyramidRemoveSelectedElementsCommand.class.st @@ -13,7 +13,7 @@ PyramidRemoveSelectedElementsCommand >> getValueFor: anElementOfSelection [ ^ nil ] -{ #category : #'as yet unclassified' } +{ #category : #history } PyramidRemoveSelectedElementsCommand >> mementoFor: anElement withArguments: anArgument [ self saveIndexOf: anElement.