fix: restore suspended windows that macOS reports as occluded

Author: reycn

electron/main/windows/window-service-mode.mjs

@@ -28,7 +28,15 @@ export function createWindowServiceMode({
       })
     );
   };
-  const visible = (target) => target.isVisible() && !target.isMinimized();
+  // macOS isVisible() is also false while a window is occluded or on another
+  // Space, so a restored window may never look "visible" when its events fire.
+  // Any non-minimized window that is not an inactive tab (or hidden settings
+  // window) is on screen from the user's point of view and needs its renderer.
+  const visible = (target) => {
+    if (target.isMinimized()) return false;
+    if (target.isVisible()) return true;
+    return !registry.stateFor(target)?.settingsOwner && activeFor(target) === target;
+  };
   const restore = (target, state) => {
     if (state.serviceMode?.phase !== 'suspended') return;
     const saved = state.serviceMode;

tests/server/window-service-mode.test.mjs

@@ -232,6 +232,36 @@ test('suspends all windows and restores a visible window once with its snapshot'
   assert.equal(state.serviceMode, null);
 });
 
+test('restores an unminimized window even while macOS reports it occluded', async (t) => {
+  const active = fakeWindow({ minimized: true, visible: false });
+  const inactive = fakeWindow({ minimized: false, visible: false });
+  let suspended = 0;
+  const resumed = [];
+  const { service } = harness(
+    [
+      [active, {}],
+      [inactive, {}],
+    ],
+    {
+      activeFor: (target) => (target === inactive ? active : target),
+      suspend: () => suspended++,
+      resume: (window) => resumed.push(window),
+    },
+  );
+  t.after(() => service.stop());
+
+  service.update();
+  await waitFor(() => suspended === 2);
+
+  // Deminiaturized, but isVisible() is still false (occluded or another Space).
+  active.minimized = false;
+  service.update();
+  await waitFor(() => resumed.length === 1);
+  assert.deepEqual(resumed, [active]);
+  // The hidden inactive tab keeps its suspension until it is selected.
+  assert.equal(await observed(() => resumed.length > 1), false);
+});
+
 test('stopping during prepare cancels the pending suspension', async (t) => {
   const target = fakeWindow({ minimized: true, visible: false });
   const state = {};