Repository navigation
Commit 38ba11e
assignments_to_experiments: count conversion factors as uses, leave unconverted problems alone, pick an unused slope ID
- A parameter used as a model or species conversion factor counted as
unused, so a condition change of it was dropped when the parameter also
appeared in a converted assignment. Conversion factors now count as
references.
- A problem without time-dependent assignments was still changed: its
experiments' periods were re-sorted. It is now returned as it was, after
the lint.
- A ramp's slope parameter was only named so as not to clash with SBML IDs,
and clashed with, e.g., an observable parameter `<target>_slope`. It is now
named with `Problem.get_unused_id`.
`test_assignments_to_experiments_validate` relied on that slope clash to
fail the lint; it now uses an existing experiment `default_experiment`,
which the measurements without an experiment ID are assigned to as well.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>1 parent 4824cb5 commit 38ba11e
2 files changed
Lines changed: 98 additions & 31 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
820 | 820 | | |
821 | 821 | | |
822 | 822 | | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
823 | 826 | | |
824 | 827 | | |
825 | 828 | | |
826 | 829 | | |
827 | 830 | | |
828 | 831 | | |
829 | 832 | | |
830 | | - | |
| 833 | + | |
831 | 834 | | |
832 | 835 | | |
833 | 836 | | |
| |||
876 | 879 | | |
877 | 880 | | |
878 | 881 | | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
879 | 889 | | |
880 | 890 | | |
881 | 891 | | |
882 | 892 | | |
883 | 893 | | |
884 | 894 | | |
885 | 895 | | |
886 | | - | |
887 | | - | |
888 | 896 | | |
889 | 897 | | |
890 | 898 | | |
| |||
964 | 972 | | |
965 | 973 | | |
966 | 974 | | |
967 | | - | |
968 | | - | |
969 | | - | |
| 975 | + | |
| 976 | + | |
| 977 | + | |
970 | 978 | | |
971 | 979 | | |
972 | 980 | | |
| |||
1143 | 1151 | | |
1144 | 1152 | | |
1145 | 1153 | | |
1146 | | - | |
1147 | | - | |
| 1154 | + | |
| 1155 | + | |
| 1156 | + | |
1148 | 1157 | | |
1149 | | - | |
| 1158 | + | |
1150 | 1159 | | |
1151 | 1160 | | |
1152 | 1161 | | |
| |||
1155 | 1164 | | |
1156 | 1165 | | |
1157 | 1166 | | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
1158 | 1173 | | |
1159 | 1174 | | |
1160 | 1175 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1477 | 1477 | | |
1478 | 1478 | | |
1479 | 1479 | | |
1480 | | - | |
1481 | | - | |
1482 | | - | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
1483 | 1483 | | |
1484 | 1484 | | |
1485 | | - | |
1486 | | - | |
1487 | | - | |
1488 | | - | |
1489 | | - | |
1490 | | - | |
1491 | | - | |
1492 | | - | |
1493 | | - | |
1494 | | - | |
1495 | | - | |
1496 | | - | |
1497 | | - | |
1498 | | - | |
1499 | | - | |
1500 | | - | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
1501 | 1496 | | |
1502 | 1497 | | |
1503 | 1498 | | |
| |||
1661 | 1656 | | |
1662 | 1657 | | |
1663 | 1658 | | |
1664 | | - | |
| 1659 | + | |
| 1660 | + | |
1665 | 1661 | | |
1666 | 1662 | | |
1667 | 1663 | | |
| |||
1672 | 1668 | | |
1673 | 1669 | | |
1674 | 1670 | | |
| 1671 | + | |
1675 | 1672 | | |
| 1673 | + | |
| 1674 | + | |
| 1675 | + | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
1676 | 1708 | | |
1677 | 1709 | | |
1678 | 1710 | | |
1679 | 1711 | | |
1680 | 1712 | | |
1681 | 1713 | | |
1682 | 1714 | | |
1683 | | - | |
1684 | | - | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
0 commit comments