Refactor item lifecycle and trip APIs to enhance data handling and logging

- Removed 'retired' condition from VALID_CONDITIONS in item_lifecycle.py to streamline item status management.
- Added logging for condition changes and acquisition dates in the update function of item.py to improve tracking of item history.
- Updated trip creation and update logic to check user subscription status before modifying trip status, ensuring only subscribed users can create or update trips with locations.

Author: maplethorpej

app/api/item.py

@@ -1,4 +1,5 @@
 import csv
+import datetime
 import logging
 
 from fastapi import APIRouter, Depends, HTTPException, File, UploadFile
@@ -8,7 +9,7 @@
 from io import StringIO
 from sqlalchemy import or_, func
 
-from models.base import User, Item, ItemCategory, Category, Brand, Product, ProductVariant, CatalogProduct
+from models.base import User, Item, ItemLog, ItemCategory, Category, Brand, Product, ProductVariant, CatalogProduct
 from utils.auth import authenticate
 from utils.weight import standardize_weight_unit
 from utils.item_category import get_or_create_item_category
@@ -139,10 +140,33 @@ def update(payload: ItemUpdate, user: User = Depends(authenticate)):
     if not item:
         raise HTTPException(404, "Item not found.")
 
+    old_condition = item.condition
+    old_acquired_date = item.acquired_date
+
     for key, value in fields.items():
         setattr(item, key, value)
 
     try:
+        if payload.condition and payload.condition != old_condition:
+            log = ItemLog(
+                item_id=item.id,
+                user_id=user.id,
+                event_type="condition_change",
+                notes=f"Condition changed from {old_condition or 'unset'} to {payload.condition}",
+                logged_at=datetime.datetime.utcnow(),
+            )
+            db.session.add(log)
+
+        if payload.acquired_date and not old_acquired_date:
+            log = ItemLog(
+                item_id=item.id,
+                user_id=user.id,
+                event_type="acquired",
+                notes=f"Acquired on {payload.acquired_date}",
+                logged_at=datetime.datetime.utcnow(),
+            )
+            db.session.add(log)
+
         db.session.commit()
         db.session.refresh(item)
     except Exception:

app/api/item_lifecycle.py

@@ -14,7 +14,7 @@
 
 route = APIRouter(dependencies=[Depends(authenticate)])
 
-VALID_CONDITIONS = {"new", "good", "fair", "worn", "retired"}
+VALID_CONDITIONS = {"new", "good", "fair", "worn"}
 VALID_STATUSES = {"active", "wishlist", "retired", "sold", "lost"}
 VALID_ACQUISITION_TYPES = {"purchased", "gifted", "traded", "diy"}
 VALID_RETIRED_REASONS = {"worn_out", "upgraded", "lost", "sold", "gifted"}

app/api/trip.py

@@ -130,7 +130,7 @@ def create(payload: TripType, user: User = Depends(authenticate)):
     except Exception:
         raise HTTPException(400, "Unable to create trip.")
 
-    if payload.location and payload.location.strip():
+    if user.is_subscribed and payload.location and payload.location.strip():
         new_trip.enrich_status = "pending"
         db.session.commit()
         db.session.refresh(new_trip)
@@ -165,7 +165,7 @@ def update(payload: TripUpdate, user: User = Depends(authenticate)):
             (payload.start_date and payload.start_date != old_start_date) or
             (payload.end_date and payload.end_date != old_end_date)
         )
-        if trip.location and (location_changed or dates_changed):
+        if user.is_subscribed and trip.location and (location_changed or dates_changed):
             trip.enrich_status = "pending"
 
         db.session.commit()

app/utils/gear_lifecycle.py

@@ -29,7 +29,6 @@
     "good": 0.25,
     "fair": 0.5,
     "worn": 0.8,
-    "retired": 1.0,
 }