Skip to content

Commit 69bcf8f

Browse files
committed
fix(agentgateway): remove telemetry compat and revert test_lob noise
1 parent f9ca3d5 commit 69bcf8f

6 files changed

Lines changed: 6 additions & 39 deletions

File tree

src/sap_cloud_sdk/agentgateway/agw_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
)
3939
from sap_cloud_sdk.agentgateway._token_cache import _GatewayUrlCache, _TokenCache
4040
from sap_cloud_sdk.agentgateway.exceptions import AgentGatewaySDKError
41-
from sap_cloud_sdk.core._telemetry_compat import Module, Operation, record_metrics
41+
from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics
4242

4343
logger = logging.getLogger(__name__)
4444

src/sap_cloud_sdk/core/_telemetry_compat.py

Lines changed: 0 additions & 31 deletions
This file was deleted.

src/sap_cloud_sdk/destination/certificate_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from typing import List, Optional, TypeVar, Callable
66

7-
from sap_cloud_sdk.core._telemetry_compat import Module, Operation, record_metrics
7+
from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics
88
from sap_cloud_sdk.destination._http import DestinationHttp, API_V1
99
from sap_cloud_sdk.destination._models import (
1010
AccessStrategy,

src/sap_cloud_sdk/destination/client.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,7 @@
66
import warnings
77
from typing import Any, Dict, List, Optional, Callable, TypeVar
88

9-
# Conditional telemetry import - works even when telemetry packages are not installed
10-
from sap_cloud_sdk.core._telemetry_compat import Module, Operation, record_metrics
11-
9+
from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics
1210
from sap_cloud_sdk.core.secret_resolver import read_from_mount_and_fallback_to_env_var
1311
from sap_cloud_sdk.destination._http import DestinationHttp, API_V1, API_V2
1412
from sap_cloud_sdk.destination._models import (

src/sap_cloud_sdk/destination/fragment_client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
from typing import Callable, List, Optional, TypeVar
66

7-
from sap_cloud_sdk.core._telemetry_compat import Module, Operation, record_metrics
7+
from sap_cloud_sdk.core.telemetry import Module, Operation, record_metrics
88
from sap_cloud_sdk.destination._http import DestinationHttp, API_V1
99
from sap_cloud_sdk.destination._models import (
1010
AccessStrategy,

tests/agentgateway/unit/test_lob.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,9 @@
2828
from sap_cloud_sdk.agentgateway._models import Agent, AgentCard, MCPTool
2929
from sap_cloud_sdk.agentgateway._token_cache import _GatewayUrlCache, _TokenCache
3030
from sap_cloud_sdk.agentgateway.config import ClientConfig
31+
from sap_cloud_sdk.destination import ConsumptionOptions, ConsumptionLevel
3132
from sap_cloud_sdk.agentgateway.exceptions import AgentGatewaySDKError, MCPServerNotFoundError
32-
from sap_cloud_sdk.destination import ConsumptionLevel, ConsumptionOptions
33+
from sap_cloud_sdk.destination import ConsumptionLevel
3334

3435
# Aliases for use in existing test assertions
3536
_LABEL_KEY = LABEL_KEY
@@ -1065,4 +1066,3 @@ def test_raises_when_landscape_env_not_set(self):
10651066
with patch("sap_cloud_sdk.agentgateway._lob._ias_dest_name", side_effect=EnvironmentError("APPFND_CONHOS_LANDSCAPE not set")):
10661067
with pytest.raises(EnvironmentError, match="APPFND_CONHOS_LANDSCAPE"):
10671068
get_ias_client_id_lob()
1068-

0 commit comments

Comments
 (0)