refactor: use the shared case-insensitive BOOLEAN in network-route-addr validators

Drop NETWORK_ROUTE_ADDR_BOOLEAN_ANY_CASE now that BOOLEAN matches parse_boolean()'s
STRCASE_IN_SET. IPv6SendRA=/IPv6PrefixDelegation= use the explicit
PreferValidAlternativeCombinator(names, BOOLEAN) form, with case-sensitive names as
string_table_lookup_from_string uses streq. IPProtocol= keeps ignoreCase (gperf
--ignore-case plus an ascii_strlower retry) and moves to PreferValidAlternativeCombinator
so the lenient name regex cannot shadow a number on the classic engine.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Author: SJrX

src/main/kotlin/net/sjrx/intellij/plugins/systemdunitfiles/semanticdata/optionvalues/ai/ConfigParseRouterPrefixDelegationOptionValue.kt

@@ -3,10 +3,10 @@ package net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.ai
 import com.intellij.codeInspection.ProblemsHolder
 import net.sjrx.intellij.plugins.systemdunitfiles.psi.UnitFilePropertyType
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.SimpleGrammarOptionValues
-import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.AlternativeCombinator
-import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.NETWORK_ROUTE_ADDR_BOOLEAN_ANY_CASE
+import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.BOOLEAN
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.EOF
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.FlexibleLiteralChoiceTerminal
+import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.PreferValidAlternativeCombinator
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.SequenceCombinator
 
 /*
@@ -29,15 +29,18 @@ import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.gram
  * Both keys share one (parser, ltype) registration, so the registered grammar is the union — a boolean,
  * or `static` / `dhcpv6` — which is exact for `IPv6PrefixDelegation=`. For `IPv6SendRA=`
  * [generateProblemDescriptors] branches on the key, as the C does, and checks against a boolean-only
- * grammar, so `IPv6SendRA=static` is flagged. Booleans are matched case-insensitively, as
- * parse_boolean() does. The names come before the boolean so the classic matcher tries them first.
+ * grammar, so `IPv6SendRA=static` is flagged.
+ *
+ * string_table_lookup_from_string_with_boolean() runs parse_boolean() first (STRCASE_IN_SET, so `Yes`,
+ * `TRUE`, `oFf` are fine), then a case-sensitive streq() lookup, so `Static` is refused. The table's
+ * `no` / `yes` entries are left out of the names because [BOOLEAN] already covers them in any case.
  */
 class ConfigParseRouterPrefixDelegationOptionValue : SimpleGrammarOptionValues(
     "config_parse_router_prefix_delegation",
     SequenceCombinator(
-        AlternativeCombinator(
+        PreferValidAlternativeCombinator(
             FlexibleLiteralChoiceTerminal("static", "dhcpv6"),
-            NETWORK_ROUTE_ADDR_BOOLEAN_ANY_CASE,
+            BOOLEAN,
         ),
         EOF()
     )
@@ -55,7 +58,7 @@ class ConfigParseRouterPrefixDelegationOptionValue : SimpleGrammarOptionValues(
     // streq(lvalue, "IPv6SendRA") → parse_boolean() only.
     val SEND_RA_BOOLEAN_ONLY = SimpleGrammarOptionValues(
         "config_parse_router_prefix_delegation",
-        SequenceCombinator(NETWORK_ROUTE_ADDR_BOOLEAN_ANY_CASE, EOF())
+        SequenceCombinator(BOOLEAN, EOF())
     )
   }
 }

src/main/kotlin/net/sjrx/intellij/plugins/systemdunitfiles/semanticdata/optionvalues/ai/ConfigParseRoutingPolicyRuleIpProtocolOptionValue.kt

@@ -1,11 +1,11 @@
 package net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.ai
 
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.SimpleGrammarOptionValues
-import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.AlternativeCombinator
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.Checked
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.EOF
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.FlexibleLiteralChoiceTerminal
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.NetworkRouteAddrSafeAtouTerminal
+import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.PreferValidAlternativeCombinator
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.SequenceCombinator
 import net.sjrx.intellij.plugins.systemdunitfiles.semanticdata.optionvalues.grammar.safeAtouValue
 
@@ -56,7 +56,7 @@ private val IP_PROTOCOL_NUMBERS = setOf(
 class ConfigParseRoutingPolicyRuleIpProtocolOptionValue : SimpleGrammarOptionValues(
     "config_parse_routing_policy_rule",
     SequenceCombinator(
-        AlternativeCombinator(
+        PreferValidAlternativeCombinator(
             FlexibleLiteralChoiceTerminal(*IP_PROTOCOL_NAMES, ignoreCase = true),
             Checked(NetworkRouteAddrSafeAtouTerminal(0, 256)) { text -> safeAtouValue(text)?.toInt() in IP_PROTOCOL_NUMBERS },
         ),

src/main/kotlin/net/sjrx/intellij/plugins/systemdunitfiles/semanticdata/optionvalues/grammar/BatchNetworkRouteAddrCombinators.kt

@@ -429,12 +429,6 @@ fun ipIsMulticast(bytes: ByteArray): Boolean =
   if (bytes.size == 4) (bytes[0].toInt() and 0xF0) == 0xE0 else (bytes[0].toInt() and 0xFF) == 0xFF
 
 
-// ---------------------------------------------------------------------------------------------------
-// parse_boolean() (src/basic/parse-util.c) compares with STRCASE_IN_SET, so `Yes`, `TRUE` and `Off` are
-// all booleans. The shared [BOOLEAN] terminal is case-sensitive; this one is not.
-val NETWORK_ROUTE_ADDR_BOOLEAN_ANY_CASE = FlexibleLiteralChoiceTerminal(*BOOLEAN_SPELLINGS, ignoreCase = true)
-
-
 // ---------------------------------------------------------------------------------------------------
 // IPv6 prefixes — in_addr_prefix_from_string(…, AF_INET6, …) (src/basic/in-addr-util.c): an IPv6 literal
 // and an optional `/LEN`, where LEN goes through in_addr_parse_prefixlen → safe_atou8 (base 0) and must

src/test/kotlin/net/sjrx/intellij/plugins/systemdunitfiles/inspections/ai/ConfigParseRouterPrefixDelegationOptionValueTest.kt

@@ -16,9 +16,16 @@ class ConfigParseRouterPrefixDelegationOptionValueTest : AbstractUnitFileTest()
             IPv6SendRA=no
             IPv6SendRA=True
             IPv6SendRA=0
+            IPv6SendRA=Yes
+            IPv6SendRA=TRUE
+            IPv6SendRA=oFf
             IPv6PrefixDelegation=static
             IPv6PrefixDelegation=dhcpv6
             IPv6PrefixDelegation=yes
+            IPv6PrefixDelegation=Yes
+            IPv6PrefixDelegation=TRUE
+            IPv6PrefixDelegation=oFf
+            IPv6PrefixDelegation=No
         """.trimIndent()
 
     setupFileInEditor("file.network", file)
@@ -36,10 +43,13 @@ class ConfigParseRouterPrefixDelegationOptionValueTest : AbstractUnitFileTest()
             IPv6SendRA=both
             IPv6SendRA=static
             IPv6SendRA=dhcpv6
+            IPv6PrefixDelegation=Static
+            IPv6PrefixDelegation=DHCPv6
+            IPv6PrefixDelegation=maybe
         """.trimIndent()
 
     setupFileInEditor("file.network", file)
     enableInspection(InvalidValueInspection::class.java)
-    assertSize(4, myFixture.doHighlighting())
+    assertSize(7, myFixture.doHighlighting())
   }
 }

src/test/kotlin/net/sjrx/intellij/plugins/systemdunitfiles/inspections/ai/ConfigParseRoutingPolicyRuleIpProtocolOptionValueTest.kt

@@ -25,6 +25,9 @@ class ConfigParseRoutingPolicyRuleIpProtocolOptionValueTest : AbstractUnitFileTe
             IPProtocol=144
             IPProtocol=0
             IPProtocol=58
+            IPProtocol=TcP
+            IPProtocol=IcMpV6
+            IPProtocol=L2TP
         """.trimIndent()
 
     setupFileInEditor("file.network", file)
@@ -44,10 +47,12 @@ class ConfigParseRoutingPolicyRuleIpProtocolOptionValueTest : AbstractUnitFileTe
             IPProtocol=-6
             IPProtocol=3
             IPProtocol=200
+            IPProtocol=TcPx
+            IPProtocol=Yes
         """.trimIndent()
 
     setupFileInEditor("file.network", file)
     enableInspection(InvalidValueInspection::class.java)
-    assertSize(6, myFixture.doHighlighting())
+    assertSize(8, myFixture.doHighlighting())
   }
 }