test: close the preservation review gaps

The review of the pruned suites found contracts that the keepers restated
without proving. The iOS view test now undoes and redoes typed text with a
real history, and the read-only test types first so the dropped undo has
something to drop. The Android read-only test asserts that a vertical move
and copy still run, not only a horizontal move. The emoji undo vector checks
the restored text, the bad-query registry test counts the provider read so
the null cannot come from an unknown id, and the docs fixture lists its
captures out of order so the sort is exercised.

Author: SectionTN

android/src/test/java/me/sectiontn/codepad/syntax/LanguageRegistryTest.kt

@@ -28,12 +28,14 @@ class LanguageRegistryTest {
     assertNull(LanguageRegistry.resolve("no_such_language"))
     assertNull(LanguageRegistry.resolveInjection("c_sharp"))
     assertTrue(LanguageRegistry.resolveInjection("js") === LanguageRegistry.resolve("javascript"))
+    var reads = 0
     LanguageRegistry.register(object : LanguageProvider {
       override val id = "javascript_bad"
-      override val languagePointer = base.pointer
+      override val languagePointer: Long get() { reads++; return base.pointer }
       override val highlights = "(no_such_node) @x"
       override val injections = ""
     })
     assertNull("a highlights query naming a missing node fails the load", LanguageRegistry.resolve("javascript_bad"))
+    assertEquals("the provider was asked, so the null is the bad query and not an unknown id", 1, reads)
   }
 }

example/android/app/src/androidTest/java/codepad/example/HardwareKeysTest.kt

@@ -1,5 +1,6 @@
 package codepad.example
 
+import android.content.ClipboardManager
 import android.os.SystemClock
 import android.view.KeyEvent
 import android.view.View
@@ -77,17 +78,23 @@ class HardwareKeysTest {
     launch().use { s ->
       val editor = s.editor()
       onMain {
-        editor.setInitialText("ab")
+        editor.setInitialText("ab\ncd")
+        layout(editor)
         editor.setReadOnly(true)
         key(editor, KeyEvent.KEYCODE_DEL)
         key(editor, KeyEvent.KEYCODE_Q)
         key(editor, KeyEvent.KEYCODE_ENTER)
         key(editor, KeyEvent.KEYCODE_TAB)
-        assertEquals("ab", editor.core.document.text())
+        assertEquals("ab\ncd", editor.core.document.text())
         key(editor, KeyEvent.KEYCODE_DPAD_RIGHT)
         assertEquals(Selection(1, 1), editor.core.selection)
+        key(editor, KeyEvent.KEYCODE_DPAD_DOWN)
+        assertEquals("a vertical move still runs", Selection(4, 4), editor.core.selection)
         key(editor, KeyEvent.KEYCODE_A, ctrl)
-        assertEquals(Selection(0, 2), editor.core.selection)
+        assertEquals(Selection(0, 5), editor.core.selection)
+        key(editor, KeyEvent.KEYCODE_C, ctrl)
+        val clip = editor.context.getSystemService(ClipboardManager::class.java)?.primaryClip
+        assertEquals("copy still runs", "ab\ncd", clip?.getItemAt(0)?.text?.toString())
       }
     }
   }

example/ios/CodepadTests/ToolbarApiTests.swift

@@ -40,8 +40,11 @@ final class ToolbarApiTests: XCTestCase {
     XCTAssertEqual(editor.core.document.text(), "(){\n    \n}")
     editor.setText("", keepHistory: false)
     editor.typeText("ab")
-    editor.core.undo()
-    XCTAssertEqual(editor.core.document.text(), "", "two typed chars undo as one group")
+    editor.perform(.undo)
+    XCTAssertEqual(editor.core.document.text(), "", "two typed chars undo as one group through the view")
+    editor.perform(.redo)
+    XCTAssertEqual(editor.core.document.text(), "ab", "redo runs through the view")
+    editor.perform(.undo)
     editor.typeText("[")
     editor.perform(.backspace)
     XCTAssertEqual(editor.core.document.text(), "", "backspace removes the empty pair")
@@ -52,8 +55,11 @@ final class ToolbarApiTests: XCTestCase {
 
   func testReadOnlyIgnoresEditsAndStillMoves() {
     let editor = launch()
-    editor.setInitialText("ab")
+    editor.setInitialText("a")
     layout(editor)
+    editor.core.setSelection(anchor: 1, head: 1)
+    editor.typeText("b")
+    XCTAssertEqual(editor.core.document.text(), "ab")
     editor.setReadOnly(true)
     editor.typeText("x")
     editor.perform(.backspace)
@@ -62,7 +68,8 @@ final class ToolbarApiTests: XCTestCase {
     editor.perform(.newline)
     editor.perform(.tab)
     editor.perform(.undo)
-    XCTAssertEqual(editor.core.document.text(), "ab")
+    XCTAssertEqual(editor.core.document.text(), "ab", "read-only drops the edits and the undo of the typed b")
+    editor.core.setSelection(anchor: 0, head: 0)
     editor.perform(.move(unit: .char, forward: true, extend: true))
     XCTAssertEqual(editor.core.selection, Selection(anchor: 0, head: 1))
     editor.perform(.selectAll)

languages/generator/docs.test.ts

@@ -17,10 +17,10 @@ test('languagesPage lists every generated package with its grammar, scanner, inj
       codepad: { generated: true, grammar: 'org/tree-sitter-foo@abc' },
     }),
   );
-  // The capture list drops private captures, dedupes and sorts.
+  // The capture list drops private captures, dedupes and sorts, so the fixture lists them out of order.
   writeFileSync(
     path.join(pkg, 'queries/foo/highlights.scm'),
-    '(a) @keyword\n((b) @_hidden @string.special)\n(c) @keyword\n',
+    '(a) @string.special\n((b) @_hidden @keyword)\n(c) @string.special\n',
   );
   writeFileSync(
     path.join(pkg, 'queries/foo/injections.scm'),

tests/vectors/undo.json

@@ -75,7 +75,7 @@
     { "name": "backspace at the start is a no-op", "text": "ab", "ops": [{ "op": "backspace" }], "expect": { "revision": 0 } },
     { "name": "backspace removes a whole emoji", "text": "a\uD83D\uDE00", "ops": [
       { "op": "setSelection", "anchor": 3, "head": 3 }, { "op": "backspace", "expect": { "text": "a", "selection": { "anchor": 1, "head": 1 } } },
-      { "op": "undo", "expect": { "length": 3, "selection": { "anchor": 3, "head": 3 } } }
+      { "op": "undo", "expect": { "text": "a😀", "length": 3, "selection": { "anchor": 3, "head": 3 } } }
     ] },
     { "name": "backspace with a selection deletes it", "text": "abcd", "ops": [
       { "op": "setSelection", "anchor": 1, "head": 3 }, { "op": "backspace" }