From 88ce15f71dc0e266a6558a78eb968448973c234d Mon Sep 17 00:00:00 2001 From: onionviolet <142947238+onionviolet@users.noreply.github.com> Date: Sun, 6 Sep 2026 02:00:03 -0400 Subject: [PATCH 1/3] Fix fresh-clone dependency build --- Makefile | 34 ++++++++++++++++++++++------------ scripts/build.sh | 18 ------------------ 2 files changed, 22 insertions(+), 30 deletions(-) diff --git a/Makefile b/Makefile index fb5500b..13d9deb 100644 --- a/Makefile +++ b/Makefile @@ -12,7 +12,8 @@ LDFLAGS := -arch $(ARCH) -mmacosx-version-min=$(MIN_VER) \ FRAMEWORKS := -framework CoreFoundation -framework CFNetwork -DOBBY_DIR := build/vendor/dobby +DOBBY_REV := 5dfc8546954ce3b3198132ab13fddb89ee92cdd7 +DOBBY_DIR := build DOBBY_LIBS := $(DOBBY_DIR)/libdobby.a \ $(DOBBY_DIR)/builtin-plugin/SymbolResolver/libdobby_symbol_resolver.a \ $(DOBBY_DIR)/builtin-plugin/SymbolResolver/libmacho_ctx_kit.a \ @@ -65,9 +66,9 @@ DEPS := $(OBJS:.o=.d) all: $(TARGET) -$(ARM64_DYLIB): $(OBJS) +$(ARM64_DYLIB): $(OBJS) | dobby @mkdir -p $(dir $@) - $(CC) $(LDFLAGS) -o $@ $^ $(DOBBY_LIBS) $(FRAMEWORKS) -lc++ + $(CC) $(LDFLAGS) -o $@ $(OBJS) $(DOBBY_LIBS) $(FRAMEWORKS) -lc++ $(X86_STUB): src/stub_x86_64.c @mkdir -p $(dir $@) @@ -144,12 +145,21 @@ test: .PHONY: dobby dobby: - @echo "==> Building Dobby from source..." - @mkdir -p build - cd build && cmake ../vendor/dobby \ - -DCMAKE_OSX_ARCHITECTURES=arm64 \ - -DDOBBY_DEBUG=OFF \ - -DDOBBY_GENERATE_SHARED=OFF \ - -G "Unix Makefiles" - $(MAKE) -C build -j$(shell sysctl -n hw.ncpu) - @echo "==> Dobby rebuilt." + @if [ ! -d vendor/dobby/.git ]; then \ + echo "==> Cloning Dobby..."; \ + git clone https://github.com/jmpews/Dobby.git vendor/dobby; \ + fi + @if [ "$$(git -C vendor/dobby rev-parse HEAD)" != "$(DOBBY_REV)" ]; then \ + echo "==> Checking out pinned Dobby revision $(DOBBY_REV)..."; \ + git -C vendor/dobby fetch --depth=1 origin $(DOBBY_REV); \ + git -C vendor/dobby checkout --detach $(DOBBY_REV); \ + fi + @if [ ! -f "$(DOBBY_DIR)/libdobby.a" ]; then \ + echo "==> Building Dobby from source..."; \ + cmake -S vendor/dobby -B "$(DOBBY_DIR)" \ + -DCMAKE_OSX_ARCHITECTURES=arm64 \ + -DCMAKE_OSX_DEPLOYMENT_TARGET=$(MIN_VER) \ + -DDOBBY_DEBUG=OFF \ + -G "Unix Makefiles"; \ + $(MAKE) -C "$(DOBBY_DIR)" -j$$(sysctl -n hw.ncpu); \ + fi diff --git a/scripts/build.sh b/scripts/build.sh index 4127161..e67dfd0 100755 --- a/scripts/build.sh +++ b/scripts/build.sh @@ -5,24 +5,6 @@ SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" PROJECT_DIR="$(dirname "$SCRIPT_DIR")" cd "$PROJECT_DIR" -if [ ! -d "vendor/dobby" ]; then - echo "[build] Cloning Dobby..." - git clone --depth=1 https://github.com/jmpews/Dobby.git vendor/dobby -fi - -if [ ! -f "build/vendor/dobby/libdobby.a" ]; then - echo "[build] Building Dobby..." - mkdir -p build - cd build - cmake ../vendor/dobby \ - -DCMAKE_OSX_ARCHITECTURES=arm64 \ - -DDOBBY_DEBUG=OFF \ - -DDOBBY_GENERATE_SHARED=OFF \ - -G "Unix Makefiles" - make -j$(sysctl -n hw.ncpu) - cd "$PROJECT_DIR" -fi - make -j$(sysctl -n hw.ncpu) if [ -f out/macsteam.dylib ]; then From 6ae83a6cd5ab11616896e856149ad78b61608659 Mon Sep 17 00:00:00 2001 From: onionviolet <142947238+onionviolet@users.noreply.github.com> Date: Tue, 8 Sep 2026 00:23:06 -0400 Subject: [PATCH 2/3] Complete fresh-checkout config app build --- macsteam-app/Sources/MacsteamApp/DesignSystem.swift | 4 ---- macsteam-app/Tests/MacsteamAppTests/.gitkeep | 1 + 2 files changed, 1 insertion(+), 4 deletions(-) create mode 100644 macsteam-app/Tests/MacsteamAppTests/.gitkeep diff --git a/macsteam-app/Sources/MacsteamApp/DesignSystem.swift b/macsteam-app/Sources/MacsteamApp/DesignSystem.swift index f085a2d..3d73717 100644 --- a/macsteam-app/Sources/MacsteamApp/DesignSystem.swift +++ b/macsteam-app/Sources/MacsteamApp/DesignSystem.swift @@ -151,10 +151,6 @@ final class SettingsCard: NSView { applyCardSurfaceColors() } - @available(macOS 27, *) - override var cornerConfiguration: NSViewCornerConfiguration? { - .uniformCorners(radius: .containerConcentric(Metrics.cornerRadius)) - } } @MainActor diff --git a/macsteam-app/Tests/MacsteamAppTests/.gitkeep b/macsteam-app/Tests/MacsteamAppTests/.gitkeep new file mode 100644 index 0000000..8b13789 --- /dev/null +++ b/macsteam-app/Tests/MacsteamAppTests/.gitkeep @@ -0,0 +1 @@ + From f6300aff5d84a6def74a3346a9991607aea81692 Mon Sep 17 00:00:00 2001 From: onionviolet <142947238+onionviolet@users.noreply.github.com> Date: Tue, 8 Sep 2026 00:37:01 -0400 Subject: [PATCH 3/3] Rebuild pinned dependencies and skip absent tests --- Makefile | 10 +++++-- macsteam-app/Package.swift | 30 ++++++++++++-------- macsteam-app/Tests/MacsteamAppTests/.gitkeep | 1 - 3 files changed, 26 insertions(+), 15 deletions(-) delete mode 100644 macsteam-app/Tests/MacsteamAppTests/.gitkeep diff --git a/Makefile b/Makefile index 13d9deb..2a37278 100644 --- a/Makefile +++ b/Makefile @@ -14,6 +14,7 @@ FRAMEWORKS := -framework CoreFoundation -framework CFNetwork DOBBY_REV := 5dfc8546954ce3b3198132ab13fddb89ee92cdd7 DOBBY_DIR := build +DOBBY_STAMP := $(DOBBY_DIR)/.dobby-revision DOBBY_LIBS := $(DOBBY_DIR)/libdobby.a \ $(DOBBY_DIR)/builtin-plugin/SymbolResolver/libdobby_symbol_resolver.a \ $(DOBBY_DIR)/builtin-plugin/SymbolResolver/libmacho_ctx_kit.a \ @@ -66,7 +67,7 @@ DEPS := $(OBJS:.o=.d) all: $(TARGET) -$(ARM64_DYLIB): $(OBJS) | dobby +$(ARM64_DYLIB): $(OBJS) $(DOBBY_STAMP) @mkdir -p $(dir $@) $(CC) $(LDFLAGS) -o $@ $(OBJS) $(DOBBY_LIBS) $(FRAMEWORKS) -lc++ @@ -144,6 +145,9 @@ test: -include $(DEPS) .PHONY: dobby +$(DOBBY_STAMP): dobby + @test -f "$@" + dobby: @if [ ! -d vendor/dobby/.git ]; then \ echo "==> Cloning Dobby..."; \ @@ -154,7 +158,8 @@ dobby: git -C vendor/dobby fetch --depth=1 origin $(DOBBY_REV); \ git -C vendor/dobby checkout --detach $(DOBBY_REV); \ fi - @if [ ! -f "$(DOBBY_DIR)/libdobby.a" ]; then \ + @if [ ! -f "$(DOBBY_DIR)/libdobby.a" ] || \ + [ "$$(cat "$(DOBBY_STAMP)" 2>/dev/null)" != "$(DOBBY_REV)" ]; then \ echo "==> Building Dobby from source..."; \ cmake -S vendor/dobby -B "$(DOBBY_DIR)" \ -DCMAKE_OSX_ARCHITECTURES=arm64 \ @@ -162,4 +167,5 @@ dobby: -DDOBBY_DEBUG=OFF \ -G "Unix Makefiles"; \ $(MAKE) -C "$(DOBBY_DIR)" -j$$(sysctl -n hw.ncpu); \ + echo "$(DOBBY_REV)" > "$(DOBBY_STAMP)"; \ fi diff --git a/macsteam-app/Package.swift b/macsteam-app/Package.swift index f8f3eb2..e99a75e 100644 --- a/macsteam-app/Package.swift +++ b/macsteam-app/Package.swift @@ -1,6 +1,23 @@ // swift-tools-version: 6.0 +import Foundation import PackageDescription +var targets: [Target] = [ + .executableTarget( + name: "MacsteamApp", + dependencies: ["Sparkle"], + path: "Sources/MacsteamApp" + ) +] + +if FileManager.default.fileExists(atPath: "Tests/MacsteamAppTests") { + targets.append(.testTarget( + name: "MacsteamAppTests", + dependencies: ["MacsteamApp"], + path: "Tests/MacsteamAppTests" + )) +} + let package = Package( name: "MacsteamApp", platforms: [ @@ -9,16 +26,5 @@ let package = Package( dependencies: [ .package(url: "https://github.com/sparkle-project/Sparkle", from: "2.9.6"), ], - targets: [ - .executableTarget( - name: "MacsteamApp", - dependencies: ["Sparkle"], - path: "Sources/MacsteamApp" - ), - .testTarget( - name: "MacsteamAppTests", - dependencies: ["MacsteamApp"], - path: "Tests/MacsteamAppTests" - ) - ] + targets: targets ) diff --git a/macsteam-app/Tests/MacsteamAppTests/.gitkeep b/macsteam-app/Tests/MacsteamAppTests/.gitkeep deleted file mode 100644 index 8b13789..0000000 --- a/macsteam-app/Tests/MacsteamAppTests/.gitkeep +++ /dev/null @@ -1 +0,0 @@ -