Skip to content

ComicVine: book-level metadata not applied for dash-delimited comic filenames #293

Description

@firestaerter3

Problem

When using the ComicVine provider on comics with European-style filenames (Series - NUMBER - Title, e.g. Suske En Wiske - 195 - De Hippe Heksen), individual book titles, covers, and descriptions are not updated in Komga after identification. The PATCH body contains only numberSort (43 bytes).

Root cause

getBookMetadata() — which calls /api/issue/{id}/ — is fully implemented and working. The issue is upstream: BookNameParser.getBookNumber() cannot parse the - NUMBER - pattern, so associateBookMetadata() returns null for every book. With no match, getBookMetadata() is never called.

The existing regexes only handle:

  • Numbers at the end of a string (Batman 123)
  • Issue N / Volume N prefixes

They do not handle - NUMBER - (number flanked by dashes with spaces), which is standard for many European comics.

Evidence

With DEBUG logging, associateBookMetadata() logs parsed number=null for every book in the series. Fixing the parser immediately results in 175/175 books matched and PATCH bodies of ~260 bytes including title, summary, authors, and cover.

Fix

Add a last-priority fallback regex to bookNumberRegexes. See PR #294.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions