|
1 | 1 | ### Refactor routine |
2 | | -_Last updated 2026-10-29T17:15Z · main @ c07af61_ |
| 2 | +_Last updated 2026-10-29T19:40Z · main @ c07af61_ |
3 | 3 |
|
4 | 4 | #### In flight |
5 | 5 | | PR | Kind | Scope | State | |
6 | 6 | |---|---|---|---| |
7 | | -| [#1842](https://github.com/SocketDev/socket-patch/pull/1842) | sweep | `cli/src/args.rs` (+ the Deno guard moved into `lib.rs`) | ready; CI and Bugbot pending | |
| 7 | +| [#1842](https://github.com/SocketDev/socket-patch/pull/1842) | sweep | `cli/src/args.rs` (+ the Deno guard moved into `lib.rs`) | ready | |
| 8 | +| [#1849](https://github.com/SocketDev/socket-patch/pull/1849) | structural | A01 [#1832](https://github.com/SocketDev/socket-patch/issues/1832): `utils/cargo_build_cache.rs` | ready; CI and Bugbot pending | |
8 | 9 |
|
9 | 10 | #### Merged |
10 | 11 | _None._ |
11 | 12 |
|
12 | 13 | #### Queue |
13 | 14 | Structural candidates, scored `3·B + 2·U + 2·D + 2·C − risk`: |
14 | | -1. A01 [#1832](https://github.com/SocketDev/socket-patch/issues/1832), cargo config chain read twice (bug): B1 D1 C1, risk L. **7** |
15 | | -2. A02 [#1833](https://github.com/SocketDev/socket-patch/issues/1833), three segment glob matchers (bug): B1 D1 C1, risk L. **7** |
16 | | -3. T01, `get <uuid>` re-implements `download_and_apply_patches_into`: D2.2 C2, risk M. **~6.4** (blocked while #1698 touches `get.rs` / `agent_download.rs`) |
17 | | -4. A03 [#1834](https://github.com/SocketDev/socket-patch/issues/1834), GOMODCACHE rule twice: D1 C1, risk L. **4** |
18 | | -5. T03 [#1837](https://github.com/SocketDev/socket-patch/issues/1837), hand-written env var lists: D1 C1, risk L. **4** |
| 15 | +1. A02 [#1833](https://github.com/SocketDev/socket-patch/issues/1833), three segment glob matchers (bug): B1 D1 C1, risk L. **7** (blocked while #1829 touches `workspace_globs.rs` / `npm_crawler.rs`) |
| 16 | +2. T01 [#1835](https://github.com/SocketDev/socket-patch/issues/1835), `get <uuid>` re-implements `download_and_apply_patches_into`: D2.2 C2, risk M. **~6.4** (blocked while #1698 touches `get.rs` / `agent_download.rs`) |
| 17 | +3. A03 [#1834](https://github.com/SocketDev/socket-patch/issues/1834), GOMODCACHE rule twice: D1 C1, risk L. **4** |
| 18 | +4. T03 [#1837](https://github.com/SocketDev/socket-patch/issues/1837), hand-written env var lists: D1 C1, risk L. **4** |
| 19 | +5. A05 [#1844](https://github.com/SocketDev/socket-patch/issues/1844), `lock_fragments` pairing loops ×3: D1 C1, risk M. **~2** |
19 | 20 |
|
20 | | -The next run is structural (the previous run was a sweep). Next sweep files, in order: `commands/bun_preflight.rs`, `commands/composer_hints.rs`, `commands/context.rs`, `commands/fetch_stage.rs`. Skip `agent_download.rs`, `apply.rs` and `get.rs` while #1698 is open. |
| 21 | +The next run is a sweep (this run was structural). Next sweep files, in order: `commands/bun_preflight.rs`, `commands/composer_hints.rs`, `commands/context.rs`, `commands/fetch_stage.rs`. Skip `agent_download.rs`, `apply.rs` and `get.rs` while #1698 is open. |
21 | 22 |
|
22 | 23 | #### Notes |
23 | 24 | - The PRs of the first thread (`arch-refactor/<issue>-*`) are listed in `review/2026-10-v1/register/90-refactor.md`. |
24 | 25 | - The `args.rs` note "drop api_client_overrides empty filter" was wrong: core `build_proxy_fallback_client` uses `overrides.proxy_url` unfiltered, so the CLI filter is load-bearing. Check every "redundant filter" note against all consumers of the value. |
25 | 26 | - Field doc comments on clap structs are `--help` output. Trimming them changes output bytes, so sweeps leave them alone. |
| 27 | +- `--cwd` defaults to `.`, and `Path::new(".").ancestors()` stops at `.`. Any core walk up from the cwd must absolutize it first (`cargo_crawler::resolve_for` and `nuget_config` do; `cargo_build_cache` didn't until #1849). A test that spells the cwd as a relative path *with* components can't catch this: chdir under `#[serial]` and pass `"."`. |
| 28 | +- `vendor/cargo_config.rs` (~L165-L190) keeps a third, async copy of the `.cargo/config` pick, with canonical dedup. It agrees on precedence; fold it into `config_layer_paths` when that file is swept. |
0 commit comments