Merge branch 'main' into fix-dns-capability-check-15487683922587520007

Author: Tcode-Motion

.github/workflows/docs.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up Python
-        uses: actions/setup-python@v4
+        uses: actions/setup-python@v7
         with:
           python-version: '3.10'
 

.github/workflows/graphify.yml

@@ -20,7 +20,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v7
         with:
           python-version: ${{ matrix.python-version }}
           cache: 'pip'

.github/workflows/pypi-publish.yml

@@ -16,7 +16,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Set up Python
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v7
         with:
           python-version: "3.12"
 
@@ -64,7 +64,7 @@ jobs:
       - uses: actions/checkout@v4
 
       - name: Set up Python ${{ matrix.python-version }}
-        uses: actions/setup-python@v5
+        uses: actions/setup-python@v7
         with:
           python-version: ${{ matrix.python-version }}
 

.jules/bolt.md

@@ -8,3 +8,6 @@
 ## 2024-05-18 - Removed redundant clone of VM stack during trace logs
 **Learning:** In `runtime/vm/src/executor.rs`, the debugging instruction trace `self.debugger.trace_instruction` was cloning the entire VM stack using `&self.stack.get_dump()` for every single instruction executed. This caused significant `O(N)` overhead inside the main fetch-decode-execute loop just to format debug output. A new `data_slice()` method was added to `ValueStack` to provide zero-copy slice access (`&[RuntimeValue]`) instead, completely eliminating the allocation overhead.
 **Action:** Always scrutinize deep clones in logging, tracing, or hot path loops. Use slice references (`&[T]`) instead of `Vec::clone` when the caller only needs read-only access to a collection.
+## 2024-06-25 - Suboptimal Line Search in LSP
+**Learning:** Using `chars().nth()` with a byte offset (such as one returned by `.find()`) inside a loop over a string creates an O(N) penalty and may result in an incorrect character lookup if multi-byte unicode characters are present.
+**Action:** Use string slicing with the byte index to create a subset string slice, and call `.chars().next_back()` or `.chars().next()` on it for an O(1) and UTF-8 safe boundary lookup.

cli/src/commands/migrate.rs

@@ -263,7 +263,9 @@ fn replace_call(source: &str, prefix: &str, keyword: &str) -> String {
                 remaining = &remaining[pos + full.len()..];
                 if let Some(close) = remaining.find(')') {
                     let args = &remaining[..close];
-                    result.push_str(&format!("{keyword} {args}"));
+                    result.push_str(keyword);
+                    result.push(' ');
+                    result.push_str(args);
                     remaining = &remaining[close + 1..];
                 } else {
                     result.push_str(remaining);

cli/src/watch.rs

@@ -71,29 +71,7 @@ impl FileWatcher {
     fn scan_files(&self, states: &mut HashMap<PathBuf, SystemTime>) -> anyhow::Result<()> {
         let mut dirs = vec![self.root.clone()];
         while let Some(dir) = dirs.pop() {
-            if dir.is_dir() {
-                if let Ok(entries) = std::fs::read_dir(dir) {
-                    for entry in entries.flatten() {
-                        let path = entry.path();
-                        if path.is_dir() {
-                            // Don't watch build or cache directories to prevent infinite loops
-                            let name = path.file_name().unwrap_or_default().to_string_lossy();
-                            if name != "build" && name != ".git" && name != "target" {
-                                dirs.push(path);
-                            }
-                        } else {
-                            let ext = path.extension().unwrap_or_default().to_string_lossy();
-                            if ext == "txs" || ext == "ts" {
-                                if let Ok(metadata) = entry.metadata() {
-                                    if let Ok(modified) = metadata.modified() {
-                                        states.insert(path, modified);
-                                    }
-                                }
-                            }
-                        }
-                    }
-                }
-            } else {
+            if !dir.is_dir() {
                 // Root is a single file
                 let ext = self.root.extension().unwrap_or_default().to_string_lossy();
                 if ext == "txs" || ext == "ts" {
@@ -103,6 +81,32 @@ impl FileWatcher {
                         }
                     }
                 }
+                continue;
+            }
+
+            if let Ok(entries) = std::fs::read_dir(dir) {
+                for entry in entries.flatten() {
+                    let path = entry.path();
+                    if path.is_dir() {
+                        // Don't watch build or cache directories to prevent infinite loops
+                        let name = path.file_name().unwrap_or_default().to_string_lossy();
+                        if name != "build" && name != ".git" && name != "target" {
+                            dirs.push(path);
+                        }
+                        continue;
+                    }
+
+                    let ext = path.extension().unwrap_or_default().to_string_lossy();
+                    if ext != "txs" && ext != "ts" {
+                        continue;
+                    }
+
+                    if let Ok(metadata) = entry.metadata() {
+                        if let Ok(modified) = metadata.modified() {
+                            states.insert(path, modified);
+                        }
+                    }
+                }
             }
         }
         Ok(())

compiler/lexer/src/lib.rs

@@ -12,7 +12,6 @@ use techscript_syntax::{lookup_keyword, Token, TokenKind};
 /// Private token enumeration used internally by Logos for scanning.
 #[derive(Logos, Debug, Clone, Copy, PartialEq, Eq)]
 #[logos(skip r"[ \t\r]+")] // Skip spaces, tabs, and carriage returns
-#[allow(dead_code)]
 enum LogosToken {
     #[token("\n")]
     #[token("\r\n")]

compiler/parser/src/parser.rs

@@ -1,5 +1,5 @@
 use std::collections::HashSet;
-use techscript_common::{NodeIdGenerator, Span};
+use techscript_common::NodeIdGenerator;
 use techscript_errors::{Diagnostic, DiagnosticLevel, DiagnosticReporter, ErrorCode};
 use techscript_syntax::{Token, TokenKind};
 
@@ -18,7 +18,6 @@ pub struct Parser<'a> {
     pub(crate) dsl_sub_blocks: HashSet<String>,
 }
 
-#[allow(dead_code)]
 impl<'a> Parser<'a> {
     /// Create a new Parser instance with DSL keyword registry initialized.
     pub fn new(tokens: &'a [Token]) -> Self {
@@ -212,16 +211,6 @@ impl<'a> Parser<'a> {
         self.node_id_gen.next()
     }
 
-    /// Returns the span of the current token.
-    pub(crate) fn current_span(&self) -> Span {
-        self.peek().span
-    }
-
-    /// Returns the span of the previous token.
-    pub(crate) fn prev_span(&self) -> Span {
-        self.previous().span
-    }
-
     /// Synchronizes the parser boundary to recover from syntax errors.
     pub(crate) fn synchronize(&mut self) {
         self.advance();