Skip to content

Problem with forge auto-remappings #60

Description

@kyriediculous

When installing this repository as a git submodule using foundry, there are issues with both open-zeppelin modules used in this repository.

when running forge remappings in the target repository where this is installed, the open-zeppelin dependencies remappings are missing the /contracts suffix

this repo

openzeppelin-contracts-upgradeable/=lib/openzeppelin-contracts-upgradeable/contracts/
openzeppelin-contracts/=lib/openzeppelin-contracts/contracts/

target repo

      openzeppelin-contracts-upgradeable/=/Users/nico/tenderize/tenderswap/lib/staking/lib/openzeppelin-contracts-upgradeable/contracts/
      openzeppelin-contracts/=/Users/nico/tenderize/tenderswap/lib/staking/lib/openzeppelin-contracts/
      ```

The current fix is to manually overwrite the incorrect automatic remappings in the target repo. 

openzeppelin-contracts-upgradeable/=lib/staking/lib/openzeppelin-contracts-upgradeable/contracts/
openzeppelin-contracts/=lib/staking/lib/openzeppelin-contracts/contracts/

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions