Skip to content

Commit 8a81abf

Browse files
Apply batched suggestions from code review
Co-authored-by: priya-sundaram-dev <oc-409d01@agentmail.to>
1 parent 9a0927a commit 8a81abf

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

‎financial/fractional_differentiation.py‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,19 +77,28 @@ def fracdiff_fixedwindow(
7777
The price series to calculate the fractional differentiation.
7878
degree : float
7979
The degree of differentiation.
80+
window_size : int
81+
The number of past observations used to compute each value.
8082
8183
Returns
8284
-------
8385
list[float]
8486
The fractional differentiated series.
8587
88+
Raises
89+
------
90+
ValueError
91+
If ``window_size`` is greater than the length of ``price_series``.
92+
8693
Examples
8794
--------
8895
>>> price_series = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
8996
>>> fracdiff_fixedwindow(price_series, 0.5, 3)
9097
[nan, nan, nan, 2.25, 2.625, 3.0, 3.375, 3.75, 4.125, 4.5]
9198
"""
92-
weights = calculate_weights(degree=degree, length=len(price_series))
99+
if window_size > len(price_series):
100+
raise ValueError("window_size cannot exceed the length of price_series")
101+
weights = calculate_weights(degree=degree, length=window_size)
93102
frac_diff_series = [nan] * window_size
94103
for i in range(window_size, len(price_series)):
95104
frac_diff_series.append(

0 commit comments

Comments
 (0)