Skip to content

Commit 76d4c47

Browse files
cubehouseclaude
andauthored
chore(deps-dev): eslint 10 and vitest 4, holding typescript at 5 (#35)
* chore(deps-dev): eslint 10 and vitest 4, holding typescript at 5 Splits the dev-dependencies group bump. Two of its three majors land here; the third cannot land at all yet. eslint 9 -> 10 and vitest 1 -> 4 are clean: no config or source change, and the emitted dist/index.d.ts is byte-identical to main, so nothing about the published type surface moves. typescript 5 -> 6 is held back. openapi-typescript 7.13.0, the newest release, still declares `peer typescript@"^5.x"`, so a clean `npm ci` with TypeScript 6 fails to resolve. That is what makes the grouped bump red, and no amount of retrying the group will fix it. Worth recording for whenever that peer range widens: TypeScript 6 also breaks `tsup --dts`. tsup 8.5.1 hardcodes `baseUrl: compilerOptions.baseUrl || "."` when it builds declarations, and TS 6 errors on `baseUrl` as deprecated (TS5101). Adding `"ignoreDeprecations": "6.0"` to tsconfig.json clears it, but only until TypeScript 7 removes the option outright, so the durable answer is a tsup that stops injecting it, or moving declaration emit to tsc. Verified from a clean `npm ci`: typecheck, lint, unit tests (64), build and live smoke tests all pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * chore: drop Node 18, moving the tested floor to 20 eslint 10 and vitest 4 both require Node 20 or newer, so the Node 18 lane fails on `npm ci` while 20 and 22 pass. Node 18 reached end of life on 2025-04-30. The constraint is entirely in the dev toolchain — nothing in the shipped bundle needs Node 20. The choice was between quietly dropping the lane while still advertising `engines: >=18`, and withdrawing a support claim nothing verifies. This does the second: matrix moves to 20/22/24, `engines` to `>=20`, README and CHANGELOG updated to match. Consumers still on Node 18 should stay on 7.1.x. Note for whoever merges: branch protection still requires `Test (Node 18)`, which no longer exists. The required contexts need updating to `Test (Node 20)`, `Test (Node 22)`, `Test (Node 24)` or this cannot merge. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
1 parent b3811b9 commit 76d4c47

5 files changed

Lines changed: 1154 additions & 1441 deletions

File tree

‎.github/workflows/ci.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
strategy:
1414
fail-fast: false
1515
matrix:
16-
node: [18, 20, 22]
16+
node: [20, 22, 24]
1717
steps:
1818
- uses: actions/checkout@v4
1919
- uses: actions/setup-node@v4

‎CHANGELOG.md‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,27 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [Unreleased]
9+
10+
### Changed
11+
12+
- **Minimum supported Node is now 20.** Node 18 reached end of life on
13+
2025-04-30 and is no longer tested. `engines` moves from `>=18` to `>=20`,
14+
and CI now runs Node 20, 22 and 24.
15+
16+
Nothing in the shipped bundle needed Node 18 specifically; the constraint
17+
arrives from the dev toolchain, where eslint 10 and vitest 4 both require
18+
Node 20 or newer. Rather than keep claiming support for a runtime nothing
19+
verifies, the claim is withdrawn. If you are still on Node 18, stay on
20+
7.1.x.
21+
22+
- Dev dependencies: eslint 9 to 10, vitest 1 to 4. No change to the published
23+
type surface: `dist/index.d.ts` is byte-identical to 7.1.0's.
24+
25+
TypeScript stays on 5.x. `openapi-typescript@7.13.0` still declares
26+
`peer typescript@"^5.x"`, so TypeScript 6 cannot be installed here until
27+
that range widens upstream.
28+
829
## [7.1.0] - 2026-09-01
930

1031
### Fixed

‎README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ A typed, modern TypeScript/JavaScript SDK for the [ThemeParks.wiki](https://api.
1010
npm i themeparks
1111
```
1212

13-
Runs on Node 18+, evergreen browsers, Deno, Bun, and Cloudflare Workers. Zero runtime dependencies.
13+
Runs on Node 20+, evergreen browsers, Deno, Bun, and Cloudflare Workers. Zero runtime dependencies.
1414

1515
## Print live wait times
1616

@@ -265,7 +265,7 @@ v7 is a full TypeScript rewrite. It replaces the v6 OpenAPI-Generator surface wi
265265
266266
## Supported runtimes
267267
268-
- Node 18, 20, 22
268+
- Node 20, 22, 24
269269
- Evergreen browsers
270270
- Deno
271271
- Bun

0 commit comments

Comments
 (0)