You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 24d306b
Browse filesBrowse the repository at this point in the historyBrowse files
Seat a room-link claim without waiting for the knock (#1082)
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
Owner: Dev
Reviewer: Reviewer
Fixes#1064
## What changed
A guest who joins a group link claims the ticket at Bot Social and then
knocks. The host seated those Bots only when that accepting knock was
delivered. A knock that was denied, held, or never read — a room-only
Bot is not polled — left the host listing only its own Bots and the
guest stuck on “Asked to join the group…”.
The inbox poll now reads every open server claim
(`flybot.rooms.seatOpenClaims`) and seats the Bots the claim names. The
claim is the authority. A knock that does arrive is still answered, and
a seat already told is not told again. A claim the host cannot finish (a
Bot in the group that cannot be shown, a notice waiting on approval, or
a join that did not leave) is named on the group’s Members card, and
**Seat them** asks the host to finish it. Join no longer says the group
was asked when nothing was claimed.
No `CHANGELOG.md` edit and no version bump. The user-visible note is
`changelog.d/1064-invite-claim-seat.fixed.md`.
## Verification at the tip
Tip SHA: a73cbdc
Rebased onto `origin/main` `2ce0e7f1e6056ff55540e07960d30264b8fd3b61`
(includes #1075, #1097, #1094, #1095, #1092, #1090, #1071, #1093). `git
diff origin/main...HEAD` lists only the files in this change. Conflicts
were only in generated patches (`0001-core-fixes`,
`0003-flybot-api-client`, `0008-client-bundle`). Sources auto-merged.
`client.js` was rebuilt and `node scripts/ds-bot-patches.mjs generate`
then `check` passed (`core/` equals `ds-bot/` + patches).
Ran:
- `TZ=UTC npm run verify` at this tip → exit 0. Core lint (arch-docs OK,
25 changed files), plugin lint, `build-client.mjs --check`,
`ds-bot-patches.mjs check`, core suite 1439, social 475, tree 125,
timeline 125, script tests 417, interop 37, live-e2e 16. All `# fail 0`.
That run includes the #1064 seat tests and the tests that landed on main
(#1048, #1053, #1054, #1087, #1088, #1089).
Not run (and why):
- Smoke bench (`core/dev/bench.sh`): `src/host/` changed, and there is
no `deepseek-harness` checkout beside this worktree for the bench to
start. Unit coverage is the two-home room harness in
`core/test/room-ticket-seat.test.js`.
- Desktop and a real-model steward.
<!-- CURSOR_AGENT_PR_BODY_END -->
<div><a
href="https://cursor.com/agents/bc-51aa2612-d9b8-5428-bcce-8b1518847321?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a
href="https://cursor.com/background-agent?bcId=bc-51aa2612-d9b8-5428-bcce-8b1518847321&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
A group invite link seats the guest's Bots when they claim it, even if the accepting knock never arrives, and the group opens in the guest's sidebar. A claim the host cannot finish is named on the group's Members card ([#1064](https://github.com/ThinkFlowLab/FlyBot/issues/1064)).
Copy file name to clipboardExpand all lines: core/client.js
+5Lines changed: 5 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -94,6 +94,11 @@ var ZH = {
94
94
"1 earlier link still works.": "还有 1 个之前的链接仍然有效。",
95
95
"{count} earlier links still work.": "还有 {count} 个之前的链接仍然有效。",
96
96
"Withdraw all": "全部撤回",
97
+
"{names} cannot be shown to someone who joins by link. Share them (Bot settings → Sharing) or remove them from the group, then seat the guest.": "{names} 不能给通过链接加入的人看到。请在 Bot 设置 → 共享里共享他们,或把他们移出群,然后再安排客人入座。",
98
+
"A Bot in this group cannot be shown to someone who joins by link. Share that Bot or remove it, then seat the guest.": "这个群里有一个 Bot 不能给通过链接加入的人看到。请共享该 Bot 或把它移出群,然后再安排客人入座。",
99
+
"A guest is in the group, but telling their FlyBot is waiting for your approval.": "客人已经在群里,但通知对方 FlyBot 还在等你批准。",
100
+
"A guest is in the group, but their FlyBot has not opened it yet. Seat them again.": "客人已经在群里,但对方的 FlyBot 还没有打开这个群。请再安排一次入座。",
Copy file name to clipboardExpand all lines: core/src/client/i18n.js
+5Lines changed: 5 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -57,6 +57,11 @@ const ZH = {
57
57
'1 earlier link still works.': '还有 1 个之前的链接仍然有效。',
58
58
'{count} earlier links still work.': '还有 {count} 个之前的链接仍然有效。',
59
59
'Withdraw all': '全部撤回',
60
+
'{names} cannot be shown to someone who joins by link. Share them (Bot settings → Sharing) or remove them from the group, then seat the guest.': '{names} 不能给通过链接加入的人看到。请在 Bot 设置 → 共享里共享他们,或把他们移出群,然后再安排客人入座。',
61
+
'A Bot in this group cannot be shown to someone who joins by link. Share that Bot or remove it, then seat the guest.': '这个群里有一个 Bot 不能给通过链接加入的人看到。请共享该 Bot 或把它移出群,然后再安排客人入座。',
62
+
'A guest is in the group, but telling their FlyBot is waiting for your approval.': '客人已经在群里,但通知对方 FlyBot 还在等你批准。',
63
+
'A guest is in the group, but their FlyBot has not opened it yet. Seat them again.': '客人已经在群里,但对方的 FlyBot 还没有打开这个群。请再安排一次入座。',
0 commit comments