You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit cf61952
Browse filesBrowse the repository at this point in the historyBrowse files
Name a friend's Bot one way and approval cards by the receiving person (#502)
Fixes#498
**What.** A friend's Bot now has one name in a friend chat, on both
homes. Approval cards name the person who gets the message.
- `friendBotTitle(bot)` / `friendBotOwner(bot)` in
`core/src/shared/remote-label.js` are the one formatter for a friend's
chat. The sidebar row, chat header, tab title, composer placeholder and
@ menu call it, so they all read `Chief (SelfB1233)` (#384/#305). The
sidebar row is now one string, without the muted owner part. The @ menu
no longer falls back to the handle (`@chief.selfb1233.home (SelfB1233)`)
for a friend's chat. The social plugin's classic script reads the same
functions from `globalThis.__flybot__.names`, set in `flybot-slots.js`
`registry()`.
- Approval cards (the held-reply card on the bubble, the
overlay/pointer, and the social dock for local and Bot Social holds)
name the receiving person: the stored `recipientName`/`toOwner` first,
then the friend chat's owner. A card reads `Chief → SelfB1233` (#418)
and is the same before and after a reload. It never shows `Chief → Chief
(SelfB1233)` again.
- Face rooms are unchanged: they stay person-first per #457. The
composer placeholder only changes through the shared formatter, and the
#499 placeholder regression is left to #499.
**Why.** The owner's decision (option a, 2026-10-20) was to unify friend
Bot names as `Chief (SelfB1233)` through one formatter, and have
approval cards show the receiver.
**Test.** `ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify` passes with
0 failures (core 1079, social 297,
tree/timeline/scripts/interop/live-e2e all pass; plugin lint OK). New
and updated tests:
- the formatter names both homes' Chiefs and the owner
(`remote-room.test.js`)
- the held card reads the same with and without the friend's chat in the
roster (`held-reply.test.js`)
- the overlay pointer names the person (`overlay-approvals.test.js`)
- the @ menu names a host-shaped friend chat (`at-menu.test.js`)
- the sidebar row and other surfaces use the formatter
(`flybot-client.test.js`)
- the social dock names the person through the host formatter
(`social.test.js`)
Not run: the live two-home Mac instances and the smoke bench
(client-only change).
Risk tier: T3 (estimate, from the risk-gate report: remote-label.js and
displayName paths; the controller sets the label)
---------
Co-authored-by: Birfy <15378933+Birfy@users.noreply.github.com>
A friend's Bot now has one name everywhere in a friend chat, on both homes: the sidebar row, chat header, tab, composer placeholder and @ menu all read `Chief (SelfB1233)`, from one shared formatter, and the @ menu no longer shows the handle as the Bot's name. A held message's approval card names the person who gets it (`Chief → SelfB1233`), the same before and after a reload, instead of `Chief → Chief (SelfB1233)` ([#498](https://github.com/ThinkFlowLab/FlyBot/issues/498)).
0 commit comments