Skip to content

Commit 19b1574

Browse files
author
DavidQ
committed
Add post-closeout guard and monitoring for fullscreen rules.
Ensures no regression after Level 23 closeout. PR: LEVEL 23.11 POST CLOSEOUT GUARD
1 parent 22e8ea2 commit 19b1574

3 files changed

Lines changed: 40 additions & 0 deletions

File tree

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
Post Closeout Monitoring
2+
3+
- Rule remains: fullscreen only in sample 0713
4+
- Any future addition outside 0713 = violation
5+
- Validation automation must be rerun on PRs touching samples
6+
- Required automation reuse for future PRs that touch `samples/`:
7+
- `rg -n --glob "samples/**" "requestFullscreen|webkitRequestFullscreen|engine\\.fullscreen|fullscreenPreferred|settings-fullscreen"`
8+
- `node --input-type=module -e "import('./tests/samples/FullscreenRuleEnforcement.test.mjs').then(m=>m.run())"`
9+
- `node --input-type=module -e "import('./tests/samples/FullscreenAbility0713ViewportFit.test.mjs').then(m=>m.run())"`

docs/dev/validation_checklist.txt

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
Validation Checklist
2+
3+
[x] Guard rules persist
4+
[x] Monitoring defined
5+
[x] No regression introduced
6+
[x] Fullscreen scan command documented for reuse
7+
[x] `FullscreenRuleEnforcement` test reuse documented
8+
[x] `FullscreenAbility0713ViewportFit` test reuse documented
Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# BUILD PR LEVEL 23.11
2+
## Post-Closeout Guard and Monitoring
3+
4+
### Purpose
5+
Ensure fullscreen rule remains permanently enforced after closeout.
6+
7+
### Scope
8+
- Reinforce guard rules
9+
- Add ongoing monitoring expectations
10+
- Prevent regression
11+
- Reuse existing validation automation (do not create duplicate checks)
12+
13+
### Required Reuse On Future PRs Touching `samples/`
14+
- Run fullscreen scan:
15+
- `rg -n --glob "samples/**" "requestFullscreen|webkitRequestFullscreen|engine\\.fullscreen|fullscreenPreferred|settings-fullscreen"`
16+
- Run fullscreen guard tests:
17+
- `tests/samples/FullscreenRuleEnforcement.test.mjs`
18+
- `tests/samples/FullscreenAbility0713ViewportFit.test.mjs`
19+
20+
### Acceptance
21+
- Fullscreen remains restricted to sample 0713
22+
- Any regression is detectable
23+
- No engine changes

0 commit comments

Comments
 (0)