BUILD PR: centralize getRuntimeAndRegistry across exact command-pack/preset batch.

Author: DavidQ

docs/dev/CODEX_COMMANDS.md

@@ -1,11 +1,11 @@
 MODEL: GPT-5.3-codex
 REASONING: high
 COMMAND:
-Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_42_CREATE_RESULT_COMMANDPACK_BATCH.md exactly.
+Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_43_GET_RUNTIME_AND_REGISTRY_BATCH.md exactly.
 Edit only these files:
-- tools/dev/commandPacks/commandPackResultUtils.js (new file)
+- tools/dev/shared/runtimeRegistryUtils.js (new file)
 - tools/dev/commandPacks/groupCommandPack.js
-- tools/dev/commandPacks/macroCommandPack.js
-- tools/dev/commandPacks/toggleCommandPack.js
+- tools/dev/commandPacks/overlayCommandPack.js
+- tools/dev/presets/debugPresetApplier.js
 Do not expand scope.
-Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_42_CREATE_RESULT_COMMANDPACK_BATCH_delta.zip
+Package the delta output to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_43_GET_RUNTIME_AND_REGISTRY_BATCH_delta.zip

docs/dev/COMMIT_COMMENT.txt

@@ -1 +1 @@
-BUILD PR: centralize createResult across exact command-pack batch.
+BUILD PR: centralize getRuntimeAndRegistry across exact command-pack/preset batch.

docs/dev/NEXT_COMMAND.txt

@@ -1 +1 @@
-Next: run BUILD_PR_SHARED_EXTRACTION_43_GET_RUNTIME_AND_REGISTRY_BATCH after this batch.
+Next: continue duplicate-family extraction from the provided duplicate report.

docs/dev/reports/change_summary.txt

@@ -1 +1 @@
-Execution-grade batch for createResult using the exact duplicate-report file list.
+Execution-grade batch for getRuntimeAndRegistry using the exact duplicate-report file list.

docs/pr/BUILD_PR_SHARED_EXTRACTION_43_GET_RUNTIME_AND_REGISTRY_BATCH.md

@@ -0,0 +1,94 @@
+# BUILD_PR_SHARED_EXTRACTION_43_GET_RUNTIME_AND_REGISTRY_BATCH
+
+## Purpose
+Centralize duplicated `getRuntimeAndRegistry(context)` implementations across the exact command-pack/preset batch identified in the duplicate report.
+
+## Single PR Purpose
+Normalize ONLY this helper:
+
+- `getRuntimeAndRegistry(context)`
+
+## Exact Files Allowed
+
+### New shared file
+1. `tools/dev/shared/runtimeRegistryUtils.js`
+
+### Consumer files
+2. `tools/dev/commandPacks/groupCommandPack.js`
+3. `tools/dev/commandPacks/overlayCommandPack.js`
+4. `tools/dev/presets/debugPresetApplier.js`
+
+Do not edit any other file.
+
+## Source of Truth
+This exact scope comes from the provided duplicate report entry for:
+
+`function getRuntimeAndRegistry(context)`
+
+Only the 3 listed consumer files are in scope.
+
+## Exact Shared Helper Creation
+Create:
+
+`tools/dev/shared/runtimeRegistryUtils.js`
+
+Export exactly:
+
+```js
+export function getRuntimeAndRegistry(context) {
+  // copy one existing implementation exactly
+}
+```
+
+Implementation rules:
+- use ONE existing local implementation as source-of-truth
+- do NOT merge logic
+- do NOT generalize behavior
+- preserve the function signature exactly:
+  - `getRuntimeAndRegistry(context)`
+
+## Exact Consumer Changes
+For each of the 3 listed consumer files:
+
+If the file contains a local function definition matching:
+```js
+function getRuntimeAndRegistry(context)
+```
+then:
+- remove the local `getRuntimeAndRegistry(context)` function definition
+- import `getRuntimeAndRegistry` from the correct relative path to:
+  - `../shared/runtimeRegistryUtils.js` for command pack files
+  - `../shared/runtimeRegistryUtils.js` for `tools/dev/presets/debugPresetApplier.js`
+- if the file already imports from that module, add `getRuntimeAndRegistry` with the minimum safe edit
+- do not duplicate imports
+- do not touch unrelated helpers
+- do not change logic
+
+If a listed file already imports and uses shared `getRuntimeAndRegistry`, leave it unchanged.
+
+## Relative Import Rule
+Use exactly:
+
+`../shared/runtimeRegistryUtils.js`
+
+Do not use aliases.
+Do not change `.js` extension usage.
+
+## Hard Constraints
+- no engine changes
+- no files outside the 3 listed consumers plus the one new shared file
+- no repo-wide preset/command-pack helper cleanup
+- no behavior changes
+- keep one PR purpose only
+
+## Validation Checklist
+1. Confirm no more than the 4 listed files changed
+2. Confirm `tools/dev/shared/runtimeRegistryUtils.js` exists and exports `getRuntimeAndRegistry`
+3. Confirm local `function getRuntimeAndRegistry(context)` definitions no longer exist in changed listed consumer files
+4. Confirm changed consumer files import `getRuntimeAndRegistry` from `../shared/runtimeRegistryUtils.js`
+5. Confirm no unrelated files changed
+6. Confirm no behavior changes were made
+
+## Non-Goals
+- no cleanup outside the 3 listed consumer files
+- no refactor beyond this exact duplicate-removal batch

tools/dev/commandPacks/groupCommandPack.js

@@ -12,43 +12,10 @@ import {
   requireNoArgs
 } from "./packUtils.js";
 import { createResult } from "./commandPackResultUtils.js";
+import { getRuntimeAndRegistry } from "../shared/runtimeRegistryUtils.js";
 
 import { sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
 
-function getRuntimeAndRegistry(context) {
-  const runtime = context?.consoleRuntime;
-  const panelRegistry = runtime?.panelRegistry;
-  if (!runtime || typeof runtime.getState !== "function") {
-    return {
-      status: "failed",
-      error: createResult(
-        "failed",
-        "Group",
-        ["Console runtime is unavailable."],
-        "MISSING_COMMAND_CONTEXT"
-      )
-    };
-  }
-
-  if (!panelRegistry || typeof panelRegistry.getOrderedPanels !== "function" || typeof panelRegistry.setPanelEnabled !== "function") {
-    return {
-      status: "failed",
-      error: createResult(
-        "failed",
-        "Group",
-        ["Overlay panel registry is unavailable."],
-        "MISSING_OVERLAY_REGISTRY"
-      )
-    };
-  }
-
-  return {
-    status: "ready",
-    runtime,
-    panelRegistry
-  };
-}
-
 function buildSnapshot(panelRegistry) {
   const panels = panelRegistry.getOrderedPanels(true);
   const allPanels = Array.isArray(panels) ? panels : [];
@@ -78,7 +45,12 @@ function persistSnapshotIfConfigured(context, panelRegistry) {
 function setGroupEnabled(context, groupDescriptor, nextEnabled) {
   const runtimeContext = getRuntimeAndRegistry(context);
   if (runtimeContext.status !== "ready") {
-    return runtimeContext.error;
+    return createResult(
+      "failed",
+      "Group",
+      [runtimeContext.message],
+      runtimeContext.code
+    );
   }
 
   const panelRegistry = runtimeContext.panelRegistry;
@@ -256,7 +228,12 @@ export function createGroupCommandPack() {
 
           const runtimeContext = getRuntimeAndRegistry(context);
           if (runtimeContext.status !== "ready") {
-            return runtimeContext.error;
+            return createResult(
+              "failed",
+              "Group",
+              [runtimeContext.message],
+              runtimeContext.code
+            );
           }
 
           const panelRegistry = runtimeContext.panelRegistry;