Clarify and enforce separation of tool IDs and asset kinds - PR 11.107

Author: DavidQ

docs/dev/codex_commands.md

@@ -3,22 +3,16 @@
 Model: GPT-5.3-codex
 Reasoning: low
 
-1. Update resolveAcceptedAssetKindsForTool:
-   - remove aliases
-   - use canonical mapping only
+1. Scan repo:
+   - ensure no asset kind equals a tool id
+   - ensure no tool id used as asset kind
 
-2. Replace all asset kinds in repo:
-   - normalize to canonical names
+2. Validate mapping:
+   resolveAcceptedAssetKindsForTool is:
+   toolId -> asset kinds ONLY
 
-3. Remove:
-   - "*"
-   - duplicate kinds per tool
-   - alias values
+3. Fix violations:
+   - replace incorrect asset kinds with canonical types
 
-4. Validate:
-   - tools match schema
-   - samples use canonical kinds
-   - no unknown kinds exist
-
-5. Report:
-   docs/dev/reports/asset_kind_canonicalization_11_106.txt
+4. Report:
+   docs/dev/reports/tool_vs_asset_kind_11_107.txt

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Enforce single canonical asset kind per concept and remove alias mappings - PR 11.106
+Clarify and enforce separation of tool IDs and asset kinds - PR 11.107

docs/dev/reports/tool_vs_asset_kind_11_107.txt

@@ -0,0 +1,54 @@
+BUILD_PR_LEVEL_11_107_TOOL_VS_ASSET_KIND_GUARD
+Date: 2026-04-30
+
+Scope
+- Scan repo for tool-id/asset-kind crossover violations.
+- Validate resolveAcceptedAssetKindsForTool remains toolId -> asset kinds only.
+- Fix violations if present.
+
+Files Changed
+- docs/dev/reports/tool_vs_asset_kind_11_107.txt
+
+1) Repo scan: no asset kind equals a tool id
+- Tool IDs extracted from tools/toolRegistry.js: 18
+- Broad JSON scan (excluding docs/non-JSONC noise):
+  - kind fields scanned: 177
+  - violations (kind == tool id): 0
+
+2) Asset-facing manifest/catalog scan
+- Scanned files:
+  - games/**/game.manifest.json (asset-browser.assets)
+  - games/**/workspace.asset-catalog.json
+  - samples/**/workspace*.json
+  - workspace.manifest.json
+- Unique asset-facing kind values observed:
+  audio, collision, data, font, image, other, palette, parallax, polygon, polyline, runtime-shape, skin, sprite, svg, tile, tilemap, vector
+- tool-id used as asset kind violations: 0
+
+3) resolveAcceptedAssetKindsForTool validation
+- File: tools/shared/platformShell.js
+- Mapping is toolId -> asset kinds only:
+  - skin-editor -> [skin]
+  - sprite-editor -> [sprite]
+  - tile-map-editor -> [tilemap]
+  - parallax-editor -> [parallax]
+  - svg-asset-studio -> [vector]
+  - vector-map-editor -> [vector-map]
+  - 3d-asset-viewer -> [model]
+  - 3d-camera-path-editor -> [camera-path]
+  - asset-browser -> [asset]
+  - asset-pipeline -> []
+  - tile-model-converter -> [tilemap, vector, model]
+- Duplicate kind entries: 0
+- Mapping values equal to a tool id: 0
+
+4) Violations fixed
+- None required.
+- No incorrect asset-kind values matched a tool id, so no canonical replacement patch was needed for this PR.
+
+Validation Commands (targeted)
+- Python scan: tool ids vs all JSON kind fields -> 0 violations
+- Python scan: asset-facing manifests/catalogs -> 0 tool-id-as-kind violations
+
+Result
+- Constraint satisfied: no asset kind equals a tool id and no tool id is used as an asset kind.

docs/pr/BUILD_PR_LEVEL_11_107_TOOL_VS_ASSET_KIND_CLARIFICATION.md

@@ -0,0 +1,75 @@
+# BUILD_PR_LEVEL_11_107_TOOL_VS_ASSET_KIND_CLARIFICATION
+
+## Purpose
+Clarify and enforce separation between:
+- Tool IDs
+- Asset Kinds
+
+## Key Rule
+
+Tool ≠ Asset Kind
+
+They are DIFFERENT layers.
+
+## Definitions
+
+### Tool ID (FULL NAME)
+Used for:
+- UI
+- routing
+- registry
+- manifest.tools
+
+Examples:
+- sprite-editor
+- vector-map-editor
+- asset-browser
+
+### Asset Kind (DATA TYPE)
+Used for:
+- asset classification
+- filtering
+- validation
+
+Examples:
+- sprite
+- vector-map
+- model
+- tilemap
+
+## Correct Relationship
+
+Tool -> accepts Asset Kind(s)
+
+Example:
+
+sprite-editor -> ["sprite"]
+vector-map-editor -> ["vector-map"]
+
+## What NOT to do
+
+❌ DO NOT use tool names as asset kinds:
+["sprite-editor"]
+
+❌ DO NOT mix layers:
+toolId === assetKind
+
+## Current Function (CORRECT)
+
+The function is correct structurally:
+
+toolId (full name) → asset kinds (data types)
+
+## Required Enforcement
+
+- Tool IDs remain full canonical names
+- Asset kinds remain canonical data types
+- No overlap
+- No aliasing
+- No duplication
+
+## Acceptance
+
+- Tool IDs are never used as asset kinds
+- Asset kinds are never tool IDs
+- Mapping is clean and 1-directional