|
| 1 | +# PLAN_PR_SAMPLES_BUNDLED_FINALIZATION |
| 2 | + |
| 3 | +## Objective |
| 4 | +Bundle the remaining samples PRs into the fewest rule-safe BUILD/APPLY waves while preserving one-purpose-per-PR, testability, canonical paths, and Windows-safe zero-dependency execution. |
| 5 | + |
| 6 | +## Scope |
| 7 | +Docs-only planning. |
| 8 | +No implementation code changes. |
| 9 | +No gameplay scope. |
| 10 | +No engine-core scope. |
| 11 | +No start_of_day directory changes. |
| 12 | + |
| 13 | +## Remaining 7 Sample Objectives |
| 14 | +1. Preview assets and thumbnails |
| 15 | +2. Metadata validation hardening |
| 16 | +3. Index performance pass |
| 17 | +4. Tag standardization |
| 18 | +5. Navigation polish |
| 19 | +6. Hover preview |
| 20 | +7. Favorites/pinning |
| 21 | + |
| 22 | +## Bundling Decision |
| 23 | +Minimum safe wave count: **3 BUILD/APPLY waves**. |
| 24 | + |
| 25 | +Why not 1 wave: |
| 26 | +- mixes incompatible concerns and violates one-purpose intent. |
| 27 | + |
| 28 | +Why not 2 waves: |
| 29 | +- still forces data-quality and performance/personalization concerns into the same BUILD. |
| 30 | + |
| 31 | +Why 3 waves works: |
| 32 | +- each wave keeps a singular execution purpose, |
| 33 | +- each wave has a clear test surface, |
| 34 | +- each wave can fail fast cleanly. |
| 35 | + |
| 36 | +## Wave Plan |
| 37 | +### Wave 1 |
| 38 | +BUILD: `BUILD_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION` |
| 39 | +APPLY: `APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION` |
| 40 | + |
| 41 | +Purpose: |
| 42 | +- browse-time UX enhancements. |
| 43 | + |
| 44 | +Includes: |
| 45 | +- preview assets and thumbnails |
| 46 | +- hover preview |
| 47 | +- navigation polish |
| 48 | + |
| 49 | +Testability gates: |
| 50 | +- index/detail render previews with deterministic fallback |
| 51 | +- next/previous/related navigation links resolve |
| 52 | +- representative links still load (first sample, last sample, 1316-1318) |
| 53 | +- no console errors on tested pages |
| 54 | + |
| 55 | +### Wave 2 |
| 56 | +BUILD: `BUILD_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY` |
| 57 | +APPLY: `APPLY_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY` |
| 58 | + |
| 59 | +Purpose: |
| 60 | +- discovery data correctness. |
| 61 | + |
| 62 | +Includes: |
| 63 | +- metadata validation hardening |
| 64 | +- tag standardization |
| 65 | + |
| 66 | +Testability gates: |
| 67 | +- malformed metadata fails fast |
| 68 | +- duplicates/mismatch conditions fail fast |
| 69 | +- filter/search consistency improves with standardized tags |
| 70 | +- canonical paths unchanged |
| 71 | + |
| 72 | +### Wave 3 |
| 73 | +BUILD: `BUILD_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION` |
| 74 | +APPLY: `APPLY_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION` |
| 75 | + |
| 76 | +Purpose: |
| 77 | +- index responsiveness and optional user personalization. |
| 78 | + |
| 79 | +Includes: |
| 80 | +- index performance pass |
| 81 | +- favorites/pinning |
| 82 | + |
| 83 | +Testability gates: |
| 84 | +- filter/search interactions remain responsive |
| 85 | +- favorites persist locally without external dependencies |
| 86 | +- no path contract changes |
| 87 | +- no gameplay or engine-core changes |
| 88 | + |
| 89 | +## Compatibility Guardrails |
| 90 | +Do not combine in one BUILD: |
| 91 | +- discovery-data hardening with personalization features |
| 92 | +- performance optimizations with metadata schema policy changes |
| 93 | +- preview asset wiring with broad non-sample refactors |
| 94 | + |
| 95 | +## Execution Order |
| 96 | +1. BUILD_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION |
| 97 | +2. APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION |
| 98 | +3. BUILD_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY |
| 99 | +4. APPLY_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY |
| 100 | +5. BUILD_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION |
| 101 | +6. APPLY_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION |
| 102 | + |
| 103 | +## Windows-Safe Assumptions |
| 104 | +- zero dependency execution only |
| 105 | +- no npm install / no node_modules requirements |
| 106 | +- Node.js/vanilla JS-first scripts |
| 107 | +- deterministic local validation scripts |
| 108 | + |
| 109 | +## Canonical Path Contract |
| 110 | +Must remain unchanged: |
| 111 | +- `samples/phaseXX/XXYY/index.html` |
| 112 | + |
| 113 | +## Acceptance Criteria |
| 114 | +- all 7 remaining sample objectives are covered |
| 115 | +- bundling is minimized to the fewest safe waves |
| 116 | +- no incompatible purpose mixing per BUILD |
| 117 | +- each future BUILD remains testable |
| 118 | +- canonical path contract is preserved |
| 119 | +- Windows-safe zero-dependency assumptions are preserved |
0 commit comments