Skip to content

Commit 7fdafef

Browse files
author
DavidQ
committed
Add Asset Manager V2 keyboard selection and missing file logging - PR_26126_101-asset-manager-v2-selection-and-missing-file-log
1 parent 4e54eec commit 7fdafef

13 files changed

Lines changed: 524 additions & 472 deletions

‎docs/dev/reports/PR_26126_101_asset_manager_v2_keyboard_navigation_notes.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26126_101 Asset Manager V2 Keyboard Navigation Notes
2+
3+
## Asset Tile Navigation
4+
- Asset tiles now support ArrowRight and ArrowDown for next tile selection.
5+
- Asset tiles now support ArrowLeft and ArrowUp for previous tile selection.
6+
- Navigation follows the rendered/sorted tile order: type, then role, then ID.
7+
- Arrow navigation clamps at the first and last tile instead of wrapping.
8+
9+
## Selection Updates
10+
- Arrow navigation calls the same selection path used by tile clicks.
11+
- Selected Asset Detail updates to the new asset ID, type/kind, role, and path.
12+
- The center preview updates to the newly selected asset type.
13+
- Focus moves to the newly selected tile button after the re-render.
14+
15+
## Validation
16+
- Playwright validates adjacent keyboard selection from audio to image and back.
17+
- Playwright validates Selected Asset Detail, preview type, and focused tile all update together.

‎docs/dev/reports/PR_26126_101_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# PR_26126_101 Asset Manager V2 Manual Validation Notes
2+
3+
## Commands
4+
- `node --check tools/asset-manager-v2/js/controls/AssetCatalogControl.js`
5+
- `node --check tools/asset-manager-v2/js/controls/AssetFormControl.js`
6+
- `node --check tools/asset-manager-v2/js/AssetManagerV2App.js`
7+
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
8+
- `git diff --check`
9+
- `npm run test:workspace-v2`
10+
11+
## Results
12+
- JavaScript syntax checks passed for changed runtime and Playwright files.
13+
- Required workspace-v2 Playwright gate passed: 12 tests passed.
14+
- `git diff --check` passed with no whitespace errors.
15+
- `docs/dev/reports/playwright_v8_coverage_report.txt` was regenerated by the required workspace-v2 validation run.
16+
17+
## Manual Checks Covered By Tests
18+
- Arrow-key adjacent tile selection updates selected tile, Selected Asset Detail, preview, and keyboard focus.
19+
- Selected color swatch gets a visible white selected border on the button and inner swatch.
20+
- Valid imported JSON still loads when referenced files are missing.
21+
- Missing referenced files are logged to Status with asset ID and path.
22+
- Missing file warnings do not write into Output Summary or block export.
23+
- Sample JSON files were not modified.

‎docs/dev/reports/PR_26126_101_asset_manager_v2_missing_file_logging_notes.md‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR_26126_101 Asset Manager V2 Missing File Logging Notes
2+
3+
## Availability Check
4+
- After Workspace V2 asset payload load, Asset Manager V2 checks file-backed asset paths after schema validation succeeds.
5+
- After NAV Import JSON, Asset Manager V2 checks file-backed asset paths after schema validation succeeds.
6+
- Color assets and protocol paths such as `palette://workspace/...` are skipped because they are not referenced files.
7+
8+
## Warning Behavior
9+
- Missing files are logged to Status as informational file availability warnings.
10+
- Missing files do not make otherwise valid schema payloads fail.
11+
- The warning includes the asset ID and original path.
12+
13+
## Example
14+
- `File availability warning: Missing referenced file for assets.font.ui.vector-battle: assets/fonts/vector_battle.ttf.`
15+
16+
## Validation
17+
- Playwright imports valid Asset Manager V2 JSON with missing referenced file paths.
18+
- Playwright validates Status contains missing-file warnings for both imported assets while import and export still succeed.

‎docs/dev/reports/PR_26126_101_asset_manager_v2_selected_swatch_notes.md‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
# PR_26126_101 Asset Manager V2 Selected Swatch Notes
2+
3+
## Selected State
4+
- Palette color swatches now re-render with a visible selected state after click.
5+
- The selected swatch button receives `is-selected` and `aria-pressed="true"`.
6+
- The selected swatch outer button border uses white.
7+
- The selected swatch color indicator border also uses white.
8+
9+
## Scope
10+
- The swatch name, tooltip, palette metadata, Color path, and Color ID generation are unchanged.
11+
- The selected state follows the current normalized palette swatch by hex and name.
12+
13+
## Validation
14+
- Playwright validates the selected UAT sample palette swatch has `aria-pressed="true"`.
15+
- Playwright validates the selected swatch button border and inner color indicator border are white.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -2,29 +2,27 @@
22
M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
44
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
5-
M tools/asset-manager-v2/index.html
6-
M tools/asset-manager-v2/js/assetManagerMetadata.js
7-
M tools/asset-manager-v2/js/bootstrap.js
5+
M tools/asset-manager-v2/js/AssetManagerV2App.js
6+
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
87
M tools/asset-manager-v2/js/controls/AssetFormControl.js
9-
M tools/asset-manager-v2/js/services/AssetSchemaValidator.js
108
M tools/asset-manager-v2/styles/assetManager.css
11-
?? docs/dev/reports/PR_26126_100_asset_manager_v2_color_usage_id_notes.md
12-
?? docs/dev/reports/PR_26126_100_asset_manager_v2_manual_validation_notes.md
13-
?? docs/dev/reports/PR_26126_100_asset_manager_v2_selected_detail_height_notes.md
9+
?? docs/dev/reports/PR_26126_101_asset_manager_v2_keyboard_navigation_notes.md
10+
?? docs/dev/reports/PR_26126_101_asset_manager_v2_manual_validation_notes.md
11+
?? docs/dev/reports/PR_26126_101_asset_manager_v2_missing_file_logging_notes.md
12+
?? docs/dev/reports/PR_26126_101_asset_manager_v2_selected_swatch_notes.md
1413

1514
# git ls-files --others --exclude-standard
16-
docs/dev/reports/PR_26126_100_asset_manager_v2_color_usage_id_notes.md
17-
docs/dev/reports/PR_26126_100_asset_manager_v2_manual_validation_notes.md
18-
docs/dev/reports/PR_26126_100_asset_manager_v2_selected_detail_height_notes.md
15+
docs/dev/reports/PR_26126_101_asset_manager_v2_keyboard_navigation_notes.md
16+
docs/dev/reports/PR_26126_101_asset_manager_v2_manual_validation_notes.md
17+
docs/dev/reports/PR_26126_101_asset_manager_v2_missing_file_logging_notes.md
18+
docs/dev/reports/PR_26126_101_asset_manager_v2_selected_swatch_notes.md
1919

2020
# git diff --stat
21-
docs/dev/reports/coverage_changed_js_guardrail.txt | 8 ++--
22-
docs/dev/reports/playwright_v8_coverage_report.txt | 22 ++++-----
23-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 53 ++++++++++++++++++----
24-
tools/asset-manager-v2/index.html | 4 ++
25-
tools/asset-manager-v2/js/assetManagerMetadata.js | 11 +++++
26-
tools/asset-manager-v2/js/bootstrap.js | 2 +
27-
.../js/controls/AssetFormControl.js | 44 ++++++++++++++++--
28-
.../js/services/AssetSchemaValidator.js | 11 ++++-
29-
tools/asset-manager-v2/styles/assetManager.css | 4 +-
30-
9 files changed, 128 insertions(+), 31 deletions(-)
21+
docs/dev/reports/coverage_changed_js_guardrail.txt | 4 ++-
22+
docs/dev/reports/playwright_v8_coverage_report.txt | 12 +++++---
23+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 25 ++++++++++++++++
24+
tools/asset-manager-v2/js/AssetManagerV2App.js | 33 ++++++++++++++++++--
25+
.../js/controls/AssetCatalogControl.js | 35 ++++++++++++++++++++++
26+
.../js/controls/AssetFormControl.js | 4 ++-
27+
tools/asset-manager-v2/styles/assetManager.css | 9 ++++++
28+
7 files changed, 114 insertions(+), 8 deletions(-)

0 commit comments

Comments
 (0)