Enforce full strict schema mode across tool and workspace schemas - PR 11.18

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,20 +1,24 @@
 # CODEX COMMANDS
 
 model: gpt-5.3-codex
-reasoning: medium
+reasoning: high
 
-Apply PR_11_14_WORKSPACE_SCHEMA_PALETTE_TOOL_AND_1902_REBUILD.
+Apply PR_11_18_FULL_STRICT_SCHEMA_MODE.
 
 Required:
-- Update `tools/schemas/workspace.manifest.schema.json` so Palette is a singular tool payload under `tools.palette`.
-- Remove top-level required `palettes` collection from the manifest schema unless migration compatibility is required and documented.
-- Rebuild only `samples/phase-19/1902/`.
-- Delete/remove `sample.1902.palette.json`.
-- Rebuild sample 1902 workspace payload so all tool data is under `tools`, including `tools.palette`.
-- Allow only one palette in the workspace manifest.
-- Ensure Workspace shows all valid tools, not only Palette.
-- Do not modify other samples.
+- Enforce `additionalProperties: false` on every object schema under `tools/schemas/**/*.json`.
+- No schema object may use `additionalProperties: true`.
+- No schema object may omit `additionalProperties`.
+- Explicitly define every allowed field instead of allowing loose payloads.
+- Complete missing/weak tool schemas rather than bypassing validation.
+- Workspace manifest must reference tool schemas via `$ref`.
+- Workspace `tools.palette` remains singular and required.
+- Workspace `tools.additionalProperties` must be false.
+- Validate all `$ref` targets resolve.
+- Add tests/checks that unknown fields fail validation.
+- Validate/rebuild only sample 1902 as needed.
+- Ensure sample 1902 Workspace shows all valid tools, not only Palette.
 - Do not add fallback/default/hidden data.
 - Do not modify start_of_day folders.
-- Add validation report at docs/dev/reports/PR_11_14_WORKSPACE_SCHEMA_PALETTE_TOOL_AND_1902_REBUILD_report.md.
-- Return ZIP artifact at tmp/PR_11_14_WORKSPACE_SCHEMA_PALETTE_TOOL_AND_1902_REBUILD_delta.zip.
+- Add validation report at docs/dev/reports/PR_11_18_FULL_STRICT_SCHEMA_MODE_report.md.
+- Return ZIP artifact at tmp/PR_11_18_FULL_STRICT_SCHEMA_MODE_delta.zip.

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Make Workspace palette a singular tool payload and rebuild sample 1902 - PR 11.14
+Enforce full strict schema mode across tool and workspace schemas - PR 11.18

docs/dev/reports/PR_11_17_SCHEMA_SET_NORMALIZATION_AND_WORKSPACE_REF_ENFORCEMENT_report.md

@@ -0,0 +1,77 @@
+# PR_11_17_SCHEMA_SET_NORMALIZATION_AND_WORKSPACE_REF_ENFORCEMENT Report
+
+## Result
+- PASS
+
+## Summary
+- The requested schema contract state was already present in `HEAD`, so no schema/sample code edits were required for this PR purpose.
+- Execution-focused validation was run to prove the current repo state satisfies PR 11.17 requirements.
+
+## Contract Verification
+
+### Workspace Manifest Schema
+File:
+- `tools/schemas/workspace.manifest.schema.json`
+
+Verified:
+- Top-level `palettes` is removed.
+- Top-level `tools` is required.
+- `tools.palette` is singular and required.
+- `tools.properties` explicitly lists all active workspace-supported registry ids.
+- `tools.additionalProperties` is `false`.
+- `$ref` entries are used for each declared tool/palette schema target.
+
+### Canonical `$ref` Targets
+Verified resolvable and valid JSON:
+- `./tools/palette.schema.json`
+- `./tools/vector-map-editor.schema.json`
+- `./tools/vector-asset-studio.schema.json`
+- `./tools/tile-map-editor.schema.json`
+- `./tools/parallax-editor.schema.json`
+- `./tools/sprite-editor.schema.json`
+- `./tools/skin-editor.schema.json`
+- `./tools/asset-browser.schema.json`
+- `./tools/palette-browser.schema.json`
+- `./tools/state-inspector.schema.json`
+- `./tools/replay-visualizer.schema.json`
+- `./tools/performance-profiler.schema.json`
+- `./tools/physics-sandbox.schema.json`
+- `./tools/asset-pipeline-tool.schema.json`
+- `./tools/tile-model-converter.schema.json`
+- `./tools/3d-json-payload-normalizer.schema.json`
+- `./tools/3d-asset-viewer.schema.json`
+- `./tools/3d-camera-path-editor.schema.json`
+
+## Sample 1902 Validation
+File:
+- `samples/phase-19/1902/sample.1902.workspace-all-tools.json`
+
+Verified:
+- No top-level `palettes`.
+- Contains `tools.palette` singleton payload.
+- Uses canonical registry-id tool keys plus `palette`.
+- No `sample.1902.palette.json` file present.
+- No `sample.1902.palette.json` references in sample 1902 payload.
+
+Validation script result:
+- `PR_11_17_schema_and_sample_validation PASS`
+- `tools_property_count 18`
+- `sample_1902_tool_keys vector-map-editor,vector-asset-studio,tile-map-editor,parallax-editor,sprite-editor,skin-editor,asset-browser,palette-browser,state-inspector,replay-visualizer,performance-profiler,physics-sandbox,asset-pipeline-tool,tile-model-converter,3d-json-payload-normalizer,3d-asset-viewer,3d-camera-path-editor,palette`
+
+## Workspace Visibility Validation
+Command:
+- `npm run test:launch-smoke -- --tools`
+
+Result:
+- `PASS=287 FAIL=0 TOTAL=287`
+- Includes `sample 1902` PASS and all active tool launches PASS.
+- Confirms workspace/tool launch path is not constrained to Palette only.
+
+## Scope and Safety Confirmations
+- No changes to other sample folders.
+- No `start_of_day` folder changes.
+- No fallback/default/hidden data added.
+- No `sample.1902.palette.json` introduced.
+
+## Files Changed for PR 11.17
+- `docs/dev/reports/PR_11_17_SCHEMA_SET_NORMALIZATION_AND_WORKSPACE_REF_ENFORCEMENT_report.md`

docs/dev/reports/PR_11_18_FULL_STRICT_SCHEMA_MODE_report.md

@@ -0,0 +1,114 @@
+# PR_11_18_FULL_STRICT_SCHEMA_MODE Report
+
+## Result
+- PASS (required PR scope met)
+
+## Schemas Changed
+- `tools/schemas/workspace.manifest.schema.json`
+- `tools/schemas/sample.tool-payload.schema.json`
+- `tools/schemas/tool.manifest.schema.json`
+- `tools/schemas/tools/3d-asset-viewer.schema.json`
+- `tools/schemas/tools/3d-camera-path-editor.schema.json`
+- `tools/schemas/tools/3d-json-payload-normalizer.schema.json`
+- `tools/schemas/tools/asset-browser.schema.json`
+- `tools/schemas/tools/asset-pipeline-tool.schema.json`
+- `tools/schemas/tools/palette-browser.schema.json`
+- `tools/schemas/tools/palette.schema.json`
+- `tools/schemas/tools/parallax-editor.schema.json`
+- `tools/schemas/tools/performance-profiler.schema.json`
+- `tools/schemas/tools/physics-sandbox.schema.json`
+- `tools/schemas/tools/replay-visualizer.schema.json`
+- `tools/schemas/tools/skin-editor.schema.json`
+- `tools/schemas/tools/sprite-editor.schema.json`
+- `tools/schemas/tools/state-inspector.schema.json`
+- `tools/schemas/tools/tile-map-editor.schema.json`
+- `tools/schemas/tools/tile-model-converter.schema.json`
+- `tools/schemas/tools/vector-asset-studio.schema.json`
+- `tools/schemas/tools/vector-map-editor.schema.json`
+
+## Sample Updated (allowed scope)
+- `samples/phase-19/1902/sample.1902.workspace-all-tools.json`
+
+## Tests/Checks Added
+- `tests/tools/ToolSchemaStrictModeValidation.test.mjs`
+- `tests/run-tests.mjs` (wired new strict schema validation test)
+
+## Strictness Conversion Counts
+- `additionalProperties: true -> false`: 20 object schemas
+- missing `additionalProperties` fixed: 22 object schemas
+- post-change strictness audit: 0 missing, 0 true
+
+## Fields Explicitly Added
+- Workspace manifest top-level explicit fields: `$schema`, `documentKind`, `schema`, `version`, `id`, `name`, `tools`
+- Workspace `tools` explicit allowed ids with `additionalProperties: false` and required singular `palette`
+- Per-tool strict root fields: `tool`, `version`, `config` (+ explicit tool extras only where required: `sprite-editor.assetRegistry`, `skin-editor.gameId`, `skin-editor.skin`)
+- Per-tool strict `config` allowed keys explicitly declared per tool id
+- `sample.tool-payload` and `tool.manifest` converted to strict object contracts with explicit fields and strict nested object handling
+
+## Validation Evidence
+
+### 1) Syntax checks
+Command:
+- `node --check tests/tools/ToolSchemaStrictModeValidation.test.mjs`
+- `node --check tests/run-tests.mjs`
+
+Result:
+- PASS
+
+### 2) Strict schema + `$ref` + unknown field rejection + sample 1902 conformance
+Command:
+- `node -e "import { run } from './tests/tools/ToolSchemaStrictModeValidation.test.mjs'; await run(); console.log('PASS ToolSchemaStrictModeValidation');"`
+
+Result:
+- PASS
+- Includes proof of:
+  - all schema objects strict (`additionalProperties: false`)
+  - all `$ref` targets resolve
+  - unknown field injection rejected (`asset-browser.config.__unknown`)
+  - sample 1902 manifest validates against strict workspace/tool schema shape
+  - sample 1902 includes all intended workspace tools
+  - no `sample.1902.palette.json` sidecar
+
+### 3) Workspace/tool launch validation
+Command:
+- `npm run test:launch-smoke -- --tools`
+
+Result:
+- PASS (`PASS=287 FAIL=0 TOTAL=287`)
+- Includes `sample 1902` PASS and all tool entries PASS
+
+### 4) Additional check executed (not required by PR but recorded)
+Command:
+- `npm run test:sample-standalone:data-flow`
+
+Result:
+- FAIL (existing contract mismatch for sample 1902 being a workspace manifest, not standalone sample wrapper)
+- Failure details:
+  - `tool field must match filename tool id (workspace-all-tools)`
+  - `version must be a non-empty string`
+  - `payload container must exist (config, payload, or toolState)`
+  - `wrapper fields not allowed (documentKind, id)`
+
+## Workspace 1902 Tool List Validation
+- Verified present under `tools`:
+  - `vector-map-editor`
+  - `vector-asset-studio`
+  - `tile-map-editor`
+  - `parallax-editor`
+  - `sprite-editor`
+  - `skin-editor`
+  - `asset-browser`
+  - `palette-browser`
+  - `state-inspector`
+  - `replay-visualizer`
+  - `performance-profiler`
+  - `physics-sandbox`
+  - `asset-pipeline-tool`
+  - `tile-model-converter`
+  - `3d-json-payload-normalizer`
+  - `3d-asset-viewer`
+  - `3d-camera-path-editor`
+  - `palette`
+
+## start_of_day Confirmation
+- No `start_of_day` folders modified.

docs/dev/reports/REPORT_PR_11_18.md

@@ -0,0 +1,10 @@
+# REPORT_PR_11_18_FULL_STRICT_SCHEMA_MODE
+
+## Summary
+This PR locks schemas into strict mode to stop malformed tool/workspace JSON from passing validation.
+
+## Target
+- `additionalProperties: false` everywhere.
+- Unknown fields fail.
+- Tool schemas become complete.
+- Workspace 1902 validates and shows all intended tools.

docs/dev/reports/launch_smoke_report.md

@@ -1,6 +1,6 @@
 # Launch Smoke Report
 
-Generated: 2026-04-29T01:57:36.705Z
+Generated: 2026-04-29T02:30:38.214Z
 
 Filters: games=true, samples=true, tools=true, sampleRange=all
 

docs/pr/PR_11_18_FULL_STRICT_SCHEMA_MODE/BUILD.md

@@ -0,0 +1,65 @@
+# BUILD_PR_11_18_FULL_STRICT_SCHEMA_MODE
+
+## Required Codex Work
+
+### 1. Enforce strict mode globally
+Scan all JSON schemas under:
+`tools/schemas/`
+
+For every schema object with `"type": "object"`:
+- add `"additionalProperties": false` if missing
+- change `"additionalProperties": true` to false
+- explicitly list every allowed property under `properties`
+
+### 2. Complete incomplete schemas
+Do not hide unknown fields by leaving schemas loose.
+If existing payloads need fields:
+- add those fields explicitly
+- define type and required behavior
+- add nested object schemas with `additionalProperties: false`
+
+### 3. Workspace schema rules
+Workspace must be strict:
+- no top-level extra properties
+- `tools.additionalProperties: false`
+- `tools.palette` required and singular
+- tool payloads referenced via `$ref`
+- all supported tool keys explicitly listed
+
+### 4. Tool schema rules
+Each tool schema must be strict:
+- root object additionalProperties false
+- nested objects additionalProperties false
+- arrays must define item schemas
+- metadata/config/style/editorOptions must be explicit objects, not loose catchalls
+
+### 5. Validation
+Add/run validation that proves:
+- all schemas parse
+- all `$ref` targets resolve
+- no schema object has missing additionalProperties
+- no schema has additionalProperties true
+- unknown field injection fails
+- sample 1902 validates
+- sample 1902 Workspace shows all intended tools
+
+### 6. Validation report
+Create:
+docs/dev/reports/PR_11_18_FULL_STRICT_SCHEMA_MODE_report.md
+
+Report must include:
+- schemas changed
+- count of `additionalProperties` changed from true to false
+- count of object schemas fixed where property was missing
+- fields explicitly added
+- unknown-field rejection test result
+- sample 1902 validation result
+- Workspace 1902 tool list validation
+- confirmation no start_of_day changes
+
+## Constraints
+- One PR purpose only: strict schema mode.
+- No broad UI changes.
+- No fallback/default/hidden data.
+- No loosening schemas to make validation pass.
+- Do not modify unrelated samples.

docs/pr/PR_11_18_FULL_STRICT_SCHEMA_MODE/PLAN.md

@@ -0,0 +1,33 @@
+# PLAN_PR_11_18_FULL_STRICT_SCHEMA_MODE
+
+## Purpose
+Force strict JSON Schema validation across the full tool/workspace schema set until every tool has a good, complete schema.
+
+## Problem
+Loose schemas are allowing malformed JSON payloads to pass. This is creating repeated tool/workspace failures, copied garbage JSON, unsupported fields, and payloads that do not match the intended data contracts.
+
+## Decision
+For this stabilization phase:
+- `additionalProperties` must be `false` on all object schemas.
+- Every allowed field must be explicitly declared.
+- Unknown fields must fail validation.
+- Missing schemas must be created instead of bypassed.
+- Later, after all tools are working, selected internals may be relaxed intentionally.
+
+## Scope
+- All schemas under `tools/schemas/`
+- Workspace schema
+- Workspace manifest schema
+- All tool schemas
+- Sample 1902 only for validation/rebuild if needed
+- No other sample changes unless required to fix schema validation for an already-invalid schema fixture
+- Do not modify start_of_day folders
+
+## Acceptance
+- Every object schema in `tools/schemas/**/*.json` has `additionalProperties: false`
+- No schema uses `additionalProperties: true`
+- No object schema omits `additionalProperties`
+- Workspace manifest references tool schemas via `$ref`
+- Unknown fields fail validation
+- Sample 1902 validates against strict schemas
+- Workspace 1902 shows all valid tools, not only Palette

samples/phase-19/1902/sample.1902.workspace-all-tools.json

@@ -1,4 +1,5 @@
 {
+  "$schema": "../../../tools/schemas/workspace.manifest.schema.json",
   "documentKind": "workspace-manifest",
   "schema": "html-js-gaming.project",
   "version": 1,

tests/run-tests.mjs

@@ -97,6 +97,7 @@ import { run as runAssetRemediationSystem } from './tools/AssetRemediationSystem
 import { run as runToolBoundaryEnforcement } from './tools/ToolBoundaryEnforcement.test.mjs';
 import { run as runProjectToolDataContracts } from './tools/ProjectToolDataContracts.test.mjs';
 import { run as runToolWorkspaceSchemaManifestBoundaries } from './tools/ToolWorkspaceSchemaManifestBoundaries.test.mjs';
+import { run as runToolSchemaStrictModeValidation } from './tools/ToolSchemaStrictModeValidation.test.mjs';
 import { run as runAssetPipelineTooling } from './tools/AssetPipelineTooling.test.mjs';
 import { run as runAssetOwnershipStrategyCloseout } from './tools/AssetOwnershipStrategyCloseout.test.mjs';
 import { run as runAssetErrorHandlingStandard } from './tools/AssetErrorHandlingStandard.test.mjs';
@@ -237,6 +238,7 @@ const tests = [
     ['ToolBoundaryEnforcement', runToolBoundaryEnforcement],
     ['ProjectToolDataContracts', runProjectToolDataContracts],
     ['ToolWorkspaceSchemaManifestBoundaries', runToolWorkspaceSchemaManifestBoundaries],
+    ['ToolSchemaStrictModeValidation', runToolSchemaStrictModeValidation],
     ['AssetPipelineTooling', runAssetPipelineTooling],
     ['AssetOwnershipStrategyCloseout', runAssetOwnershipStrategyCloseout],
     ['AssetErrorHandlingStandard', runAssetErrorHandlingStandard],