Remove tool selector; keep pager-only navigation

Author: DavidQ

docs/dev/codex_rules.md

@@ -1 +1 @@
-Enable and populate existing select. No duplication.
+Remove select completely. Pager only.

docs/dev/reports/tool_select_removed_validation.md

@@ -0,0 +1 @@
+validation placeholder

docs/operations/dev/codex_commands.md

@@ -1,8 +1,6 @@
 
 Execute:
 
-- populate select from tool registry
-- remove tabindex -1
-- remove aria-hidden
-- bind change event
-- sync with pager
+- remove select element from DOM/template
+- remove all JS references to select
+- ensure pager still works

docs/operations/dev/commit_comment.txt

@@ -1 +1 @@
-Fix tool selector population and enable interaction
+Remove tool selector; keep pager-only navigation

docs/pr/BUILD_PR_LEVEL_20_29_REMOVE_TOOL_SELECT_KEEP_PAGER_ONLY.md

@@ -0,0 +1,36 @@
+
+# BUILD_PR_LEVEL_20_29_REMOVE_TOOL_SELECT_KEEP_PAGER_ONLY
+
+## Purpose
+Remove the tool `<select>` control entirely and keep the pager `[PREV] <toolname> [NEXT]` as the sole navigation.
+
+## Scope
+- Remove `<select data-tool-host-select>` from render (DOM + code)
+- Remove any logic that populates or listens to the select
+- Keep pager working (Prev/Next)
+- Keep first-tool-on-load behavior
+- Keep mount/remount behavior
+
+## Required Changes
+- Delete select element from pager template (or do not render it)
+- Remove any references:
+  - getElementById('tool-host-select')
+  - querySelector('[data-tool-host-select]')
+  - select.addEventListener(...)
+  - population logic for select
+- Ensure no errors if select is absent
+
+## Behavior
+- On load:
+  - first tool selected and mounted
+  - label shows tool name
+- Prev/Next:
+  - changes tool
+  - updates label
+  - remounts tool
+
+## Forbidden
+- Do not reintroduce select
+- Do not break pager
+- Do not change layout
+- Do not add new UI

tools/Workspace Manager/main.js

@@ -83,7 +83,6 @@ async function readGameAssetCatalog(assetCatalogPath) {
 }
 
 const refs = {
-  toolSelect: document.querySelector("[data-tool-host-select]"),
   stateInput: document.querySelector("[data-tool-host-state-input]"),
   mountButton: null,
   prevButton: document.querySelector("[data-tool-host-prev]"),
@@ -107,12 +106,11 @@ const TOOL_LAUNCH_PARAM_PREFIXES = Object.freeze({
   workspaceHref: ["/tools/Workspace%20Manager/", "/tools/Workspace Manager/"],
   returnTo: ["/games/", "/samples/"]
 });
-let selectedToolId = refs.toolSelect instanceof HTMLSelectElement ? refs.toolSelect.value : "";
+let selectedToolId = "";
 let pagerEventsBound = false;
 let pagerMessageBridgeBound = false;
 
 function refreshPagerRefs() {
-  refs.toolSelect = document.querySelector("[data-tool-host-select]");
   refs.prevButton = document.querySelector("[data-tool-host-prev]");
   refs.nextButton = document.querySelector("[data-tool-host-next]");
   refs.currentLabel = document.querySelector("[data-tool-host-current-label]");
@@ -194,20 +192,12 @@ function readForwardedToolLaunchParams() {
 }
 
 function readSelectedToolId() {
-  refreshPagerRefs();
-  if (refs.toolSelect instanceof HTMLSelectElement) {
-    return refs.toolSelect.value;
-  }
   return selectedToolId;
 }
 
 function writeSelectedToolId(toolId) {
-  refreshPagerRefs();
   const normalizedToolId = typeof toolId === "string" ? toolId.trim() : "";
   selectedToolId = normalizedToolId;
-  if (refs.toolSelect instanceof HTMLSelectElement) {
-    refs.toolSelect.value = normalizedToolId;
-  }
 }
 
 function writeStatus(text) {
@@ -496,15 +486,7 @@ function syncControlState() {
   }
 }
 
-function populateToolSelect(initialToolId) {
-  refreshPagerRefs();
-  if (refs.toolSelect instanceof HTMLSelectElement) {
-    refs.toolSelect.innerHTML = toolIds
-      .map((toolId) => getToolHostEntryById(manifest, toolId))
-      .filter(Boolean)
-      .map((tool) => `<option value="${tool.id}">${tool.displayName}</option>`)
-      .join("");
-  }
+function syncSelectedToolState(initialToolId) {
   const normalizedInitialToolId = toolIds.includes(initialToolId) ? initialToolId : "";
   writeSelectedToolId(normalizedInitialToolId);
   const selectedEntry = getToolHostEntryById(manifest, readSelectedToolId());
@@ -521,7 +503,7 @@ function applyToolsUsedFilterForGame(gameEntry, preferredToolId = "") {
     toolIds = [...allowed];
   }
   const initialToolId = toolIds.includes(preferredToolId) ? preferredToolId : "";
-  populateToolSelect(initialToolId);
+  syncSelectedToolState(initialToolId);
   updateStandaloneHref(initialToolId);
   syncControlState();
 }
@@ -555,18 +537,6 @@ function bindPagerDelegatedEvents() {
       mountSelectedTool("next");
     }
   });
-
-  document.addEventListener("change", (event) => {
-    const target = event.target instanceof HTMLSelectElement ? event.target : null;
-    if (!target || !target.matches("[data-tool-host-select]")) {
-      return;
-    }
-    refs.toolSelect = target;
-    writeSelectedToolId(target.value);
-    updateSwitchMeta();
-    updateStandaloneHref(readSelectedToolId());
-    mountSelectedTool("select");
-  });
 }
 
 function bindPagerMessageBridge() {
@@ -584,7 +554,7 @@ function bindPagerMessageBridge() {
       return;
     }
 
-    const action = payload.action === "prev" || payload.action === "next" || payload.action === "select"
+    const action = payload.action === "prev" || payload.action === "next"
       ? payload.action
       : "";
     if (!action) {
@@ -603,26 +573,6 @@ function bindPagerMessageBridge() {
       return;
     }
 
-    if (action === "select") {
-      const selectedToolId = typeof payload.toolId === "string"
-        ? payload.toolId.trim()
-        : "";
-      if (!selectedToolId || !toolIds.includes(selectedToolId) || !getToolHostEntryById(manifest, selectedToolId)) {
-        writeStatus(`Tool "${selectedToolId || "(missing)"}" is not available for Workspace Manager launch.`);
-        renderMountDiagnostic(
-          `Tool "${selectedToolId || "(missing)"}" is not available for delegated pager selection.`,
-          "Select a valid tool id from the active registry."
-        );
-        syncControlState();
-        return;
-      }
-      writeSelectedToolId(selectedToolId);
-      updateSwitchMeta();
-      updateStandaloneHref(selectedToolId);
-      mountSelectedTool("select");
-      return;
-    }
-
     const offset = action === "prev" ? -1 : 1;
     if (!selectToolByOffset(offset)) {
       writeStatus(`Unable to select ${action === "prev" ? "previous" : "next"} tool.`);

tools/shared/platformShell.js

@@ -853,15 +853,6 @@ function renderWorkspaceSummary(currentTool) {
     return "";
   }
 
-  const workspacePagerOptions = getToolRegistry()
-    .filter((entry) => entry?.active === true && entry?.visibleInToolsList === true)
-    .map((entry) => {
-      const displayName = normalizeTextValue(entry.displayName || entry.name || entry.id);
-      const selected = entry.id === currentTool.id ? " selected" : "";
-      return `<option value="${escapeHtml(entry.id)}"${selected}>${escapeHtml(displayName || entry.id)}</option>`;
-    })
-    .join("");
-
   const lockState = resolveWorkspaceToolLockState();
   const workspaceActionDisabled = !lockState.workspaceReady
     ? ' disabled aria-disabled="true"'
@@ -888,7 +879,7 @@ function renderWorkspaceSummary(currentTool) {
         <strong class="tools-platform-frame__project-name">${escapeHtml(workspaceName)}${escapeHtml(dirtyMark)}</strong>
         <span class="tools-platform-frame__project-meta">${escapeHtml(readiness)}</span>
       </div>       
-      <section class="tool-host-pager" aria-label="Workspace tool pager" data-tool-host-pager><button type="button" class="tool-host-pager__button" data-tool-host-prev>[PREV]</button><span class="tool-host-pager__name" data-tool-host-current-label>${escapeHtml(currentTool?.displayName || "Tool")}</span><button type="button" class="tool-host-pager__button" data-tool-host-next>[NEXT]</button><select id="tool-host-select" class="tool-host-pager__select" data-tool-host-select>${workspacePagerOptions}</select></section>
+      <section class="tool-host-pager" aria-label="Workspace tool pager" data-tool-host-pager><button type="button" class="tool-host-pager__button" data-tool-host-prev>[PREV]</button><span class="tool-host-pager__name" data-tool-host-current-label>${escapeHtml(currentTool?.displayName || "Tool")}</span><button type="button" class="tool-host-pager__button" data-tool-host-next>[NEXT]</button></section>
     </div>
   `;
 }
@@ -1224,36 +1215,6 @@ function bindWorkspacePagerDelegatedEvents() {
       console.warn("[WorkspacePager] Failed to dispatch delegated pager action.", error);
     }
   });
-
-  headerHost.addEventListener("change", (event) => {
-    const select = event.target instanceof HTMLSelectElement
-      ? event.target
-      : null;
-    if (!select || !select.matches("[data-tool-host-select]")) {
-      return;
-    }
-    const toolId = normalizeTextValue(select.value);
-    if (!toolId) {
-      console.warn("[WorkspacePager] Select change ignored because tool id is missing.");
-      return;
-    }
-    console.info(`[WorkspacePager] SELECT handler fired (${toolId}).`);
-
-    if (typeof window === "undefined" || window.top === window) {
-      console.warn("[WorkspacePager] No parent host available for delegated pager select.");
-      return;
-    }
-
-    try {
-      window.top.postMessage({
-        type: "workspace-pager-action",
-        action: "select",
-        toolId
-      }, window.location.origin);
-    } catch (error) {
-      console.warn("[WorkspacePager] Failed to dispatch delegated pager select.", error);
-    }
-  });
 }
 
 function renderShell(currentTool) {