Fix Workspace V2 Session Library save semantics for new session IDs - PR_11_266

Author: DavidQ

docs/dev/reports/PR_11_266_session_tools_closeout_bundle_report.md

@@ -57,3 +57,26 @@ Workspace V2 only:
 ## Full Samples Smoke Decision
 - Full samples smoke test was skipped.
 - Reason: changes are tightly scoped to Workspace V2 session UX/state handling and were covered by targeted runtime tests.
+
+
+## Continuation Fix (Session Library Save Behavior)
+- Adjusted Session Library action behavior so `Save Session` no longer requires the entered ID to pre-resolve to sessionStorage/recent history.
+- `Save Session` now creates a new saved entry when:
+  - session ID is non-empty
+  - session ID is not already saved
+  - a valid current Workspace V2 payload is available (resolved from entered ID, recent/history, active session, or current payload)
+- `Overwrite Session`, `Load Session`, and `Delete Saved Session` continue to require existing saved library entries.
+- Updated status messages to clearly distinguish:
+  - new ID save success
+  - overwrite/load/delete existing entry requirements
+  - missing/invalid active save source
+
+### Additional Files Updated
+- tests/runtime/V2SessionLibraryActions.test.mjs
+
+### Additional Validation
+1. `node --check tests/runtime/V2SessionLibraryActions.test.mjs`
+   - PASS
+2. `node tests/runtime/V2SessionLibraryActions.test.mjs`
+   - PASS
+   - Results: `tmp/v2-session-library-actions-results.json`

tests/runtime/V2SessionLibraryActions.test.mjs

@@ -40,7 +40,7 @@ function evaluateSaveAction(inputId, activePayload, library) {
     return { message: "Saved session already exists. Use Overwrite Session.", library: libraryMap };
   }
   libraryMap[sessionId] = activePayload;
-  return { message: "Saved session created.", library: libraryMap };
+  return { message: "Saved session created. New session ID is now available for Load, Overwrite, and Delete.", library: libraryMap };
 }
 
 function evaluateOverwriteAction(inputId, activePayload, library) {
@@ -132,7 +132,7 @@ export function run() {
     "Enter a session ID before saving.",
     "No active Workspace V2 session is available to save.",
     "Saved session already exists. Use Overwrite Session.",
-    "Saved session created.",
+    "Saved session created. New session ID is now available for Load, Overwrite, and Delete.",
     "Enter a session ID before overwriting.",
     "No active Workspace V2 session is available to overwrite from.",
     "Saved session not found. Use Save Session to create it first.",
@@ -174,7 +174,7 @@ export function run() {
   if (emptyDelete.message !== "Enter a saved session ID before deleting.") failures.push("Delete empty input message mismatch.");
 
   const saveCreated = evaluateSaveAction("saved-a", activePayload, {});
-  if (saveCreated.message !== "Saved session created." || !Object.prototype.hasOwnProperty.call(saveCreated.library, "saved-a")) {
+  if (saveCreated.message !== "Saved session created. New session ID is now available for Load, Overwrite, and Delete." || !Object.prototype.hasOwnProperty.call(saveCreated.library, "saved-a")) {
     failures.push("Save with valid active payload should create library entry.");
   }
 

tools/workspace-v2/index.js

@@ -673,6 +673,25 @@ class WorkspaceV2SessionProducer {
     return parsed.value;
   }
 
+  readSessionPayloadForSaveAction(sessionId) {
+    const storagePayload = this.readSessionPayloadForLibraryWrite(sessionId);
+    if (this.isValidSessionPayload(storagePayload)) {
+      return storagePayload;
+    }
+    const recentPayload = this.readSessionPayloadFromRecentSessionId(sessionId);
+    if (this.isValidSessionPayload(recentPayload)) {
+      return recentPayload;
+    }
+    const activePayload = this.readActiveSessionPayloadForLibraryActions();
+    if (this.isValidSessionPayload(activePayload)) {
+      return activePayload;
+    }
+    if (this.isValidSessionPayload(this.currentSessionPayload)) {
+      return this.currentSessionPayload;
+    }
+    return null;
+  }
+
   selectedMergedSessionId() {
     return typeof this.mergedSessionIdNode.value === "string" ? this.mergedSessionIdNode.value.trim() : "";
   }
@@ -2680,23 +2699,27 @@ class WorkspaceV2SessionProducer {
       return;
     }
     const exists = Object.prototype.hasOwnProperty.call(library, sessionName);
+    if (overwriteExisting && !exists) {
+      this.setLibraryStatus("Saved session not found. Use Save Session to create it first.");
+      return;
+    }
     if (!overwriteExisting && exists) {
       this.setLibraryStatus("Saved session already exists. Use Overwrite Session.");
       return;
     }
-    const payloadForWrite = this.readSessionPayloadForLibraryWrite(sessionName);
+    const payloadForWrite = this.readSessionPayloadForSaveAction(sessionName);
     if (!this.isValidSessionPayload(payloadForWrite)) {
-      this.setLibraryStatus("Session ID does not resolve to a valid Workspace V2 session.");
-      return;
-    }
-    if (overwriteExisting && !exists) {
-      this.setLibraryStatus("Saved session not found. Use Save Session to create it first.");
+      this.setLibraryStatus(overwriteExisting
+        ? "No active Workspace V2 session is available to overwrite from."
+        : "No active Workspace V2 session is available to save.");
       return;
     }
     library[sessionName] = payloadForWrite;
     this.writeSessionLibrary(library);
     this.renderSessionLibrary();
-    this.setLibraryStatus(overwriteExisting ? "Saved session overwritten." : "Saved session created.");
+    this.setLibraryStatus(overwriteExisting
+      ? "Saved session overwritten."
+      : "Saved session created. New session ID is now available for Load, Overwrite, and Delete.");
   }
 
   loadNamedSession() {