Skip to content

Commit ba0935f

Browse files
author
DavidQ
committed
Polish Asset Manager V2 selected asset detail preview and palette swatches - PR_26126_094-asset-manager-v2-detail-preview-and-palette-polish
1 parent e9c8e14 commit ba0935f

14 files changed

Lines changed: 800 additions & 1093 deletions

‎docs/dev/reports/PR_26126_094_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# PR_26126_094 Asset Manager V2 Manual Validation Notes
2+
3+
## Commands
4+
- `node --check tools/asset-manager-v2/js/assetPreviewHelpers.js`
5+
- `node --check tools/asset-manager-v2/js/controls/AssetCatalogControl.js`
6+
- `node --check tools/asset-manager-v2/js/controls/AssetFormControl.js`
7+
- `node --check tests/playwright/PreviewGeneratorV2Baseline.spec.mjs`
8+
- `npx playwright test tests/playwright/PreviewGeneratorV2Baseline.spec.mjs --project=playwright --reporter=list -g "Asset Manager V2"`
9+
- `npm run test:workspace-v2`
10+
11+
## Results
12+
- Focused Asset Manager V2 Playwright slice passed: 4 tests passed.
13+
- Required workspace-v2 Playwright gate passed: 11 tests passed.
14+
- `docs/dev/reports/playwright_v8_coverage_report.txt` was regenerated by the full run.
15+
16+
## Manual Checks Covered By Tests
17+
- Asset Manager V2-local preview helper import path.
18+
- Selected Asset Detail compact layout and embedded preview.
19+
- Single ID source of truth in Selected Asset Detail.
20+
- Palette sort labels `Hue Sat Bri Nam Tag`.
21+
- Tooltip-only palette swatch details and 35px swatches.
22+
- Pick Asset hidden when Type is Color.
23+
- Sample JSON files were not modified.

‎docs/dev/reports/PR_26126_094_asset_manager_v2_palette_swatch_notes.md‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR_26126_094 Asset Manager V2 Palette Swatch Notes
2+
3+
## Sort Labels
4+
- Palette sort labels were shortened to `Hue`, `Sat`, `Bri`, `Nam`, and `Tag`.
5+
6+
## Swatches
7+
- Palette swatches now render side-by-side as compact swatch buttons.
8+
- Visible swatch names were removed from the picker surface.
9+
- Swatch size increased from 20px to 35px.
10+
- Hover tooltips contain the swatch details: name, hex, symbol, source, and tags.
11+
12+
## Color Mode
13+
- When Type is Color, the Pick Asset fieldset and button are hidden.
14+
- Palette Colors replaces Pick Asset for Color type selection.
15+
- Non-Color types continue to show Pick Asset and hide Palette Colors.
16+
17+
## Validation
18+
- Playwright validates labels, tooltip-only swatch details, 35px swatch sizing, and hidden Pick Asset behavior for Color.

‎docs/dev/reports/PR_26126_094_asset_manager_v2_preview_helper_location_notes.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# PR_26126_094 Asset Manager V2 Preview Helper Location Notes
2+
3+
## Helper Location
4+
- Moved preview helper code from `src/shared/assets/assetPreviewHelpers.js` to `tools/asset-manager-v2/js/assetPreviewHelpers.js`.
5+
- `AssetCatalogControl` now imports the Asset Manager V2-local helper with `../assetPreviewHelpers.js`.
6+
- The old shared helper file was removed.
7+
8+
## Scope
9+
- Preview behavior remains scoped to Asset Manager V2.
10+
- The local helper covers image, audio, font, video, shader, data, localization, and color previews.
11+
- Workspace V2 game asset path resolution remains in the local helper.
12+
13+
## Validation
14+
- Playwright dynamically imports `/tools/asset-manager-v2/js/assetPreviewHelpers.js`.
15+
- Playwright verifies the old `/src/shared/assets/assetPreviewHelpers.js` path is no longer available.
16+
- The V8 coverage report shows `tools/asset-manager-v2/js/assetPreviewHelpers.js` covered at 100%.

‎docs/dev/reports/PR_26126_094_asset_manager_v2_selected_asset_detail_notes.md‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# PR_26126_094 Asset Manager V2 Selected Asset Detail Notes
2+
3+
## Layout
4+
- Selected Asset Detail remains a dedicated collapsible control under Assets.
5+
- `assetPreview` now lives inside Selected Asset Detail at the bottom of that control.
6+
- The preview card no longer owns the selected asset metadata rows.
7+
8+
## Fields
9+
- The first detail line shows `ID`, combined `type/kind`, and `Role`.
10+
- The second detail line shows `Path`.
11+
- Separate `Type` and `Kind` rows were removed.
12+
- `Final ID` was removed entirely.
13+
- The selected asset ID is the single ID source shown in the detail control.
14+
15+
## Validation
16+
- Playwright validates the one-line `ID type/kind Role` layout.
17+
- Playwright validates the `Path` line.
18+
- Playwright validates `assetPreview` is nested under `selectedAssetDetailsContent`.
19+
- Playwright validates `Final ID` is not present.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 20 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,32 @@
11
# git status --short
22
M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
4-
M src/shared/assets/assetPreviewHelpers.js
4+
D src/shared/assets/assetPreviewHelpers.js
55
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
66
M tools/asset-manager-v2/index.html
7-
M tools/asset-manager-v2/js/AssetManagerV2App.js
8-
M tools/asset-manager-v2/js/bootstrap.js
97
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
108
M tools/asset-manager-v2/js/controls/AssetFormControl.js
11-
M tools/asset-manager-v2/js/services/WorkspaceBridge.js
129
M tools/asset-manager-v2/styles/assetManager.css
13-
?? docs/dev/reports/PR_26126_093_asset_manager_v2_manual_validation_notes.md
14-
?? docs/dev/reports/PR_26126_093_asset_manager_v2_palette_sample_notes.md
15-
?? docs/dev/reports/PR_26126_093_asset_manager_v2_preview_path_resolution_notes.md
16-
?? docs/dev/reports/PR_26126_093_asset_manager_v2_selected_asset_detail_notes.md
17-
?? tools/asset-manager-v2/js/services/TemporaryUatSamplePalette.js
10+
?? docs/dev/reports/PR_26126_094_asset_manager_v2_manual_validation_notes.md
11+
?? docs/dev/reports/PR_26126_094_asset_manager_v2_palette_swatch_notes.md
12+
?? docs/dev/reports/PR_26126_094_asset_manager_v2_preview_helper_location_notes.md
13+
?? docs/dev/reports/PR_26126_094_asset_manager_v2_selected_asset_detail_notes.md
14+
?? tools/asset-manager-v2/js/assetPreviewHelpers.js
1815

1916
# git ls-files --others --exclude-standard
20-
docs/dev/reports/PR_26126_093_asset_manager_v2_manual_validation_notes.md
21-
docs/dev/reports/PR_26126_093_asset_manager_v2_palette_sample_notes.md
22-
docs/dev/reports/PR_26126_093_asset_manager_v2_preview_path_resolution_notes.md
23-
docs/dev/reports/PR_26126_093_asset_manager_v2_selected_asset_detail_notes.md
24-
tools/asset-manager-v2/js/services/TemporaryUatSamplePalette.js
17+
docs/dev/reports/PR_26126_094_asset_manager_v2_manual_validation_notes.md
18+
docs/dev/reports/PR_26126_094_asset_manager_v2_palette_swatch_notes.md
19+
docs/dev/reports/PR_26126_094_asset_manager_v2_preview_helper_location_notes.md
20+
docs/dev/reports/PR_26126_094_asset_manager_v2_selected_asset_detail_notes.md
21+
tools/asset-manager-v2/js/assetPreviewHelpers.js
2522

2623
# git diff --stat
27-
docs/dev/reports/coverage_changed_js_guardrail.txt | 13 +-
28-
docs/dev/reports/playwright_v8_coverage_report.txt | 31 ++--
29-
src/shared/assets/assetPreviewHelpers.js | 29 +--
30-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 196 ++++++++++++++++++---
31-
tools/asset-manager-v2/index.html | 26 ++-
32-
tools/asset-manager-v2/js/AssetManagerV2App.js | 20 ++-
33-
tools/asset-manager-v2/js/bootstrap.js | 2 +
34-
.../js/controls/AssetCatalogControl.js | 37 +++-
35-
.../js/controls/AssetFormControl.js | 19 +-
36-
.../js/services/WorkspaceBridge.js | 42 +++++
37-
tools/asset-manager-v2/styles/assetManager.css | 68 ++++++-
38-
11 files changed, 412 insertions(+), 71 deletions(-)
24+
docs/dev/reports/coverage_changed_js_guardrail.txt | 9 +-
25+
docs/dev/reports/playwright_v8_coverage_report.txt | 22 ++---
26+
src/shared/assets/assetPreviewHelpers.js | 104 ---------------------
27+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 78 ++++++++++------
28+
tools/asset-manager-v2/index.html | 2 +-
29+
.../js/controls/AssetCatalogControl.js | 25 +++--
30+
.../js/controls/AssetFormControl.js | 14 ++-
31+
tools/asset-manager-v2/styles/assetManager.css | 49 +++++-----
32+
8 files changed, 108 insertions(+), 195 deletions(-)

0 commit comments

Comments
 (0)