Commit c5d0e69
DavidQ
Implemented minimal scoped Level 11.1 changes only under
**Changed Files**
- [transitions.js](c:/Users/davidq/Documents/GitHub/HTML-JavaScript-Gaming/src/advanced/state/transitions.js:96)
- [WorldGameStateAuthoritativeHandoff.test.mjs](c:/Users/davidq/Documents/GitHub/HTML-JavaScript-Gaming/tests/world/WorldGameStateAuthoritativeHandoff.test.mjs:99)
```diff
diff --git a/src/advanced/state/transitions.js b/src/advanced/state/transitions.js
@@
function validateUpdateObjectiveProgress(payload) {
@@
+ if (payload.currentValue !== undefined && !Number.isFinite(Number(payload.currentValue))) {
+ return { ok: false, reason: 'updateObjectiveProgress payload.currentValue must be numeric when provided.' };
+ }
+ if (payload.targetValue !== undefined && !Number.isFinite(Number(payload.targetValue))) {
+ return { ok: false, reason: 'updateObjectiveProgress payload.targetValue must be numeric when provided.' };
+ }
+ if (payload.isComplete !== undefined && typeof payload.isComplete !== 'boolean') {
+ return { ok: false, reason: 'updateObjectiveProgress payload.isComplete must be boolean when provided.' };
+ }
return { ok: true };
}
diff --git a/tests/world/WorldGameStateAuthoritativeHandoff.test.mjs b/tests/world/WorldGameStateAuthoritativeHandoff.test.mjs
@@
+ const invalidPayloadResult = passiveComparisonSystem.requestTransition('updateObjectiveProgress', {
+ objectiveId: 'obj-invalid',
+ currentValue: 'not-a-number'
+ });
+ assert.equal(invalidPayloadResult.ok, false);
+ assert.equal(invalidPayloadResult.code, 'INVALID_PAYLOAD');
+ assert.equal(invalidPayloadResult.eventType, WORLD_GAME_STATE_EVENT_TYPES.TRANSITION_REJECTED);
+ assert.equal(passiveComparisonSystem.select('selectObjectiveSnapshot').byId['obj-invalid'], undefined);
```
**Targeted Validation Run**
- `node tests/world/WorldGameStateAuthoritativeHandoff.test.mjs` passed
- `node tests/world/WorldGameStateAuthoritativeScore.test.mjs` passed
- `node --check src/advanced/state/transitions.js` passed
No unrelated files were modified by this implementation pass.src/advanced/state + targeted test.1 parent 73b0631 commit c5d0e69
8 files changed
Lines changed: 51 additions & 986 deletions
File tree
- APPLY_PR_ENGINE_IMPORT_BASELINE_AND_CONTRACT_VALIDATE/payload
- BUILD_PR_LEVEL_11_1_AUTHORITATIVE_STATE_HANDOFF_CANDIDATE/payload
- docs/dev/reports
- src/advanced/state
- tests/world
Lines changed: 0 additions & 482 deletions
This file was deleted.
Lines changed: 0 additions & 482 deletions
This file was deleted.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | | - | |
18 | 12 | | |
19 | | - | |
20 | | - | |
21 | | - | |
22 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
23 | 17 | | |
24 | 18 | | |
25 | 19 | | |
| |||
29 | 23 | | |
30 | 24 | | |
31 | 25 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
| 26 | + | |
38 | 27 | | |
39 | 28 | | |
40 | 29 | | |
41 | 30 | | |
42 | 31 | | |
43 | 32 | | |
44 | | - | |
45 | | - | |
46 | | - | |
| 33 | + | |
47 | 34 | | |
48 | | - | |
| 35 | + | |
49 | 36 | | |
50 | | - | |
| 37 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
96 | 96 | | |
97 | 97 | | |
98 | 98 | | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
99 | 108 | | |
100 | 109 | | |
101 | 110 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
102 | 111 | | |
103 | 112 | | |
104 | 113 | | |
| |||
0 commit comments