Move V2 static shell into index.html and keep tool JavaScript behavior-only - PR 11.192

Author: DavidQ

docs/dev/codex_commands.md

@@ -1,22 +1,24 @@
-# Codex Commands — PR_11_191 Vector Map Editor V2
+# Codex Commands — PR_11_192
 
 ## Model
-GPT-5.4-codex
+GPT-5.4
 
 ## Reasoning
-High
+high
 
 ## Command
-```powershell
-codex --model gpt-5.4-codex --reasoning high "Apply PR_11_191 exactly as documented in docs/pr/PR_11_191_VECTOR_MAP_EDITOR_V2_REENGINEER_PLAN.md. Re-engineer Vector Map Editor V2 only. Do not copy/paste legacy tool code. Do not modify schemas, samples, games, Workspace Manager v1, platformShell, assetUsageIntegration, or tools/shared. Use session-backed data only. Visible tool name must end with V2. Header must use the /index.html shared theme header mount: <div id="shared-theme-header"></div>. Keep implementation to a single tool file and single class unless the existing repo entry file requires only wiring to that one class. No helper classes, no alias variables, no abstraction layers, no fallback/default data. Add targeted validation and write findings to docs/dev/reports/PR_11_191_VECTOR_MAP_EDITOR_V2_VALIDATION.md. Do not run full samples smoke test."
-```
+codex exec --model gpt-5.4 --reasoning high "Apply PR_11_192 exactly as documented in docs/pr/PR_11_192_v2_html_shell_correction.md. Correct V2 tools so index.html owns the static shell, CSS links, shared header mount, page layout, menuTool/menuWorkspace containers, and module script. Keep index.js behavior-only: title/tool id setup, session read, validation, DOM population, rendering, and empty/error states. Do not inject CSS or replace document.body.innerHTML from JS. Do not touch schemas, samples, games, Workspace Manager v1, platformShell, tools/shared, or legacy tools. Return a ZIP at tmp/PR_11_192_20260501_01.zip."
 
-## Targeted Validation
-```powershell
+## Targeted validation
+node --check tools/palette-manager-v2/index.js
+node --check tools/svg-asset-studio-v2/index.js
 node --check tools/vector-map-editor-v2/index.js
-```
 
-If the exact file name differs after Codex creates the V2 lane structure, run `node --check` on the created Vector Map Editor V2 entry file only.
+Skip any validation command only if the file does not exist and document why in docs/dev/reports/PR_11_192_validation.md.
 
-## Full Samples Smoke Test
-Skipped by default. Reason: this PR is limited to one V2 tool and does not modify shared sample loader/framework.
+## Manual validation
+Open each corrected V2 tool directly and verify:
+- shared header renders from `<div id="shared-theme-header"></div>`
+- static page shell is visible before session data
+- empty session shows explicit empty state
+- valid session renders without legacy coupling

docs/dev/commit_comment.txt

@@ -1 +1 @@
-Re-engineer Vector Map Editor V2 with session-only data and shared header compliance - PR 11.191
+Move V2 static shell into index.html and keep tool JavaScript behavior-only - PR 11.192

docs/dev/reports/PR_11_192_validation.md

@@ -0,0 +1,82 @@
+# PR_11_192 Validation
+
+## Purpose
+Correct V2 tools so `index.html` owns the static shell and `index.js` remains behavior-only.
+
+## Changed Files
+- `tools/palette-manager-v2/index.html`
+- `tools/palette-manager-v2/index.js`
+- `tools/svg-asset-studio-v2/index.html`
+- `tools/svg-asset-studio-v2/index.js`
+- `tools/vector-map-editor-v2/index.html`
+- `tools/vector-map-editor-v2/index.js`
+- `docs/dev/reports/PR_11_192_validation.md`
+
+## Removed Superseded V2 Paths
+- `tools/Palette Manager v2/main.js`
+- `tools/SVG Asset Studio v2/main.js`
+
+## HTML Shell Correction
+- Each V2 tool now has a static `index.html`.
+- Each `index.html` owns CSS links, `<div id="shared-theme-header"></div>`, page shell, accordion, `menuTool`, `menuWorkspace`, stable DOM nodes, shared header module script, and tool module script.
+- Each `index.js` is behavior-only: title/tool id setup, session read, validation, DOM population, rendering, and empty/error states.
+- JS no longer injects CSS, appends the shared header script, or replaces `document.body.innerHTML`.
+
+## Targeted Validation
+All requested validation commands were run. No validation command was skipped.
+
+```powershell
+node --check tools/palette-manager-v2/index.js
+node --check tools/svg-asset-studio-v2/index.js
+node --check tools/vector-map-editor-v2/index.js
+```
+
+Results:
+- `node --check tools/palette-manager-v2/index.js` passed.
+- `node --check tools/svg-asset-studio-v2/index.js` passed.
+- `node --check tools/vector-map-editor-v2/index.js` passed.
+
+## Guard Scan
+A targeted file-content guard scan checked the corrected V2 tool folders for forbidden shell-building and legacy coupling markers:
+
+- `document.body.innerHTML`
+- `insertAdjacentHTML`
+- dynamic shared header script creation/append
+- `<style>`
+- `platformShell`
+- `assetUsageIntegration`
+- `tools/shared`
+- `Workspace Manager`
+- `handoff`
+- `fallback`
+- `default data`
+- `demo data`
+- static imports/exports
+
+Result: passed. No matches.
+
+## Scope Guard
+No changes were made to:
+
+- schemas
+- samples
+- games
+- `start_of_day/**`
+- Workspace Manager v1
+- `platformShell`
+- `tools/shared/**`
+- legacy tools
+
+## Manual Validation
+Manual browser validation was not run from this terminal session. The static shells are present for direct opening and expose explicit empty states before session data.
+
+## Full Samples Smoke Decision
+Full samples smoke test skipped.
+
+Reason: PR 11.192 is limited to V2 static shell separation and targeted direct tool validation. It does not modify shared sample loader/framework behavior.
+
+## ZIP Artifact
+
+```text
+tmp/PR_11_192_20260501_01.zip
+```

docs/pr/PR_11_192_v2_html_shell_correction.md

@@ -0,0 +1,43 @@
+# PR_11_192_20260501_01 — V2 Tool HTML Shell Correction
+
+## Purpose
+Correct the V2 tool implementation direction so static page structure lives in `tools/<tool>-v2/index.html` and JavaScript stays behavior-only.
+
+## Scope
+- Palette Manager V2
+- SVG Asset Studio V2
+- Vector Map Editor V2 if present from the current lane
+
+## Required correction
+Each V2 tool must use:
+
+```text
+tools/<tool>-v2/index.html
+  - static CSS links
+  - <div id="shared-theme-header"></div>
+  - static page shell
+  - static menuTool/menuWorkspace containers
+  - module script reference
+
+tools/<tool>-v2/index.js
+  - single class behavior
+  - read session
+  - validate contract
+  - populate existing DOM nodes
+  - render valid/empty/error states
+```
+
+## Forbidden
+- Do not build body HTML inside JavaScript.
+- Do not inject CSS from JavaScript.
+- Do not append the shared header script dynamically from JavaScript.
+- Do not overwrite `document.body.innerHTML`.
+- Do not use `palette-manager` for V2 body dataset/tool id.
+- Do not touch schemas, samples, games, Workspace Manager v1, `platformShell`, or `tools/shared/*`.
+
+## Acceptance
+- `index.html` owns static shell and header mount.
+- `index.js` owns behavior only.
+- V2 tool id/name uses explicit `V2` naming and `*-v2` identifiers.
+- Header mount is present as `<div id="shared-theme-header"></div>`.
+- Empty/error/valid states remain testable through stable DOM ids.