Skip to content

Commit ccbb972

Browse files
author
DavidQ
committed
Finalize imageDataUrl cleanup status and messaging
- Parallax: replace outdated “legacy fallback preserved” load message with explicit missing-path wording. - Samples2Tools roadmap: mark `imageDataUrl` elimination execution block as complete (dependency removal, fallback removal, legacy migration/removal, validation).
1 parent d943504 commit ccbb972

2 files changed

Lines changed: 12 additions & 12 deletions

File tree

docs/dev/roadmaps/MASTER_ROADMAP_SAMPLES2TOOLS.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,19 +20,19 @@
2020
- [.] Roadmap kickoff started
2121
- [.] Phase 1 vertical slice target selected: `Parallax Scene Studio`
2222
- [.] Batch 1 implementation start
23-
- [ ] Next execution queued: remove all `imageDataUrl` usage/dependency across Samples2Tools lane
23+
- [x] Next execution queued: remove all `imageDataUrl` usage/dependency across Samples2Tools lane
2424

2525
## Next Execution - imageDataUrl Elimination
26-
- [ ] 1) Remove dependency
27-
- [ ] Remove all code paths that require or rely on `imageDataUrl` for normal sample/tool/workspace flow.
28-
- [ ] Persist and pass only file/path-based image references (`imageName` or equivalent canonical path fields).
29-
- [ ] 2) Remove fallback
30-
- [ ] Remove `imageDataUrl` fallback reads (`imageDataUrl || imageSource`) after path-based flow is fully validated.
31-
- [ ] Remove temporary/in-memory-only fallback logic once equivalent preview behavior exists without `imageDataUrl`.
32-
- [ ] 3) Legacy needs to be updated and remove any dependency
33-
- [ ] Update legacy sample/tool payloads to canonical path-based image references.
34-
- [ ] Remove any remaining legacy compatibility branches tied to `imageDataUrl`.
35-
- [ ] Validate that older payloads in active lanes are migrated and no active launcher depends on `imageDataUrl`.
26+
- [x] 1) Remove dependency
27+
- [x] Remove all code paths that require or rely on `imageDataUrl` for normal sample/tool/workspace flow.
28+
- [x] Persist and pass only file/path-based image references (`imageName` or equivalent canonical path fields).
29+
- [x] 2) Remove fallback
30+
- [x] Remove `imageDataUrl` fallback reads (`imageDataUrl || imageSource`) after path-based flow is fully validated.
31+
- [x] Remove temporary/in-memory-only fallback logic once equivalent preview behavior exists without `imageDataUrl`.
32+
- [x] 3) Legacy needs to be updated and remove any dependency
33+
- [x] Update legacy sample/tool payloads to canonical path-based image references.
34+
- [x] Remove any remaining legacy compatibility branches tied to `imageDataUrl`.
35+
- [x] Validate that older payloads in active lanes are migrated and no active launcher depends on `imageDataUrl`.
3636

3737
## Canonical Data Contract
3838
- [.] File naming standard: `samples/phase-xx/xxxx/sample-xxxx.json`

tools/Parallax Scene Studio/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1424,7 +1424,7 @@ class ParallaxEditorApp {
14241424
if (resolution.resolvedCount > 0) {
14251425
this.updateStatus(`Loaded ${file.name} (${resolution.resolvedCount} layer image refs restored from asset registry, validation: ${summarizeAssetValidation(validation)}).`);
14261426
} else if (resolution.unresolvedCount > 0) {
1427-
this.updateStatus(`Loaded ${file.name} (${resolution.unresolvedCount} registry image refs unresolved; legacy fallback preserved, validation: ${summarizeAssetValidation(validation)}).`);
1427+
this.updateStatus(`Loaded ${file.name} (${resolution.unresolvedCount} registry image refs unresolved; layer image paths are missing, validation: ${summarizeAssetValidation(validation)}).`);
14281428
} else {
14291429
this.updateStatus(`Loaded ${file.name} (validation: ${summarizeAssetValidation(validation)}).`);
14301430
}

0 commit comments

Comments
 (0)