Fix Preview Generator workspace launch display and enable Generate Preview - PR_26127_012-preview-launch-ui-and-generate-enable-fix

DavidQ · DavidQ · commit daeee704c703 · 2026-05-07T18:59:06.000-04:00
diff --git a/docs/dev/reports/PR_26127_012-preview-launch-ui-and-generate-enable-fix.md b/docs/dev/reports/PR_26127_012-preview-launch-ui-and-generate-enable-fix.md
@@ -0,0 +1,31 @@
+# PR_26127_012-preview-launch-ui-and-generate-enable-fix
+
+## Summary
+- Removed the visible Workspace launch hydration field from Preview Generator V2 Repo Destination.
+- Kept workspace launch hydration details in the Status log.
+- Allowed Workspace Manager V2 manifest repoRoot hydration to count as a valid repo destination.
+- Kept pre-populated `games`, asset folder, game id, and manifest preview path as valid generation inputs.
+- Removed background hydration from the Generate Image enablement gate.
+- Changed missing/unavailable workspace background hydration from blocking `FAIL` behavior to visible `WARN` logging.
+- Used the manifest palette background/black swatch as the explicit preview background color when available.
+
+## Validation
+- PASS: `npm run test:workspace-v2`
+- PASS: Workspace Manager V2 launches Preview Generator V2 with Pong.
+- PASS: Pong launch hydrates repo root, target source `games`, asset folder, preview source, and generated preview target.
+- PASS: Generate Image is enabled after valid Pong launch hydration.
+- PASS: Repo Destination no longer displays `Workspace launch` or `Hydrated Pong workspace (games/Pong)`.
+- PASS: Missing Pong background image role logs `WARN` and does not block preview generation.
+- PASS: `assets.image.background.preview` was not re-added.
+- PASS: Sample JSON files were not modified.
+- SKIPPED: Full samples smoke test, per Workspace/Preview V2 scoped validation.
+
+## Manual Validation Notes
+- Open Workspace Manager V2.
+- Select Pong.
+- Launch Preview Generator V2 from the Preview Generator V2 tool tile.
+- Confirm Repo selected shows `HTML-JavaScript-Gaming`.
+- Confirm Repo Destination does not show a Workspace launch hydration field.
+- Confirm Target Source shows only Games, Asset folder is `assets/images`, and Paths or IDs contains `Pong`.
+- Confirm Generate Image is enabled.
+- Confirm Status contains workspace hydration details and a WARN for the missing background image role.
diff --git a/tests/playwright/tools/WorkspaceManagerV2.spec.mjs b/tests/playwright/tools/WorkspaceManagerV2.spec.mjs
@@ -511,6 +511,10 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#paletteStatus")).toHaveText("Loaded active workspace palette Asteroids Palette.");
       await page.locator("#returnToWorkspaceButton").click();
       await expect(page).toHaveURL(/workspace-manager-v2\/index\.html\?hostContextId=workspace-manager-v2-/);
+      await page.locator("#activeGameSelect").selectOption("Pong");
+      await expect(page.locator("#activeGameSummary")).toContainText("games/Pong/");
+      await expect(previewTile).toBeEnabled();
+      await expect(previewTile).toContainText("Schema-valid manifest");
       await page.locator('[data-workspace-tool-id="preview-generator-v2"]').click();
       await expect(page).toHaveURL(/preview-generator-v2\/index\.html.*launch=workspace/);
       await expect(page.locator('[data-launch-mode-nav="tool"]')).toBeHidden();
@@ -519,26 +523,27 @@ test.describe("Workspace Manager V2 bootstrap", () => {
       await expect(page.locator("#executeBtn")).toBeVisible();
       await expect(page.locator("#executeBtn")).toBeEnabled();
       await expect(page.locator("#repoSelectedValue")).toHaveText("HTML-JavaScript-Gaming");
-      await expect(page.locator("#workspaceContextValue")).toHaveText("Hydrated Asteroids workspace (games/Asteroids)");
+      await expect(page.locator("#workspaceContextValue")).toHaveCount(0);
+      await expect(page.locator("#repoDestinationContent")).not.toContainText("Workspace launch");
       await expect(page.locator("#targetTypeGames")).toBeChecked();
       await expect(page.locator('label[for="targetTypeGames"]')).toBeVisible();
       await expect(page.locator('label[for="targetTypeSamples"]')).toBeHidden();
       await expect(page.locator('label[for="targetTypeTools"]')).toBeHidden();
       await expect(page.locator("#assetFolder")).toHaveValue("assets/images");
-      await expect(page.locator("#sampleList")).toHaveValue("Asteroids");
-      await expect(page.locator("#previewTargetValue")).toHaveText("games/Asteroids/assets/images/preview.svg");
+      await expect(page.locator("#sampleList")).toHaveValue("Pong");
+      await expect(page.locator("#previewTargetValue")).toHaveText("games/Pong/assets/images/preview.svg");
       await expect(page.locator("#lastGeneratedImagePreview")).toBeVisible();
-      await expect(page.locator("#lastGeneratedImageMeta")).toHaveText("Preview target: games/Asteroids/assets/images/preview.png");
-      await expect(page.locator("#log")).toContainText("OK Workspace launch context hydrated for Asteroids.");
+      await expect(page.locator("#lastGeneratedImageMeta")).toHaveText("Preview target: games/Pong/assets/images/preview.svg");
+      await expect(page.locator("#log")).toContainText("OK Workspace launch context hydrated for Pong.");
       await expect(page.locator("#log")).toContainText("Repo selected from Workspace Manager V2 manifest repoRoot: HTML-JavaScript-Gaming.");
       await expect(page.locator("#log")).toContainText("Asset folder: assets\\images");
-      await expect(page.locator("#log")).toContainText("Manifest preview asset: assets.image.preview.preview (image/png)");
-      await expect(page.locator("#log")).toContainText("Manifest preview source: games/Asteroids/assets/images/preview.png");
-      await expect(page.locator("#log")).toContainText("Generated preview target: games/Asteroids/assets/images/preview.svg");
-      await expect(page.locator("#log")).toContainText("Preview target: games/Asteroids/assets/images/preview.svg");
-      await expect(page.locator("#log")).toContainText("Workspace background source: assets.image.background.deluxe -> games/Asteroids/assets/images/deluxe.png");
-      await expect(page.locator("#log")).toContainText("Workspace background color: Space Black #020617 from palette-manager-v2 swatch.");
-      await expect(page.locator("#log")).toContainText("OK Workspace manifest preview source is valid at games/Asteroids/assets/images/preview.png.");
+      await expect(page.locator("#log")).toContainText("Manifest preview asset: assets.image.preview.preview (image/svg)");
+      await expect(page.locator("#log")).toContainText("Manifest preview source: games/Pong/assets/images/preview.svg");
+      await expect(page.locator("#log")).toContainText("Generated preview target: games/Pong/assets/images/preview.svg");
+      await expect(page.locator("#log")).toContainText("Preview target: games/Pong/assets/images/preview.svg");
+      await expect(page.locator("#log")).toContainText("WARN Workspace background image role is missing; using manifest palette background color Background #05070A.");
+      await expect(page.locator("#log")).not.toContainText("FAIL Workspace background hydration");
+      await expect(page.locator("#log")).toContainText("OK Workspace manifest preview source is valid at games/Pong/assets/images/preview.svg.");
       await page.locator("#returnToWorkspaceButton").click();
       await expect(page).toHaveURL(/workspace-manager-v2\/index\.html\?hostContextId=workspace-manager-v2-/);
       expect(pageErrors).toEqual([]);
diff --git a/tools/preview-generator-v2/PreviewGeneratorV2App.js b/tools/preview-generator-v2/PreviewGeneratorV2App.js
@@ -19,7 +19,6 @@ let repoDisplayName = "";
 let isGenerating = false;
 let workspacePreviewAssetFolder = "";
 let workspacePreviewFileValid = false;
-let workspaceBackgroundValid = true;
 let workspacePreviewGameId = "";
 let workspaceRepoRootHydrated = false;
 let workspaceRepoRootName = "";
@@ -195,17 +194,19 @@ function workspaceGameAssetPath(manifest, assetPath) {
 }
 
 function workspaceBackgroundContext(manifest) {
-  const assetFolder = workspaceAssetFolder(manifest);
-  if (!assetFolder) {
-    return { ok: false, message: "assetsPath must be inside gameRoot before hydrating the preview background." };
-  }
   const backgroundAsset = workspaceImageAssetByRole(manifest, BACKGROUND_ROLE);
+  const color = workspacePaletteBackgroundColor(manifest);
   if (!backgroundAsset) {
-    return { ok: false, message: "manifest must include an Asset Manager V2 image asset with role background." };
+    return {
+      ok: true,
+      backgroundAssetMissing: true,
+      colorHex: color?.hex || "",
+      colorName: color?.name || ""
+    };
   }
-  const color = workspacePaletteBackgroundColor(manifest);
-  if (!color) {
-    return { ok: false, message: "manifest palette must include a background or black swatch for Preview Generator V2 background hydration." };
+  const assetFolder = workspaceAssetFolder(manifest);
+  if (!assetFolder) {
+    return { ok: false, message: "assetsPath must be inside gameRoot before hydrating the preview background." };
   }
   const backgroundPath = workspaceGameAssetPath(manifest, backgroundAsset.path);
   if (!backgroundPath.pathFromGameRoot.startsWith(`${assetFolder}/`)) {
@@ -215,8 +216,8 @@ function workspaceBackgroundContext(manifest) {
     ok: true,
     backgroundAssetId: backgroundAsset.id,
     backgroundPath: backgroundPath.absolutePath,
-    colorHex: color.hex,
-    colorName: color.name
+    colorHex: color?.hex || "",
+    colorName: color?.name || ""
   };
 }
 
@@ -754,7 +755,6 @@ class PreviewGeneratorV2App {
       return true;
     }
     return workspacePreviewFileValid
-      && workspaceBackgroundValid
       && ui.getSelectedTargetType() === "games"
       && getAssetFolderRelativePath() === workspacePreviewAssetFolder
       && parseInputList(ui.pathsOrIds.getValue()).includes(workspacePreviewGameId);
@@ -902,7 +902,6 @@ class PreviewGeneratorV2App {
     }
     logger.log("Workspace launch context hydration started.");
     workspacePreviewFileValid = false;
-    workspaceBackgroundValid = false;
     workspaceRepoRootHydrated = false;
     workspaceManifestPreviewPath = "";
     workspaceGeneratedPreviewPath = "";
@@ -930,7 +929,6 @@ class PreviewGeneratorV2App {
     workspaceManifestPreviewPath = previewTarget.manifestPreviewPath;
     workspaceGeneratedPreviewPath = previewTarget.generatedPreviewPath;
     ui.setRepoDestinationDisplayName(repoDisplayName);
-    ui.repoDestination.setWorkspaceContextLabel(`Hydrated ${manifest.gameId} workspace (${normalizeWorkspacePath(manifest.gameRoot)})`);
     ui.targetSource.setSelectedTargetType("games");
     ui.targetSource.showWorkspaceGamesOnly();
     ui.assetFolder.setValue(workspacePreviewAssetFolder);
@@ -947,17 +945,29 @@ class PreviewGeneratorV2App {
 
     const backgroundContext = workspaceBackgroundContext(manifest);
     if (backgroundContext.ok) {
-      const backgroundValidation = await validateWorkspaceImagePath(backgroundContext.backgroundPath, "Workspace background source");
-      if (backgroundValidation.ok) {
-        workspaceBackgroundValid = true;
-        capture.setCaptureBackgroundColor(backgroundContext.colorHex);
-        logger.log(`Workspace background source: ${backgroundContext.backgroundAssetId} -> ${backgroundContext.backgroundPath}`);
-        logger.log(`Workspace background color: ${backgroundContext.colorName} ${backgroundContext.colorHex} from palette-manager-v2 swatch.`);
+      if (backgroundContext.backgroundAssetMissing) {
+        if (backgroundContext.colorHex) {
+          capture.setCaptureBackgroundColor(backgroundContext.colorHex);
+          logger.log(`WARN Workspace background image role is missing; using manifest palette background color ${backgroundContext.colorName} ${backgroundContext.colorHex}.`);
+        } else {
+          logger.log("WARN Workspace background image role is missing and no manifest palette background or black swatch is available; preview generation remains enabled without an explicit workspace background color.");
+        }
       } else {
-        logger.log(`FAIL Workspace background hydration: ${backgroundValidation.message}`);
+        const backgroundValidation = await validateWorkspaceImagePath(backgroundContext.backgroundPath, "Workspace background source");
+        if (backgroundValidation.ok) {
+          logger.log(`Workspace background source: ${backgroundContext.backgroundAssetId} -> ${backgroundContext.backgroundPath}`);
+        } else {
+          logger.log(`WARN Workspace background source unavailable: ${backgroundValidation.message}`);
+        }
+        if (backgroundContext.colorHex) {
+          capture.setCaptureBackgroundColor(backgroundContext.colorHex);
+          logger.log(`Workspace background color: ${backgroundContext.colorName} ${backgroundContext.colorHex} from palette-manager-v2 swatch.`);
+        } else {
+          logger.log("WARN Workspace background color is not available from a manifest palette background or black swatch; preview generation remains enabled without an explicit workspace background color.");
+        }
       }
     } else {
-      logger.log(`FAIL Workspace background hydration: ${backgroundContext.message}`);
+      logger.log(`WARN Workspace background hydration: ${backgroundContext.message}`);
     }
 
     const previewResult = await validateWorkspaceImagePath(workspaceManifestPreviewPath, "Workspace manifest preview source");
diff --git a/tools/preview-generator-v2/controls/RepoDestinationControl.js b/tools/preview-generator-v2/controls/RepoDestinationControl.js
@@ -5,25 +5,13 @@ class RepoDestinationControl {
     this.accordion = new AccordionSection({ content: documentRef.getElementById("repoDestinationContent") });
     this.pickRepoBtn = documentRef.getElementById("pickRepoBtn");
     this.repoSelectedValueEl = documentRef.getElementById("repoSelectedValue");
-    this.workspaceContextFieldEl = documentRef.getElementById("workspaceContextField");
-    this.workspaceContextValueEl = documentRef.getElementById("workspaceContextValue");
   }
 
   setRepoDestinationDisplayName(displayName) {
     this.repoSelectedValueEl.textContent = displayName;
     this.repoSelectedValueEl.setAttribute("title", displayName);
   }
 
-  setWorkspaceContextLabel(label) {
-    if (!this.workspaceContextFieldEl || !this.workspaceContextValueEl) {
-      return;
-    }
-    const displayLabel = String(label || "").trim();
-    this.workspaceContextFieldEl.hidden = !displayLabel;
-    this.workspaceContextValueEl.textContent = displayLabel || "not hydrated";
-    this.workspaceContextValueEl.setAttribute("title", displayLabel || "not hydrated");
-  }
-
   onPickRepo(handler) {
     this.pickRepoBtn.addEventListener("click", handler);
   }
diff --git a/tools/preview-generator-v2/index.html b/tools/preview-generator-v2/index.html
@@ -70,11 +70,6 @@ <h2 class="tools-platform-frame__eyebrow">First-Class Tools Surface</h2>
               <div id="repoSelectedValue" class="preview-generator-v2__value">not selected</div>
             </div>
 
-            <div class="palette-manager-v2__field preview-generator-v2__workspace-context-field" id="workspaceContextField" hidden>
-              <span>Workspace launch</span>
-              <div id="workspaceContextValue" class="preview-generator-v2__value">not hydrated</div>
-            </div>
-
             <p class="preview-generator-v2__note">
               Pick the repo root folder, for example <code>HTML-JavaScript-Gaming</code>.
             </p>
