centralize cloneJson

DavidQ · DavidQ · commit e1f9e76b6fa1 · 2026-04-08T16:56:55.000-04:00
diff --git a/docs/dev/CODEX_COMMANDS.md b/docs/dev/CODEX_COMMANDS.md
@@ -1,8 +1 @@
-MODEL: GPT-5.3-codex
-REASONING: high
-COMMAND:
-Execute docs/pr/BUILD_PR_SHARED_EXTRACTION_30_DEBUG_CONFIG_HELPERS_BATCH.md exactly.
-Edit only listed files.
-Create shared helper file.
-Do not expand scope.
-Package to <project folder>/tmp/BUILD_PR_SHARED_EXTRACTION_30_DEBUG_CONFIG_HELPERS_BATCH_delta.zip
+Execute BUILD_PR_SHARED_EXTRACTION_32_IS_OBJECT_BATCH.md exactly.
diff --git a/docs/dev/COMMIT_COMMENT.txt b/docs/dev/COMMIT_COMMENT.txt
@@ -1 +1 @@
-BUILD PR: centralize debug config helpers across main entry points.
+centralize isObject
diff --git a/docs/dev/NEXT_COMMAND.txt b/docs/dev/NEXT_COMMAND.txt
@@ -1 +1 @@
-Next: continue duplicate-family extraction.
+Next: network helpers batch
diff --git a/docs/dev/reports/change_summary.txt b/docs/dev/reports/change_summary.txt
@@ -1 +1 @@
-debug config helpers centralized
+isObject centralized
diff --git a/docs/dev/reports/validation_checklist.txt b/docs/dev/reports/validation_checklist.txt
@@ -1 +1 @@
-helpers moved to shared
+validate per PR
diff --git a/docs/pr/BUILD_PR_SHARED_EXTRACTION_31_CLONE_JSON_BATCH.md b/docs/pr/BUILD_PR_SHARED_EXTRACTION_31_CLONE_JSON_BATCH.md
@@ -0,0 +1,17 @@
+# BUILD_PR_SHARED_EXTRACTION_31_CLONE_JSON_BATCH
+
+Centralize cloneJson(value) across tools/dev and tools/shared.
+
+Create:
+src/shared/utils/jsonUtils.js
+
+Export:
+cloneJson
+
+Update all occurrences from tools/dev + tools/shared listed in dupes report.
+Remove local implementations, import shared.
+
+Constraints:
+- no behavior change
+- no engine edits
+- exact batch only
diff --git a/docs/pr/BUILD_PR_SHARED_EXTRACTION_32_IS_OBJECT_BATCH.md b/docs/pr/BUILD_PR_SHARED_EXTRACTION_32_IS_OBJECT_BATCH.md
@@ -0,0 +1,16 @@
+# BUILD_PR_SHARED_EXTRACTION_32_IS_OBJECT_BATCH
+
+Centralize isObject(value).
+
+Create or use:
+src/shared/utils/objectUtils.js
+
+Export:
+isObject
+
+Update tools/dev + tools/shared consumers.
+Remove local duplicates.
+
+Constraints:
+- no behavior change
+- exact batch only
diff --git a/src/shared/utils/objectUtils.js b/src/shared/utils/objectUtils.js
@@ -5,8 +5,12 @@ David Quesenberry
 objectUtils.js
 */
 
+function isObject(value) {
+  return value !== null && typeof value === 'object' && !Array.isArray(value);
+}
+
 function isPlainObject(value) {
   return !!value && typeof value === 'object' && !Array.isArray(value);
 }
 
-export { isPlainObject };
+export { isObject, isPlainObject };
diff --git a/tools/dev/commandPacks/packUtils.js b/tools/dev/commandPacks/packUtils.js
@@ -6,10 +6,7 @@ packUtils.js
 */
 
 import { sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
-
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
+import { isObject } from "../../../src/shared/utils/objectUtils.js";
 
 export function requireNoArgs({ args = [], commandName = "" } = {}) {
   if (Array.isArray(args) && args.length > 0) {
diff --git a/tools/dev/devConsoleCommandRegistry.js b/tools/dev/devConsoleCommandRegistry.js
@@ -6,10 +6,7 @@ devConsoleCommandRegistry.js
 */
 
 import { sanitizeText } from "../../src/engine/debug/inspectors/shared/inspectorUtils.js";
-
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
+import { isObject } from "../../src/shared/utils/objectUtils.js";
 
 function toLines(lines) {
   if (!Array.isArray(lines)) {
diff --git a/tools/dev/devConsoleIntegration.js b/tools/dev/devConsoleIntegration.js
@@ -56,10 +56,7 @@ const DEFAULT_PLUGIN_CAPABILITIES = Object.freeze([
 ]);
 
 import { sanitizeText } from "../../src/engine/debug/inspectors/shared/inspectorUtils.js";
-
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
+import { isObject } from "../../src/shared/utils/objectUtils.js";
 
 function cloneJson(value) {
   if (typeof structuredClone === "function") {
diff --git a/tools/dev/inspectors/inspectorStore.js b/tools/dev/inspectors/inspectorStore.js
@@ -12,10 +12,7 @@ const DEFAULT_LIMITS = Object.freeze({
 });
 
 import { asArray, asObject, sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
-
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
+import { isObject } from "../../../src/shared/utils/objectUtils.js";
 
 function asFinite(value, fallback = 0) {
   return Number.isFinite(value) ? Number(value) : fallback;
diff --git a/tools/dev/plugins/debugPluginSystem.js b/tools/dev/plugins/debugPluginSystem.js
@@ -6,10 +6,7 @@ debugPluginSystem.js
 */
 
 import { asArray, asObject, sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
-
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
+import { isObject } from "../../../src/shared/utils/objectUtils.js";
 
 function asPositiveInt(value, fallback) {
   const normalized = Number.isFinite(value) ? Math.floor(Number(value)) : fallback;
diff --git a/tools/dev/presets/debugPresetApplier.js b/tools/dev/presets/debugPresetApplier.js
@@ -6,10 +6,7 @@ debugPresetApplier.js
 */
 
 import { sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
-
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
+import { isObject } from "../../../src/shared/utils/objectUtils.js";
 
 function cloneJson(value) {
   if (typeof structuredClone === "function") {
diff --git a/tools/dev/presets/debugPresetRegistry.js b/tools/dev/presets/debugPresetRegistry.js
@@ -6,6 +6,7 @@ debugPresetRegistry.js
 */
 
 import { sanitizeText } from "../../../src/engine/debug/inspectors/shared/inspectorUtils.js";
+import { isObject } from "../../../src/shared/utils/objectUtils.js";
 
 function asStringArray(value) {
   if (!Array.isArray(value)) {
@@ -21,10 +22,6 @@ function asStringArray(value) {
   return Array.from(unique.values());
 }
 
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
-
 function cloneJson(value) {
   if (typeof structuredClone === "function") {
     return structuredClone(value);
diff --git a/tools/shared/devConsoleDebugOverlay.js b/tools/shared/devConsoleDebugOverlay.js
@@ -96,10 +96,7 @@ const CORE_PANEL_SPECS = Object.freeze([
 ]);
 
 import { sanitizeText } from "../../src/engine/debug/inspectors/shared/inspectorUtils.js";
-
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
+import { isObject } from "../../src/shared/utils/objectUtils.js";
 
 function cloneJson(value) {
   if (typeof structuredClone === "function") {
diff --git a/tools/shared/performanceBenchmarks.js b/tools/shared/performanceBenchmarks.js
@@ -4,6 +4,7 @@ David Quesenberry
 04/05/2026
 performanceBenchmarks.js
 */
+import { isObject } from "../../src/shared/utils/objectUtils.js";
 
 export const PERFORMANCE_BENCHMARK_CONTRACT_ID = "toolbox.performance.benchmarks";
 export const PERFORMANCE_BENCHMARK_CONTRACT_VERSION = "1.0.0";
@@ -12,10 +13,6 @@ function sanitizeText(value) {
   return typeof value === "string" ? value.trim() : "";
 }
 
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
-
 function normalizeNumber(value, fallback = 0) {
   return Number.isFinite(value) ? Number(value) : fallback;
 }
diff --git a/tools/shared/renderPipelineContract.js b/tools/shared/renderPipelineContract.js
@@ -11,6 +11,7 @@ import {
   evaluateContractVersion,
   normalizeContractVersion
 } from "./contractVersioning.js";
+import { isObject } from "../../src/shared/utils/objectUtils.js";
 
 export const RENDER_CONTRACT_VERSION = "1.0.0";
 export const RENDER_CONTRACT_ID = "toolbox.render.contract";
@@ -99,10 +100,6 @@ function pushError(errors, stage, code, path, message, details = {}) {
   errors.push(createContractError(stage, code, path, message, details));
 }
 
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
-
 function validateEnvelope(document, expectedType, errors, pathPrefix) {
   const rootPath = sanitizeText(pathPrefix) || "document";
   if (!isObject(document)) {
diff --git a/tools/shared/runtimeSceneLoaderHotReload.js b/tools/shared/runtimeSceneLoaderHotReload.js
@@ -6,6 +6,7 @@ runtimeSceneLoaderHotReload.js
 */
 import { normalizeProjectRelativePath } from "./projectAssetRegistry.js";
 import { runRenderContractRuntimePath } from "./renderPipelineContract.js";
+import { isObject } from "../../src/shared/utils/objectUtils.js";
 
 const DOMAIN_ORDER = Object.freeze(["parallax", "tilemap", "sprite", "vector", "overlay"]);
 
@@ -38,10 +39,6 @@ function cloneJson(value) {
   return JSON.parse(JSON.stringify(value));
 }
 
-function isObject(value) {
-  return value !== null && typeof value === "object" && !Array.isArray(value);
-}
-
 function createStructuredReport(level, stage, code, message, details = {}) {
   return {
     level: sanitizeText(level) || "info",

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-BUILD PR: centralize debug config helpers across main entry points.`
	`1`	`+centralize isObject`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-Next: continue duplicate-family extraction.`
	`1`	`+Next: network helpers batch`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-debug config helpers centralized`
	`1`	`+isObject centralized`
Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-helpers moved to shared`
	`1`	`+validate per PR`