style

Clearing out some of the verbosity.

Author: NoelStephensUnity

.yamato/_run-all.yml

@@ -447,7 +447,6 @@ run_all_project_tests_cmb_service_default:
 
 
 # Runs the NGO 2.x -> 3.x editor script upgrade validation (see api-updater-test.yml)
-# Manual only today. Add this to develop_nightly or develop_weekly_trunk in _triggers.yml to schedule it.
 run_all_api_updater_tests:
   name: Run All API Updater Tests
   dependencies:

.yamato/_triggers.yml

@@ -116,11 +116,6 @@ pr_code_changes_checks:
     cancel_old_ci: true
 
 
-
-
-
-
-
 # Unified (NGO + N4E) validation, on demand.
 # This job allows the Unified tests to be kicked off by commenting "/ci unified". 
 # This is useful for PRs where pr_code_changes_checks doesn't trigger.
@@ -134,12 +129,8 @@ unified_pr_checks:
     cancel_old_ci: true
 
 
-# NGO 2.x -> 3.x editor script upgrade validation, on demand.
+# NGO 2.x -> 3.x on demand editor script upgrade validation.
 # This job allows the API updater test to be kicked off by commenting "/ci apiupdater".
-# It is deliberately not part of the PR gate: what it protects only changes when a public editor type
-# is added, moved or removed, so paying a full editor import on every PR is not worth it.
-# To put it on a schedule, add .yamato/_run-all.yml#run_all_api_updater_tests to develop_nightly or
-# develop_weekly_trunk below.
 api_updater_pr_checks:
   name: API Updater checks [on demand]
   dependencies:

.yamato/api-updater-test.yml

@@ -1,4 +1,4 @@
-{% metadata_file .yamato/project.metafile %} # All configuration that is used to create different configurations (used in for loops) is taken from this file.
+{% metadata_file .yamato/project.metafile %}
 ---
 
 # DESCRIPTION--------------------------------------------------------------------------
@@ -10,20 +10,6 @@
   # -accept-apiupdate and asserts that every 2.x type reference was rewritten and none survived.
   # See apiupdaterproject/README.md.
 
-# WHY THIS JOB IS MANUAL ONLY-----------------------------------------------------------
-  # It is deliberately not wired into pr_minimal_required_checks or pr_code_changes_checks. The thing
-  # it protects only changes when a public editor type is added, moved or removed, so paying a full
-  # editor import on every PR is not worth it. Kick it off with "/ci apiupdater" in a PR comment
-  # (see api_updater_pr_checks in _triggers.yml), or from the Yamato UI.
-  # If it should also run on a schedule, add .yamato/_run-all.yml#run_all_api_updater_tests to
-  # develop_nightly or develop_weekly_trunk in _triggers.yml.
-
-# CONFIGURATION STRUCTURE--------------------------------------------------------------
-  # Runs on the default platform (Ubuntu) like every other basic job. run_upgrade_test.py is Python, so
-  # there is no platform constraint - the earlier PowerShell version forced a Windows agent because it
-  # needed robocopy to purge Library past MAX_PATH.
-  # A single editor is enough - the job is asserting on the editor's API updater, not on NGO
-  # behaviour across editor versions. Widen to validation_editors.all if that stops being true.
 
 # TECHNICAL CONSIDERATIONS---------------------------------------------------------------
   # apiupdaterproject/Packages/manifest.json references the package by relative path
@@ -34,15 +20,6 @@
   # --clean purges Library first: the assertion is meaningless against a warm Library that already
   # holds rewritten sources from a previous run.
 
-# QUALITY CONSIDERATIONS--------------------------------------------------------------------
-  # The expected type list in run_upgrade_test.py is inline and hand-written. That is fine because
-  # its input is frozen: it enumerates the 2.x public editor API, and develop-2.0.0 is released.
-  # TODO: the list does not extend itself. A later relocation within 3.x, or a back port into 2.x,
-  #       has to be added by hand or this job silently stops covering it. Deriving the list from the
-  #       [MovedFrom] attributes in the package source would close that.
-
-#------------------------------------------------------------------------------------
-
 {% for platform in test_platforms.default -%}
 {% for editor in validation_editors.default -%}
 api_updater_test_{{ platform.name }}_{{ editor }}:

apiupdaterproject/Assets/Editor/DeprecatedApiUsage.cs

@@ -1,7 +1,6 @@
-// NGO 2.x-era editor code. Every type reference below must be rewritten by Unity's API updater to
-// its `Unity.Netcode.GameObjects.Editor` equivalent. Do not "fix" this file - it is the input to
-// the upgrade test. See ../../README.md.
-#pragma warning disable 169 // field is never used
+// Update only if new public editor API is added to NGO v2.x.x.
+// It is used to validate the upgrade test. See ../../README.md.
+#pragma warning disable 169 // Ignore field is never used warnings
 
 using ApiUpdaterProject;
 using Unity.Netcode.Editor;

apiupdaterproject/Assets/Editor/DeprecatedApiUsageQualified.cs

@@ -1,7 +1,6 @@
-// The same 2.x API reached through the reference forms the updater has to handle separately from a
-// plain `using` + simple name: fully qualified names, a namespace alias, a type alias, a base type
-// and a typeof. Do not "fix" this file - it is the input to the upgrade test.
-#pragma warning disable 169 // field is never used
+// Update only if new public editor API is added to NGO v2.x.x.
+// It is used to validate the upgrade test. See ../../README.md.
+#pragma warning disable 169 // Ignore field is never used warnings
 
 using System;
 using Cfg = Unity.Netcode.Editor.Configuration;