Remove invalid null checks

Author: EmandM

com.unity.netcode.gameobjects/Editor/Configuration/NetcodeForGameObjectsProjectSettings.cs

@@ -22,7 +22,7 @@ public class NetcodeForGameObjectsProjectSettings : ScriptableSingleton<NetcodeF
 
         private void OnEnable()
         {
-            if (NetworkPrefabsPath?.Length == 0)
+            if (NetworkPrefabsPath.Length == 0)
             {
                 NetworkPrefabsPath = DefaultNetworkPrefabsPath;
             }

com.unity.netcode.gameobjects/Editor/Configuration/NetcodeSettingsProvider.cs

@@ -36,7 +36,7 @@ private static void OnDeactivate()
             if (settings.TempNetworkPrefabsPath != settings.NetworkPrefabsPath)
             {
                 var newPath = settings.TempNetworkPrefabsPath;
-                if (newPath?.Length == 0)
+                if (newPath.Length == 0)
                 {
                     newPath = NetcodeForGameObjectsProjectSettings.DefaultNetworkPrefabsPath;
                     settings.TempNetworkPrefabsPath = newPath;

com.unity.netcode.gameobjects/Editor/HiddenScriptEditor.cs

@@ -55,7 +55,6 @@ public class UnityTransportEditor : HiddenScriptEditor
 
         private SerializedProperty m_ServerAddressProperty;
         private SerializedProperty m_ServerPortProperty;
-        private SerializedProperty m_OverrideBindIpProperty;
 
         private const string k_LoopbackIpv4 = "127.0.0.1";
         private const string k_LoopbackIpv6 = "::1";
@@ -76,7 +75,7 @@ private void Initialize()
 
             m_ServerAddressProperty = connectionDataProperty.FindPropertyRelative(nameof(UnityTransport.ConnectionAddressData.Address));
             m_ServerPortProperty = connectionDataProperty.FindPropertyRelative(nameof(UnityTransport.ConnectionAddressData.Port));
-            m_OverrideBindIpProperty = connectionDataProperty.FindPropertyRelative(nameof(UnityTransport.ConnectionAddressData.ServerListenAddress));
+            connectionDataProperty.FindPropertyRelative(nameof(UnityTransport.ConnectionAddressData.ServerListenAddress));
         }
 
         /// <summary>
@@ -129,7 +128,7 @@ public override void OnInspectorGUI()
                 overrideIp = EditorGUILayout.TextField("Override Bind IP (optional)", overrideIp);
                 if (allowRemoteConnections)
                 {
-                    if (overrideIp?.Length == 0)
+                    if (overrideIp.Length == 0)
                     {
                         if (isIpV6)
                         {

com.unity.netcode.gameobjects/Editor/NetworkManagerEditor.cs

@@ -251,12 +251,12 @@ private void DisplayNetworkManagerProperties()
                         // Default directory
                         var directory = "Assets/";
                         var assetPath = AssetDatabase.GetAssetPath(m_NetworkManager);
-                        if (assetPath?.Length == 0)
+                        if (assetPath.Length == 0)
                         {
                             assetPath = PrefabUtility.GetPrefabAssetPathOfNearestInstanceRoot(m_NetworkManager);
                         }
 
-                        if (assetPath != "")
+                        if (assetPath.Length > 0)
                         {
                             directory = Path.GetDirectoryName(assetPath);
                         }
@@ -270,7 +270,7 @@ private void DisplayNetworkManagerProperties()
                             if (prefabStage != null)
                             {
                                 var prefabPath = prefabStage.assetPath;
-                                if (!string.IsNullOrEmpty(prefabPath))
+                                if (prefabPath.Length > 0)
                                 {
                                     directory = Path.GetDirectoryName(prefabPath);
                                 }