Skip to content

Custom extensions documentation - #581

Merged
dotansimha merged 3 commits into
masterfrom
docs
Oct 30, 2019
Merged

dotansimha merged 3 commits into
masterfrom
docs

Conversation

@dotansimha

@dotansimha dotansimha commented Oct 30, 2019 •

Copy link
Copy Markdown
Collaborator

@wtrocki

wtrocki commented Oct 30, 2019

Copy link
Copy Markdown
Collaborator

@dotansimha On the other note. How about we stage those in /docs folder along with migration.
This will mean that the community can contribute with docusaurus page later.

Comment thread CUSTOM_EXTENSION.md Outdated
Comment thread CUSTOM_EXTENSION.md
@dotansimha

Copy link
Copy Markdown
Collaborator Author

@wtrocki you are right, moved to docs.

@ardatan I did a fix in the code to allow sub-commands in Commander, I'm releasing a new alpha after we get this merged.

@wtrocki wtrocki left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Downloaded sample app
  2. Verified instruction
    Amazing work.

Left some minor comment to fix

@dotansimha

Copy link
Copy Markdown
Collaborator Author

@wtrocki fixed all comments ;) thank you for the review!

I'll merge and release a new version in a few minutes, because I did a small bug fix to allow sub-commands to work.

@dotansimha
dotansimha merged commit 604b38c into master Oct 30, 2019
@dotansimha
dotansimha deleted the docs branch October 30, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants