Commit 30ddd79
authored
Registry-powered onboarding: full-page picker, quick add, spec-carried auth (#1851)
* Add standalone reproduction of the current add-integration flow
* Add reworked add-integration flow alongside the current one
* Drop the sidebar, deep-link the reworked flow, add the custom-URL path
* Restore the console sidebar in the reworked flow, drop the notes panel
* Full-page integration picker: one row per service, add/added, focused search
* Name each row by its surface instead of grouping by service
* Match added state on domain and kind, not domain alone
* Identify rows by registry surface, not by domain
* Source the picker from the registry only
* Name the detected auth method and show the provider's key instructions
* Load integration icons eagerly so they render in the console's scroll container
* Give the sidebar the same icon inputs as the integrations list
* Expire cached catalog searches instead of holding them for the session
* Revalidate catalog requests so registry fixes are not held by a stale browser cache
* Restore preset integrations in the picker; the registry does not cover them
* Browse picker: named catalog rows, per-surface identity
The registry now returns named product rows (many products on one
vendor domain, like Microsoft Graph's workloads), so rows title by the
registry name when present instead of prettifying the domain, and row
keys carry the surface slug — one domain no longer collapses to one row
per kind. Named rows also make the preset dedupe effective for products
whose preset shares the name. The catalog origin is overridable via
VITE_PUBLIC_INTEGRATIONS_SH_ORIGIN for testing against a local registry.
The catalog-search scenario clicks the row's Add button, which is where
the action lives since the add/added rework.
* Detect Google Discovery URLs in the add flow; registry identity on preset rows
Pasting a Discovery URL failed as 'not OpenAPI' while the identical URL
worked through a preset, because the spec-format adapter only engaged
when a preset supplied specFormat. Adapters can now recognize URLs, and
resolution falls back to detection when no explicit format is given.
A preset row and a catalog row for the same product no longer read as
two different kinds of thing: the row shows the registry's identity
(the domain) like every other result, and the preset supplies the add
flow.
* Seed GraphQL auth methods from the registry's declared credential
The registry now says how a GraphQL surface authenticates — credential
kind, header pattern, and a note — because a GraphQL endpoint has no
spec document to say it itself. Adding Linear from the picker seeds the
auth-method editor with 'Authorization: {api_key}' (no Bearer prefix,
which is the whole point) and shows the note; the same facts ride along
when a preset owns the add flow. The detected-method footer says
'Declared by this API' rather than 'Read from the spec', which was
untrue for spec-less surfaces.
* Registry auth for OpenAPI and preset add flows; product-key matching
GitHub's official OpenAPI description declares no securitySchemes, so
the add flow offered OAuth (from the preset template) and nothing else,
while a PAT bearer header is how most calls actually authenticate. The
registry's declared placement now seeds an API key method alongside
detected OAuth; a spec-declared key method still wins over the
registry's version of the same fact.
Preset-to-catalog matching moves from rendered titles to a product key
(normalized name plus kind), so 'GitHub REST' and the registry's
'GitHub API' count as one product — titles and domains both proved
unreliable joins. MCP surfaces carry their auth facts too.
* MCP add flow consumes registry auth facts
The probe stays authoritative when it lands: its OAuth and open-server
verdicts are unchanged, but the registry's declared header pattern now
replaces the generic Bearer guess on a bare 401, rides alongside
detected OAuth (GitHub's MCP takes a PAT bearer in clients without
OAuth support), and stands in entirely when there is no probe result —
an authless server is a fact the registry already knew.
* Prefill spec overrides from the registry
Registry surfaces can carry RFC 6902 JSON Patch for a spec; the picker
passes it through and the OpenAPI add flow prefills its overrides
editor with it, so the patch is visible and editable rather than
applied invisibly. A preset's own overrides win, and a user's draft
wins over both. First use: Neon's spec declares the Neon console's
session cookies as security schemes — the registry's patch removes
them, and the add flow now offers exactly the real Bearer method.
* Detect query-located API keys; drop unrenderable auth strategies
An apiKey with in=query (Viator's legacy ?apiKey=) reached the add flow
as a method with a '(query)' label and zero placements — an empty,
unfillable card that would register as a no-auth method. Query keys now
become real query placements end to end (the invoke layer always knew
how to render them). Cookie-located schemes stop producing methods
entirely: placements carry header|query only, and a cookie scheme is
usually the vendor console's own session, not a mintable credential.
* Infinite scroll for the picker's catalog list
The registry search API now pages (offset over its full ranked list),
so the picker keeps appending as you scroll instead of stopping at the
browse head: a sentinel near the list end fetches the next page a
screen early, appended pages are keyed to the query so a keystroke
discards them, and rows that slide across page boundaries while the
live index moves are deduped. A failed page fetch is retried the next
time the sentinel scrolls into view rather than ending the list.
* Picker results as a card grid
Three cards per row on desktop, two on tablet, one on mobile. Each card
carries the icon, Add/Added state, name, mono domain, and a two-line
description clamp; skeletons and the loading-more placeholders match
the card shape, and the infinite-scroll sentinel spans the full grid
width.
* Only offer connectable catalog surfaces; failures render on the card
The registry can know a surface exists without knowing where it lives
(conjur.org's OpenAPI has no recorded spec URL); such surfaces rendered
an Add card whose click could only fail — and the failure appeared as a
page-top alert, three screens away from the card that was clicked.
Surfaces without a connect target are no longer offered, and the
remaining resolve-on-click path (kinds-only entries from older
registries) reports its failure on the card itself.
* Preset cards recognise adds made through them
Adding Stripe MCP produced slug stripe_mcp (the add flow derives its
namespace from 'Stripe' + the surface word), but the card's added check
only tried the preset's bare name. The rendered title is now a
candidate too, and preset test ids carry the plugin key — two plugins
both naming a preset 'stripe' produced duplicate ids.
* Remove the Petstore and Emulate MCP demo presets
Demo fixtures are not integrations anyone ships with; both existed to
demo executor, and the picker is not the place for that.
* The registry is the picker; presets shrink to local-process cards
Every connectable card now comes from the registry, which carries the
identity, spec or endpoint, auth facts, and overrides; the spec itself
declares how to authenticate, and a deployment's first-party OAuth
clients bind at connect time by endpoint host. Presets with a connect
URL stop being cards — only local-process servers (Chrome DevTools over
stdio) remain, since they have no registry representation yet. The
per-query identity borrowing, product-key preset enrichment, and its
flickering domain chips all go with it. Registry-hosted spec URLs
resolve against the configured catalog origin so a local registry is
self-consistent before a deploy.
* Update integration onboarding scenarios
* Slot local-process cards alphabetically instead of pinning them first
* Catalog origin is always production integrations.sh
The dev-time origin override and its asset-URL rewriting existed only
because the registry's spec mirrors were not deployed yet; they are.
* Cards use the registry's product marks when curated
A curated surface can carry a hand-picked icon (Google Calendar's own
logo, Outlook's); the card prefers it over the domain favicon, which
rendered every Google product as the G and every Microsoft product as
the four squares.
* Survive MCP servers that echo the proposed protocol revision
Walmart's MCP answers any proposed protocolVersion affirmatively —
including 2026-07-28 — while emitting 2024-era results, which the
modern client rightly rejects (SdkError INVALID_RESULT), so the add
flow reported 'couldn't discover tools' for a server that works fine.
Discovery now detects that exact signature (modern-era connection,
INVALID_RESULT) and retries once with legacy negotiation; the probe
reports which handshake worked and the add flow pins
versionNegotiation: legacy on the integration so refreshes and tool
calls use the same one. Tool-discovery failures also stop swallowing
the underlying SDK error message.
* Local-process cards wait for the catalog
Painting a lone Chrome DevTools card while the registry loads read as a
one-item catalog, then reflowed; the skeleton grid now owns the loading
paint. When the registry is unreachable the local cards still render,
so the page degrades to what works.
* Fix fast-scroll paging; move start-from-scratch above the list
Two paging bugs: a fast scroll fired the sentinel before React
committed loadingMore, so parallel fetches hit the same offset and
corrupted the next one (now a synchronous in-flight ref); and both the
offset and the exhaustion check counted FILTERED entries while the
server pages by raw index — dropping CLI-only rows made full pages look
short, ending the scroll mid-catalog (now keyed on raw page size).
Start-from-scratch sat below an endless list, which has no reachable
bottom; it is now one quiet chip row under the facets, where the label
carries the action and the chips stay bare format names.
* Remove the kind facet chips
Kind was the only facet and it earned its row less than it cost: the
surface is already in every card's name, and the search covers all
kinds. The paste-URL hint moves onto the start-from-scratch line.
* Stop the search results jumping
Three causes. Typing toward a URL flipped the grid back to the browse
head mid-keystroke ('stripe.co' parses as a URL), so the list now
freezes on the last real query while only the detect hint changes.
Stale results swapped wholesale with no signal when the debounced
response landed; the grid now dims while a new query loads. And cards
without descriptions were shorter, so grid rows resized between result
sets; cards hold a uniform minimum height. Debounce drops to 150ms.
* Results stay at full opacity while a new query loads
* Port the multiplayer shell to the browse page
Upstream gave the multiplayer shell a connect-dialog affordance while
this branch replaced the dialog with the full-page picker; the sidebar
action navigates there instead.
* Fall back to the service-hosted Google Discovery URL
Normalization canonicalizes a service-hosted Discovery URL onto the
central directory, which is right for identity but not universally
fetchable: the directory does not list every service. Google Ads
answers only on googleads.googleapis.com, so a URL a user pasted and
that works returned HTTP 404 through the adapter. The fetch now falls
back to the host the caller named rather than growing an allowlist of
every such service.
* Point the Axiom preset at a live spec URL
axiom.co/docs/restapi/versions/v2.json 404s; Axiom publishes the spec
in its docs repo. Verified through the add flow: 78 tools, api key and
oauth2 methods detected.
* Detect Microsoft Graph sources from the URL
The Graph adapter only engaged when a preset supplied specFormat, so a
hand-pasted Graph URL fell to the plain OpenAPI path and died on the
43 MB monolith. It now recognizes the published monolith and executor's
slice assets, with or without a #preset selector — the same URL
detection the Google Discovery adapter already had. Already-sliced
hosted specs stay on the plain path, since they parse there fine.
* One-click add from the picker
Registry rows already carry the URL and auth indicators, so clicking
Add now registers in place: the card flips to a View link into the
integration's hub, the user stays on the picker, and several adds can
run at once. Each plugin exposes a headless useQuickAdd on its client
plugin — MCP probes and declares the detected methods (sharing the add
page's seed policy via mcpDetectedAuthSeeds), OpenAPI lets the spec
carry auth, GraphQL declares the registry's header pattern. A quick
add that cannot complete falls back to the configuration screen
prefilled with the same facts.
Also fixes two latent bugs this surfaced: the probe API response
schema stripped versionNegotiation, so the legacy-protocol pin never
survived the HTTP boundary; and per-row state keyed on domain|kind,
which conflated two same-kind products on one domain (Google Photos
Library and Picker).
* Added integrations lead the picker list
What you already have floats to the front of the results, where its
View state is worth seeing. Fresh quick-adds hold their place for the
rest of the session — teleporting the card the user just clicked is
the jumping this page keeps having to unlearn — and float on the next
visit.
* Every added integration leads the picker
The float now covers the whole catalog, not just loaded rows:
installed integrations whose registry rows sit below the loaded page
get cards synthesized from the integration record, deduplicated
against loaded rows by claimed slug. Added-ness also matches the
namespaces the classic add pages derive (domain, display name), not
only the registry slug. The check icon goes; View carries the state.
* Picker cards share the sidebar's icon cascade; only the grid scrolls
Synthetic installed cards ran their own letter-mark fallback while the
sidebar resolved real icons for the same integrations — two resolvers
for one integration. They now run the identical cascade: preset icon
by exact identity, else the logo proxy from the integration's own URL.
The page also stops scrolling as a whole: the title, search, and
scratch row pin, and the results grid scrolls in its own container —
an endless list makes the page scrollbar meaningless and drags the
search box off screen.
* Stale search results stop impersonating live ones
The hook held the previous query's entries while the next loaded — by
design, to avoid flashing — but nothing recorded which query they
belonged to, so after the loading dim was removed a calendar search
showed Gmail cards at full opacity. Entries now carry their request
key and the hook exposes stale; the page keeps held rows only while
every token of the live text matches their name or domain, so
refinements keep their rows and new words drop the old ones instantly.
Also: extra pages reset when the request changes, which unwedges the
sentinel after a mid-flight query switch (the in-flight guard held it
until a scroll), and stops minutes-old extras reviving verbatim under
a fresh first page.
* Per-checkout portless name for the dev server
Every checkout registered the dev server as the same portless name on
the machine-shared multiplex proxy, so the proxy's duplicate-app
selector listed every parallel checkout's server under one host — and
its per-entry Kill button SIGTERMed whichever sibling you clicked.
The name now derives from the checkout directory, scoping the
selector (and its Kill button) to that checkout's own processes.
* Label credential guidance as AI-generated registry data
The setup text reads like the provider's own docs but is
machine-written registry data; a mono provenance line names the
source and links the domain's integrations.sh page so the reader
weights it accordingly.
* Quick add pulls every knowledge source; rate the AI guidance
The GitHub registry row quick-added with no auth methods: its spec
declares no security at all, the preset's OAuth endpoints only rode
the preset path, and the registry's PAT header pattern was dropped.
The OpenAPI quick add now pulls both across — a URL-matched preset
contributes its OAuth template, spec overrides, spec format, family,
and health check; the registry's header pattern becomes a declared
API-key method — while spec-derived defaults still apply when neither
source knows anything.
The AI-generated guidance line also gains thumbs: votes land in
analytics keyed by domain and credential label, so wrong registry
guidance is findable instead of silently misleading.
* Open the connection modal on a key method, not OAuth
OAuth needs a registered app (or a DCR round-trip) before Connect does
anything, so an integration declaring both greeted most users with
"Register app" — a dead end — while the working method sat one tab
over. The modal now opens on the first non-OAuth method; OAuth stays
one click away, and a handoff-specified template still wins.
* Record the product domain on quick-added OpenAPI integrations
Credential guidance and favicons key on the integration's display URL,
which falls back to the spec URL when no base URL is stored — and a
registry quick add stores neither, so a spec hosted on a code host sent
guidance lookups to raw.githubusercontent.com instead of the product.
The registry row already names the product's domain; quick add now
records it as displayDomain and display derivation prefers it. The
field is declared at all three hops (extension input, HTTP payload,
handler map) — the handler's explicit field list is where such fields
silently die.
* Fix the review findings on the quick-add group
Selection carries the CLICKED surface instead of re-finding by kind,
and the kinds-only fallback disambiguates same-kind products by the
row's product name against surface slugs — two same-kind products on
one domain no longer merge one card's URL with the other's slug, auth,
and overrides. The OpenAPI quick add replicates the full add page's
method policy: preset OAuth wins outright; otherwise every
spec-detected method is preserved (one preview call, only when the
registry declared a header) and the registry key is appended only when
the spec has no key method. The MCP remote add carries
versionNegotiation through the payload schema and handler map, with a
round-trip test — the legacy pin previously died at the HTTP boundary.
URL presets hide only when registry-listed (built-ins and the
provider catalogs declare it), so a deployment's custom preset keeps
its card, and quick add matches the plugin's complete preset list.
Quick-add bridges render only for plugins with the hook and call it
unconditionally; duplicate plugin keys get one bridge.
* Quick add previews the same effective document it stores
Auth derivation previewed the raw spec while the add stored the
overridden one, so a preset's scope overrides were derived away; and
registry overrides wrongly beat preset overrides. One spec plan
(preset overrides first, mirroring the full page) now feeds both the
preview and the add, and the composition is a pure exported function
with tests pinning the contract: override-changed OAuth scopes survive
alongside an appended registry key, and a spec-declared key suppresses
the registry's.
* Presence-based override precedence; preview and add share one builder
An explicitly empty preset override list is a decision (suppress the
registry's patches), not an absence — presence-based selection now
mirrors the full page's ?? exactly. Both request payloads come from
one builder, and the tests assert the actual regression contract:
identical specFormat and specOverrides on the preview and the add,
so reverting either call site fails the suite.
* Quick add is a testable operation; tests observe the real payloads
performQuickAdd holds the whole operation with the two mutations
injected; the hook is a thin binder. The tests now capture what
preview and add actually receive — identical spec plan on both,
auth composed from the overridden document with the registry key
appended, the derived slug — so reverting either call site fails
the suite instead of slipping past helper-level assertions.
* Post-merge fixes: drop deleted-section import, scope the fixture server
* Update auth-method scenarios to the renamed detected rows
Detected rows are titled by their kind now ('OAuth · Detected') and
the summary footer names the source and next step; six scenarios in
directories the local runs never covered still asserted the old
'Method 1 · Detected' copy and the removed aria-disabled block.
* Port the remaining dialog-era scenarios; preset links self-seed
Three more CI-only scenarios still drove the removed connect dialog:
the disabled-API journey now enters through the preset deep link, and
the frontend-error test keys its loaded-signal on the header's Add
link. A ?preset= deep link also seeds the spec URL from the preset
itself — the dialog always passed &url= alongside, which hid that the
link never worked on its own.1 parent 48ab9fe commit 30ddd79
99 files changed
Lines changed: 7429 additions & 876 deletions
File tree
- apps
- cloud/src
- host-cloudflare/web
- host-selfhost/web
- local
- e2e
- cloud
- scenarios
- selfhost
- packages
- app/src
- web
- core/sdk/src
- onboarding-demo
- src
- screens
- next
- plugins
- graphql/src/react
- mcp/src
- api
- react
- sdk
- openapi/src
- api
- providers
- google
- microsoft
- react
- sdk
- react/src
- api
- components
- lib
- multiplayer
- pages
- routes
- plans
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
| |||
115 | 116 | | |
116 | 117 | | |
117 | 118 | | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
118 | 127 | | |
119 | 128 | | |
120 | 129 | | |
| |||
172 | 181 | | |
173 | 182 | | |
174 | 183 | | |
| 184 | + | |
175 | 185 | | |
176 | 186 | | |
177 | 187 | | |
| |||
194 | 204 | | |
195 | 205 | | |
196 | 206 | | |
| 207 | + | |
197 | 208 | | |
198 | 209 | | |
199 | 210 | | |
| |||
217 | 228 | | |
218 | 229 | | |
219 | 230 | | |
| 231 | + | |
220 | 232 | | |
221 | 233 | | |
222 | 234 | | |
| |||
241 | 253 | | |
242 | 254 | | |
243 | 255 | | |
| 256 | + | |
244 | 257 | | |
245 | 258 | | |
246 | 259 | | |
| |||
263 | 276 | | |
264 | 277 | | |
265 | 278 | | |
| 279 | + | |
266 | 280 | | |
267 | 281 | | |
268 | 282 | | |
| |||
285 | 299 | | |
286 | 300 | | |
287 | 301 | | |
| 302 | + | |
288 | 303 | | |
289 | 304 | | |
290 | 305 | | |
| |||
307 | 322 | | |
308 | 323 | | |
309 | 324 | | |
| 325 | + | |
310 | 326 | | |
311 | 327 | | |
312 | 328 | | |
| |||
418 | 434 | | |
419 | 435 | | |
420 | 436 | | |
| 437 | + | |
| 438 | + | |
| 439 | + | |
| 440 | + | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
421 | 444 | | |
422 | 445 | | |
423 | 446 | | |
| |||
511 | 534 | | |
512 | 535 | | |
513 | 536 | | |
| 537 | + | |
| 538 | + | |
514 | 539 | | |
515 | 540 | | |
516 | 541 | | |
| |||
520 | 545 | | |
521 | 546 | | |
522 | 547 | | |
| 548 | + | |
523 | 549 | | |
| 550 | + | |
524 | 551 | | |
525 | 552 | | |
526 | 553 | | |
| 554 | + | |
527 | 555 | | |
| 556 | + | |
528 | 557 | | |
529 | 558 | | |
530 | 559 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
| 20 | + | |
20 | 21 | | |
21 | 22 | | |
22 | 23 | | |
| |||
76 | 77 | | |
77 | 78 | | |
78 | 79 | | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
79 | 88 | | |
80 | 89 | | |
81 | 90 | | |
| |||
128 | 137 | | |
129 | 138 | | |
130 | 139 | | |
| 140 | + | |
131 | 141 | | |
132 | 142 | | |
133 | 143 | | |
| |||
143 | 153 | | |
144 | 154 | | |
145 | 155 | | |
| 156 | + | |
146 | 157 | | |
147 | 158 | | |
148 | 159 | | |
| |||
159 | 170 | | |
160 | 171 | | |
161 | 172 | | |
| 173 | + | |
162 | 174 | | |
163 | 175 | | |
164 | 176 | | |
| |||
176 | 188 | | |
177 | 189 | | |
178 | 190 | | |
| 191 | + | |
179 | 192 | | |
180 | 193 | | |
181 | 194 | | |
| |||
191 | 204 | | |
192 | 205 | | |
193 | 206 | | |
| 207 | + | |
194 | 208 | | |
195 | 209 | | |
196 | 210 | | |
| |||
206 | 220 | | |
207 | 221 | | |
208 | 222 | | |
| 223 | + | |
209 | 224 | | |
210 | 225 | | |
211 | 226 | | |
| |||
221 | 236 | | |
222 | 237 | | |
223 | 238 | | |
| 239 | + | |
224 | 240 | | |
225 | 241 | | |
226 | 242 | | |
| |||
284 | 300 | | |
285 | 301 | | |
286 | 302 | | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
287 | 310 | | |
288 | 311 | | |
289 | 312 | | |
| |||
369 | 392 | | |
370 | 393 | | |
371 | 394 | | |
| 395 | + | |
| 396 | + | |
372 | 397 | | |
373 | 398 | | |
374 | 399 | | |
| |||
0 commit comments