Tests: Clean up the wp_delete_post() unit tests.

Four independent clean-ups in the test file:
- **Remove the unused `$user_ids` fixture.** The property and its `wpSetUpBeforeClass()` method were copied over from the `wp_insert_post()` tests. Nothing in this class references `self::$user_ids`, so the only effect was creating three users for every test in the class.
- **Rename `test_wp_delete_post_returns_false_for_invalid_post()`** to `test_wp_delete_post_returns_null_for_already_deleted_post()`. The test asserts `assertNull()`, and that is the correct expectation: for an ID with no matching row, `wp_delete_post()` returns the `null` coming out of `$wpdb->get_row()`, whereas `false` is only returned by the `$post_id <= 0` guard. The old name described the opposite of what the test covers.
- **Reuse the `$actions` array** in the assertion loop of `test_wp_delete_post_actions()`. The same six action names were spelled out a second time inline, so the registration loop and the assertion loop could drift apart.
- **Fix the `@ticket @63975` annotation.** The stray `@` made the tag invalid, so the test was not associated with the ticket.
No assertion was added, removed or changed, and no test behavior changes.

Developed in #13036.

Follow-up to [60906].

Props Soean.
See #65819.

git-svn-id: https://develop.svn.wordpress.org/trunk@63295 602fd350-edb4-49c9-b593-d223f7449a82

Author: SergeyBiryukov

tests/phpunit/tests/post/wpDeletePost.php

@@ -16,38 +16,6 @@
  */
 class Tests_Post_WpDeletePost extends WP_UnitTestCase {
 
-	/**
-	 * User IDs for the test.
-	 *
-	 * @var array{administrator: int, editor: int, contributor: int}
-	 */
-	protected static $user_ids;
-
-	/**
-	 * Set up before class.
-	 *
-	 * @param WP_UnitTest_Factory $factory The Unit Test Factory.
-	 */
-	public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
-		self::$user_ids = array(
-			'administrator' => $factory->user->create(
-				array(
-					'role' => 'administrator',
-				)
-			),
-			'editor'        => $factory->user->create(
-				array(
-					'role' => 'editor',
-				)
-			),
-			'contributor'   => $factory->user->create(
-				array(
-					'role' => 'contributor',
-				)
-			),
-		);
-	}
-
 	/**
 	 * Tests wp_delete_post reassign hierarchical post type.
 	 */
@@ -120,9 +88,9 @@ public function test_wp_delete_post_short_circuit_on_post_id_zero() {
 	}
 
 	/**
-	 * Tests wp_delete_post() when the post for the post_id has been already deleted.
+	 * Tests that wp_delete_post() returns null when the post has already been deleted.
 	 */
-	public function test_wp_delete_post_returns_false_for_invalid_post() {
+	public function test_wp_delete_post_returns_null_for_already_deleted_post() {
 		$post_id      = self::factory()->post->create();
 		$deleted_post = wp_delete_post( $post_id, true );
 		$this->assertInstanceOf( WP_Post::class, $deleted_post );
@@ -163,7 +131,7 @@ static function () use ( $action, &$captured_action_args ) {
 		$deleted_post = wp_delete_post( (string) $post_id, true );
 		$this->assertInstanceOf( WP_Post::class, $deleted_post );
 
-		foreach ( array( 'before_delete_post', 'delete_post_post', 'delete_post', 'deleted_post_post', 'deleted_post', 'after_delete_post' ) as $action ) {
+		foreach ( $actions as $action ) {
 			$this->assertSame( $initial_action_counts[ $action ] + 1, did_action( $action ), "Expected $action action count to increment by 1." );
 			$this->assertCount( 2, $captured_action_args[ $action ], "Expected count for $action action" );
 			$this->assertSame( $post_id, $captured_action_args[ $action ][0], "Expected post ID for $action action" );
@@ -175,7 +143,7 @@ static function () use ( $action, &$captured_action_args ) {
 	/**
 	 * Tests short-circuiting wp_delete_post() with pre_delete_post filter.
 	 *
-	 * @ticket @63975
+	 * @ticket 63975
 	 */
 	public function test_wp_delete_post_can_be_short_circuited() {
 		$post_id = self::factory()->post->create();