Skip to content

Run existing tests in the deploy workflows for Pipe Notch and PDF Master #152

Description

@YurMil

Both repos have a passing test suite that runs on pull requests but not on the workflow that builds and publishes to the site — so a regression merged to main still deploys.

  • YurMil/Pipe-notch-generator — 31 tests, deploy.yml runs build only
  • YurMil/pdfs-master — 22 tests, deploy.yml runs build only

For comparison, Blind Flange, Tube Sheet and Dished End all run their tests before building in the deploy path.

Acceptance criteria:

  • npm test / pnpm test runs before the build step in both deploy workflows
  • A deliberately failing test blocks the deploy (verified once)

Found while writing the QA strategy page (#105).


This repo is using Opire - what does it mean? 👇
💵 Everyone can add rewards for this issue commenting /reward 100 (replace 100 with the amount).
🕵️‍♂️ If someone starts working on this issue to earn the rewards, they can comment /try to let everyone know!
🙌 And when they open the PR, they can comment /claim #152 either in the PR description or in a PR's comment.

🪙 Also, everyone can tip any user commenting /tip 20 @YurMil (replace 20 with the amount, and @YurMil with the user to tip).

📖 If you want to learn more, check out our documentation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions