From 4096613e7f0410afc1bba8ea28aceec8383f59f5 Mon Sep 17 00:00:00 2001 From: Roomote Date: Tue, 8 Sep 2026 22:40:58 +0000 Subject: [PATCH 1/6] chore: align CodeRabbit approval gates --- .coderabbit.yaml | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index a31c1b2616..65e71a8829 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -146,17 +146,19 @@ reviews: pre_merge_checks: override_requested_reviewers_only: true + # Warning failures are mergeable but prevent CodeRabbit's automatic approval. + # Keep only intentional blocking gates enabled so approval matches enforcement. docstrings: mode: off title: - mode: warning + mode: off description: - mode: warning + mode: off issue_assessment: - mode: warning + mode: off custom_checks: - name: Regression evidence - mode: warning + mode: error instructions: >- Fail only when a concrete changed behavior lacks focused coverage at the lowest valid test layer, tests merely mirror implementation, an affected error/negative/unset branch From 5733c7dc9c43e36f497a868c47da8da80ba5b0b3 Mon Sep 17 00:00:00 2001 From: Roomote Date: Wed, 9 Sep 2026 00:27:37 +0000 Subject: [PATCH 2/6] chore: guide provider architecture reviews --- .coderabbit.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 65e71a8829..6055d0ecf3 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -105,6 +105,15 @@ reviews: lifecycle correctness, and behavior under retries and partial failure. Check listeners, resources, and providers are disposed without stale state or duplicate work. + - path: "src/api/providers/**" + instructions: >- + For provider request configuration and cancellation changes, check whether existing shared + abstractions, especially `RequestConfigBuilder` and the shared abort-signal utilities, can preserve + the provider SDK contract before adding local controller, listener, timeout, or request-option + logic. Flag unnecessary duplication. Accept provider-specific handling when the SDK boundary + requires it and pre-abort behavior, cancellation propagation, timeout and error semantics, and + cleanup remain correct. + - path: "webview-ui/**" instructions: >- Check React state and effect dependencies, cleanup, accessibility, i18n, and light/dark From 78cf0cea8fc83b176ac40cfbdb6a212f9136acca Mon Sep 17 00:00:00 2001 From: Roomote Date: Wed, 9 Sep 2026 00:49:42 +0000 Subject: [PATCH 3/6] chore: generalize CodeRabbit reuse guidance --- .coderabbit.yaml | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 6055d0ecf3..e5fb8b38ff 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -55,7 +55,10 @@ reviews: or upstream repositories. Report only concrete, actionable conflicts or failure modes, citing the relevant repository location or external source. Prioritize correctness, security, data loss, lifecycle, and test gaps. Do not report generic best practices, unsupported concerns, speculative - style comments, or unrelated refactors. Search for existing helpers before suggesting abstractions. + style comments, or unrelated refactors. When changed code introduces a local implementation of a + cross-cutting concern, check whether it bypasses or duplicates an established repository abstraction + or nearby convention. Report only a concrete inconsistency with behavioral or maintenance impact, + and allow intentional deviations. - path: "**/*.{ts,tsx,js,jsx,mts,mjs,cts,cjs}" instructions: >- @@ -105,15 +108,6 @@ reviews: lifecycle correctness, and behavior under retries and partial failure. Check listeners, resources, and providers are disposed without stale state or duplicate work. - - path: "src/api/providers/**" - instructions: >- - For provider request configuration and cancellation changes, check whether existing shared - abstractions, especially `RequestConfigBuilder` and the shared abort-signal utilities, can preserve - the provider SDK contract before adding local controller, listener, timeout, or request-option - logic. Flag unnecessary duplication. Accept provider-specific handling when the SDK boundary - requires it and pre-abort behavior, cancellation propagation, timeout and error semantics, and - cleanup remain correct. - - path: "webview-ui/**" instructions: >- Check React state and effect dependencies, cleanup, accessibility, i18n, and light/dark From c8859da810c2ac92e72cf98e81abcaec6cb2a303 Mon Sep 17 00:00:00 2001 From: Roomote Date: Wed, 9 Sep 2026 01:51:13 +0000 Subject: [PATCH 4/6] chore: surface CodeRabbit pre-merge results --- .coderabbit.yaml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index e5fb8b38ff..7f360f44b4 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -21,7 +21,7 @@ reviews: high_level_summary_in_walkthrough: true review_status: true review_details: true - collapse_walkthrough: true + collapse_walkthrough: false changed_files_summary: true poem: false @@ -149,16 +149,14 @@ reviews: pre_merge_checks: override_requested_reviewers_only: true - # Warning failures are mergeable but prevent CodeRabbit's automatic approval. - # Keep only intentional blocking gates enabled so approval matches enforcement. docstrings: mode: off title: - mode: off + mode: warning description: - mode: off + mode: warning issue_assessment: - mode: off + mode: warning custom_checks: - name: Regression evidence mode: error From d731260fbb8d05b65e0ad495f41b6149c08e3804 Mon Sep 17 00:00:00 2001 From: Roomote Date: Thu, 10 Sep 2026 01:03:19 +0000 Subject: [PATCH 5/6] chore: enforce CodeRabbit scope checks --- .coderabbit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index 7f360f44b4..b125b991d8 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -156,7 +156,7 @@ reviews: description: mode: warning issue_assessment: - mode: warning + mode: error custom_checks: - name: Regression evidence mode: error From eeabf45c18d616aca6cc1cd1415dc520e29f8f9d Mon Sep 17 00:00:00 2001 From: Roomote Date: Thu, 10 Sep 2026 01:16:39 +0000 Subject: [PATCH 6/6] chore: keep CodeRabbit walkthrough collapsed --- .coderabbit.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.coderabbit.yaml b/.coderabbit.yaml index b125b991d8..175482f29f 100644 --- a/.coderabbit.yaml +++ b/.coderabbit.yaml @@ -21,7 +21,7 @@ reviews: high_level_summary_in_walkthrough: true review_status: true review_details: true - collapse_walkthrough: false + collapse_walkthrough: true changed_files_summary: true poem: false